Re: [tor-bugs] #29280 [Core Tor/Tor]: Use Chutney in Tor's CI

[Tor Bug Tracker & Wiki]

#29280: Use Chutney in Tor's CI
-+-
 Reporter:  cohosh   |  Owner:  teor
 Type:  task | Status:  closed
 Priority:  High |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  CI, PTs, 029-backport,   |  Actual Points:  2
  035-backport, 040-backport, network-team-  |
  roadmap-2019-Q1Q2, reviewer-was-   |
  teor-20190422, tor-ci, 041-deferred-20190530,  |
  dgoulet-merge  |
Parent ID:  #29267   | Points:  1
 Reviewer:  nickm|Sponsor:
 |  Sponsor19
-+-
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed
 * milestone:  Tor: 0.4.0.x-final => Tor: 0.2.9.x-final


Comment:

 Backported to 0.2.9 and later.
 Merged #30213, #29280, and #30591 together.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29280 [Core Tor/Tor]: Use Chutney in Tor's CI

[Tor Bug Tracker & Wiki]

#29280: Use Chutney in Tor's CI
-+-
 Reporter:  cohosh   |  Owner:  teor
 Type:  task | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  CI, PTs, 029-backport,   |  Actual Points:  2
  035-backport, 040-backport, network-team-  |
  roadmap-2019-Q1Q2, reviewer-was-   |
  teor-20190422, tor-ci, 041-deferred-20190530,  |
  dgoulet-merge  |
Parent ID:  #29267   | Points:  1
 Reviewer:  nickm|Sponsor:
 |  Sponsor19
-+-
Changes (by dgoulet):

 * milestone:  Tor: 0.4.2.x-final => Tor: 0.4.0.x-final


Comment:

 Merged in 041 and master. Moving to 040 for backport.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29280 [Core Tor/Tor]: Use Chutney in Tor's CI

[Tor Bug Tracker & Wiki]

#29280: Use Chutney in Tor's CI
-+-
 Reporter:  cohosh   |  Owner:  teor
 Type:  task | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  CI, PTs, 029-backport,   |  Actual Points:  2
  035-backport, 040-backport, network-team-  |
  roadmap-2019-Q1Q2, reviewer-was-   |
  teor-20190422, tor-ci, 041-deferred-20190530,  |
  dgoulet-merge  |
Parent ID:  #29267   | Points:  1
 Reviewer:  nickm|Sponsor:
 |  Sponsor19
-+-
Changes (by nickm):

 * keywords:
 CI, PTs, 029-backport, 035-backport, 040-backport, network-team-
 roadmap-2019-Q1Q2, reviewer-was-teor-20190422, tor-ci,
 041-deferred-20190530
 =>
 CI, PTs, 029-backport, 035-backport, 040-backport, network-team-
 roadmap-2019-Q1Q2, reviewer-was-teor-20190422, tor-ci,
 041-deferred-20190530, dgoulet-merge


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29280 [Core Tor/Tor]: Use Chutney in Tor's CI

[Tor Bug Tracker & Wiki]

#29280: Use Chutney in Tor's CI
-+-
 Reporter:  cohosh   |  Owner:  teor
 Type:  task | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  CI, PTs, 029-backport,   |  Actual Points:  2
  035-backport, 040-backport, network-team-  |
  roadmap-2019-Q1Q2, reviewer-was-   |
  teor-20190422, tor-ci, 041-deferred-20190530   |
Parent ID:  #29267   | Points:  1
 Reviewer:  nickm|Sponsor:
 |  Sponsor19
-+-
Changes (by nickm):

 * status:  needs_review => merge_ready


Comment:

 This all LGTM now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29280 [Core Tor/Tor]: Use Chutney in Tor's CI

[Tor Bug Tracker & Wiki]

#29280: Use Chutney in Tor's CI
-+-
 Reporter:  cohosh   |  Owner:  teor
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  CI, PTs, 029-backport,   |  Actual Points:  2
  035-backport, 040-backport, network-team-  |
  roadmap-2019-Q1Q2, reviewer-was-   |
  teor-20190422, tor-ci, 041-deferred-20190530   |
Parent ID:  #29267   | Points:  1
 Reviewer:  nickm|Sponsor:
 |  Sponsor19
-+-
Changes (by teor):

 * status:  needs_revision => needs_review


Comment:

 Oops

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29280 [Core Tor/Tor]: Use Chutney in Tor's CI

[Tor Bug Tracker & Wiki]

#29280: Use Chutney in Tor's CI
-+-
 Reporter:  cohosh   |  Owner:  teor
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  CI, PTs, 029-backport,   |  Actual Points:  2
  035-backport, 040-backport, network-team-  |
  roadmap-2019-Q1Q2, reviewer-was-   |
  teor-20190422, tor-ci, 041-deferred-20190530   |
Parent ID:  #29267   | Points:  1
 Reviewer:  nickm|Sponsor:
 |  Sponsor19
-+-
Changes (by teor):

 * actualpoints:  1.5 => 2


Comment:

 See my pull requests:
 * 0.2.9: https://github.com/torproject/tor/pull/1155
 * 0.3.5: https://github.com/torproject/tor/pull/1156
   * merge chutney job from 0.2.9 and stem job from 0.3.5
   * adds a commit that uses SKIP_MAKE_CHECK for stem
 * 0.4.0: https://github.com/torproject/tor/pull/1157
   * merge removes an incorrect comment about the stem version script

 Clean merges:
 * 0.4.1: https://github.com/torproject/tor/pull/1158
 * master: https://github.com/torproject/tor/pull/1159

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29280 [Core Tor/Tor]: Use Chutney in Tor's CI

[Tor Bug Tracker & Wiki]

#29280: Use Chutney in Tor's CI
-+-
 Reporter:  cohosh   |  Owner:  teor
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  CI, PTs, 029-backport,   |  Actual Points:  1.5
  035-backport, 040-backport, network-team-  |
  roadmap-2019-Q1Q2, reviewer-was-   |
  teor-20190422, tor-ci, 041-deferred-20190530   |
Parent ID:  #29267   | Points:  1
 Reviewer:  nickm|Sponsor:
 |  Sponsor19
-+-
Changes (by teor):

 * status:  assigned => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29280 [Core Tor/Tor]: Use Chutney in Tor's CI

[Tor Bug Tracker & Wiki]

#29280: Use Chutney in Tor's CI
-+-
 Reporter:  cohosh   |  Owner:  teor
 Type:  task | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  CI, PTs, 029-backport,   |  Actual Points:  1.5
  035-backport, 040-backport, network-team-  |
  roadmap-2019-Q1Q2, reviewer-was-   |
  teor-20190422, tor-ci, 041-deferred-20190530   |
Parent ID:  #29267   | Points:  1
 Reviewer:  nickm|Sponsor:
 |  Sponsor19
-+-
Changes (by teor):

 * owner:  (none) => teor
 * reviewer:  teor => nickm
 * status:  needs_revision => assigned


Comment:

 I'll do the remaining changes, and nickm will review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29280 [Core Tor/Tor]: Use Chutney in Tor's CI

[Tor Bug Tracker & Wiki]

#29280: Use Chutney in Tor's CI
-+-
 Reporter:  cohosh   |  Owner:  (none)
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  CI, PTs, 029-backport,   |  Actual Points:  1.5
  035-backport, 040-backport, network-team-  |
  roadmap-2019-Q1Q2, reviewer-was-   |
  teor-20190422, tor-ci, 041-deferred-20190530   |
Parent ID:  #29267   | Points:  1
 Reviewer:  teor |Sponsor:
 |  Sponsor19
-+-
Changes (by teor):

 * status:  needs_review => needs_revision
 * reviewer:   => teor


Comment:

 The CI and config look good.
 So do the merges.

 0.3.5 and later is going to conflict with #30591, let's try to merge this
 change, then rebase #30591. (#29280 is more complex than #30951, which is
 a simple patch on 0.3.5 and a clean merge forward.)

 I like that we are re-using "make test-network-all", there's no need to
 mess around with chutney networks vs tor versions.

 We're almost there!

 There's a few tweaks that we need to do for good diagnostics:
 * cat test_network_log on failure
 * show the python version in 0.2.9 and 0.3.5, like we do in 0.4.0 and
 later
   * if we cherry-pick c31346ffb4, the merges might be eaiser
   * but the comment about stem is wrong:
 * in 0.2.9, we don't run stem
 * in 0.3.5 and later, that line just shows the stem version, it
 doesn't actually run stem
 * show the chutney commit hash after we check it out

 (We've needed all this information to diagnose stem and test failures in
 the past, so let's put it in now.)

 There's one fix that I would do, but feel free to do whatever you think is
 easiest to maintain and read:
 * remove the redundant os: linux line (see my comment in the pull request)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29280 [Core Tor/Tor]: Use Chutney in Tor's CI

[Tor Bug Tracker & Wiki]

#29280: Use Chutney in Tor's CI
-+-
 Reporter:  cohosh   |  Owner:  (none)
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  CI, PTs, 029-backport,   |  Actual Points:  1.5
  035-backport, 040-backport, network-team-  |
  roadmap-2019-Q1Q2, reviewer-was-   |
  teor-20190422, tor-ci, 041-deferred-20190530   |
Parent ID:  #29267   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor19
-+-
Changes (by nickm):

 * status:  needs_revision => needs_review
 * actualpoints:  1 => 1.5


Comment:

 * Base branch at `chutney_ci_v3_029` with PR at
 https://github.com/torproject/tor/pull/1103
  * Merged to 0.3.5 with `chutney_ci_v3_029`. Resolved merge conflicts
 here, hopefully in a sensible way. PR at
 https://github.com/torproject/tor/pull/1104
  * Merges to 0.4.0 through 0.4.2 as `chutney_ci_v3_{040,041,024}`. No
 conflicts here; CI only. PRs at
 https://github.com/torproject/tor/pull/1105 and
 https://github.com/torproject/tor/pull/1106 and
 https://github.com/torproject/tor/pull/1107 respectively.

 I'll check this again in a little while to see whether CI is passing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29280 [Core Tor/Tor]: Use Chutney in Tor's CI

[Tor Bug Tracker & Wiki]

#29280: Use Chutney in Tor's CI
-+-
 Reporter:  cohosh   |  Owner:  (none)
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  CI, PTs, 029-backport,   |  Actual Points:  1
  035-backport, 040-backport, network-team-  |
  roadmap-2019-Q1Q2, reviewer-was-   |
  teor-20190422, tor-ci, 041-deferred-20190530   |
Parent ID:  #29267   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor19
-+-

Comment (by teor):

 I talked to nickm on IRC today, here's how we're going to move forward:

 In this ticket:
 * start on 0.2.9
 * add a Linux job with CHUTNEY_ALLOW_FAILURES=2 make test-network-all
 * implement SKIP_MAKE_TEST for the chutney job
 * create merge branches from 0.2.9 to master
 * merge to master and see how it goes, then backport all the way

 In #30859:
 * start on 0.3.5
 * SKIP_MAKE_TEST for stem jobs
 * create merge branches from 0.3.5 to master
 * merge to master and see how it goes, then backport all the way

 In #30860:
 * start on 0.2.9
 * add a macOS job with CHUTNEY_ALLOW_FAILURES=2 make test-network-all
 * implement SKIP_MAKE_TEST for the chutney job
 * create branches from 0.2.9 to master
 * merge to master and see how it goes
 * if it's taking too much time, stick it on the end of one of the other
 macOS jobs instead
 * backport all the way

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29280 [Core Tor/Tor]: Use Chutney in Tor's CI

[Tor Bug Tracker & Wiki]

#29280: Use Chutney in Tor's CI
-+-
 Reporter:  cohosh   |  Owner:  (none)
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  CI, PTs, 029-backport,   |  Actual Points:  1
  034-backport, 035-backport, 040-backport,  |
  network-team-roadmap-2019-Q1Q2, reviewer-was-  |
  teor-20190422, tor-ci, 041-deferred-20190530   |
Parent ID:  #29267   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor19
-+-

Comment (by teor):

 Replying to [comment:25 nickm]:
 > Summarizing for my benefit, here are the changes I need to make:
 >   * Make a new test-network-ci target that behaves like test-network-
 all, but only runs the selected networks for CI (bridges-min, hs-v2-min,
 and hs-v3-min where supported).  This should happen after #30459 is
 merged, so that we can have chutney handle the skip logic.

 Let's just use test-network-all?
 All of the networks in test-network-all work fine in chutney's CI.

 Let's add a Linux job, and a macOS job (for IPv6).
 Once we're sure chutney is stable in Tor's CI, and we know how much time
 it takes, we can think about adding it to the end of one of the other
 jobs.
 (Or we can remove or combine some of the existing jobs.)

 >   * Open a ticket to disable "make check" for stem.  Do this after stem
 is allow_failure, to avoid conflects.
 >   * Re-do the merges to 0.3.5 and forward; drop plans to support 0.3.4.
 Make sure that I get the use of SKIP_MAKE_TEST right.
 >
 > I think that I am currently blocked on the allow_failure change in stem
 and the merge of #30459.

 I think they've both been merged, do you need stem allow_failures
 backported to 0.3.5?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29280 [Core Tor/Tor]: Use Chutney in Tor's CI

[Tor Bug Tracker & Wiki]

#29280: Use Chutney in Tor's CI
-+-
 Reporter:  cohosh   |  Owner:  (none)
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  CI, PTs, 029-backport,   |  Actual Points:  1
  034-backport, 035-backport, 040-backport,  |
  network-team-roadmap-2019-Q1Q2, reviewer-was-  |
  teor-20190422, tor-ci, 041-deferred-20190530   |
Parent ID:  #29267   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor19
-+-

Comment (by nickm):

 Summarizing for my benefit, here are the changes I need to make:
   * Make a new test-network-ci target that behaves like test-network-all,
 but only runs the selected networks for CI (bridges-min, hs-v2-min, and
 hs-v3-min where supported).  This should happen after #30459 is merged, so
 that we can have chutney handle the skip logic.
   * Open a ticket to disable "make check" for stem.  Do this after stem is
 allow_failure, to avoid conflects.
   * Re-do the merges to 0.3.5 and forward; drop plans to support 0.3.4.
 Make sure that I get the use of SKIP_MAKE_TEST right.

 I think that I am currently blocked on the allow_failure change in stem
 and the merge of #30459.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29280 [Core Tor/Tor]: Use Chutney in Tor's CI

[Tor Bug Tracker & Wiki]

#29280: Use Chutney in Tor's CI
-+-
 Reporter:  cohosh   |  Owner:  (none)
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  CI, PTs, 029-backport,   |  Actual Points:  1
  034-backport, 035-backport, 040-backport,  |
  network-team-roadmap-2019-Q1Q2, reviewer-was-  |
  teor-20190422, tor-ci, 041-deferred-20190530   |
Parent ID:  #29267   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor19
-+-

Comment (by nickm):

 Sure, I'd be happy to make these changes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29280 [Core Tor/Tor]: Use Chutney in Tor's CI

[Tor Bug Tracker & Wiki]

#29280: Use Chutney in Tor's CI
-+-
 Reporter:  cohosh   |  Owner:  (none)
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  CI, PTs, 029-backport,   |  Actual Points:  1
  034-backport, 035-backport, 040-backport,  |
  network-team-roadmap-2019-Q1Q2, reviewer-was-  |
  teor-20190422, tor-ci, 041-deferred-20190530   |
Parent ID:  #29267   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor19
-+-

Comment (by teor):

 Hi nickm, would you like to do the revisions in comments 16 and 17, or
 would you like me to do them?

 I'm going to merge #29729 soon, so we can merge #29024 and #30459.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29280 [Core Tor/Tor]: Use Chutney in Tor's CI

[Tor Bug Tracker & Wiki]

#29280: Use Chutney in Tor's CI
-+-
 Reporter:  cohosh   |  Owner:  (none)
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  CI, PTs, 029-backport,   |  Actual Points:  1
  034-backport, 035-backport, 040-backport,  |
  network-team-roadmap-2019-Q1Q2, reviewer-was-  |
  teor-20190422  |
Parent ID:  #29267   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor19
-+-

Comment (by teor):

 I'd like to block merging the chutney job in Tor's CI (#29280) until I get
 back.
 (This ticket is in needs_revision, so feel free to do revisions on it!)

 I think that's the wisest course of action: I want to be around to fix any
 CI failures (or instability) after we merge.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29280 [Core Tor/Tor]: Use Chutney in Tor's CI

[Tor Bug Tracker & Wiki]

#29280: Use Chutney in Tor's CI
-+-
 Reporter:  cohosh   |  Owner:  (none)
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  CI, PTs 029-backport 034-backport|  Actual Points:  1
  035-backport 040-backport, network-team-   |
  roadmap-2019-Q1Q2  |
Parent ID:  #29267   | Points:  1
 Reviewer:  teor |Sponsor:
 |  Sponsor19
-+-

Comment (by teor):

 Oops, I forgot to review 0.3.4 and later:

 I am not so sure about this part of the merge commit to 0.3.4:
 {{{
 ++- env: DISTCHECK="yes" RUST_OPTIONS="--enable-rust --enable-cargo-
 online-mode" HARDENING_OPTIONS="" SKIP_MAKE_CHECK="yes"
 }}}
 I don't think we should skip make check on the only online rust build. We
 could move online to the dirauth build, and skip make check on distcheck?

 Also, in future, let's try to do semantic changes like this in a separate
 commit?
 
https://trac.torproject.org/projects/tor/wiki/org/teams/NetworkTeam/MergePolicy?action=diff=11

 In 0.3.5, you dropped the SKIP_MAKE_CHECK you added in 0.3.4:
 {{{
  -## But without hardening (see above)
  -- env: DISTCHECK="yes" RUST_OPTIONS="--enable-rust --enable-cargo-
 online-mode" HARDENING_OPTIONS="" SKIP_MAKE_CHECK="yes"
  +- env: DISTCHECK="yes" RUST_OPTIONS="--enable-rust --enable-cargo-
 online-mode"
 }}}

 We should also re-run all these branches with the latest chutney.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29280 [Core Tor/Tor]: Use Chutney in Tor's CI

[Tor Bug Tracker & Wiki]

#29280: Use Chutney in Tor's CI
-+-
 Reporter:  cohosh   |  Owner:  (none)
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  CI, PTs 029-backport 034-backport|  Actual Points:  1
  035-backport 040-backport, network-team-   |
  roadmap-2019-Q1Q2  |
Parent ID:  #29267   | Points:  1
 Reviewer:  teor |Sponsor:
 |  Sponsor19
-+-
Changes (by teor):

 * status:  needs_review => needs_revision
 * points:   => 1


Comment:

 From a commit message:
 > Previously we had "make check" launched whenever DISTCHECK was
 > false.  Now we'd like to turn it off in a few other circumstances,
 > like running chutney.  Maybe stem too?

 Yes, let's turn off "make check" for stem.

 The default network in chutney is bridges+hs-v2, but I discovered in
 #29729 that it is really unstable in chutney's CI. (Sometimes all the jobs
 work, and sometimes multiple jobs fail. I think it might be due to network
 or CPU load issues on machines.)

 So let's change to a subset of the CI tests that work in chutney?

 So for 0.2.9, let's use:
 * bridges-min
 * hs-v2-min
 And for 0.3.4 and later, let's add:
 * hs-v3-min
 Each test should only take 30-60 seconds, so I think it's worth running
 these 3 tests. (That's about 2 extra minutes per branch, or an 18 extra
 minutes for a full merge-forward from 0.2.9.)

 Here's the full list of all the tests in chutney from #29729:
 https://github.com/torproject/chutney/pull/25/files#diff-
 354f30a63fb0907d4ad57269548329e3R29

 We're missing:
 * basic-min
 * single-onion-v23
 * and all the IPv6 tests
   * We can only run IPv6 tests in macOS Travis, because Linux Travis
 doesn't support IPv6.
 I opened #30212 to add them later.

 Then let's let CI run for a while to evaluate the chutney tests.

 If we think chutney is too unstable in Tor's Chutney job, or Chutney's CI,
 we could:
 * run chutney in offline mode (#30183), or
 * add a sleep after failure in test-network --forgiving (#30210).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29280 [Core Tor/Tor]: Use Chutney in Tor's CI

[Tor Bug Tracker & Wiki]

#29280: Use Chutney in Tor's CI
-+-
 Reporter:  cohosh   |  Owner:  (none)
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  CI, PTs 029-backport 034-backport|  Actual Points:  1
  035-backport 040-backport, network-team-   |
  roadmap-2019-Q1Q2  |
Parent ID:  #29267   | Points:
 Reviewer:  teor |Sponsor:
 |  Sponsor19
-+-

Comment (by teor):

 I've just finished #29729, and discovered a lot of interesting things
 about chutney, tor, and Travis in the process.

 I'll have some feedback on these pull requests tomorrow (~18 hours).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29280 [Core Tor/Tor]: Use Chutney in Tor's CI (was: Use Chutney for CI)

[Tor Bug Tracker & Wiki]

#29280: Use Chutney in Tor's CI
-+-
 Reporter:  cohosh   |  Owner:  (none)
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  CI, PTs 029-backport 034-backport|  Actual Points:  1
  035-backport 040-backport, network-team-   |
  roadmap-2019-Q1Q2  |
Parent ID:  #29267   | Points:
 Reviewer:  teor |Sponsor:
 |  Sponsor19
-+-

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs