Re: [tor-bugs] #29669 [Core Tor/Tor]: hs: ADD_ONION with NEW:BEST is still pinned on v2

2019-10-07 Thread Tor Bug Tracker & Wiki 
#29669: hs: ADD_ONION with NEW:BEST is still pinned on v2
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tor-hs, tor-control, hs-v3, tor- |  Actual Points:  0.1
  spec, security, 041-deferred-20190530  |
  042-should |
Parent ID:  #29995   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged both branches.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29669 [Core Tor/Tor]: hs: ADD_ONION with NEW:BEST is still pinned on v2

2019-10-07 Thread Tor Bug Tracker & Wiki 
#29669: hs: ADD_ONION with NEW:BEST is still pinned on v2
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tor-control, hs-v3, tor- |  Actual Points:  0.1
  spec, security, 041-deferred-20190530  |
  042-should |
Parent ID:  #29995   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 LGTM! Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29669 [Core Tor/Tor]: hs: ADD_ONION with NEW:BEST is still pinned on v2

2019-10-03 Thread Tor Bug Tracker & Wiki 
#29669: hs: ADD_ONION with NEW:BEST is still pinned on v2
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tor-control, hs-v3, tor- |  Actual Points:  0.1
  spec, security, 041-deferred-20190530  |
  042-should |
Parent ID:  #29995   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by dgoulet):

 * status:  needs_revision => needs_review


Comment:

 Spec: `ticket29669_01`

 I've also fixed the PR to be on latest master and remove that weird `;` in
 the changes file.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29669 [Core Tor/Tor]: hs: ADD_ONION with NEW:BEST is still pinned on v2

2019-09-13 Thread Tor Bug Tracker & Wiki 
#29669: hs: ADD_ONION with NEW:BEST is still pinned on v2
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tor-control, hs-v3, tor- |  Actual Points:  0.1
  spec, security, 041-deferred-20190530  |
  042-should |
Parent ID:  #29995   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Patch LGTM but the changes file ends in a weird semicolon instead of a
 colon.
 Also we need a spec file and we should be good. Marking as needs_revision
 for the above.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29669 [Core Tor/Tor]: hs: ADD_ONION with NEW:BEST is still pinned on v2

2019-09-11 Thread Tor Bug Tracker & Wiki 
#29669: hs: ADD_ONION with NEW:BEST is still pinned on v2
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tor-control, hs-v3, tor- |  Actual Points:  0.1
  spec, security, 041-deferred-20190530  |
  042-should |
Parent ID:  #29995   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by dgoulet):

 * status:  accepted => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29669 [Core Tor/Tor]: hs: ADD_ONION with NEW:BEST is still pinned on v2

2019-09-11 Thread Tor Bug Tracker & Wiki 
#29669: hs: ADD_ONION with NEW:BEST is still pinned on v2
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  accepted
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tor-control, hs-v3, tor- |  Actual Points:  0.1
  spec, security, 041-deferred-20190530  |
  042-should |
Parent ID:  #29995   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by dgoulet):

 * owner:  (none) => dgoulet
 * status:  needs_review => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29669 [Core Tor/Tor]: hs: ADD_ONION with NEW:BEST is still pinned on v2

2019-09-11 Thread Tor Bug Tracker & Wiki 
#29669: hs: ADD_ONION with NEW:BEST is still pinned on v2
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tor-control, hs-v3, tor- |  Actual Points:  0.1
  spec, security, 041-deferred-20190530  |
  042-should |
Parent ID:  #29995   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by dgoulet):

 * status:  new => needs_review
 * reviewer:   => asn
 * actualpoints:   => 0.1


Comment:

 PR: https://github.com/torproject/tor/pull/1317
 Branch: `ticket29669_042_01`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29669 [Core Tor/Tor]: hs: ADD_ONION with NEW:BEST is still pinned on v2

2019-09-11 Thread Tor Bug Tracker & Wiki 
#29669: hs: ADD_ONION with NEW:BEST is still pinned on v2
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tor-control, hs-v3, tor- |  Actual Points:
  spec, security, 041-deferred-20190530  |
  042-should |
Parent ID:  #29995   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor27-must
-+-
Changes (by dgoulet):

 * sponsor:   => Sponsor27-must
 * parent:   => #29995


Comment:

 Falls under s27 for feature parity and stability.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29669 [Core Tor/Tor]: hs: ADD_ONION with NEW:BEST is still pinned on v2

2019-09-10 Thread Tor Bug Tracker & Wiki 
#29669: hs: ADD_ONION with NEW:BEST is still pinned on v2
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tor-control, hs-v3, tor- |  Actual Points:
  spec, security, 041-deferred-20190530  |
  042-should |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  tor-hs, tor-control, hs-v3, tor-spec, security,
 041-deferred-20190530 =>
 tor-hs, tor-control, hs-v3, tor-spec, security, 041-deferred-20190530
 042-should


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29669 [Core Tor/Tor]: hs: ADD_ONION with NEW:BEST is still pinned on v2

2019-03-06 Thread Tor Bug Tracker & Wiki 
#29669: hs: ADD_ONION with NEW:BEST is still pinned on v2
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor: 0.4.1.x-final
Component:  Core |Version:  Tor: 0.3.5.1-alpha
  Tor/Tor|   Keywords:  tor-hs, tor-control, hs-v3, tor-
 Severity:  Normal   |  spec
Actual Points:   |  Parent ID:
   Points:  1|   Reviewer:
  Sponsor:   |
-+-
 Even though the control spec says:

 {{{
   (The "NEW:BEST" option obeys the HiddenServiceVersion torrc option
 default
   value. Since 0.3.5.1-alpha, it is 3. For Tor versions before
 0.3.5.1-alpha,
   default HiddenServiceVersion is 2.)
 }}}

 ... in control.c, the `ADD_ONION` command has this condition that
 basically pins the `NEW:BEST` to v2:

 {{{
 if (!strcasecmp(key_type_rsa1024, key_blob) ||
 !strcasecmp(key_type_best, key_blob)) {
   /* "RSA1024", RSA 1024 bit, also currently "BEST" by default. */
 }}}

 Not good! `NEW:BEST` should obey the default version, not something
 hardcoded like so. This will need a spec update to mention the correct tor
 version.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs