Re: [tor-bugs] #30334 [Applications/Tor Browser]: build_go_lib for executables?

[Tor Bug Tracker & Wiki]

#30334: build_go_lib for executables?
-+-
 Reporter:  JeremyRand   |  Owner:  gk
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen202006,  |  Actual Points:
  TorBrowserTeam202006   |
Parent ID:   | Points:
 Reviewer:  JeremyRand   |Sponsor:
-+-

Comment (by JeremyRand):

 Apologies for the slow responses on my end here; happy to review this once
 it's rebased.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30334 [Applications/Tor Browser]: build_go_lib for executables?

[Tor Bug Tracker & Wiki]

#30334: build_go_lib for executables?
-+-
 Reporter:  JeremyRand   |  Owner:  gk
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen202006,  |  Actual Points:
  TorBrowserTeam202006   |
Parent ID:   | Points:
 Reviewer:  JeremyRand   |Sponsor:
-+-
Changes (by gk):

 * owner:  tbb-team => gk
 * status:  needs_revision => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30334 [Applications/Tor Browser]: build_go_lib for executables?

[Tor Bug Tracker & Wiki]

#30334: build_go_lib for executables?
-+-
 Reporter:  JeremyRand   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen202006,  |  Actual Points:
  TorBrowserTeam202006   |
Parent ID:   | Points:
 Reviewer:  JeremyRand   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-rbm, TorBrowserTeam202004R => tbb-rbm, GeorgKoppen202006,
 TorBrowserTeam202006
 * status:  assigned => needs_revision


Comment:

 Gonna rebase this once more and then ping JeremyRand.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30334 [Applications/Tor Browser]: build_go_lib for executables?

[Tor Bug Tracker & Wiki]

#30334: build_go_lib for executables?
+--
 Reporter:  JeremyRand  |  Owner:  boklm
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam202004R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  JeremyRand  |Sponsor:
+--
Changes (by pili):

 * reviewer:  boklm => JeremyRand


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30334 [Applications/Tor Browser]: build_go_lib for executables?

[Tor Bug Tracker & Wiki]

#30334: build_go_lib for executables?
+--
 Reporter:  JeremyRand  |  Owner:  boklm
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201912R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  boklm   |Sponsor:
+--

Comment (by boklm):

 I rebased the patch on master in branch `bug_30334_v2`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_30334_v2=debe3ddd8e3967d4b56632a9b11b7cde14e01f16

 I had to adapt the changes from #28803 in `projects/obfs4/build` to do
 them in `projects/obfs4/config`.

 JeremyRand: Could you check whether the patch still looks good for you?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30334 [Applications/Tor Browser]: build_go_lib for executables?

[Tor Bug Tracker & Wiki]

#30334: build_go_lib for executables?
+--
 Reporter:  JeremyRand  |  Owner:  boklm
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201911R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by sysrqb):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30334 [Applications/Tor Browser]: build_go_lib for executables?

[Tor Bug Tracker & Wiki]

#30334: build_go_lib for executables?
+--
 Reporter:  JeremyRand  |  Owner:  boklm
 Type:  enhancement | Status:  assigned
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201911R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by JeremyRand):

 > I'm not certain whether the patch in this ticket exposes reproducibility
 issues, but if it does, #31691 and #31688 are the most likely culprits.

 Further investigation suggests that the changes in this ticket's patch
 won't expose any new reproducibility issues.  (I was wondering if the
 usage of `go install` instead of `go build` will expose build paths, but
 testing confirms that this isn't a problem.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30334 [Applications/Tor Browser]: build_go_lib for executables?

[Tor Bug Tracker & Wiki]

#30334: build_go_lib for executables?
+--
 Reporter:  JeremyRand  |  Owner:  boklm
 Type:  enhancement | Status:  assigned
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201911R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by JeremyRand):

 I'm not certain whether the patch in this ticket exposes reproducibility
 issues, but if it does, #31691 and #31688 are the most likely culprits.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30334 [Applications/Tor Browser]: build_go_lib for executables?

[Tor Bug Tracker & Wiki]

#30334: build_go_lib for executables?
-+-
 Reporter:  JeremyRand   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201910R,  |  Actual Points:
  TorBrowserTeam201911   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:6 JeremyRand]:
 > Thanks for the review @boklm.  I've made the requested changes, Git
 commit hash 07fc3310bcee2d39def889b48c2d7120d4b96e48.  To make it easier
 to review the new changes, I didn't yet squash the commits; let me know if
 you'd like me to squash them prior to a merge.

 I rebased/adapted the patch on master:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_30334=ca460ed70d8726ae1c6805ab1e870d230ded951e

 However I did not check yet that it still builds correctly.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30334 [Applications/Tor Browser]: build_go_lib for executables?

[Tor Bug Tracker & Wiki]

#30334: build_go_lib for executables?
+--
 Reporter:  JeremyRand  |  Owner:  tbb-team
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201907R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * keywords:  tbb-rbm, TorBrowserTeam201906 => tbb-rbm,
   TorBrowserTeam201907R
 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30334 [Applications/Tor Browser]: build_go_lib for executables?

[Tor Bug Tracker & Wiki]

#30334: build_go_lib for executables?
---+---
 Reporter:  JeremyRand |  Owner:  tbb-team
 Type:  enhancement| Status:
   |  needs_revision
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201906  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---

Comment (by JeremyRand):

 Thanks for the review @boklm.  I've made the requested changes, Git commit
 hash 07fc3310bcee2d39def889b48c2d7120d4b96e48.  To make it easier to
 review the new changes, I didn't yet squash the commits; let me know if
 you'd like me to squash them prior to a merge.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30334 [Applications/Tor Browser]: build_go_lib for executables?

[Tor Bug Tracker & Wiki]

#30334: build_go_lib for executables?
---+---
 Reporter:  JeremyRand |  Owner:  tbb-team
 Type:  enhancement| Status:
   |  needs_revision
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201906  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by boklm):

 * keywords:  tbb-rbm, TorBrowserTeam201906R => tbb-rbm,
   TorBrowserTeam201906
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:3 JeremyRand]:
 > Patch at https://notabug.org/JeremyRand/tor-browser-build/src/build-go-
 lib-exe (commit hash 690a8334a7c7c3e7db40f09783da7096d5ab4c56).  There was
 indeed a lot of boilerplate / duplicated code present in
 meek/obfs4/snowflake, and I think this patch does a reasonably good job of
 improving the situation.  I definitely find the code easier to read with
 this patch applied, though admittedly this is subjective and I'm probably
 biased toward finding code that I wrote easy to read.

 I think this looks mostly good.

 A possible improvement is to add a `var/build_go_lib_post` option, move
 the instructions to generate the archives there, and then remove the
 `build` files. This will avoid having part of the custom instructions in
 `config` and an other part in `build`.

 An other minor thing is the missing indentation after the `IF
 !c("var/go_lib_no_output")`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30334 [Applications/Tor Browser]: build_go_lib for executables?

[Tor Bug Tracker & Wiki]

#30334: build_go_lib for executables?
+--
 Reporter:  JeremyRand  |  Owner:  tbb-team
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201906R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * status:  new => needs_review
 * keywords:  tbb-rbm => tbb-rbm, TorBrowserTeam201906R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30334 [Applications/Tor Browser]: build_go_lib for executables?

[Tor Bug Tracker & Wiki]

#30334: build_go_lib for executables?
--+--
 Reporter:  JeremyRand|  Owner:  tbb-team
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by JeremyRand):

 Patch at https://notabug.org/JeremyRand/tor-browser-build/src/build-go-
 lib-exe (commit hash 690a8334a7c7c3e7db40f09783da7096d5ab4c56).  There was
 indeed a lot of boilerplate / duplicated code present in
 meek/obfs4/snowflake, and I think this patch does a reasonably good job of
 improving the situation.  I definitely find the code easier to read with
 this patch applied, though admittedly this is subjective and I'm probably
 biased toward finding code that I wrote easy to read.

 Feel free to review.  I've tested all of the build targets that I could
 think of to make sure that it builds without errors and that the outputs
 of meek/obfs4/snowflake look sane when untarred, but I haven't tested the
 resulting Tor Browser binaries.

 As a side note, this patch would make my life easier with regards to
 #30558, since solving that ticket involves adding another Go executable,
 which exacerbates the code duplication issues unless this patch is
 applied.  (I'm not familiar enough with Trac culture to know how to tag
 that relationship, or whether I even have the needed privs to do so.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30334 [Applications/Tor Browser]: build_go_lib for executables?

[Tor Bug Tracker & Wiki]

#30334: build_go_lib for executables?
--+--
 Reporter:  JeremyRand|  Owner:  tbb-team
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by boklm):

 > Would a patch be accepted that adapted the meek/obfs4/snowflake projects
 in tor-browser-build to use build_go_lib (or an executable-focused
 analogue of it)?

 I think yes, if it allows to cut down on boilerplate / code duplication
 and does not make things more complex.

 The reason I added `build_go_lib` was that all the go libraries are built
 in the same way, with little differences, so having some instructions that
 works for all of them was easy. For meek/obfs4/snowflake, there are lot
 more differences, so it's more difficult to do, and less clear whether it
 is worth it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30334 [Applications/Tor Browser]: build_go_lib for executables?

[Tor Bug Tracker & Wiki]

#30334: build_go_lib for executables?
--+--
 Reporter:  JeremyRand|  Owner:  tbb-team
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * cc: boklm (added)
 * keywords:   => tbb-rbm


Comment:

 Not sure actually. boklm might know, though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #30334 [Applications/Tor Browser]: build_go_lib for executables?

[Tor Bug Tracker & Wiki]

#30334: build_go_lib for executables?
-+--
 Reporter:  JeremyRand   |  Owner:  tbb-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Component:  Applications/Tor Browser
  Version:   |   Severity:  Normal
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
 Is there a reason that build_go_lib (from the go project in tor-browser-
 build) is only used for libraries and not executables?  At first glance,
 it seems to me that using it (or something very similar) for executables
 as well would cut down on boilerplate / code duplication.  Would a patch
 be accepted that adapted the meek/obfs4/snowflake projects in tor-browser-
 build to use build_go_lib (or an executable-focused analogue of it)?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs