Re: [tor-bugs] #30552 [Applications/Tor Browser]: Android - Clean up torrc

[Tor Bug Tracker & Wiki]

#30552: Android - Clean up torrc
---+---
 Reporter:  sysrqb |  Owner:  tbb-team
 Type:  defect | Status:
   |  needs_review
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam202004R  |  Actual Points:  1
Parent ID: | Points:  0.5
 Reviewer:  sysrqb |Sponsor:
---+---

Comment (by cypherpunks):

 TorBrowserTeam202006R ?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30552 [Applications/Tor Browser]: Android - Clean up torrc

[Tor Bug Tracker & Wiki]

#30552: Android - Clean up torrc
---+---
 Reporter:  sysrqb |  Owner:  tbb-team
 Type:  defect | Status:
   |  needs_review
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201912R  |  Actual Points:  1
Parent ID: | Points:  0.5
 Reviewer:  sysrqb |Sponsor:
---+---
Changes (by sisbell):

 * actualpoints:   => 1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30552 [Applications/Tor Browser]: Android - Clean up torrc

[Tor Bug Tracker & Wiki]

#30552: Android - Clean up torrc
---+---
 Reporter:  sysrqb |  Owner:  tbb-team
 Type:  defect | Status:
   |  needs_review
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201911R  |  Actual Points:
Parent ID: | Points:  0.5
 Reviewer: |Sponsor:
---+---
Changes (by sisbell):

 * keywords:  tbb-mobile, TorBrowserTeam201911 => tbb-mobile,
 TorBrowserTeam201911R
 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30552 [Applications/Tor Browser]: Android - Clean up torrc

[Tor Bug Tracker & Wiki]

#30552: Android - Clean up torrc
--+
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:
  |  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201911  |  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+

Comment (by sisbell):

 I made the change to accept 0 value for a port and null will assign "auto"
 as the value. Anything less than 0 will throw an IllegalArgumentException.
 This is a runtime exception so we won't start tor at all if user passes in
 negative value. I added unit tests to verify behavior.

 
https://github.com/sisbell/Tor_Onion_Proxy_Library/commit/47b53aeb243639a3ffd46916d88111d71e8ea124

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30552 [Applications/Tor Browser]: Android - Clean up torrc

[Tor Bug Tracker & Wiki]

#30552: Android - Clean up torrc
--+
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:
  |  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201911  |  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+

Comment (by sisbell):

 I'm looking into how to handle SocksPort with an Integer (if possible):
 * negative, throw exception
 * >=0 pass directly
 * null is "auto"
 * unix file path(???) not quite sure how to handle this with an Int

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30552 [Applications/Tor Browser]: Android - Clean up torrc

[Tor Bug Tracker & Wiki]

#30552: Android - Clean up torrc
--+
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:
  |  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201911  |  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+

Comment (by sisbell):

 I'll do the following: throw exception if port less than 1. accept any
 value >=0, and treat null as auto.

 According to the specs transparentProxyPort (as well all tunnel port) are
 0 default, which means it is disabled. So I'm thinking TOPL should not
 have any default values. If Orbot needs these values set, it can set them
 through the prefs backing the AndroidTorSettings impl.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30552 [Applications/Tor Browser]: Android - Clean up torrc

[Tor Bug Tracker & Wiki]

#30552: Android - Clean up torrc
--+
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:
  |  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201910  |  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+

Comment (by sysrqb):

 Replying to [comment:13 sisbell]:
 > Replying to [comment:8 sysrqb]:
 > >
 > >
 
`universal/src/main/java/com/msopentech/thali/toronionproxy/DefaultSettings.java`
 > > {{{
 > >  @Override
 > > -public int getHttpTunnelPort() {
 > > -return 8118;
 > > +public String getHttpTunnelHost() {
 > > +return null;
 > > +}
 > > +
 > > +@Override
 > > +public Integer getHttpTunnelPort() {
 > > +return null;
 > >  }
 > > }}}
 > > This is changing the default port, is that intentional?
 >
 > Yes, I don't believe we use this by default. it can be set in tor-
 android-service if needed.
 > >
 > > {{{
 > >  @Override
 > > -public String transPort() {
 > > -return "9040";
 > > +public String getTransparentProxyAddress() {
 > > +return null;
 > > +}
 > > +
 > > +@Override
 > > +public Integer getTransparentProxyPort() {
 > > +return null;
 > > }}}
 > > This is changing the default port, is that intentional?
 > Yes, I don't believe we use this by default. it can be set in tor-
 android-service if needed.
 > >

 Okay, it seems a little weird to change the default value in TOPL instead
 of change the values we want in `AndroidTorSettings` (in tor-android-
 service), but if this will be accepted by upstream then that's fine.

 > > {{{
 > > +TorConfigBuilder addAddress(String fieldName, String address,
 Integer port, String flags) {
 > > +if(isNullOrEmpty(address) && port == null) {
 > > +return this;
 > > +}
 > > +buffer.append(fieldName).append(" ");
 > > +if(!isNullOrEmpty(address)) {
 > > +buffer.append(address).append(":");
 > > +}
 > > +if (port != null) {
 > > +buffer.append(port <= 0 ? "auto" : port);
 > > }}}
 > > Please pass this directly to tor, we shouldn't change the intended
 behavior if the app configures a 0 or negative port number. Tor will emit
 a warning which the app should handle itself.
 > The negative int or null value is treated a "magic" number for "auto".
 This is really because tor config accepts strings (auto) or int types for
 port so we have to be able to handle this somehow.

 The `null` check is fine, but `0` has a special meaning, so that should be
 passed unmodified to tor. Do we need both `null` and negative integers
 representing `auto`?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30552 [Applications/Tor Browser]: Android - Clean up torrc

[Tor Bug Tracker & Wiki]

#30552: Android - Clean up torrc
--+
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:
  |  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201910  |  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+

Comment (by sysrqb):

 Replying to [comment:12 sisbell]:
 > Replying to [comment:10 sysrqb]:
 > > Something else, but not for this ticket, is that TOPL should be
 consistent about how it handles integer config options.
 > >
 > > {{{
 > > @Override
 > > public String getSocksPort() {
 > > return "9050";
 > > }
 > > }}}
 > >
 >
 > I left this since we also need to handle "auto" and we have the auto
 detect on the port so its a bigger change for this field.
 Okay. That's unfortunate, but it's fine for now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30552 [Applications/Tor Browser]: Android - Clean up torrc

[Tor Bug Tracker & Wiki]

#30552: Android - Clean up torrc
--+
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:
  |  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201910  |  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+

Comment (by sisbell):

 Replying to [comment:8 sysrqb]:
 > Replying to [comment:6 sisbell]:
 > > I made the following changes to tor-onion-proxy-library. If the
 changes look good, I will need to make it compatible with tor-android-
 service.
 >
 > I think it would make more sense leaving TOPL's defaults unchanged, as
 much as possible. I don't see a problem with explicitly setting default
 values in the torrc (like `TestSocks 0`), but I do like cleaner defaults
 and a cleaner/smaller generated torrc.
 >
 >
 > >
 > > * StrictNodes, UseBridges, SafeSocks, TestSocks will not be included
 in the torrc if they have a 0 value
 >
 > I don't have a strong opinion on this. It doesn't really have any impact
 until tor's default values change for whatever reason.
 >
 >
 > > * DnsPort, HttpTunnelPort, TransparentProxyPort are now all Integers.
 I also added an associated host field for each one.
 > > * ProxyPort, ProxySocks5ServerPort are now an Integers rather than
 Strings.
 > > * HttpTunnelPort and TransPort values are set to null so it won't
 appear in torrc by default.
 > > * AutomapHostsOnResolve is set to false so won't appear in torrc by
 default
 >
 > These are the more important changes.
 >
 >
 > >
 > > The remaining field VirtualAddrNetwork will need to be removed in tor-
 android-service
 > >
 > >
 
https://github.com/sisbell/Tor_Onion_Proxy_Library/commit/73aeed144259a66930e605c7804946c9f6041b59
 > >
 >
 >
 
`universal/src/main/java/com/msopentech/thali/toronionproxy/DefaultSettings.java`
 > {{{
 >  @Override
 > -public int getHttpTunnelPort() {
 > -return 8118;
 > +public String getHttpTunnelHost() {
 > +return null;
 > +}
 > +
 > +@Override
 > +public Integer getHttpTunnelPort() {
 > +return null;
 >  }
 > }}}
 > This is changing the default port, is that intentional?

 Yes, I don't believe we use this by default. it can be set in tor-android-
 service if needed.
 >
 > {{{
 >  @Override
 > -public String transPort() {
 > -return "9040";
 > +public String getTransparentProxyAddress() {
 > +return null;
 > +}
 > +
 > +@Override
 > +public Integer getTransparentProxyPort() {
 > +return null;
 > }}}
 > This is changing the default port, is that intentional?
 Yes, I don't believe we use this by default. it can be set in tor-android-
 service if needed.
 >
 > {{{
 > +TorConfigBuilder addAddress(String fieldName, String address,
 Integer port, String flags) {
 > +if(isNullOrEmpty(address) && port == null) {
 > +return this;
 > +}
 > +buffer.append(fieldName).append(" ");
 > +if(!isNullOrEmpty(address)) {
 > +buffer.append(address).append(":");
 > +}
 > +if (port != null) {
 > +buffer.append(port <= 0 ? "auto" : port);
 > }}}
 > Please pass this directly to tor, we shouldn't change the intended
 behavior if the app configures a 0 or negative port number. Tor will emit
 a warning which the app should handle itself.
 The negative int or null value is treated a "magic" number for "auto".
 This is really because tor config accepts strings (auto) or int types for
 port so we have to be able to handle this somehow.

 >
 >
 
`universal/src/test/java/com/msopentech/thali/toronionproxy/TorConfigBuilderTest.java`
 >
 > {{{
 > +/**
 > + * SHould be empty
 > + */
 > }}}
 > nit.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30552 [Applications/Tor Browser]: Android - Clean up torrc

[Tor Bug Tracker & Wiki]

#30552: Android - Clean up torrc
--+
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:
  |  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201910  |  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+

Comment (by sisbell):

 Replying to [comment:10 sysrqb]:
 > Something else, but not for this ticket, is that TOPL should be
 consistent about how it handles integer config options.
 >
 > {{{
 > @Override
 > public String getSocksPort() {
 > return "9050";
 > }
 > }}}
 >

 I left this since we also need to handle "auto" and we have the auto
 detect on the port so its a bigger change for this field.
 > At this point, I don't think it matters if they are stored and handled
 as Strings or Integers, but they should all be the same.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30552 [Applications/Tor Browser]: Android - Clean up torrc

[Tor Bug Tracker & Wiki]

#30552: Android - Clean up torrc
--+
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:
  |  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201910  |  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+
Changes (by sysrqb):

 * keywords:  tbb-mobile, TorBrowserTeam201910R => tbb-mobile,
 TorBrowserTeam201910


Comment:

 sigh.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30552 [Applications/Tor Browser]: Android - Clean up torrc

[Tor Bug Tracker & Wiki]

#30552: Android - Clean up torrc
---+---
 Reporter:  sysrqb |  Owner:  tbb-team
 Type:  defect | Status:
   |  needs_revision
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201910R  |  Actual Points:
Parent ID: | Points:  0.5
 Reviewer: |Sponsor:
---+---
Changes (by sysrqb):

 * keywords:  tbb-mobile, TorBrowserTeam201910 => tbb-mobile,
 TorBrowserTeam201910R


Comment:

 Something else, but not for this ticket, is that TOPL should be consistent
 about how it handles integer config options.

 {{{
 @Override
 public String getSocksPort() {
 return "9050";
 }
 }}}

 At this point, I don't think it matters if they are stored and handled as
 Strings or Integers, but they should all be the same.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30552 [Applications/Tor Browser]: Android - Clean up torrc

[Tor Bug Tracker & Wiki]

#30552: Android - Clean up torrc
---+---
 Reporter:  sysrqb |  Owner:  tbb-team
 Type:  defect | Status:
   |  needs_revision
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201910R  |  Actual Points:
Parent ID: | Points:  0.5
 Reviewer: |Sponsor:
---+---
Changes (by sysrqb):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:6 sisbell]:
 > I made the following changes to tor-onion-proxy-library. If the changes
 look good, I will need to make it compatible with tor-android-service.

 I think it would make more sense leaving TOPL's defaults unchanged, as
 much as possible. I don't see a problem with explicitly setting default
 values in the torrc (like `TestSocks 0`), but I do like cleaner defaults
 and a cleaner/smaller generated torrc.


 >
 > * StrictNodes, UseBridges, SafeSocks, TestSocks will not be included in
 the torrc if they have a 0 value

 I don't have a strong opinion on this. It doesn't really have any impact
 until tor's default values change for whatever reason.


 > * DnsPort, HttpTunnelPort, TransparentProxyPort are now all Integers. I
 also added an associated host field for each one.
 > * ProxyPort, ProxySocks5ServerPort are now an Integers rather than
 Strings.
 > * HttpTunnelPort and TransPort values are set to null so it won't appear
 in torrc by default.
 > * AutomapHostsOnResolve is set to false so won't appear in torrc by
 default

 These are the more important changes.


 >
 > The remaining field VirtualAddrNetwork will need to be removed in tor-
 android-service
 >
 >
 
https://github.com/sisbell/Tor_Onion_Proxy_Library/commit/73aeed144259a66930e605c7804946c9f6041b59
 >

 
`universal/src/main/java/com/msopentech/thali/toronionproxy/DefaultSettings.java`
 {{{
  @Override
 -public int getHttpTunnelPort() {
 -return 8118;
 +public String getHttpTunnelHost() {
 +return null;
 +}
 +
 +@Override
 +public Integer getHttpTunnelPort() {
 +return null;
  }
 }}}
 This is changing the default port, is that intentional?

 {{{
  @Override
 -public String transPort() {
 -return "9040";
 +public String getTransparentProxyAddress() {
 +return null;
 +}
 +
 +@Override
 +public Integer getTransparentProxyPort() {
 +return null;
 }}}
 This is changing the default port, is that intentional?

 {{{
 +TorConfigBuilder addAddress(String fieldName, String address, Integer
 port, String flags) {
 +if(isNullOrEmpty(address) && port == null) {
 +return this;
 +}
 +buffer.append(fieldName).append(" ");
 +if(!isNullOrEmpty(address)) {
 +buffer.append(address).append(":");
 +}
 +if (port != null) {
 +buffer.append(port <= 0 ? "auto" : port);
 }}}
 Please pass this directly to tor, we shouldn't change the intended
 behavior if the app configures a 0 or negative port number. Tor will emit
 a warning which the app should handle itself.

 
`universal/src/test/java/com/msopentech/thali/toronionproxy/TorConfigBuilderTest.java`

 {{{
 +/**
 + * SHould be empty
 + */
 }}}
 nit.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30552 [Applications/Tor Browser]: Android - Clean up torrc

[Tor Bug Tracker & Wiki]

#30552: Android - Clean up torrc
---+---
 Reporter:  sysrqb |  Owner:  tbb-team
 Type:  defect | Status:
   |  needs_review
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201910R  |  Actual Points:
Parent ID: | Points:  0.5
 Reviewer: |Sponsor:
---+---
Changes (by gk):

 * keywords:  tbb-mobile, TorBrowserTeam201910 => tbb-mobile,
 TorBrowserTeam201910R


Comment:

 sisbell: please add the review keyword (TorBrowserTeam2019YYYMMR) if you
 put tickets into `needs_review`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30552 [Applications/Tor Browser]: Android - Clean up torrc

[Tor Bug Tracker & Wiki]

#30552: Android - Clean up torrc
--+
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:
  |  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201910  |  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+
Changes (by sisbell):

 * cc: gk (added)
 * status:  new => needs_review


Comment:

 I made the following changes to tor-onion-proxy-library. If the changes
 look good, I will need to make it compatible with tor-android-service.

 * StrictNodes, UseBridges, SafeSocks, TestSocks will not be included in
 the torrc if they have a 0 value
 * DnsPort, HttpTunnelPort, TransparentProxyPort are now all Integers. I
 also added an associated host field for each one.
 * ProxyPort, ProxySocks5ServerPort are now an Integers rather than
 Strings.
 * HttpTunnelPort and TransPort values are set to null so it won't appear
 in torrc by default.
 * AutomapHostsOnResolve is set to false so won't appear in torrc by
 default

 The remaining field VirtualAddrNetwork will need to be removed in tor-
 android-service

 
https://github.com/sisbell/Tor_Onion_Proxy_Library/commit/73aeed144259a66930e605c7804946c9f6041b59

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30552 [Applications/Tor Browser]: Android - Clean up torrc

[Tor Bug Tracker & Wiki]

#30552: Android - Clean up torrc
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201910  |  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+--

Comment (by sisbell):

 From investigating, we don't need the following since 0 is the default
 value

  * StrictNodes 0
  * UseBridges 0
  * SafeSocks 0
  * TestSocks 0

 The following also don't need to be set as far as I can tell (they are
 their specifically for Orbot support)

  * AutomapHostsOnResolve 1
  * HTTPTunnelPort 8218
  * TransPort 9140
  * VirtualAddrNetwork 10.192.0.0/10

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30552 [Applications/Tor Browser]: Android - Clean up torrc

[Tor Bug Tracker & Wiki]

#30552: Android - Clean up torrc
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201910  |  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+--
Changes (by sisbell):

 * keywords:  tbb-mobile => tbb-mobile, TorBrowserTeam201910
 * points:  0.25 => 0.5


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30552 [Applications/Tor Browser]: Android - Clean up torrc

[Tor Bug Tracker & Wiki]

#30552: Android - Clean up torrc
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile|  Actual Points:
Parent ID:| Points:  0.25
 Reviewer:|Sponsor:
--+--

Comment (by sisbell):

 From what I can tell, we have a bunch of entries with 0 value (the
 defaults for those fields). I'll remove those. It requires switching from
 primitive int to class Integer so we can detect if the value is null and
 shouldn't be set.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30552 [Applications/Tor Browser]: Android - Clean up torrc

[Tor Bug Tracker & Wiki]

#30552: Android - Clean up torrc
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile|  Actual Points:
Parent ID:| Points:  0.25
 Reviewer:|Sponsor:
--+--

Comment (by sisbell):

 I'm not clear from the referenced issues which config entries we should
 remove.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30552 [Applications/Tor Browser]: Android - Clean up torrc

[Tor Bug Tracker & Wiki]

#30552: Android - Clean up torrc
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile|  Actual Points:
Parent ID:| Points:  0.25
 Reviewer:|Sponsor:
--+--
Changes (by sysrqb):

 * points:   => 0.25


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #30552 [Applications/Tor Browser]: Android - Clean up torrc

[Tor Bug Tracker & Wiki]

#30552: Android - Clean up torrc
--+
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-mobile
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 As mentioned in ticket:30284#comment:22 and shown in
 ticket:30518#comment:3, the current torrc file has many entries we don't
 need. Let's clean out that file and only include the pieces we need.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs