Re: [tor-bugs] #30691 [Core Tor/Tor]: Refactor decoding outside the if expression in dirserv_load_fingerprint_file()

2019-06-13 Thread Tor Bug Tracker & Wiki
#30691: Refactor decoding outside the if expression in
dirserv_load_fingerprint_file()
+--
 Reporter:  teor|  Owner:  neel
 Type:  enhancement | Status:  closed
 Priority:  Medium  |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  technical-debt  |  Actual Points:
Parent ID:  #22029  | Points:
 Reviewer:  teor|Sponsor:
+--
Changes (by teor):

 * status:  needs_review => closed
 * reviewer:   => teor
 * resolution:   => fixed


Comment:

 I'm going to review this code in #22029.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30691 [Core Tor/Tor]: Refactor decoding outside the if expression in dirserv_load_fingerprint_file()

2019-06-11 Thread Tor Bug Tracker & Wiki
#30691: Refactor decoding outside the if expression in
dirserv_load_fingerprint_file()
+--
 Reporter:  teor|  Owner:  neel
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  technical-debt  |  Actual Points:
Parent ID:  #22029  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by neel):

 * status:  assigned => needs_review


Comment:

 PR: https://github.com/torproject/tor/pull/970 with commit `8c0a166`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30691 [Core Tor/Tor]: Refactor decoding outside the if expression in dirserv_load_fingerprint_file()

2019-06-11 Thread Tor Bug Tracker & Wiki
#30691: Refactor decoding outside the if expression in
dirserv_load_fingerprint_file()
+--
 Reporter:  teor|  Owner:  neel
 Type:  enhancement | Status:  assigned
 Priority:  Medium  |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  technical-debt  |  Actual Points:
Parent ID:  #22029  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by neel):

 * status:  new => assigned
 * owner:  (none) => neel


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #30691 [Core Tor/Tor]: Refactor decoding outside the if expression in dirserv_load_fingerprint_file()

2019-05-29 Thread Tor Bug Tracker & Wiki
#30691: Refactor decoding outside the if expression in
dirserv_load_fingerprint_file()
--+--
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  technical-debt
Actual Points:|  Parent ID:  #22029
   Points:|   Reviewer:
  Sponsor:|
--+--
 There have already been two bugs in this code, so we should refactor it:
 https://github.com/torproject/tor/pull/970#pullrequestreview-242268332

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs