Re: [tor-bugs] #31126 [Circumvention/Snowflake]: Query.parse returns spurious keys (originating from Object.prototype)

[Tor Bug Tracker & Wiki]

#31126: Query.parse returns spurious keys (originating from Object.prototype)
-+
 Reporter:  dcf  |  Owner:  dcf
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Minor| Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by dcf):

 Replying to [comment:5 cohosh]:
 > Looks like there might be a broken test here: https://travis-
 ci.com/cohosh/snowflake/builds/120769742#L915

 Oops, you're right. It's actually a problem with #31203.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31126 [Circumvention/Snowflake]: Query.parse returns spurious keys (originating from Object.prototype)

[Tor Bug Tracker & Wiki]

#31126: Query.parse returns spurious keys (originating from Object.prototype)
-+
 Reporter:  dcf  |  Owner:  dcf
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Minor| Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by cohosh):

 Looks like there might be a broken test here: https://travis-
 ci.com/cohosh/snowflake/builds/120769742#L915

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31126 [Circumvention/Snowflake]: Query.parse returns spurious keys (originating from Object.prototype)

[Tor Bug Tracker & Wiki]

#31126: Query.parse returns spurious keys (originating from Object.prototype)
-+
 Reporter:  dcf  |  Owner:  dcf
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Minor| Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by dcf):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged in [https://gitweb.torproject.org/pluggable-
 transports/snowflake.git/commit/?id=e87ec6585801eb704ccabb783a56bc9a29ea2c7b
 e87ec6585801eb704ccabb783a56bc9a29ea2c7b].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31126 [Circumvention/Snowflake]: Query.parse returns spurious keys (originating from Object.prototype)

[Tor Bug Tracker & Wiki]

#31126: Query.parse returns spurious keys (originating from Object.prototype)
-+-
 Reporter:  dcf  |  Owner:  dcf
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Minor| Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arlolra):

 * status:  needs_review => merge_ready


Comment:

 lgtm

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31126 [Circumvention/Snowflake]: Query.parse returns spurious keys (originating from Object.prototype)

[Tor Bug Tracker & Wiki]

#31126: Query.parse returns spurious keys (originating from Object.prototype)
-+--
 Reporter:  dcf  |  Owner:  dcf
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Minor| Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by dcf):

 * status:  assigned => needs_review


Comment:

 Here's a branch for review. It deletes `Query.parse` and replaces
 `Query.parse(location.search.substr(1))` with `new
 URLSearchParams(location.search)`. Then in a second commit, I converted
 the single call to `Query.buildString(params)` to `new
 URLSearchParams(params).toString()`, and removed the now-unused `Query`
 global.

 
https://gitweb.torproject.org/user/dcf/snowflake.git/log/?h=bug31126=e87ec6585801eb704ccabb783a56bc9a29ea2c7b
 
https://gitweb.torproject.org/user/dcf/snowflake.git/diff/?h=bug31126=e87ec6585801eb704ccabb783a56bc9a29ea2c7b=76b81bcf77be01565365833ade805397ed093dc9

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31126 [Circumvention/Snowflake]: Query.parse returns spurious keys (originating from Object.prototype)

[Tor Bug Tracker & Wiki]

#31126: Query.parse returns spurious keys (originating from Object.prototype)
-+--
 Reporter:  dcf  |  Owner:  dcf
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Minor| Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by arlolra):

 Sure, or use a Map

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31126 [Circumvention/Snowflake]: Query.parse returns spurious keys (originating from Object.prototype)

[Tor Bug Tracker & Wiki]

#31126: Query.parse returns spurious keys (originating from Object.prototype)
-+--
 Reporter:  dcf  |  Owner:  dcf
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Minor|   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+--
 For example, these test cases would fail:
 {{{#!javascript
 describe 'query string', ->
   it 'should parse correctly', ->
 expect ("toString" in (Query.parse ''))
   .toBe(false)
 expect ((Query.parse '')["hasOwnProperty"])
   .toBeUndefined()
 }}}

 I'm tempted to replace all this with [https://developer.mozilla.org/en-
 US/docs/Web/API/URL new URL] and [https://developer.mozilla.org/en-
 US/docs/Web/API/URLSearchParams URLSearchParams].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs