Re: [tor-bugs] #31147 [Core Tor/Tor]: Check tor_vasprintf for error return values.

[Tor Bug Tracker & Wiki]

#31147: Check tor_vasprintf for error return values.
--+
 Reporter:  paldium   |  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  Low   |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.4.0.5
 Severity:  Normal| Resolution:  fixed
 Keywords:  042-can   |  Actual Points:
Parent ID:| Points:
 Reviewer:  ahf   |Sponsor:
--+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged to master.  Thanks, Paldium!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31147 [Core Tor/Tor]: Check tor_vasprintf for error return values.

[Tor Bug Tracker & Wiki]

#31147: Check tor_vasprintf for error return values.
--+
 Reporter:  paldium   |  Owner:  (none)
 Type:  defect| Status:  merge_ready
 Priority:  Low   |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.4.0.5
 Severity:  Normal| Resolution:
 Keywords:  042-can   |  Actual Points:
Parent ID:| Points:
 Reviewer:  ahf   |Sponsor:
--+
Changes (by ahf):

 * status:  needs_review => merge_ready


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31147 [Core Tor/Tor]: Check tor_vasprintf for error return values.

[Tor Bug Tracker & Wiki]

#31147: Check tor_vasprintf for error return values.
--+
 Reporter:  paldium   |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Low   |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.4.0.5
 Severity:  Normal| Resolution:
 Keywords:  042-can   |  Actual Points:
Parent ID:| Points:
 Reviewer:  ahf   |Sponsor:
--+
Changes (by ahf):

 * status:  needs_revision => needs_review
 * keywords:  035-backport 040-backport 041-backport 042-can => 042-can


Comment:

 I don't think this needs to be backported. I think the NULL dereference
 bugs would cause a crash at run-time if this had ever happened in the
 wild.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31147 [Core Tor/Tor]: Check tor_vasprintf for error return values.

[Tor Bug Tracker & Wiki]

#31147: Check tor_vasprintf for error return values.
-+-
 Reporter:  paldium  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.5
 Severity:  Normal   | Resolution:
 Keywords:  035-backport 040-backport|  Actual Points:
  041-backport 042-can   |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => needs_revision


Comment:

 This LGTM but the ticket says it is for backporting, and the branch is
 based against master.  Can I have a branch based on 035 if this is really
 for backport?

 Alternatively we could say that this is not for backport, and I'd be okay
 with that too.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31147 [Core Tor/Tor]: Check tor_vasprintf for error return values.

[Tor Bug Tracker & Wiki]

#31147: Check tor_vasprintf for error return values.
-+-
 Reporter:  paldium  |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.5
 Severity:  Normal   | Resolution:
 Keywords:  035-backport 040-backport|  Actual Points:
  041-backport 042-can   |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 Okay, I think the patch looks good.

 To the merger: it seems like something went fishy with AppVeyor and Travis
 at first where it tried to pull a branch from `torproject/tor` instead of
 `ahf/tor`, which failed, but the second round seems to have passed. I have
 no idea why that is the case.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31147 [Core Tor/Tor]: Check tor_vasprintf for error return values.

[Tor Bug Tracker & Wiki]

#31147: Check tor_vasprintf for error return values.
-+-
 Reporter:  paldium  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.5
 Severity:  Normal   | Resolution:
 Keywords:  035-backport 040-backport|  Actual Points:
  041-backport 042-can   |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by ahf):

 I added a changes file and opened a PR on Github:

 https://github.com/torproject/tor/pull/1417

 Let us see what our CI says to this.

 In the future it is generally a good idea to open the PR on Github
 directly, since this allows the CI to run upfront such that we can check
 it once the CI passes :-)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31147 [Core Tor/Tor]: Check tor_vasprintf for error return values.

[Tor Bug Tracker & Wiki]

#31147: Check tor_vasprintf for error return values.
-+-
 Reporter:  paldium  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.5
 Severity:  Normal   | Resolution:
 Keywords:  035-backport 040-backport|  Actual Points:
  041-backport 042-can   |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by asn):

 * reviewer:   => ahf


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31147 [Core Tor/Tor]: Check tor_vasprintf for error return values.

[Tor Bug Tracker & Wiki]

#31147: Check tor_vasprintf for error return values.
-+-
 Reporter:  paldium  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.5
 Severity:  Normal   | Resolution:
 Keywords:  035-backport 040-backport|  Actual Points:
  041-backport 042-can   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  035-backport 040-backport 041-backport => 035-backport
 040-backport 041-backport 042-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31147 [Core Tor/Tor]: Check tor_vasprintf for error return values.

[Tor Bug Tracker & Wiki]

#31147: Check tor_vasprintf for error return values.
-+-
 Reporter:  paldium  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.5
 Severity:  Normal   | Resolution:
 Keywords:  035-backport 040-backport|  Actual Points:
  041-backport   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * reviewer:  mikeperry =>


Comment:

 Mike is not doing reviews this month, please re-assign.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31147 [Core Tor/Tor]: Check tor_vasprintf for error return values.

[Tor Bug Tracker & Wiki]

#31147: Check tor_vasprintf for error return values.
-+-
 Reporter:  paldium  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.5
 Severity:  Normal   | Resolution:
 Keywords:  035-backport 040-backport|  Actual Points:
  041-backport   |
Parent ID:   | Points:
 Reviewer:  mikeperry|Sponsor:
-+-
Changes (by nickm):

 * type:  enhancement => defect


Comment:

 Calling this "defect" rather than "enhancement" since the problem is not
 checking the return value.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31147 [Core Tor/Tor]: Check tor_vasprintf for error return values.

[Tor Bug Tracker & Wiki]

#31147: Check tor_vasprintf for error return values.
-+-
 Reporter:  paldium  |  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.0.5
 Severity:  Normal   | Resolution:
 Keywords:  035-backport 040-backport|  Actual Points:
  041-backport   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  new => needs_review
 * keywords:   => 035-backport 040-backport 041-backport
 * milestone:   => Tor: 0.4.2.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31147 [Core Tor/Tor]: Check tor_vasprintf for error return values.

[Tor Bug Tracker & Wiki]

#31147: Check tor_vasprintf for error return values.
--+--
 Reporter:  paldium   |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Low   |  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: 0.4.0.5
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by paldium):

 * Attachment "0001-Check-tor_vasprintf-for-error-return-values.patch"
 added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31147 [Core Tor/Tor]: Check tor_vasprintf for error return values.

[Tor Bug Tracker & Wiki]

#31147: Check tor_vasprintf for error return values.
--+--
 Reporter:  paldium   |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Low   |  Component:  Core Tor/Tor
  Version:  Tor: 0.4.0.5  |   Severity:  Normal
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
 In case of error, a negative value will be returned or NULL written into
 first supplied argument.

 This patch uses both cases to comply with style in the specific files.

 A tor_vasprintf error in process_vprintf would lead to a NULL dereference
 later on in buf_add, because the return value -1 casted to size_t would
 pass an assertion check inside of buf_add.

 On the other hand, common systems will fail on such an operation, so it
 is not a huge difference to a simple assertion. Yet it is better to
 properly fail instead of relying on such behaviour on all systems.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs