Re: [tor-bugs] #31303 [Applications/Tor Browser]: Browser Toolboxfails to open when tor-launcher is present

[Tor Bug Tracker & Wiki]

#31303: Browser Toolboxfails to open when tor-launcher is present
-+-
 Reporter:  pospeselr|  Owner:
 |  pospeselr
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  TorBrowserTeam201909R, tbb-9.0   |  Actual Points:  0.35
  -must-alpha|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by mcs):

 * actualpoints:  0.25 => 0.35


Comment:

 Replying to [comment:13 acat]:
 > Not sure how to update the Actual Points here, since most of the work
 (investigating) was done by mcs. But let's say 0.25.

 I added another 0.1 (it was probably even less, but 0.1 is close enough).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31303 [Applications/Tor Browser]: Browser Toolboxfails to open when tor-launcher is present

[Tor Bug Tracker & Wiki]

#31303: Browser Toolboxfails to open when tor-launcher is present
-+-
 Reporter:  pospeselr|  Owner:
 |  pospeselr
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  TorBrowserTeam201909R, tbb-9.0   |  Actual Points:  0.25
  -must-alpha|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by acat):

 * actualpoints:   => 0.25


Comment:

 Not sure how to update the Actual Points here, since most of the work
 (investigating) was done by mcs. But let's say 0.25.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31303 [Applications/Tor Browser]: Browser Toolboxfails to open when tor-launcher is present

[Tor Bug Tracker & Wiki]

#31303: Browser Toolboxfails to open when tor-launcher is present
-+-
 Reporter:  pospeselr|  Owner:
 |  pospeselr
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  TorBrowserTeam201909R, tbb-9.0   |  Actual Points:
  -must-alpha|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks good. Merged to `master` (commit
 810ba7e93981511765ec1be667689ae2992e8c49).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31303 [Applications/Tor Browser]: Browser Toolboxfails to open when tor-launcher is present

[Tor Bug Tracker & Wiki]

#31303: Browser Toolboxfails to open when tor-launcher is present
-+-
 Reporter:  pospeselr|  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201909R, tbb-9.0   |  Actual Points:
  -must-alpha|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by acat):

 * keywords:  TorBrowserTeam201909, tbb-9.0-must-alpha =>
 TorBrowserTeam201909R, tbb-9.0-must-alpha
 * status:  needs_revision => needs_review


Comment:

 Sounds good: https://github.com/acatarineu/tor-launcher/commit/31303+1

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31303 [Applications/Tor Browser]: Browser Toolboxfails to open when tor-launcher is present

[Tor Bug Tracker & Wiki]

#31303: Browser Toolboxfails to open when tor-launcher is present
-+-
 Reporter:  pospeselr|  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201909, tbb-9.0-must-  |  Actual Points:
  alpha  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:9 gk]:
 > Replying to [comment:8 acat]:
 > > I tested mcs suggestion and everything seems to work as expected in
 browser toolbox (https://github.com/acatarineu/tor-launcher/commit/31303)
 > >
 > > Alternatively we could add `TOR_SKIP_LAUNCH=1` in
 https://searchfox.org/mozilla-
 
esr68/rev/9fe22f6a90e0a5c495d22b2e8b56fac5f46b0ba0/devtools/client/framework/ToolboxProcess.jsm#258,
 but I think changing tor-launcher is fine.
 >
 > I agree. Just a tiny nit: please add the toolbox check after the skip
 launch check so that it a) matches the order in which you declared the
 constants and b) matches more likely the usage patterns of the env
 variables: I'd expect both to be low but the toolbox one still much lower.

 Actually, that's stupid and won't work. But swap the const declarations
 instead?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31303 [Applications/Tor Browser]: Browser Toolboxfails to open when tor-launcher is present

[Tor Bug Tracker & Wiki]

#31303: Browser Toolboxfails to open when tor-launcher is present
-+-
 Reporter:  pospeselr|  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201909, tbb-9.0-must-  |  Actual Points:
  alpha  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  TorBrowserTeam201909R, tbb-9.0-must-alpha =>
 TorBrowserTeam201909, tbb-9.0-must-alpha
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:8 acat]:
 > I tested mcs suggestion and everything seems to work as expected in
 browser toolbox (https://github.com/acatarineu/tor-launcher/commit/31303)
 >
 > Alternatively we could add `TOR_SKIP_LAUNCH=1` in https://searchfox.org
 /mozilla-
 
esr68/rev/9fe22f6a90e0a5c495d22b2e8b56fac5f46b0ba0/devtools/client/framework/ToolboxProcess.jsm#258,
 but I think changing tor-launcher is fine.

 I agree. Just a tiny nit: please add the toolbox check after the skip
 launch check so that it a) matches the order in which you declared the
 constants and b) matches more likely the usage patterns of the env
 variables: I'd expect both to be low but the toolbox one still much lower.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31303 [Applications/Tor Browser]: Browser Toolboxfails to open when tor-launcher is present

[Tor Bug Tracker & Wiki]

#31303: Browser Toolboxfails to open when tor-launcher is present
-+-
 Reporter:  pospeselr|  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201909R, tbb-9.0   |  Actual Points:
  -must-alpha|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by acat):

 * status:  assigned => needs_review
 * keywords:  TorBrowserTeam201909, tbb-9.0-must-alpha =>
 TorBrowserTeam201909R, tbb-9.0-must-alpha


Comment:

 I tested mcs suggestion and everything seems to work as expected in
 browser toolbox (https://github.com/acatarineu/tor-launcher/commit/31303)

 Alternatively we could add `TOR_SKIP_LAUNCH=1` in https://searchfox.org
 /mozilla-
 
esr68/rev/9fe22f6a90e0a5c495d22b2e8b56fac5f46b0ba0/devtools/client/framework/ToolboxProcess.jsm#258,
 but I think changing tor-launcher is fine.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31303 [Applications/Tor Browser]: Browser Toolboxfails to open when tor-launcher is present

[Tor Bug Tracker & Wiki]

#31303: Browser Toolboxfails to open when tor-launcher is present
-+-
 Reporter:  pospeselr|  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201909, tbb-9.0-must-  |  Actual Points:
  alpha  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by mcs):

 I do not think Kathy and I will have time to work on this before our
 vacation next week. I did a little research and fixing this issue might be
 as simple adding a check for `MOZ_BROWSER_TOOLBOX_PORT` inside
 `shouldStartAndOwnTor()` (in src/modules/tl-util.jsm). That environment
 variable should only be present in the debugger process' environment:
 https://searchfox.org/mozilla-
 esr68/source/devtools/client/framework/ToolboxProcess.jsm#258

 I am not sure if more things need to be fixed though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31303 [Applications/Tor Browser]: Browser Toolboxfails to open when tor-launcher is present

[Tor Bug Tracker & Wiki]

#31303: Browser Toolboxfails to open when tor-launcher is present
-+-
 Reporter:  pospeselr|  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201909, tbb-9.0-must-  |  Actual Points:
  alpha  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by pospeselr):

 I thought this was going to be a blocker for me in doing #31286, but I
 discovered that since (most of) the code I'm dealing with is in
 about:preferences so the regular in-page debugging tools work fine so I'm
 not actively working on this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31303 [Applications/Tor Browser]: Browser Toolboxfails to open when tor-launcher is present

[Tor Bug Tracker & Wiki]

#31303: Browser Toolboxfails to open when tor-launcher is present
-+-
 Reporter:  pospeselr|  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201909, tbb-9.0-must-  |  Actual Points:
  alpha  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  TorBrowserTeam201909 => TorBrowserTeam201909, tbb-9.0-must-
   alpha


Comment:

 Replying to [comment:4 acat]:
 > Should this be tbb-9.0-must-alpha? Without this inspecting the
 background requests and debugging is a bit more difficult...

 If that is slowing down fixing the "real" esr68 issues, sure let's fix
 this quickly.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31303 [Applications/Tor Browser]: Browser Toolboxfails to open when tor-launcher is present

[Tor Bug Tracker & Wiki]

#31303: Browser Toolboxfails to open when tor-launcher is present
--+---
 Reporter:  pospeselr |  Owner:  pospeselr
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201909  |  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:
--+---

Comment (by acat):

 Should this be tbb-9.0-must-alpha? Without this inspecting the background
 requests and debugging is a bit more difficult...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31303 [Applications/Tor Browser]: Browser Toolboxfails to open when tor-launcher is present

[Tor Bug Tracker & Wiki]

#31303: Browser Toolboxfails to open when tor-launcher is present
--+---
 Reporter:  pospeselr |  Owner:  pospeselr
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201909  |  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:
--+---
Changes (by pili):

 * points:   => 1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31303 [Applications/Tor Browser]: Browser Toolboxfails to open when tor-launcher is present

[Tor Bug Tracker & Wiki]

#31303: Browser Toolboxfails to open when tor-launcher is present
--+---
 Reporter:  pospeselr |  Owner:  pospeselr
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201908  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by pospeselr):

 * owner:  tbb-team => pospeselr
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31303 [Applications/Tor Browser]: Browser Toolboxfails to open when tor-launcher is present

[Tor Bug Tracker & Wiki]

#31303: Browser Toolboxfails to open when tor-launcher is present
--+
 Reporter:  pospeselr |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
  |  TorBrowserTeam201908
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 In latest dev branch origin/tor-browser-60.8.0esr-9.0-1 the Firefox chrome
 debugger ( enabled in about:debugging -> Enable add-on debugging ) does
 not launch. When you attempt to launch it ( via Menu -> Web Developer ->
 Browser Toolbox OR via Ctrl+Shift+Alt+I key combo ) the tor-launcher
 dialog pops up claims that it cannot connect to Tor, and the permission
 dialog asking whether you want to allow the local debugger to connect
 never appears.

 Building firefox with --disable-tor-launcher in your .mozconfig does allow
 the debugger to work.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs