Re: [tor-bugs] #31499 [Applications/Tor Browser]: Update libevent to 2.1.11-stable

[Tor Bug Tracker & Wiki]

#31499: Update libevent to 2.1.11-stable
+-
 Reporter:  cypherpunks |  Owner:  sisbell
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam202004R  |  Actual Points:
Parent ID:  #28704  | Points:  1
 Reviewer:  boklm, gk   |Sponsor:
+-
Changes (by boklm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:14 sisbell]:
 > I added the tor project change regarding libevent-2.1.so.7 to this
 ticket
 >
 > https://github.com/sisbell/tor-browser-build/commits/bug-31499d

 Thanks, this looks good to me. I merged the commit to master with commit
 `a017df805383561dde058f566255d709bc347834`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31499 [Applications/Tor Browser]: Update libevent to 2.1.11-stable

[Tor Bug Tracker & Wiki]

#31499: Update libevent to 2.1.11-stable
+--
 Reporter:  cypherpunks |  Owner:  sisbell
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam202004R  |  Actual Points:
Parent ID:  #28704  | Points:  1
 Reviewer:  boklm, gk   |Sponsor:
+--
Changes (by sisbell):

 * keywords:  tbb-rbm, TorBrowserTeam202004 => tbb-rbm,
   TorBrowserTeam202004R
 * status:  needs_revision => needs_review


Comment:

 I added the tor project change regarding libevent-2.1.so.7 to this ticket

 https://github.com/sisbell/tor-browser-build/commits/bug-31499d

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31499 [Applications/Tor Browser]: Update libevent to 2.1.11-stable

[Tor Bug Tracker & Wiki]

#31499: Update libevent to 2.1.11-stable
---+---
 Reporter:  cypherpunks|  Owner:  sisbell
 Type:  defect | Status:
   |  needs_revision
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam202004  |  Actual Points:
Parent ID:  #28704 | Points:  1
 Reviewer:  boklm, gk  |Sponsor:
---+---
Changes (by sisbell):

 * parent:  #28765 => #28704


Comment:

 Changing parent ticket since it says max parent child depth too deep (over
 5) whenever I try to comment

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31499 [Applications/Tor Browser]: Update libevent to 2.1.11-stable

[Tor Bug Tracker & Wiki]

#31499: Update libevent to 2.1.11-stable
---+---
 Reporter:  cypherpunks|  Owner:  sisbell
 Type:  defect | Status:
   |  needs_revision
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam202004  |  Actual Points:
Parent ID:  #28765 | Points:  1
 Reviewer:  boklm, gk  |Sponsor:
---+---
Changes (by boklm):

 * parent:   => #28765


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31499 [Applications/Tor Browser]: Update libevent to 2.1.11-stable

[Tor Bug Tracker & Wiki]

#31499: Update libevent to 2.1.11-stable
---+---
 Reporter:  cypherpunks|  Owner:  sisbell
 Type:  defect | Status:
   |  needs_revision
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam202004  |  Actual Points:
Parent ID: | Points:  1
 Reviewer:  boklm, gk  |Sponsor:
---+---
Changes (by pili):

 * points:   => 1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31499 [Applications/Tor Browser]: Update libevent to 2.1.11-stable

[Tor Bug Tracker & Wiki]

#31499: Update libevent to 2.1.11-stable
---+---
 Reporter:  cypherpunks|  Owner:  sisbell
 Type:  defect | Status:
   |  needs_revision
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam202004  |  Actual Points:
Parent ID: | Points:
 Reviewer:  boklm, gk  |Sponsor:
---+---

Comment (by boklm):

 With the update `libevent-2.1.so.6` is now `libevent-2.1.so.7`:
 {{{
 lrwxrwxrwx root/root 0 2019-08-01 23:37
 libevent/lib/libevent-2.1.so.7 -> libevent-2.1.so.7.0.0
 -rwx-- root/root   1639593 2019-08-01 23:37
 libevent/lib/libevent-2.1.so.7.0.0
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31499 [Applications/Tor Browser]: Update libevent to 2.1.11-stable

[Tor Bug Tracker & Wiki]

#31499: Update libevent to 2.1.11-stable
---+---
 Reporter:  cypherpunks|  Owner:  sisbell
 Type:  defect | Status:
   |  needs_revision
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam202004  |  Actual Points:
Parent ID: | Points:
 Reviewer:  boklm, gk  |Sponsor:
---+---

Comment (by sisbell):

 Replying to [comment:8 sysrqb]:


 > ugh. I almost asked about that. I noticed the last time we bumped the
 version we did:
 >
 > {{{
 > diff --git a/projects/tor/build b/projects/tor/build
 > index bf7db832..c6d9895d 100644
 > --- a/projects/tor/build
 > +++ b/projects/tor/build
 > @@ -39,7 +39,7 @@ openssldir=/var/tmp/dist/openssl
 > mkdir -p "$distdir/Debug/Tor"
 > cp $openssldir/lib/libssl.so.1.0.0 "$distdir/Tor/"
 > cp $openssldir/lib/libcrypto.so.1.0.0 "$distdir/Tor/"
 > -  cp $libeventdir/lib/libevent-2.0.so.5 "$distdir/Tor/"
 > +  cp $libeventdir/lib/libevent-2.1.so.6 "$distdir/Tor/"
 > # We need to copy the libstdc++.so.6 for Tor Browser on older Linux
 distros.
 > # Copying it into /Browser, which feels more natural, and amending
 > # LD_LIBRARY_PATH breaks updates from a Tor Browser with the old
 > }}}
 >
 > sisbell, all of your testbuilds were successful?
 > I did go through each build including linux-x86_64, but I try again and
 see if I can reproduce this issue

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31499 [Applications/Tor Browser]: Update libevent to 2.1.11-stable

[Tor Bug Tracker & Wiki]

#31499: Update libevent to 2.1.11-stable
---+---
 Reporter:  cypherpunks|  Owner:  sisbell
 Type:  defect | Status:
   |  needs_revision
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam202004  |  Actual Points:
Parent ID: | Points:
 Reviewer:  boklm, gk  |Sponsor:
---+---

Comment (by sysrqb):

 ugh. I almost asked about that. I noticed the last time we bumped the
 version we did:

 {{{
 diff --git a/projects/tor/build b/projects/tor/build
 index bf7db832..c6d9895d 100644
 --- a/projects/tor/build
 +++ b/projects/tor/build
 @@ -39,7 +39,7 @@ openssldir=/var/tmp/dist/openssl
mkdir -p "$distdir/Debug/Tor"
cp $openssldir/lib/libssl.so.1.0.0 "$distdir/Tor/"
cp $openssldir/lib/libcrypto.so.1.0.0 "$distdir/Tor/"
 -  cp $libeventdir/lib/libevent-2.0.so.5 "$distdir/Tor/"
 +  cp $libeventdir/lib/libevent-2.1.so.6 "$distdir/Tor/"
# We need to copy the libstdc++.so.6 for Tor Browser on older Linux
 distros.
# Copying it into /Browser, which feels more natural, and amending
# LD_LIBRARY_PATH breaks updates from a Tor Browser with the old
 }}}

 sisbell, all of your testbuilds were successful?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31499 [Applications/Tor Browser]: Update libevent to 2.1.11-stable

[Tor Bug Tracker & Wiki]

#31499: Update libevent to 2.1.11-stable
---+---
 Reporter:  cypherpunks|  Owner:  sisbell
 Type:  defect | Status:
   |  needs_revision
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam202004  |  Actual Points:
Parent ID: | Points:
 Reviewer:  boklm, gk  |Sponsor:
---+---
Changes (by boklm):

 * keywords:  tbb-rbm => tbb-rbm, TorBrowserTeam202004
 * status:  needs_review => needs_revision


Comment:

 I tried building tor for linux-x86_64 with this patch, but it failed with:
 {{{
 cp: cannot stat `/var/tmp/dist/libevent/lib/libevent-2.1.so.6': No such
 file or directory
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31499 [Applications/Tor Browser]: Update libevent to 2.1.11-stable

[Tor Bug Tracker & Wiki]

#31499: Update libevent to 2.1.11-stable
--+--
 Reporter:  cypherpunks   |  Owner:  sisbell
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:  boklm, gk |Sponsor:
--+--

Comment (by sysrqb):

 (specifically, commit `c2fdb4de8a0468a29c18579a8b13042537f9f6c9`).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31499 [Applications/Tor Browser]: Update libevent to 2.1.11-stable

[Tor Bug Tracker & Wiki]

#31499: Update libevent to 2.1.11-stable
--+--
 Reporter:  cypherpunks   |  Owner:  sisbell
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:  boklm, gk |Sponsor:
--+--
Changes (by sysrqb):

 * status:  assigned => needs_review
 * reviewer:   => boklm, gk


Comment:

 The patch looks good to me, but I'd like a second review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31499 [Applications/Tor Browser]: Update libevent to 2.1.11-stable

[Tor Bug Tracker & Wiki]

#31499: Update libevent to 2.1.11-stable
--+--
 Reporter:  cypherpunks   |  Owner:  sisbell
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by sysrqb):

 * owner:  tbb-team => sisbell
 * status:  needs_review => assigned
 * cc: cypherpunks, sisbell (removed)
 * cc: tbb-team (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31499 [Applications/Tor Browser]: Update libevent to 2.1.11-stable

[Tor Bug Tracker & Wiki]

#31499: Update libevent to 2.1.11-stable
--+--
 Reporter:  cypherpunks   |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by sisbell):

 * cc: sisbell (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31499 [Applications/Tor Browser]: Update libevent to 2.1.11-stable

[Tor Bug Tracker & Wiki]

#31499: Update libevent to 2.1.11-stable
--+--
 Reporter:  cypherpunks   |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by sisbell):

 * cc: sysrqb, boklm, cypherpunks (added)
 * status:  new => needs_review


Comment:

 With version 2.1.11 we don't need the osx patch anymore. The patch is
 included in the updated libevent version. The project builds across
 platforms

  * windows x86_64 and i686
  * osx,
  * linux x86_64 and i686.

 https://github.com/sisbell/tor-browser-build/commits/bug-31499a

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31499 [Applications/Tor Browser]: Update libevent to 2.1.11-stable

[Tor Bug Tracker & Wiki]

#31499: Update libevent to 2.1.11-stable
--+--
 Reporter:  cypherpunks   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * keywords:   => tbb-rbm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31499 [Applications/Tor Browser]: Update libevent to 2.1.11-stable

[Tor Bug Tracker & Wiki]

#31499: Update libevent to 2.1.11-stable
-+--
 Reporter:  cypherpunks  |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Component:  Applications/Tor Browser
  Version:   |   Severity:  Normal
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
 https://github.com/libevent/libevent/releases

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs