Re: [tor-bugs] #31550 [Applications/Tor Browser]: Fix shellcheck (and related) issues in start-tor-browser

[Tor Bug Tracker & Wiki]

#31550: Fix shellcheck (and related) issues in start-tor-browser
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam202006,   |  Actual Points:
  gitlab-tb-tor-browser-build|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by acat):

 * keywords:  tbb-tbm, TorBrowserTeam202006 => tbb-rbm,
 TorBrowserTeam202006, gitlab-tb-tor-browser-build


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31550 [Applications/Tor Browser]: Fix shellcheck (and related) issues in start-tor-browser

[Tor Bug Tracker & Wiki]

#31550: Fix shellcheck (and related) issues in start-tor-browser
---+---
 Reporter:  nickm  |  Owner:  nickm
 Type:  enhancement| Status:
   |  needs_revision
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-tbm, TorBrowserTeam201911  |  Actual Points:
Parent ID: | Points:  1
 Reviewer: |Sponsor:
---+---
Changes (by pili):

 * points:   => 1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31550 [Applications/Tor Browser]: Fix shellcheck (and related) issues in start-tor-browser

[Tor Bug Tracker & Wiki]

#31550: Fix shellcheck (and related) issues in start-tor-browser
---+---
 Reporter:  nickm  |  Owner:  nickm
 Type:  enhancement| Status:
   |  needs_revision
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-tbm, TorBrowserTeam201910  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---

Comment (by boklm):

 Patch 3 (`Stop using a heredoc in start-tor-browser`) and 5 (`Put curly
 quotes inside single quotes, so shellcheck believes them`) look good to
 me, so I merged them to master as commits
 `c5f30eb31a39a61fe300389fff1ff7adecb8b163` and
 `c14d73615ba8d9e12ae29f0168babc0ecbe55052`. I also updated the subject
 lines to include this bug number.

 Patches 2 and 4 also look good to me, but they are changing the same areas
 as patch 1, so I will merge them after patch 1.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31550 [Applications/Tor Browser]: Fix shellcheck (and related) issues in start-tor-browser

[Tor Bug Tracker & Wiki]

#31550: Fix shellcheck (and related) issues in start-tor-browser
---+---
 Reporter:  nickm  |  Owner:  nickm
 Type:  enhancement| Status:
   |  needs_revision
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-tbm, TorBrowserTeam201910  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by boklm):

 * keywords:  tbb-tbm, TorBrowserTeam201910R => tbb-tbm,
   TorBrowserTeam201910
 * status:  needs_review => needs_revision


Comment:

 In the first patch:
 {{{
 @@ -204,13 +203,13 @@ if [ -L "$myname" ]; then
 # make that function accessible to shell scripts.

 # If realpath is available, use it; it Does The Right Thing.
 -   possibly_my_real_name="`realpath "$myname" 2>/dev/null`"
 -   if [ "$?" -eq 0 ]; then
 +   if myname="$(realpath "$myname" 2>/dev/null)"; then
 myname="$possibly_my_real_name"
 else
 # realpath is not available; hopefully readlink -f works.
 -   myname="`readlink -f "$myname" 2>/dev/null`"
 -   if [ "$?" -ne 0 ]; then
 +   if myname="$(readlink -f "$myname" 2>/dev/null)"; then
 +   :
 +   else
 # Ugh.
 complain "start-tor-browser cannot be run using a
 symlink on this operating system."
 fi
 }}}

 We are removing the line creating the variable `possibly_my_real_name`,
 but we are still using it with `myname="$possibly_my_real_name"` inside
 the `if`, so it does not look correct.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31550 [Applications/Tor Browser]: Fix shellcheck (and related) issues in start-tor-browser

[Tor Bug Tracker & Wiki]

#31550: Fix shellcheck (and related) issues in start-tor-browser
+--
 Reporter:  nickm   |  Owner:  nickm
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  TorBrowserTeam201908R, tbb-tbm  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * cc: boklm (added)
 * keywords:  TorBrowserTeam201908R => TorBrowserTeam201908R, tbb-tbm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31550 [Applications/Tor Browser]: Fix shellcheck (and related) issues in start-tor-browser

[Tor Bug Tracker & Wiki]

#31550: Fix shellcheck (and related) issues in start-tor-browser
--+--
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201908R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * keywords:   => TorBrowserTeam201908R


Comment:

 #24755 might be relevant here as well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31550 [Applications/Tor Browser]: Fix shellcheck (and related) issues in start-tor-browser

[Tor Bug Tracker & Wiki]

#31550: Fix shellcheck (and related) issues in start-tor-browser
--+--
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by nickm):

 * status:  assigned => needs_review


Comment:

 I've attached the patches.   The first patch should be uncontroversial;
 you may want to consider the others more carefully.  All are against the
 master branch of the tor-browser-build repository, which I hope is right.
 I haven't tested the output, since I can't get rbm working.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31550 [Applications/Tor Browser]: Fix shellcheck (and related) issues in start-tor-browser

[Tor Bug Tracker & Wiki]

#31550: Fix shellcheck (and related) issues in start-tor-browser
--+--
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by nickm):

 * Attachment "0004-Exit-when-cd-fails.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31550 [Applications/Tor Browser]: Fix shellcheck (and related) issues in start-tor-browser

[Tor Bug Tracker & Wiki]

#31550: Fix shellcheck (and related) issues in start-tor-browser
--+--
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by nickm):

 * Attachment "0005-Put-curly-quotes-inside-single-quotes-so-
 shellcheck-.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31550 [Applications/Tor Browser]: Fix shellcheck (and related) issues in start-tor-browser

[Tor Bug Tracker & Wiki]

#31550: Fix shellcheck (and related) issues in start-tor-browser
--+--
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by nickm):

 * Attachment "0002-Tolerate-the-case-when-TORARCHITECTURE-is.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31550 [Applications/Tor Browser]: Fix shellcheck (and related) issues in start-tor-browser

[Tor Bug Tracker & Wiki]

#31550: Fix shellcheck (and related) issues in start-tor-browser
--+--
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by nickm):

 * Attachment "0003-Stop-using-a-heredoc-in-start-tor-browser.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31550 [Applications/Tor Browser]: Fix shellcheck (and related) issues in start-tor-browser

[Tor Bug Tracker & Wiki]

#31550: Fix shellcheck (and related) issues in start-tor-browser
--+--
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 I got a warning when I was running the script, so I ran shellcheck on it
 and got a bunch of warnings.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31550 [Applications/Tor Browser]: Fix shellcheck (and related) issues in start-tor-browser

[Tor Bug Tracker & Wiki]

#31550: Fix shellcheck (and related) issues in start-tor-browser
--+--
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by nickm):

 * Attachment "0001-start-tor-browser-fix-most-shellcheck-warnings.patch"
 added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs