Re: [tor-bugs] #31576 [Core Tor/Tor]: Fix shellcheck errors in contrib/dist/rc.subr, and add to test-shellcheck

[Tor Bug Tracker & Wiki]

#31576: Fix shellcheck errors in contrib/dist/rc.subr, and add to 
test-shellcheck
--+--
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:  shellcheck|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by teor):

 I'm sorry, I forgot to ask.

 Here's the thread I just started on the packagers mailing list:
 https://lists.torproject.org/pipermail/tor-
 packagers/2020-January/82.html

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31576 [Core Tor/Tor]: Fix shellcheck errors in contrib/dist/rc.subr, and add to test-shellcheck

[Tor Bug Tracker & Wiki]

#31576: Fix shellcheck errors in contrib/dist/rc.subr, and add to 
test-shellcheck
--+--
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:  shellcheck|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by rl1987):

 Do we have any answer?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31576 [Core Tor/Tor]: Fix shellcheck errors in contrib/dist/rc.subr, and add to test-shellcheck

[Tor Bug Tracker & Wiki]

#31576: Fix shellcheck errors in contrib/dist/rc.subr, and add to 
test-shellcheck
--+--
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:  shellcheck|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by teor):

 Ok, I'll ask about both unmaintained service files:

 * contrib/dist
   * rc.subr - script
   * tor.service.in - systemd service ini file

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31576 [Core Tor/Tor]: Fix shellcheck errors in contrib/dist/rc.subr, and add to test-shellcheck

[Tor Bug Tracker & Wiki]

#31576: Fix shellcheck errors in contrib/dist/rc.subr, and add to 
test-shellcheck
--+--
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:  shellcheck|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by arma):

 Replying to [comment:3 nickm]:
 > Maybe we should sent a message to the tor-packagers list, asking if
 anybody is currently using any of the init scripts from our repository?

 See also #30797. I'm not sure what the right outcome should be, but the
 discussions there seem very related to this question.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31576 [Core Tor/Tor]: Fix shellcheck errors in contrib/dist/rc.subr, and add to test-shellcheck

[Tor Bug Tracker & Wiki]

#31576: Fix shellcheck errors in contrib/dist/rc.subr, and add to 
test-shellcheck
--+--
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:  shellcheck|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by teor):

 Replying to [comment:3 nickm]:
 > Hm. I think this one is probably safe to remove: it has decorations
 indicating that it came from FreeBSD's CVS repository, which suggests to
 me that the FreeBSD people are probably maintaining their own version.

 +1

 > There are other scripts of this kind, however.  Maybe we should sent a
 message to the tor-packagers list, asking if anybody is currently using
 any of the init scripts from our repository?  If we find that some are in
 use, we can decide whether to keep them or to give other projects
 responsibility for them.

 I tried looking for these other scripts, and I could only find:
 * contrib/dist
   * rc.subr - script
   * tor.service.in - systemd service ini file

 Do you want me to ask tor-packagers about these two files?
 Or are there other files you are thinking of?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31576 [Core Tor/Tor]: Fix shellcheck errors in contrib/dist/rc.subr, and add to test-shellcheck

[Tor Bug Tracker & Wiki]

#31576: Fix shellcheck errors in contrib/dist/rc.subr, and add to 
test-shellcheck
--+--
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:  shellcheck|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by nickm):

 Hm. I think this one is probably safe to remove: it has decorations
 indicating that it came from FreeBSD's CVS repository, which suggests to
 me that the FreeBSD people are probably maintaining their own version.

 There are other scripts of this kind, however.  Maybe we should sent a
 message to the tor-packagers list, asking if anybody is currently using
 any of the init scripts from our repository?  If we find that some are in
 use, we can decide whether to keep them or to give other projects
 responsibility for them.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31576 [Core Tor/Tor]: Fix shellcheck errors in contrib/dist/rc.subr, and add to test-shellcheck

[Tor Bug Tracker & Wiki]

#31576: Fix shellcheck errors in contrib/dist/rc.subr, and add to 
test-shellcheck
--+--
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:  shellcheck|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by teor):

 * cc: nickm (added)


Comment:

 Good question: I don't know if anyone is still using it.

 Cc'ing nickm, who has done similar removals recently.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31576 [Core Tor/Tor]: Fix shellcheck errors in contrib/dist/rc.subr, and add to test-shellcheck

[Tor Bug Tracker & Wiki]

#31576: Fix shellcheck errors in contrib/dist/rc.subr, and add to 
test-shellcheck
--+--
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:  shellcheck|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by rl1987):

 Should we perhaps remove it instead? It was added in #256 back in 2006,
 and seems to be last updated in 2008.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31576 [Core Tor/Tor]: Fix shellcheck errors in contrib/dist/rc.subr, and add to test-shellcheck

[Tor Bug Tracker & Wiki]

#31576: Fix shellcheck errors in contrib/dist/rc.subr, and add to 
test-shellcheck
--+--
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Minor |   Keywords:  shellcheck
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 This would be nice to have, but it's not urgent at all.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs