Re: [tor-bugs] #31634 [Core Tor/Tor]: Check .may_include order and tor subsystem init order are compatible

[Tor Bug Tracker & Wiki]

#31634: Check .may_include order and tor subsystem init order are compatible
--+
 Reporter:  teor  |  Owner:  nickm
 Type:  enhancement   | Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  diagnostics, practracker  |  Actual Points:  1
Parent ID:| Points:  2
 Reviewer:  teor  |Sponsor:
--+
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Squashed and merged to master.

 Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31634 [Core Tor/Tor]: Check .may_include order and tor subsystem init order are compatible

[Tor Bug Tracker & Wiki]

#31634: Check .may_include order and tor subsystem init order are compatible
--+
 Reporter:  teor  |  Owner:  nickm
 Type:  enhancement   | Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  diagnostics, practracker  |  Actual Points:  1
Parent ID:| Points:  2
 Reviewer:  teor  |Sponsor:
--+
Changes (by teor):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:19 nickm]:
 > Relpath wasn't quite right -- it wants to look at the actual filesystem
 and we didn't want that.

 If you pass "start" to relpath(), it shouldn't look at the filesystem at
 all:
 "This is a path computation: the filesystem is not accessed to confirm the
 existence or nature of path or start."
 https://docs.python.org/3/library/os.path.html#os.path.relpath

 > I went with a harsher approach, and now CI is passing

 Great! The new code looks good.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31634 [Core Tor/Tor]: Check .may_include order and tor subsystem init order are compatible

[Tor Bug Tracker & Wiki]

#31634: Check .may_include order and tor subsystem init order are compatible
--+
 Reporter:  teor  |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  diagnostics, practracker  |  Actual Points:  1
Parent ID:| Points:  2
 Reviewer:  teor  |Sponsor:
--+
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 Relpath wasn't quite right -- it wants to look at the actual filesystem
 and we didn't want that.

 I went with a harsher approach, and now CI is passing

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31634 [Core Tor/Tor]: Check .may_include order and tor subsystem init order are compatible

[Tor Bug Tracker & Wiki]

#31634: Check .may_include order and tor subsystem init order are compatible
--+
 Reporter:  teor  |  Owner:  nickm
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  diagnostics, practracker  |  Actual Points:  1
Parent ID:| Points:  2
 Reviewer:  teor  |Sponsor:
--+
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 These changes look good, and distcheck now passes.

 But I'm still seeing a similar error in appveyor.

 I don't entirely understand the script. But I wonder if os.path.relpath()
 would work in normalize_srcdir(). It seems like the regular expressions
 depend on unix paths.

 See:
 https://docs.python.org/3/library/os.path.html#os.path.relpath

 That's how add_c_file.py does it:
 https://github.com/torproject/tor/blob/master/scripts/maint/add_c_file.py#L41

 I'm not sure if you'll need os.path.normpath() here, because it modifies
 the slashes in the string:
 https://docs.python.org/3/library/os.path.html#os.path.normpath

 I don't want to block this ticket, so I would also accept:
 * opening an 044-should ticket to fix this check on Windows
 * adding a comment to any Windows-only subsystems, reminding us to double-
 check their order

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31634 [Core Tor/Tor]: Check .may_include order and tor subsystem init order are compatible

[Tor Bug Tracker & Wiki]

#31634: Check .may_include order and tor subsystem init order are compatible
--+
 Reporter:  teor  |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  diagnostics, practracker  |  Actual Points:  1
Parent ID:| Points:  2
 Reviewer:  teor  |Sponsor:
--+
Changes (by nickm):

 * status:  needs_revision => needs_review
 * actualpoints:  0.5 => 1


Comment:

 Wow, there were a few issues there.  I've added on commit to fix out-of-
 tree builds from git, and another to fix distcheck builds.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31634 [Core Tor/Tor]: Check .may_include order and tor subsystem init order are compatible

[Tor Bug Tracker & Wiki]

#31634: Check .may_include order and tor subsystem init order are compatible
--+
 Reporter:  teor  |  Owner:  nickm
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  diagnostics, practracker  |  Actual Points:  0.5
Parent ID:| Points:  2
 Reviewer:  teor  |Sponsor:
--+
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Travis distcheck CI failed with:
 {{{
 Traceback (most recent call last):
   File "/home/travis/build/torproject/tor/tor-0.4.4.0-alpha-
 dev/_build/sub/../../scripts/maint/practracker/includes.py", line 348, in
 
 main(sys.argv)
   File "/home/travis/build/torproject/tor/tor-0.4.4.0-alpha-
 dev/_build/sub/../../scripts/maint/practracker/includes.py", line 345, in
 main
 check_subsystem_order=args.check_subsystem_order)
   File "/home/travis/build/torproject/tor/tor-0.4.4.0-alpha-
 dev/_build/sub/../../scripts/maint/practracker/includes.py", line 309, in
 run_check_includes
 if check_subsys_file(check_subsystem_order, uses_dirs):
   File "/home/travis/build/torproject/tor/tor-0.4.4.0-alpha-
 dev/_build/sub/../../scripts/maint/practracker/includes.py", line 275, in
 check_subsys_file
 if fname in uses_closure[prev]:
 KeyError: u'lib/llharden'
 FAIL scripts/maint/run_check_subsystem_order.sh (exit status: 1)
 }}}

 Appveyor CI failed with a similar error:
 {{{
 Traceback (most recent call last):
   File
 "C:/projects/tor/x86_64-w64-mingw32/../scripts/maint/practracker/includes.py",
 line 348, in 
 main(sys.argv)
   File
 "C:/projects/tor/x86_64-w64-mingw32/../scripts/maint/practracker/includes.py",
 line 341, in main
 run_check_includes(topdir=args.topdir,
   File
 "C:/projects/tor/x86_64-w64-mingw32/../scripts/maint/practracker/includes.py",
 line 309, in run_check_includes
 if check_subsys_file(check_subsystem_order, uses_dirs):
   File
 "C:/projects/tor/x86_64-w64-mingw32/../scripts/maint/practracker/includes.py",
 line 275, in check_subsys_file
 if fname in uses_closure[prev]:
 KeyError: 'lib/llharden'
 FAIL scripts/maint/run_check_subsystem_order.sh (exit status: 1)
 }}}

 Otherwise the changes look good.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31634 [Core Tor/Tor]: Check .may_include order and tor subsystem init order are compatible

[Tor Bug Tracker & Wiki]

#31634: Check .may_include order and tor subsystem init order are compatible
--+
 Reporter:  teor  |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  diagnostics, practracker  |  Actual Points:  0.5
Parent ID:| Points:  2
 Reviewer:  teor  |Sponsor:
--+
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 Okay, I've made an updated branch incorporating your suggestions,
 completely removing a script that apparently isn't what I had working, and
 rebasing on master to fix merge issues.

 It's `ticket31634_v2` with PR at
 https://github.com/torproject/tor/pull/1838

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31634 [Core Tor/Tor]: Check .may_include order and tor subsystem init order are compatible

[Tor Bug Tracker & Wiki]

#31634: Check .may_include order and tor subsystem init order are compatible
--+
 Reporter:  teor  |  Owner:  nickm
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  diagnostics, practracker  |  Actual Points:  0.5
Parent ID:| Points:  2
 Reviewer:  teor  |Sponsor:
--+
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Sorry it's taken me a while to review this, I've been busy with some
 urgent things the past few weeks.

 The code looks good, I added comments about a few typos and tweaks.

 There are a few conflicts between this PR and master.

 I think I ran `tor --dbg-dump-subsystem-list` and `practracker/includes.py
 --check-subsystem-order` the way you expect, and got the expected results.
 But I'm not sure.

 Can we add the relevant commands to `make check`?
 Then I can run it locally, and in CI, and confirm we got the expected
 results.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31634 [Core Tor/Tor]: Check .may_include order and tor subsystem init order are compatible

[Tor Bug Tracker & Wiki]

#31634: Check .may_include order and tor subsystem init order are compatible
--+
 Reporter:  teor  |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  diagnostics, practracker  |  Actual Points:  0.5
Parent ID:| Points:  2
 Reviewer:  teor  |Sponsor:
--+
Changes (by nickm):

 * status:  needs_revision => needs_review
 * actualpoints:   => 0.5
 * milestone:  Tor: unspecified => Tor: 0.4.4.x-final


Comment:

 I have a working script to do this that actually passes now, in
 `ticket31634`.  There is a PR in
 https://github.com/torproject/tor/pull/1741, based the code in #33316 --
 we should review and merge #33316 first.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31634 [Core Tor/Tor]: Check .may_include order and tor subsystem init order are compatible

[Tor Bug Tracker & Wiki]

#31634: Check .may_include order and tor subsystem init order are compatible
--+--
 Reporter:  teor  |  Owner:  nickm
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  diagnostics, practracker  |  Actual Points:
Parent ID:| Points:  2
 Reviewer:  teor  |Sponsor:
--+--

Comment (by nickm):

 I'm making child tickets for 044 for the parts that we can try without too
 much effort, though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31634 [Core Tor/Tor]: Check .may_include order and tor subsystem init order are compatible

[Tor Bug Tracker & Wiki]

#31634: Check .may_include order and tor subsystem init order are compatible
--+--
 Reporter:  teor  |  Owner:  nickm
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  diagnostics, practracker  |  Actual Points:
Parent ID:| Points:  2
 Reviewer:  teor  |Sponsor:
--+--
Changes (by nickm):

 * keywords:  diagnostics, 043-should, practracker => diagnostics,
   practracker
 * milestone:  Tor: 0.4.3.x-final => Tor: unspecified


Comment:

 I think this belongs in 'unspecified' for now.  The changes we need here
 are significant refactoring, and don't belong in a cleanup phase.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31634 [Core Tor/Tor]: Check .may_include order and tor subsystem init order are compatible

[Tor Bug Tracker & Wiki]

#31634: Check .may_include order and tor subsystem init order are compatible
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, 043-should, |  Actual Points:
  practracker|
Parent ID:   | Points:  2
 Reviewer:  teor |Sponsor:
 |  Sponsor31-can
-+-
Changes (by teor):

 * keywords:  diagnostics, 042-should?, practracker => diagnostics,
 043-should, practracker
 * status:  needs_review => needs_revision
 * milestone:  Tor: 0.4.2.x-final => Tor: 0.4.3.x-final


Comment:

 Yes, I think we should make big changes like this in 0.4.3.

 And in 0.4.2, we should avoid:
 * changes to .may_include
 * changes to the module init order

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31634 [Core Tor/Tor]: Check .may_include order and tor subsystem init order are compatible

[Tor Bug Tracker & Wiki]

#31634: Check .may_include order and tor subsystem init order are compatible
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, 042-should?,|  Actual Points:
  practracker|
Parent ID:   | Points:  2
 Reviewer:  teor |Sponsor:
 |  Sponsor31-can
-+-

Comment (by nickm):

 (Right now I am not asking for review on the code per se, since it is not
 ready. I'm asking for review on the decision to defer this to 0.4.3 when
 we willing to take more stability risks.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31634 [Core Tor/Tor]: Check .may_include order and tor subsystem init order are compatible

[Tor Bug Tracker & Wiki]

#31634: Check .may_include order and tor subsystem init order are compatible
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, 042-should?,|  Actual Points:
  practracker|
Parent ID:   | Points:  2
 Reviewer:  teor |Sponsor:
 |  Sponsor31-can
-+-
Changes (by nickm):

 * status:  assigned => needs_review
 * keywords:  diagnostics, 042-should, practracker => diagnostics,
 042-should?, practracker
 * reviewer:   => teor


Comment:

 I have started this, but I believe it is bigger than we should do in
 0.4.2, and we should defer part of it till 0.4.3.  Here is why:

* Our subsystems do not currently to our directory structures.
 Notably, these subsystems are defined in with names that do not match
 their locations: btrack, network, ocirc_event, oconn_event, relay,
 threads, tortls, winprocess.

* Our subsystem order does not currently match the topology very well
 at all: there are four discontinuities on the ordering.  I think they are
 caused by: btrack, compress, winprocess, threads.  We should re-order
 these, but doing so will require us to re-organize some of our code.  That
 seems like a stability risk.

 I have checked in a work-in-progress version of the code to do these
 checks as `ticket31634`.  Do you think it's reasonable to defer to 0.4.3
 based on the above reasoning?  If not, please re-assign to me for 0.4.2,
 but this just got bigger than we anticipated.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31634 [Core Tor/Tor]: Check .may_include order and tor subsystem init order are compatible

[Tor Bug Tracker & Wiki]

#31634: Check .may_include order and tor subsystem init order are compatible
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, 042-should, |  Actual Points:
  practracker|
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
 |  Sponsor31-can
-+-
Changes (by ahf):

 * owner:  (none) => nickm
 * status:  new => assigned


Comment:

 Distributing 0.4.2 tickets between network team members.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31634 [Core Tor/Tor]: Check .may_include order and tor subsystem init order are compatible

[Tor Bug Tracker & Wiki]

#31634: Check .may_include order and tor subsystem init order are compatible
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, 042-should, |  Actual Points:
  practracker|
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
 |  Sponsor31-can
-+-
Changes (by teor):

 * parent:  #31615 =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31634 [Core Tor/Tor]: Check .may_include order and tor subsystem init order are compatible

[Tor Bug Tracker & Wiki]

#31634: Check .may_include order and tor subsystem init order are compatible
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, 042-should, |  Actual Points:
  practracker|
Parent ID:  #31615   | Points:  2
 Reviewer:   |Sponsor:
 |  Sponsor31-can
-+-

Comment (by teor):

 Replying to [comment:2 nickm]:
 > Replying to [comment:1 teor]:
 > > We might also want to check against the order in subsystem_list.c.
 >
 > Yes, but have a look at check_and_setup() in subsysmgr.c -- that causes
 tor to exit with an assertion failure on startup if the subsystems are not
 sorted by priority.

 So we don't need to check the order in subsystem_list.c, because tor does
 it for us. That's good.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31634 [Core Tor/Tor]: Check .may_include order and tor subsystem init order are compatible

[Tor Bug Tracker & Wiki]

#31634: Check .may_include order and tor subsystem init order are compatible
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, 042-should, |  Actual Points:
  practracker|
Parent ID:  #31615   | Points:  2
 Reviewer:   |Sponsor:
 |  Sponsor31-can
-+-

Comment (by nickm):

 Replying to [comment:1 teor]:
 > We might also want to check against the order in subsystem_list.c.

 Yes, but have a look at check_and_setup() in subsysmgr.c -- that causes
 tor to exit with an assertion failure on startup if the subsystems are not
 sorted by priority.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31634 [Core Tor/Tor]: Check .may_include order and tor subsystem init order are compatible

[Tor Bug Tracker & Wiki]

#31634: Check .may_include order and tor subsystem init order are compatible
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  diagnostics, 042-should, |  Actual Points:
  practracker|
Parent ID:  #31615   | Points:  2
 Reviewer:   |Sponsor:
 |  Sponsor31-can
-+-

Comment (by teor):

 We might also want to check against the order in subsystem_list.c.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31634 [Core Tor/Tor]: Check .may_include order and tor subsystem init order are compatible

[Tor Bug Tracker & Wiki]

#31634: Check .may_include order and tor subsystem init order are compatible
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.4.2.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  diagnostics, 042-should,
 Severity:  Normal   |  practracker
Actual Points:   |  Parent ID:  #31615
   Points:  2|   Reviewer:
  Sponsor:   |
  Sponsor31-can  |
-+-
 In #31615, we discovered that our module init order doesn't match their
 dependency order.

 Let's use practracker and tor to make sure that doesn't happen again.
 We'll probably need a new make check target,  because we'll need a
 compiled tor and practracker output. See #31615 for details.

 Gaba, this is Sponsor 31-can, because it helps us catch refactoring bugs
 when we create new modules.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs