Re: [tor-bugs] #31673 [Core Tor/Tor]: Deprecated use of

[Tor Bug Tracker & Wiki]

#31673: Deprecated use of 
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  029-backport, 035-backport   |  Actual Points:
  040-backport 041-backport 042-must |
Parent ID:   | Points:  0.1
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged to 0.2.9 and forward.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31673 [Core Tor/Tor]: Deprecated use of

[Tor Bug Tracker & Wiki]

#31673: Deprecated use of 
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  029-backport, 035-backport   |  Actual Points:
  040-backport 041-backport 042-must |
Parent ID:   | Points:  0.1
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * keywords:  035-backport 040-backport 041-backport 042-must =>
 029-backport, 035-backport 040-backport 041-backport 042-must


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31673 [Core Tor/Tor]: Deprecated use of

[Tor Bug Tracker & Wiki]

#31673: Deprecated use of 
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  035-backport 040-backport|  Actual Points:
  041-backport 042-must  |
Parent ID:   | Points:  0.1
 Reviewer:  nickm|Sponsor:
-+-
Changes (by asn):

 * keywords:  035-backport 040-backport 041-backport asn-merge 042-must =>
 035-backport 040-backport 041-backport 042-must
 * milestone:  Tor: 0.4.2.x-final => Tor: 0.4.1.x-final


Comment:

 Merged. adjusting milestone for backports.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31673 [Core Tor/Tor]: Deprecated use of

[Tor Bug Tracker & Wiki]

#31673: Deprecated use of 
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  035-backport 040-backport|  Actual Points:
  041-backport asn-merge 042-must|
Parent ID:   | Points:  0.1
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * keywords:  035-backport 040-backport 041-backport asn-merge =>
 035-backport 040-backport 041-backport asn-merge 042-must


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31673 [Core Tor/Tor]: Deprecated use of

[Tor Bug Tracker & Wiki]

#31673: Deprecated use of 
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  035-backport 040-backport|  Actual Points:
  041-backport asn-merge |
Parent ID:   | Points:  0.1
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => merge_ready
 * keywords:  035-backport 040-backport 041-backport => 035-backport
 040-backport 041-backport asn-merge


Comment:

 CI has passed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31673 [Core Tor/Tor]: Deprecated use of

[Tor Bug Tracker & Wiki]

#31673: Deprecated use of 
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  035-backport 040-backport|  Actual Points:
  041-backport   |
Parent ID:   | Points:  0.1
 Reviewer:  nickm|Sponsor:
-+-

Comment (by nickm):

 Appears correct; let's see what CI says.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31673 [Core Tor/Tor]: Deprecated use of

[Tor Bug Tracker & Wiki]

#31673: Deprecated use of 
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  035-backport 040-backport|  Actual Points:
  041-backport   |
Parent ID:   | Points:  0.1
 Reviewer:  nickm|Sponsor:
-+-
Changes (by dgoulet):

 * status:  needs_revision => needs_review


Comment:

 Fixed in both. Going afk so taking a chance on this one ;).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31673 [Core Tor/Tor]: Deprecated use of

[Tor Bug Tracker & Wiki]

#31673: Deprecated use of 
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  035-backport 040-backport|  Actual Points:
  041-backport   |
Parent ID:   | Points:  0.1
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 I've commented on both.

 Also, I've recently started making PRs, but not putting them into needs-
 review until the CI has passed. Maybe consider doing this too?  It's saved
 me from a few problems on this kind of thing in the past week.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31673 [Core Tor/Tor]: Deprecated use of

[Tor Bug Tracker & Wiki]

#31673: Deprecated use of 
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  035-backport 040-backport|  Actual Points:
  041-backport   |
Parent ID:   | Points:  0.1
 Reviewer:  nickm|Sponsor:
-+-

Comment (by dgoulet):

 Fixed!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31673 [Core Tor/Tor]: Deprecated use of

[Tor Bug Tracker & Wiki]

#31673: Deprecated use of 
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  035-backport 040-backport|  Actual Points:
  041-backport   |
Parent ID:   | Points:  0.1
 Reviewer:  nickm|Sponsor:
-+-

Comment (by nickm):

 I'm not sure whether removing the HAVE_SYS_SYSCTL_H is correct for all the
 other places we build (ios, etc).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31673 [Core Tor/Tor]: Deprecated use of

[Tor Bug Tracker & Wiki]

#31673: Deprecated use of 
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  035-backport 040-backport|  Actual Points:
  041-backport   |
Parent ID:   | Points:  0.1
 Reviewer:  nickm|Sponsor:
-+-
Changes (by dgoulet):

 * keywords:  035-backport 040-backport 041-backport 042-should easy =>
 035-backport 040-backport 041-backport
 * reviewer:   => nickm
 * status:  new => needs_review


Comment:

 There is two approach to this I believe. Either we keep
 `HAVE_SYS_SYSCTL_H` but add `!defined(__GLIBC__)` or we just remove this
 entirely and only include it _not_ for LInux/Win32 since most BSD flavors
 still uses it afaict.

 I went with the latter.

 029: https://github.com/torproject/tor/pull/1305
 035: https://github.com/torproject/tor/pull/1307

 035 PR merges forward successfully.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31673 [Core Tor/Tor]: Deprecated use of

[Tor Bug Tracker & Wiki]

#31673: Deprecated use of 
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  035-backport 040-backport|  Actual Points:
  041-backport 042-should easy   |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  035-backport 040-backport 041-backport => 035-backport
 040-backport 041-backport 042-should easy


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31673 [Core Tor/Tor]: Deprecated use of

[Tor Bug Tracker & Wiki]

#31673: Deprecated use of 
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.4.2.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  035-backport 040-backport
 Severity:  Normal   |  041-backport
Actual Points:   |  Parent ID:
   Points:  0.1  |   Reviewer:
  Sponsor:   |
-+-
 I've been getting warnings since couple days ago:

 {{{
 /usr/include/x86_64-linux-gnu/sys/sysctl.h:21:2: warning: #warning "The
  header is deprecated and will be removed." [-Wcpp]
21 | #warning "The  header is deprecated and will be
 removed."
 }}}

 It is annoying with `enable-gcc-warnings` since it errors.

 I've removed that include and tor builds fine so, as nickm suggested on
 IRC, right solution here is to not include on Linux/Win32 instead of
 `#ifdef HAVE_SYS_SYSCTL_H`.

 I would recommend a backport since if this becomes a problem to build tor
 in the future.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs