Re: [tor-bugs] #31675 [Core Tor/Tor]: Split microdescs_parse_from_string() into smaller functions

[Tor Bug Tracker & Wiki]

#31675: Split microdescs_parse_from_string() into smaller functions
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  task   | Status:  closed
 Priority:  Low|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  042-can asn-merge  |  Actual Points:  .3
Parent ID: | Points:  0
 Reviewer:  ahf|Sponsor:  Sponsor31-can
---+
Changes (by asn):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31675 [Core Tor/Tor]: Split microdescs_parse_from_string() into smaller functions

[Tor Bug Tracker & Wiki]

#31675: Split microdescs_parse_from_string() into smaller functions
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  task   | Status:  merge_ready
 Priority:  Low|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  042-can asn-merge  |  Actual Points:  .3
Parent ID: | Points:  0
 Reviewer:  ahf|Sponsor:  Sponsor31-can
---+
Changes (by nickm):

 * keywords:  042-can => 042-can asn-merge


Comment:

 Thanks! I have squashed and re-pushed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31675 [Core Tor/Tor]: Split microdescs_parse_from_string() into smaller functions

[Tor Bug Tracker & Wiki]

#31675: Split microdescs_parse_from_string() into smaller functions
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  merge_ready
 Priority:  Low   |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-can   |  Actual Points:  .3
Parent ID:| Points:  0
 Reviewer:  ahf   |Sponsor:  Sponsor31-can
--+
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 Looks good. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31675 [Core Tor/Tor]: Split microdescs_parse_from_string() into smaller functions

[Tor Bug Tracker & Wiki]

#31675: Split microdescs_parse_from_string() into smaller functions
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  needs_review
 Priority:  Low   |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-can   |  Actual Points:  .3
Parent ID:| Points:  0
 Reviewer:  ahf   |Sponsor:  Sponsor31-can
--+
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 Thanks for the review!  I've added a fixup commit and a bool conversion
 commit.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31675 [Core Tor/Tor]: Split microdescs_parse_from_string() into smaller functions

[Tor Bug Tracker & Wiki]

#31675: Split microdescs_parse_from_string() into smaller functions
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  needs_revision
 Priority:  Low   |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-can   |  Actual Points:  .3
Parent ID:| Points:  0
 Reviewer:  ahf   |Sponsor:  Sponsor31-can
--+
Changes (by ahf):

 * status:  needs_review => needs_revision


Comment:

 I get an error when logging into GH right now, so the review comes inline
 here:

 I can see most of these things comes from code movement, but I think we
 can clean them up in follow up patches while this refactoring is
 happening:

 On line 133 in `microdesc_parse.c`: There is a typo in the comment: witll
 should be will.
 On line 143 in `microdesc_parse.c`: Minor detail, but `copy_body` could
 become a bool here.
 On line 147 in `microdesc_parse.c`: `no_onion_key` can be promoted to a
 bool.
 On line 319 in `microdesc_parse.c`: `body_not_found` can also be turned
 into a bool.

 Otherwise I think the refactoring looks good.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31675 [Core Tor/Tor]: Split microdescs_parse_from_string() into smaller functions

[Tor Bug Tracker & Wiki]

#31675: Split microdescs_parse_from_string() into smaller functions
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  needs_review
 Priority:  Low   |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-can   |  Actual Points:  .3
Parent ID:| Points:  0
 Reviewer:  ahf   |Sponsor:  Sponsor31-can
--+
Changes (by nickm):

 * keywords:   => 042-can
 * actualpoints:   => .3


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31675 [Core Tor/Tor]: Split microdescs_parse_from_string() into smaller functions

[Tor Bug Tracker & Wiki]

#31675: Split microdescs_parse_from_string() into smaller functions
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  needs_review
 Priority:  Low   |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  0
 Reviewer:  ahf   |Sponsor:  Sponsor31-can
--+
Changes (by ahf):

 * reviewer:  asn => ahf


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31675 [Core Tor/Tor]: Split microdescs_parse_from_string() into smaller functions

[Tor Bug Tracker & Wiki]

#31675: Split microdescs_parse_from_string() into smaller functions
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  needs_review
 Priority:  Low   |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  0
 Reviewer:  asn   |Sponsor:  Sponsor31-can
--+
Changes (by asn):

 * reviewer:   => asn


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31675 [Core Tor/Tor]: Split microdescs_parse_from_string() into smaller functions

[Tor Bug Tracker & Wiki]

#31675: Split microdescs_parse_from_string() into smaller functions
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  needs_review
 Priority:  Low   |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  0
 Reviewer:|Sponsor:  Sponsor31-can
--+

Comment (by nickm):

 (I've added tests, and gotten them passing)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31675 [Core Tor/Tor]: Split microdescs_parse_from_string() into smaller functions

[Tor Bug Tracker & Wiki]

#31675: Split microdescs_parse_from_string() into smaller functions
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  needs_review
 Priority:  Low   |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  0
 Reviewer:|Sponsor:  Sponsor31-can
--+
Changes (by nickm):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31675 [Core Tor/Tor]: Split microdescs_parse_from_string() into smaller functions

[Tor Bug Tracker & Wiki]

#31675: Split microdescs_parse_from_string() into smaller functions
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  assigned
 Priority:  Low   |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  0
 Reviewer:|Sponsor:  Sponsor31-can
--+

Comment (by nickm):

 CI passed, but I would like more test coverage.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31675 [Core Tor/Tor]: Split microdescs_parse_from_string() into smaller functions

[Tor Bug Tracker & Wiki]

#31675: Split microdescs_parse_from_string() into smaller functions
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  assigned
 Priority:  Low   |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  0
 Reviewer:|Sponsor:  Sponsor31-can
--+

Comment (by nickm):

 Branch is `ticket31675`; PR at https://github.com/torproject/tor/pull/1309
 .  I'll put this in needs_review when CI passes.

 For review, let's also think about the question: is this a good model for
 handling function-size practracker violations?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31675 [Core Tor/Tor]: Split microdescs_parse_from_string() into smaller functions

[Tor Bug Tracker & Wiki]

#31675: Split microdescs_parse_from_string() into smaller functions
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  task   | Status:  assigned
 Priority:  Low|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:
   Points:  0  |   Reviewer:
  Sponsor:  Sponsor31-can  |
---+
 Instead of making an extended practracker exception here, we should make
 this function conform to our best practices.

 I'm taking this on because I need a quick finger exercise between larger
 things.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs