Re: [tor-bugs] #31687 [Core Tor/Tor]: FreeBSD compilation warns with Tor 0.4.1.5

[Tor Bug Tracker & Wiki]

#31687: FreeBSD compilation warns with Tor 0.4.1.5
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.5
 Severity:  Normal   | Resolution:  fixed
 Keywords:  consider-backport-immediately|  Actual Points:  .1
  warning compiler 042-should 041-backport   |
  040-backport 035-backport BugSmashFund |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged to 0.3.5, 0.4.0, and forward.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31687 [Core Tor/Tor]: FreeBSD compilation warns with Tor 0.4.1.5

[Tor Bug Tracker & Wiki]

#31687: FreeBSD compilation warns with Tor 0.4.1.5
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.5
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-immediately|  Actual Points:  .1
  warning compiler 042-should 041-backport   |
  040-backport 035-backport BugSmashFund |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by teor):

 * keywords:
 warning compiler 042-should 041-backport 040-backport 035-backport
 BugSmashFund
 =>
 consider-backport-immediately warning compiler 042-should 041-backport
 040-backport 035-backport BugSmashFund


Comment:

 This is a compiler warning fix, which should be fine to backport after it
 passes CI.

 Here are the PRs:
 * 0.3.5: https://github.com/torproject/tor/pull/1314
 * 0.4.0: https://github.com/torproject/tor/pull/1323

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31687 [Core Tor/Tor]: FreeBSD compilation warns with Tor 0.4.1.5

[Tor Bug Tracker & Wiki]

#31687: FreeBSD compilation warns with Tor 0.4.1.5
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.5
 Severity:  Normal   | Resolution:
 Keywords:  warning compiler 042-should  |  Actual Points:  .1
  041-backport 040-backport 035-backport |
  BugSmashFund   |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by nickm):

 * milestone:  Tor: 0.4.2.x-final => Tor: 0.4.1.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31687 [Core Tor/Tor]: FreeBSD compilation warns with Tor 0.4.1.5

[Tor Bug Tracker & Wiki]

#31687: FreeBSD compilation warns with Tor 0.4.1.5
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.5
 Severity:  Normal   | Resolution:
 Keywords:  warning compiler 042-should  |  Actual Points:  .1
  041-backport 040-backport 035-backport |
  BugSmashFund   |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by asn):

 * keywords:
 warning compiler 042-should 041-backport 040-backport 035-backport
 BugSmashFund asn-merge
 =>
 warning compiler 042-should 041-backport 040-backport 035-backport
 BugSmashFund


Comment:

 Merged. Leaving ticket open for bakcport.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31687 [Core Tor/Tor]: FreeBSD compilation warns with Tor 0.4.1.5

[Tor Bug Tracker & Wiki]

#31687: FreeBSD compilation warns with Tor 0.4.1.5
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.5
 Severity:  Normal   | Resolution:
 Keywords:  warning compiler 042-should  |  Actual Points:  .1
  041-backport 040-backport 035-backport |
  BugSmashFund asn-merge |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by nickm):

 * keywords:
 warning compiler 042-should 041-backport 040-backport 035-backport
 BugSmashFund
 =>
 warning compiler 042-should 041-backport 040-backport 035-backport
 BugSmashFund asn-merge


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31687 [Core Tor/Tor]: FreeBSD compilation warns with Tor 0.4.1.5

[Tor Bug Tracker & Wiki]

#31687: FreeBSD compilation warns with Tor 0.4.1.5
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.5
 Severity:  Normal   | Resolution:
 Keywords:  warning compiler 042-should  |  Actual Points:  .1
  041-backport 040-backport 035-backport |
  BugSmashFund   |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 Looks good.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31687 [Core Tor/Tor]: FreeBSD compilation warns with Tor 0.4.1.5

[Tor Bug Tracker & Wiki]

#31687: FreeBSD compilation warns with Tor 0.4.1.5
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.5
 Severity:  Normal   | Resolution:
 Keywords:  warning compiler 042-should  |  Actual Points:  .1
  041-backport 040-backport 035-backport |
  BugSmashFund   |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by asn):

 * reviewer:   => ahf


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31687 [Core Tor/Tor]: FreeBSD compilation warns with Tor 0.4.1.5

[Tor Bug Tracker & Wiki]

#31687: FreeBSD compilation warns with Tor 0.4.1.5
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.5
 Severity:  Normal   | Resolution:
 Keywords:  warning compiler 042-should  |  Actual Points:  .1
  041-backport 040-backport 035-backport |
  BugSmashFund   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 grarmamp confirms the fix, but notes that another instance of the bug
 exists. Apparently we started using these macros a second time in 0.4.0,
 for tor_isinf().  I've added a new branch `ticket31687_040` to be merged
 into 0.4.0 and forward to fix the issue there as well.  PR at
 https://github.com/torproject/tor/pull/1323

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31687 [Core Tor/Tor]: FreeBSD compilation warns with Tor 0.4.1.5

[Tor Bug Tracker & Wiki]

#31687: FreeBSD compilation warns with Tor 0.4.1.5
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.5
 Severity:  Normal   | Resolution:
 Keywords:  warning compiler 042-should  |  Actual Points:  .1
  041-backport 040-backport 035-backport |
  BugSmashFund   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * actualpoints:   => .1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31687 [Core Tor/Tor]: FreeBSD compilation warns with Tor 0.4.1.5

[Tor Bug Tracker & Wiki]

#31687: FreeBSD compilation warns with Tor 0.4.1.5
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.5
 Severity:  Normal   | Resolution:
 Keywords:  warning compiler 042-should  |  Actual Points:
  041-backport 040-backport 035-backport |
  BugSmashFund   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  accepted => needs_review
 * keywords:  warning compiler 041-should BugSmashFund =>
 warning compiler 042-should 041-backport 040-backport 035-backport
 BugSmashFund
 * milestone:  Tor: 0.4.1.x-final => Tor: 0.4.2.x-final


Comment:

 It turns out that these warnings have been here a long time, so I've made
 `ticket31687_035` based on maint-0.3.5 for them.

 I've made a PR at https://github.com/torproject/tor/pull/1314 to check for
 CI regressions, but I don't have a FreeBSD installation to test this on.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31687 [Core Tor/Tor]: FreeBSD compilation warns with Tor 0.4.1.5

[Tor Bug Tracker & Wiki]

#31687: FreeBSD compilation warns with Tor 0.4.1.5
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.5
 Severity:  Normal   | Resolution:
 Keywords:  warning compiler 041-should  |  Actual Points:
  BugSmashFund   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  new => accepted
 * owner:  (none) => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31687 [Core Tor/Tor]: FreeBSD compilation warns with Tor 0.4.1.5

[Tor Bug Tracker & Wiki]

#31687: FreeBSD compilation warns with Tor 0.4.1.5
--+-
 Reporter:  nickm |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.4.1.5
 Severity:  Normal|   Keywords:  warning compiler 041-should
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+-
 On tor-dev, grarpamp reports:

 {{{
 src/core/or/connection_edge.c:2563:5: warning: potential null pointer
 dereference [-Wnull-dereference]
 src/lib/math/fp.c:106:16: warning: conversion from 'double' to 'float'
 may change value [-Wfloat-conversion]
 src/lib/math/fp.c:111:18: warning: conversion from 'double' to 'float'
 may change value [-Wfloat-conversion]
 src/lib/math/fp.c:136:16: warning: conversion from 'double' to 'float'
 may change value [-Wfloat-conversion]
 src/lib/math/fp.c:88:13: warning: conversion from 'double' to 'float'
 may change value [-Wfloat-conversion]
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31687 [Core Tor/Tor]: FreeBSD compilation warns with Tor 0.4.1.5

[Tor Bug Tracker & Wiki]

#31687: FreeBSD compilation warns with Tor 0.4.1.5
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.1.5
 Severity:  Normal   | Resolution:
 Keywords:  warning compiler 041-should  |  Actual Points:
  BugSmashFund   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  warning compiler 041-should => warning compiler 041-should
 BugSmashFund


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs