Re: [tor-bugs] #31748 [Applications/Tor Browser]: "Learn More" link in Security Level popup is not working

[Tor Bug Tracker & Wiki]

#31748: "Learn More" link in Security Level popup is not working
-+---
 Reporter:  acat |  Owner:  pospeselr
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff68-esr, TorBrowserTeam201910R  |  Actual Points:  0.1
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+---
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks good. That's actually caused by us not picking this change up while
 rebasing, right? So, we should do this kind of fixups as fixups to the
 commit they belong to. I'll take the commit as-is now (commit
 1a8a46866f0dfd69c7a477ce8e3a46c9640e3a53 on `tor-browser-68.1.0esr-9.0-3`)
 to make the release process not more complicated as it already is. I
 think, though, we could squash a bunch of commits that are fixing up
 issues found with the main securitySettings related patch into one single
 commit (I noted that on #31918).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31748 [Applications/Tor Browser]: "Learn More" link in Security Level popup is not working

[Tor Bug Tracker & Wiki]

#31748: "Learn More" link in Security Level popup is not working
-+-
 Reporter:  acat |  Owner:  pospeselr
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, TorBrowserTeam201910R  |  Actual Points:  0.1
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by pospeselr):

 * points:  0.25 => 0.1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31748 [Applications/Tor Browser]: "Learn More" link in Security Level popup is not working

[Tor Bug Tracker & Wiki]

#31748: "Learn More" link in Security Level popup is not working
-+-
 Reporter:  acat |  Owner:  pospeselr
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, TorBrowserTeam201910R  |  Actual Points:  0.1
Parent ID:   | Points:  0.25
 Reviewer:   |Sponsor:
-+-
Changes (by pospeselr):

 * status:  assigned => needs_review
 * keywords:  ff68-esr, TorBrowserTeam201910 => ff68-esr,
 TorBrowserTeam201910R
 * points:   => 0.25
 * actualpoints:   => 0.1


Comment:

 Solution was as simple as described above, just needed to update the label
 elements with the is="text-link" attribute.

 tor-browser: https://gitweb.torproject.org/user/richard/tor-
 browser.git/commit/?h=bug_31748_review

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31748 [Applications/Tor Browser]: "Learn More" link in Security Level popup is not working

[Tor Bug Tracker & Wiki]

#31748: "Learn More" link in Security Level popup is not working
+---
 Reporter:  acat|  Owner:  pospeselr
 Type:  defect  | Status:  assigned
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff68-esr, TorBrowserTeam201910  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+---
Changes (by gk):

 * cc: TorBrowserTeam201910 (removed)
 * keywords:  ff68-esr => ff68-esr, TorBrowserTeam201910


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31748 [Applications/Tor Browser]: "Learn More" link in Security Level popup is not working

[Tor Bug Tracker & Wiki]

#31748: "Learn More" link in Security Level popup is not working
--+---
 Reporter:  acat  |  Owner:  pospeselr
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ff68-esr  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by pospeselr):

 * cc: TorBrowserTeam201910 (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31748 [Applications/Tor Browser]: "Learn More" link in Security Level popup is not working

[Tor Bug Tracker & Wiki]

#31748: "Learn More" link in Security Level popup is not working
--+---
 Reporter:  acat  |  Owner:  pospeselr
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ff68-esr  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by pospeselr):

 * cc: tbb-team (added)
 * status:  new => assigned
 * owner:  tbb-team => pospeselr


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31748 [Applications/Tor Browser]: "Learn More" link in Security Level popup is not working

[Tor Bug Tracker & Wiki]

#31748: "Learn More" link in Security Level popup is not working
--+--
 Reporter:  acat  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ff68-esr  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by pospeselr):

 {{{
 (09/19/2019 09:41:48 AM) pospeselr: hey acat, just stumbled on a fix for
 #31748
 (09/19/2019 09:41:49 AM) zwiebelbot: (notice) tor#31748: "Learn More" link
 in Security Level popup is not working - [new] -
 https://bugs.torproject.org/31748
 (09/19/2019 09:42:12 AM) pospeselr: we need to add an is="text-link"
 attribute to "Learn More" label elements to get them to work as links
 again
 (09/19/2019 09:44:18 AM) pospeselr: will need to add to the Learn More
 links in both securityLevelPreferences.inc.xul and
 securityLevelPanel.inc.xul
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31748 [Applications/Tor Browser]: "Learn More" link in Security Level popup is not working

[Tor Bug Tracker & Wiki]

#31748: "Learn More" link in Security Level popup is not working
--+--
 Reporter:  acat  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  ff68-esr
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs