Re: [tor-bugs] #31941 [Metrics/Onionoo]: Old reverse DNS lookups are sometimes not cleared properly

[Tor Bug Tracker & Wiki]

#31941: Old reverse DNS lookups are sometimes not cleared properly
-+-
 Reporter:  karsten  |  Owner:  karsten
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by karsten):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Thanks for the review! Merged, released, and deployed.

 No host name entry for relay t6kexit1 anymore:
 
https://metrics.torproject.org/rs.html#details/64186B8BCD83E31CEFCE3018334E8C7DBBD04963

 Closing!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31941 [Metrics/Onionoo]: Old reverse DNS lookups are sometimes not cleared properly

[Tor Bug Tracker & Wiki]

#31941: Old reverse DNS lookups are sometimes not cleared properly
-+-
 Reporter:  karsten  |  Owner:  karsten
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by irl):

 * status:  needs_review => merge_ready


Comment:

 Reviewed this offline and forgot to update the ticket.

 This looks good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31941 [Metrics/Onionoo]: Old reverse DNS lookups are sometimes not cleared properly

[Tor Bug Tracker & Wiki]

#31941: Old reverse DNS lookups are sometimes not cleared properly
-+--
 Reporter:  karsten  |  Owner:  karsten
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by karsten):

 * status:  assigned => needs_review


Comment:

 irl, please review
 
[https://gitweb.torproject.org/user/karsten/onionoo.git/commit/?h=task-31941=4693bba81b8aacccbeb93489a841ea97a445d962
 commit 4693bba in my task-31941 branch].

 I tested this patch on a local Onionoo instance that was based on a backup
 from omeiense. Here's how the details status file of t6kexit1 changed:

 {{{
 @@ -99,7 +99,7 @@
"nickname": "t6kexit1",
"address": "70.39.93.111",
"first_seen_millis": 156872880,
 -  "last_seen_millis": 157010040,
 +  "last_seen_millis": 157008600,
"or_port": 443,
"dir_port": 80,
"relay_flags": [
 @@ -117,10 +117,10 @@
"exit_addresses": {
  "185.229.59.167": 1570043529000
},
 -  "consensus_weight_fraction": 2.0087525e-07,
 +  "consensus_weight_fraction": 1.9711189e-07,
"guard_probability": 0,
"middle_probability": 0,
 -  "exit_probability": 9.059996e-07,
 +  "exit_probability": 8.4231533e-07,
"latitude": 36.0907,
"longitude": -115.0886,
"country_code": "us",
 @@ -129,9 +129,6 @@
"city_name": "Las Vegas",
"as_name": "Sharktech",
"as_number": "AS46844",
 -  "verified_host_names": [
 -"c-73-95-69-17.hsd1.co.comcast.net"
 -  ],
"version": "0.4.1.5",
"version_status": "recommended"
  }
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31941 [Metrics/Onionoo]: Old reverse DNS lookups are sometimes not cleared properly

[Tor Bug Tracker & Wiki]

#31941: Old reverse DNS lookups are sometimes not cleared properly
-+--
 Reporter:  karsten  |  Owner:  karsten
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+--
 This ticket is based on a report by the t6kexit1 operator on the metrics-
 team@ mailing list.

 Relay t6kexit1 recently switched from IP address 73.95.69.17 to
 70.39.93.111. While Onionoo was able to resolve the previous IP address to
 a host name, it fails to resolve the current IP address. This failure may
 or may not be an Onionoo bug, but let's ignore this possible bug for the
 moment.

 The fact that Onionoo sticks to the previous host name, even after the
 relay changed its IP address, is for sure a bug. Let's focus on this one,
 because it may be harder to reproduce this situation at a later time.

 I looked at the relevant code. It seems like Onionoo only considers
 successful reverse DNS lookups, but disregards failed lookup attempts.
 What it should do instead is clear previous results in case of a failed
 lookup attempt.

 I'll work on a patch, test it, and then post it here for review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs