Re: [tor-bugs] #31984 [Applications/Tor Browser]: TB 9.x partial update: unable to remove directory: tobedeleted

[Tor Bug Tracker & Wiki]

#31984: TB 9.x partial update: unable to remove directory: tobedeleted
-+-
 Reporter:  mcs  |  Owner:  brade
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  not a
 Keywords:  tbb-9.0, tbb-update, |  bug
  TorBrowserTeam202002   |  Actual Points:  0.25
Parent ID:   | Points:  1.0
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Your hack seems to be a little bit dirty ;) But it is a good item for
 upstreaming to make `updater.exe` portable again :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31984 [Applications/Tor Browser]: TB 9.x partial update: unable to remove directory: tobedeleted

[Tor Bug Tracker & Wiki]

#31984: TB 9.x partial update: unable to remove directory: tobedeleted
-+-
 Reporter:  mcs  |  Owner:  brade
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  not a
 Keywords:  tbb-9.0, tbb-update, |  bug
  TorBrowserTeam202002   |  Actual Points:  0.25
Parent ID:   | Points:  1.0
 Reviewer:   |Sponsor:
-+-
Changes (by mcs):

 * actualpoints:   => 0.25


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31984 [Applications/Tor Browser]: TB 9.x partial update: unable to remove directory: tobedeleted

[Tor Bug Tracker & Wiki]

#31984: TB 9.x partial update: unable to remove directory: tobedeleted
-+-
 Reporter:  mcs  |  Owner:  brade
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  not a
 Keywords:  tbb-9.0, tbb-update, |  bug
  TorBrowserTeam202002   |  Actual Points:
Parent ID:   | Points:  1.0
 Reviewer:   |Sponsor:
-+-
Changes (by mcs):

 * status:  assigned => closed
 * resolution:   => not a bug


Comment:

 Unless the original blog commenter experienced a failed incremental
 update, this is not a bug. My guess is that they saw a line in their
 update log file that appeared to be an error and wanted to let us know
 about it.

 Kathy and I confirmed that the log message occurs in the normal course of
 things. What happens is that, on Windows, `updater.exe` cannot delete the
 DLLs that it depends on. The files are renamed and moved to a temporary
 directory named `tobedeleted`. In Firefox, `MoveFileEx()` is used to tell
 the OS remove that directory upon next reboot. Since that mechanism will
 write to the Windows Registry (which we want to avoid), our Tor Browser
 patches for #4234 add an `#ifdef` to omit the block of code that uses
 `MoveFileEx()`, here:
 https://gitweb.torproject.org/tor-
 browser.git/tree/toolkit/mozapps/update/updater/updater.cpp?h=tor-
 browser-68.3.0esr-9.5-1-build1#n4007

 To make sure `tobedeleted` and its contents are eventually removed in Tor
 Browser, we added code to do so during browser start up, here:
 https://gitweb.torproject.org/tor-
 browser.git/tree/toolkit/xre/nsUpdateDriver.cpp?h=tor-
 browser-68.3.0esr-9.5-1-build1#n879

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31984 [Applications/Tor Browser]: TB 9.x partial update: unable to remove directory: tobedeleted

[Tor Bug Tracker & Wiki]

#31984: TB 9.x partial update: unable to remove directory: tobedeleted
-+-
 Reporter:  mcs  |  Owner:  brade
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-9.0, tbb-update, |  Actual Points:
  TorBrowserTeam201911   |
Parent ID:   | Points:  1.0
 Reviewer:   |Sponsor:
-+-
Changes (by brade):

 * cc: tbb-team (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31984 [Applications/Tor Browser]: TB 9.x partial update: unable to remove directory: tobedeleted

[Tor Bug Tracker & Wiki]

#31984: TB 9.x partial update: unable to remove directory: tobedeleted
-+-
 Reporter:  mcs  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201910, tbb-9.0, tbb-  |  Actual Points:
  update |
Parent ID:   | Points:  1.0
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  TorBrowserTeam201910, tbb-update => TorBrowserTeam201910,
 tbb-9.0, tbb-update


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31984 [Applications/Tor Browser]: TB 9.x partial update: unable to remove directory: tobedeleted

[Tor Bug Tracker & Wiki]

#31984: TB 9.x partial update: unable to remove directory: tobedeleted
--+--
 Reporter:  mcs   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201910, tbb-update  |  Actual Points:
Parent ID:| Points:  1.0
 Reviewer:|Sponsor:
--+--

Comment (by mcs):

 brade and I will need to double-check, but if I remember correctly the
 updater log message about not being able to remove the tobedeleted
 directory is nothing to worry about. That directory will be removed later
 (when the browser is restarted).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31984 [Applications/Tor Browser]: TB 9.x partial update: unable to remove directory: tobedeleted

[Tor Bug Tracker & Wiki]

#31984: TB 9.x partial update: unable to remove directory: tobedeleted
-+-
 Reporter:  mcs  |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  TorBrowserTeam201910,
 Severity:  Normal   |  tbb-update
Actual Points:   |  Parent ID:
   Points:  1.0  |   Reviewer:
  Sponsor:   |
-+-
 On October 02, 2019 an anonymous blog commenter reported something that
 appears to be an update problem. From
 https://blog.torproject.org/comment/284256#comment-284256:
 {{{
 Anonymous (not verified) said:
 partial update is not clean; logs:
 NS_main: unable to remove directory: tobedeleted, err: 41

 boklm said:
 Where/when do you have this error?

 Anonymous (not verified) said:
 Win 10 x64
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs