Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

[Tor Bug Tracker & Wiki]

#32027: Bump version of Go to 1.13+
-+-
 Reporter:  cohosh   |  Owner:  boklm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  snowflake, tbb-rbm,  |  Actual Points:
  ReleaseTrainMigration, GeorgKoppen202004,  |
  TorBrowserTeam202004R, tbb-9.5a12  |
Parent ID:  #31688   | Points:  2
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58
-+-

Comment (by sysrqb):

 And for the documentation, the error in building obfs4 for Android without
 setting `CGO_ENABLED` is:

 {{{
 # _/var/tmp/build/obfs4-2d8f3c8bbfd7/obfs4proxy
 /var/tmp/dist/go/pkg/tool/linux_amd64/link: running /var/tmp/dist/android-
 toolchain/android-ndk/arm/bin/clang failed: exit status 1
 /tmp/go-link-925939917/go.o:go.go:_cgo_init: error: undefined reference to
 'x_cgo_init'
 /tmp/go-link-925939917/go.o:go.go:_cgo_notify_runtime_init_done: error:
 undefined reference to 'x_cgo_notify_runtime_init_done'
 /tmp/go-link-925939917/go.o:go.go:_cgo_thread_start: error: undefined
 reference to 'x_cgo_thread_start'
 /tmp/go-link-925939917/go.o:go.go:runtime._cgo_setenv: error: undefined
 reference to 'x_cgo_setenv'
 /tmp/go-link-925939917/go.o:go.go:runtime._cgo_unsetenv: error: undefined
 reference to 'x_cgo_unsetenv'
 /tmp/go-link-925939917/go.o:go.go:runtime.cgo_yield: error: undefined
 reference to '_cgo_yield'
 clang60: error: linker command failed with exit code 1 (use -v to see
 invocation)
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

[Tor Bug Tracker & Wiki]

#32027: Bump version of Go to 1.13+
-+-
 Reporter:  cohosh   |  Owner:  boklm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  snowflake, tbb-rbm,  |  Actual Points:
  ReleaseTrainMigration, GeorgKoppen202004,  |
  TorBrowserTeam202004R, tbb-9.5a12  |
Parent ID:  #31688   | Points:  2
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58
-+-
Changes (by sysrqb):

 * keywords:
 snowflake, tbb-rbm, ReleaseTrainMigration, GeorgKoppen202004,
 TorBrowserTeam202004R
 =>
 snowflake, tbb-rbm, ReleaseTrainMigration, GeorgKoppen202004,
 TorBrowserTeam202004R, tbb-9.5a12


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

[Tor Bug Tracker & Wiki]

#32027: Bump version of Go to 1.13+
-+-
 Reporter:  cohosh   |  Owner:  boklm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  snowflake, tbb-rbm,  |  Actual Points:
  ReleaseTrainMigration, GeorgKoppen202004,  |
  TorBrowserTeam202004R  |
Parent ID:  #31688   | Points:  2
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58
-+-
Changes (by sysrqb):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Patch looks good to me. Merged to master with commit
 `30bdc472d4d2b222b9435c4a1c728ab74ff96365`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

[Tor Bug Tracker & Wiki]

#32027: Bump version of Go to 1.13+
-+-
 Reporter:  cohosh   |  Owner:  boklm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  snowflake, tbb-rbm,  |  Actual Points:
  ReleaseTrainMigration, GeorgKoppen202004,  |
  TorBrowserTeam202004R  |
Parent ID:  #31688   | Points:  2
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58
-+-

Comment (by sysrqb):

 And thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

[Tor Bug Tracker & Wiki]

#32027: Bump version of Go to 1.13+
-+-
 Reporter:  cohosh   |  Owner:  boklm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake, tbb-rbm,  |  Actual Points:
  ReleaseTrainMigration, GeorgKoppen202004,  |
  TorBrowserTeam202004R  |
Parent ID:  #31688   | Points:  2
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58
-+-

Comment (by dcf):

 bug_32037_v4 looks good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

[Tor Bug Tracker & Wiki]

#32027: Bump version of Go to 1.13+
-+-
 Reporter:  cohosh   |  Owner:  boklm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake, tbb-rbm,  |  Actual Points:
  ReleaseTrainMigration, GeorgKoppen202004,  |
  TorBrowserTeam202004R  |
Parent ID:  #31688   | Points:  2
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58
-+-
Changes (by gk):

 * status:  needs_revision => needs_review
 * keywords:
 snowflake, tbb-rbm, ReleaseTrainMigration, GeorgKoppen202004,
 TorBrowserTeam202004
 =>
 snowflake, tbb-rbm, ReleaseTrainMigration, GeorgKoppen202004,
 TorBrowserTeam202004R


Comment:

 Replying to [comment:25 cypherpunks]:
 > For https://gitweb.torproject.org/user/gk/tor-browser-
 
build.git/tree/projects/go/config?h=bug_32027_v3=81dd92051328e23ae7b02354fb84450905c62b52#n27
 as well, please.

 That's not caused by the compiler bump to 1.13.10, so nothing for this
 ticket. I addressed your other points, though, thanks: `bug_32037_v4`
 (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_32027_v4=260a8442b8b34ace8920c93b3e92cbe3e06a0c7f).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

[Tor Bug Tracker & Wiki]

#32027: Bump version of Go to 1.13+
-+-
 Reporter:  cohosh   |  Owner:  boklm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake, tbb-rbm,  |  Actual Points:
  ReleaseTrainMigration, GeorgKoppen202004,  |
  TorBrowserTeam202004   |
Parent ID:  #31688   | Points:  2
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58
-+-

Comment (by cypherpunks):

 For https://gitweb.torproject.org/user/gk/tor-browser-
 
build.git/tree/projects/go/config?h=bug_32027_v3=81dd92051328e23ae7b02354fb84450905c62b52#n27
 as well, please.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

[Tor Bug Tracker & Wiki]

#32027: Bump version of Go to 1.13+
-+-
 Reporter:  cohosh   |  Owner:  boklm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake, tbb-rbm,  |  Actual Points:
  ReleaseTrainMigration, GeorgKoppen202004,  |
  TorBrowserTeam202004   |
Parent ID:  #31688   | Points:  2
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58
-+-
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:
 snowflake, tbb-rbm, ReleaseTrainMigration, GeorgKoppen202004,
 TorBrowserTeam202004R
 =>
 snowflake, tbb-rbm, ReleaseTrainMigration, GeorgKoppen202004,
 TorBrowserTeam202004


Comment:

 Replying to [comment:23 cypherpunks]:
 > Some comment about adding https://gitweb.torproject.org/user/gk/tor-
 browser-
 
build.git/tree/projects/obfs4/build?h=bug_32027_v3=81dd92051328e23ae7b02354fb84450905c62b52#n10?

 Yeah, I can do that. The build breaks without it for some reason.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

[Tor Bug Tracker & Wiki]

#32027: Bump version of Go to 1.13+
-+-
 Reporter:  cohosh   |  Owner:  boklm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake, tbb-rbm,  |  Actual Points:
  ReleaseTrainMigration, GeorgKoppen202004,  |
  TorBrowserTeam202004R  |
Parent ID:  #31688   | Points:  2
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58
-+-

Comment (by cypherpunks):

 Some comment about adding https://gitweb.torproject.org/user/gk/tor-
 browser-
 
build.git/tree/projects/obfs4/build?h=bug_32027_v3=81dd92051328e23ae7b02354fb84450905c62b52#n10?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

[Tor Bug Tracker & Wiki]

#32027: Bump version of Go to 1.13+
-+-
 Reporter:  cohosh   |  Owner:  boklm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake, tbb-rbm,  |  Actual Points:
  ReleaseTrainMigration, GeorgKoppen202004,  |
  TorBrowserTeam202004R  |
Parent ID:  #31688   | Points:  2
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58
-+-

Comment (by gk):

 Replying to [comment:21 cypherpunks]:
 > > But only if we set GO111MODULE=off in the obfs4 and snowflake build
 scripts instead (too).
 > Move it to https://gitweb.torproject.org/user/gk/tor-browser-
 
build.git/tree/projects/go/config?h=bug_32027_v3=81dd92051328e23ae7b02354fb84450905c62b52#n20
 instead?

 I am not sure. Not everything that uses the setup part does need that env
 variable set. So, I am  inclined to just apply it where it is needed. But
 that can probably be said for the `build_go_lib` part, too. I guess I am
 fine making that change if we think that's good. So far we kept the
 workaround for the lack of go module support in the respective projects
 which is why I added the env variable there as well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

[Tor Bug Tracker & Wiki]

#32027: Bump version of Go to 1.13+
-+-
 Reporter:  cohosh   |  Owner:  boklm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake, tbb-rbm,  |  Actual Points:
  ReleaseTrainMigration, GeorgKoppen202004,  |
  TorBrowserTeam202004R  |
Parent ID:  #31688   | Points:  2
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58
-+-

Comment (by cypherpunks):

 > But only if we set GO111MODULE=off in the obfs4 and snowflake build
 scripts instead (too).
 Move it to https://gitweb.torproject.org/user/gk/tor-browser-
 
build.git/tree/projects/go/config?h=bug_32027_v3=81dd92051328e23ae7b02354fb84450905c62b52#n20
 instead?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

[Tor Bug Tracker & Wiki]

#32027: Bump version of Go to 1.13+
-+-
 Reporter:  cohosh   |  Owner:  boklm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake, tbb-rbm,  |  Actual Points:
  ReleaseTrainMigration, GeorgKoppen202004,  |
  TorBrowserTeam202004R  |
Parent ID:  #31688   | Points:  2
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58
-+-
Changes (by gk):

 * status:  needs_revision => needs_review
 * keywords:
 snowflake, tbb-rbm, ReleaseTrainMigration, GeorgKoppen202004,
 TorBrowserTeam202004
 =>
 snowflake, tbb-rbm, ReleaseTrainMigration, GeorgKoppen202004,
 TorBrowserTeam202004R


Comment:

 Replying to [comment:19 gk]:
 > Replying to [comment:18 boklm]:
 > > Should we remove the workaround we have in `projects/obfs4/build` and
 `projects/snowflake/build` (removing the files `go.mod` and `go.sum`) if
 setting `GOMODULE111=off` makes that not needed?
 >
 > We can do that, good idea. Let me try this tomorrow and push a better
 branch if that works.

 Okay, some further digging. Yes, we can remove our previous workaround for
 the missing support for Go modules. But only if we set `GO111MODULE=off`
 in the `obfs4` and `snowflake` build scripts instead (too). I am not sure
 what's been causing this but for some reason a `go.sum` file in one of the
 PT *deps* was no issue with 1.12.x but is with 1.13.x now (which is what
 dcf was hitting).

 `bug_32027_v3` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_32027_v3=81dd92051328e23ae7b02354fb84450905c62b52)
 contains the fixups.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

[Tor Bug Tracker & Wiki]

#32027: Bump version of Go to 1.13+
-+-
 Reporter:  cohosh   |  Owner:  boklm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake, tbb-rbm,  |  Actual Points:
  ReleaseTrainMigration, GeorgKoppen202004,  |
  TorBrowserTeam202004   |
Parent ID:  #31688   | Points:  2
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58
-+-
Changes (by gk):

 * keywords:
 snowflake, tbb-rbm, ReleaseTrainMigration, GeorgKoppen202004,
 TorBrowserTeam202004R
 =>
 snowflake, tbb-rbm, ReleaseTrainMigration, GeorgKoppen202004,
 TorBrowserTeam202004
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:18 boklm]:
 > Should we remove the workaround we have in `projects/obfs4/build` and
 `projects/snowflake/build` (removing the files `go.mod` and `go.sum`) if
 setting `GOMODULE111=off` makes that not needed?

 We can do that, good idea. Let me try this tomorrow and push a better
 branch if that works.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

[Tor Bug Tracker & Wiki]

#32027: Bump version of Go to 1.13+
-+-
 Reporter:  cohosh   |  Owner:  boklm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake, tbb-rbm,  |  Actual Points:
  ReleaseTrainMigration, GeorgKoppen202004,  |
  TorBrowserTeam202004R  |
Parent ID:  #31688   | Points:  2
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58
-+-

Comment (by boklm):

 Should we remove the workaround we have in `projects/obfs4/build` and
 `projects/snowflake/build` (removing the files `go.mod` and `go.sum`) if
 setting `GOMODULE111=off` makes that not needed?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

[Tor Bug Tracker & Wiki]

#32027: Bump version of Go to 1.13+
-+-
 Reporter:  cohosh   |  Owner:  boklm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake, tbb-rbm,  |  Actual Points:
  ReleaseTrainMigration, GeorgKoppen202004,  |
  TorBrowserTeam202004R  |
Parent ID:  #31688   | Points:  2
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58
-+-
Changes (by gk):

 * keywords:
 snowflake, tbb-rbm, ReleaseTrainMigration, GeorgKoppen202004R,
 TorBrowserTeam202004R
 =>
 snowflake, tbb-rbm, ReleaseTrainMigration, GeorgKoppen202004,
 TorBrowserTeam202004R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

[Tor Bug Tracker & Wiki]

#32027: Bump version of Go to 1.13+
-+-
 Reporter:  cohosh   |  Owner:  boklm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake, tbb-rbm,  |  Actual Points:
  ReleaseTrainMigration, GeorgKoppen202004R, |
  TorBrowserTeam202004R  |
Parent ID:  #31688   | Points:  2
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58
-+-
Changes (by gk):

 * keywords:  snowflake, tbb-rbm, ReleaseTrainMigration,
 TorBrowserTeam202004 =>
 snowflake, tbb-rbm, ReleaseTrainMigration, GeorgKoppen202004R,
 TorBrowserTeam202004R
 * status:  assigned => needs_review


Comment:

 Replying to [comment:10 dcf]:
 > The `GOMODULE111=off` setting still works in go1.13 to disable the
 modules mode and work in the rbm setup. I had to do that in a branch
 recently where an upgraded quic-go required an upgraded go1.13.
 >  * https://gitweb.torproject.org/user/dcf/tor-browser-
 build.git/commit/?h=snowflake-turbotunnel-
 quic=981a62b0f0d61c9151ff1a76a79a78eb2ab3a8fc
 > It definitely does not work by default if you don't set
 `GOMODULE111=off`. You get a lot of errors like:
 > {{{
 > go: github.com/kr/pty@v1.1.1: Get
 https://proxy.golang.org/github.com/kr/pty/@v/v1.1.1.mod: \
 > dial tcp: lookup proxy.golang.org on 173.255.243.5:53: dial udp
 173.255.243.5:53: \
 > connect: network is unreachable
 > }}}

 That's a good idea, thanks. It makes we nervous that we are still using an
 old and unsupported Go version, so I picked it up: `bug_32037_V2`
 (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_32027_v2=e50ba24bb7445986df3c2ebac1fb02b75569b86d)

 I verified that both `obfs4` and `snwoflake` are still compiling on all
 supported platforms. (`meek` compiles at least for Linux x86_64 and
 Android armv7) Furthermore I tested bundles on Linux and an armv7 device
 and nothing exploded. Finally, I compared artifacts and it seems Go
 1.13.10 is not introducing any reproducibility issues. Thus, I think it's
 ready for review and testing in the next alpha (I did not jump to 1.14
 immediately as we are late in the alpha process for 9.5, so we might want
 to be a bit careful at this point).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

[Tor Bug Tracker & Wiki]

#32027: Bump version of Go to 1.13+
-+-
 Reporter:  cohosh   |  Owner:  boklm
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake, tbb-rbm,  |  Actual Points:
  ReleaseTrainMigration, TorBrowserTeam202004|
Parent ID:  #31688   | Points:  2
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58
-+-
Changes (by boklm):

 * cc: tbb-team (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

[Tor Bug Tracker & Wiki]

#32027: Bump version of Go to 1.13+
-+-
 Reporter:  cohosh   |  Owner:  boklm
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake, tbb-rbm,  |  Actual Points:
  ReleaseTrainMigration, TorBrowserTeam202004|
Parent ID:  #31688   | Points:  2
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58
-+-
Changes (by pili):

 * owner:  tbb-team => boklm
 * reviewer:   => sysrqb
 * status:  new => assigned
 * sponsor:   => Sponsor58


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

[Tor Bug Tracker & Wiki]

#32027: Bump version of Go to 1.13+
-+-
 Reporter:  cohosh   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake, tbb-rbm,  |  Actual Points:
  ReleaseTrainMigration, TorBrowserTeam202003|
Parent ID:  #31688   | Points:  2
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 I guess this ticket is relevant as well as there will be no security fixes
 for 1.12 anymore now that 1.14 is out.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

[Tor Bug Tracker & Wiki]

#32027: Bump version of Go to 1.13+
-+-
 Reporter:  cohosh   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake, tbb-rbm,  |  Actual Points:
  TorBrowserTeam202002, ReleaseTrainMigration|
Parent ID:  #31688   | Points:  2
 Reviewer:   |Sponsor:
-+-

Comment (by dcf):

 The `GOMODULE111=off` setting still works in go1.13 to disable the modules
 mode and work in the rbm setup. I had to do that in a branch recently
 where an upgraded quic-go required an upgraded go1.13.
  * https://gitweb.torproject.org/user/dcf/tor-browser-build.git/commit/?h
 =snowflake-turbotunnel-quic=981a62b0f0d61c9151ff1a76a79a78eb2ab3a8fc
 It definitely does not work by default if you don't set `GOMODULE111=off`.
 You get a lot of errors like:
 {{{
 go: github.com/kr/pty@v1.1.1: Get
 https://proxy.golang.org/github.com/kr/pty/@v/v1.1.1.mod: \
 dial tcp: lookup proxy.golang.org on 173.255.243.5:53: dial udp
 173.255.243.5:53: \
 connect: network is unreachable
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

[Tor Bug Tracker & Wiki]

#32027: Bump version of Go to 1.13+
-+-
 Reporter:  cohosh   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake, tbb-rbm,  |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #31688   | Points:  2
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * keywords:  snowflake, tbb-rbm, TorBrowserTeam202001 => snowflake, tbb-
 rbm, TorBrowserTeam202002


Comment:

 This can come after we solve supporting module.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

[Tor Bug Tracker & Wiki]

#32027: Bump version of Go to 1.13+
-+-
 Reporter:  cohosh   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake, tbb-rbm,  |  Actual Points:
  TorBrowserTeam202001   |
Parent ID:  #31688   | Points:  2
 Reviewer:   |Sponsor:
-+-
Changes (by pili):

 * points:   => 2


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

[Tor Bug Tracker & Wiki]

#32027: Bump version of Go to 1.13+
-+-
 Reporter:  cohosh   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake, tbb-rbm,  |  Actual Points:
  TorBrowserTeam202001   |
Parent ID:  #31688   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * keywords:  snowflake => snowflake, tbb-rbm, TorBrowserTeam202001


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

[Tor Bug Tracker & Wiki]

#32027: Bump version of Go to 1.13+
--+--
 Reporter:  cohosh|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  snowflake |  Actual Points:
Parent ID:  #31688| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * cc: JeremyRand (added)
 * parent:   => #31688


Comment:

 #31689 is a duplicate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

[Tor Bug Tracker & Wiki]

#32027: Bump version of Go to 1.13+
--+--
 Reporter:  cohosh|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  snowflake |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by sysrqb):

 * keywords:   => snowflake
 * actualpoints:  snowflake =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

[Tor Bug Tracker & Wiki]

#32027: Bump version of Go to 1.13+
--+---
 Reporter:  cohosh|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  snowflake
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by sysrqb):

 It looks like we need for this for supporting obfs4proxy on Android Q (and
 likely any golang project, for that matter), so that is very exciting.

 The fix for https://github.com/golang/go/issues/29674 landed in 1.13 which
 is the cause of:

 {{{
 WARN: Managed proxy at '/data/app/org.torproject.torbrowser-
 ==/lib/arm64/libObfs4proxy.so' reported: error:
 "/data/app/org.torproject.torbrowser-
 ==/lib/arm64/libObfs4proxy.so": executable's TLS segment is
 underaligned: alignment is 8, needs to be at least 64 for ARM64 Bionic
 }}}

 Multiple other project ran into this problem, too (just for reference):
 https://github.com/shadowsocks/v2ray-plugin-android/issues/6
 https://github.com/termux/termux-packages/issues/3619
 https://github.com/Catfriend1/syncthing-android/issues/370

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

[Tor Bug Tracker & Wiki]

#32027: Bump version of Go to 1.13+
--+---
 Reporter:  cohosh|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  snowflake
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by dcf):

 Another thing to watch out for in Go 1.13. By default, even commands like
 `go build` will phone home to proxy.golang.org and sum.golang.org. See:
  * https://golang.org/doc/go1.13#modules
  * https://proxy.golang.org/
> As of Go 1.13, the go command by default downloads and authenticates
 modules using the Go module mirror and Go checksum database.
  * https://golang.org/cmd/go/#hdr-Module_downloading_and_verification
> The go command can fetch modules from a proxy or connect to source
 control servers directly, according to the setting of the GOPROXY
 environment variable (see 'go help env'). The default setting for GOPROXY
 is "https://proxy.golang.org,direct;, which means to try the Go module
 mirror run by Google and fall back to a direct connection if the proxy
 reports that it does not have the module (HTTP error 404 or 410).

 The phone-home behavior is annoying, but probably mostly harmless in the
 rbm context. To disable the proxy.golang.org reporting, you can set
 `GOPROXY=direct` -- but even better for us may be `GOPROXY=off`, which is
 supposed to "disallow downloading modules from any source," which is what
 we want during the offline portion of the build.

 To disable the sum.golang.org reporting, you can set `GOSUMDB=off`.
 https://golang.org/cmd/go/#hdr-Module_authentication_failures
 > If GOSUMDB is set to "off", or if "go get" is invoked with the -insecure
 flag, the checksum database is not consulted, and all unrecognized modules
 are accepted, at the cost of giving up the security guarantee of verified
 repeatable downloads for all modules.

 I personally had problems this week with checksum mismatches using
 go1.13.1 -- it turns out they changed how checksums are calculated with
 respect to symlinks, or something, and invalidated previous checksums. I
 tried clearing my cache and everything, and could not get
 https://github.com/lucas-clemente/quic-go to build using go1.13.1 because
 of checksum mismatches. So if you get "checksum mismatch" errors, it's
 something related to that.
  * https://github.com/golang/go/issues/29278
  *
 https://github.com/search?utf8=%E2%9C%93=golang+checksum+mismatch=Issues

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

[Tor Bug Tracker & Wiki]

#32027: Bump version of Go to 1.13+
--+---
 Reporter:  cohosh|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  snowflake
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by cohosh):

 Note: as mentioned in
 https://trac.torproject.org/projects/tor/ticket/28942#comment:66 we should
 be careful about how modules are handled in 1.13

 Perhaps we want to tackle #28325 first.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

[Tor Bug Tracker & Wiki]

#32027: Bump version of Go to 1.13+
--+--
 Reporter:  cohosh|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:  snowflake |  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 We're going to need it eventually for newer versions of pion/webrtc, and
 there's a nice feature in to log package that allows us to pass the log
 output writer to libraries.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs