Re: [tor-bugs] #32053 [Applications/Tor Browser]: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)

[Tor Bug Tracker & Wiki]

#32053: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM
optimization issue)
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:  closed
 Priority:  Immediate|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:  fixed
 Keywords:  tbb-9.0-must, tbb-9.0-issues, tbb-   |  Actual Points:  14.5
  regression, tbb-9.0.1-can, |
  TorBrowserTeam201912R, GeorgKoppen201912,  |
  9.0.5, 9.5a4, tbb-backported   |
Parent ID:   | Points:
 Reviewer:  boklm|Sponsor:
-+-
Changes (by sysrqb):

 * keywords:
 tbb-9.0-must, tbb-9.0-issues, tbb-regression, tbb-9.0.1-can,
 TorBrowserTeam201912R, GeorgKoppen201912, tbb-backport
 =>
 tbb-9.0-must, tbb-9.0-issues, tbb-regression, tbb-9.0.1-can,
 TorBrowserTeam201912R, GeorgKoppen201912, 9.0.5, 9.5a4, tbb-backported


Comment:

 Replying to [comment:58 boklm]:
 > Thanks, I merged it to master as commit
 5cafc16c0e5af59f95f685025b487b306c10bd01. I'm adding the tbb-backport
 keyword as we probably want to backport this to the stable branch.

 Backported as commit `0fbb6fa8a942e8243130f8c68616a28d4181a090`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32053 [Applications/Tor Browser]: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)

[Tor Bug Tracker & Wiki]

#32053: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM
optimization issue)
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:  closed
 Priority:  Immediate|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:  fixed
 Keywords:  tbb-9.0-must, tbb-9.0-issues, tbb-   |  Actual Points:  14.5
  regression, tbb-9.0.1-can, |
  TorBrowserTeam201912R, GeorgKoppen201912,  |
  tbb-backport   |
Parent ID:   | Points:
 Reviewer:  boklm|Sponsor:
-+-
Changes (by boklm):

 * keywords:
 tbb-9.0-must, tbb-9.0-issues, tbb-regression, tbb-9.0.1-can,
 TorBrowserTeam201912R, GeorgKoppen201912
 =>
 tbb-9.0-must, tbb-9.0-issues, tbb-regression, tbb-9.0.1-can,
 TorBrowserTeam201912R, GeorgKoppen201912, tbb-backport
 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Thanks, I merged it to master as commit
 5cafc16c0e5af59f95f685025b487b306c10bd01. I'm adding the tbb-backport
 keyword as we probably want to backport this to the stable branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32053 [Applications/Tor Browser]: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)

[Tor Bug Tracker & Wiki]

#32053: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM
optimization issue)
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  Immediate|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  tbb-9.0-must, tbb-9.0-issues, tbb-   |  Actual Points:  14.5
  regression, tbb-9.0.1-can, |
  TorBrowserTeam201912R, GeorgKoppen201912   |
Parent ID:   | Points:
 Reviewer:  boklm|Sponsor:
-+-
Changes (by gk):

 * status:  needs_revision => needs_review
 * reviewer:   => boklm


Comment:

 `bug_32053_v7` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_32053_v7=5cafc16c0e5af59f95f685025b487b306c10bd01)
 has the fix, thanks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32053 [Applications/Tor Browser]: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)

[Tor Bug Tracker & Wiki]

#32053: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM
optimization issue)
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Immediate|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  tbb-9.0-must, tbb-9.0-issues, tbb-   |  Actual Points:  14.5
  regression, tbb-9.0.1-can, |
  TorBrowserTeam201912R, GeorgKoppen201912   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * status:  needs_review => needs_revision
 * actualpoints:  11.5 => 14.5


Comment:

 Replying to [comment:53 gk]:
 > `bug_32053_v5` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_32053_v5=b3863530eb585d849a1de0e4eba6690e589954e6)
 is up for review.

 There is a typo in the commit message:
 {{{
 the vast majority of different builds we good
 }}}
 good -> got ?

 Other than this, this looks good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32053 [Applications/Tor Browser]: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)

[Tor Bug Tracker & Wiki]

#32053: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM
optimization issue)
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  Immediate|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  tbb-9.0-must, tbb-9.0-issues, tbb-   |  Actual Points:  11.5
  regression, tbb-9.0.1-can, |
  TorBrowserTeam201912R, GeorgKoppen201912   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 FWIW, we have a patch in #32739 to switch to clang 8.0.1 for alpha while
 we are at it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32053 [Applications/Tor Browser]: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)

[Tor Bug Tracker & Wiki]

#32053: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM
optimization issue)
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  Immediate|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  tbb-9.0-must, tbb-9.0-issues, tbb-   |  Actual Points:  11.5
  regression, tbb-9.0.1-can, |
  TorBrowserTeam201912R, GeorgKoppen201912   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Someone (like tom) has a good idea to switch to LLVM 10 (not clang 9). And
 it's better to try fixing it before it is released. You can use `-O3` to
 go further that way.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32053 [Applications/Tor Browser]: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)

[Tor Bug Tracker & Wiki]

#32053: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM
optimization issue)
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  Immediate|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  tbb-9.0-must, tbb-9.0-issues, tbb-   |  Actual Points:  11.5
  regression, tbb-9.0.1-can, |
  TorBrowserTeam201912R, GeorgKoppen201912   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:
 tbb-9.0-must, tbb-9.0-issues, tbb-regression, tbb-9.0.1-can,
 TorBrowserTeam201912
 =>
 tbb-9.0-must, tbb-9.0-issues, tbb-regression, tbb-9.0.1-can,
 TorBrowserTeam201912R, GeorgKoppen201912
 * status:  assigned => needs_review
 * actualpoints:   => 11.5


Comment:

 `bug_32053_v5` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_32053_v5=b3863530eb585d849a1de0e4eba6690e589954e6)
 is up for review.

 I've been running into two reproducibility issues while debugging. The one
 Alex reported (bug 43909) we need to fix, I am not sure about the other
 one, bug 42574. The later got fixed in clang 9 and I only encountered it
 while testing an LLVM 8 `opt` on a non-optimized style bitcode file built
 with Rust 1.32.0. When built with 1.34.2 which we actually uses I don't
 hit the bug.

 However, it's not clear whether any of the issues (or mabye even unknown
 ones) we hit on other platforms than macOS and 32bit Linux is caused by
 bug 42575, thus I think it's safer to backport that fix as well.

 Alex: a big thank you to you for your invaluable help. Without it hunting
 down and fixing the bug(s) would have taken much longer.

 boklm: please add your points for #32052 to this ticket, too.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32053 [Applications/Tor Browser]: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)

[Tor Bug Tracker & Wiki]

#32053: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM
optimization issue)
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  Immediate|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201911, tbb-9.0-must,  |  Actual Points:
  tbb-9.0-issues, tbb-regression, tbb-9.0.1-can  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Oh, and we can't easily switch to clang 9 directly (just in case someone
 had this idea) because first of all there seem to be
 [https://bugzilla.mozilla.org/show_bug.cgi?id=1596283 new],
 [https://bugzilla.mozilla.org/show_bug.cgi?id=1596350 additional
 reproducibility issues] that got introduced with clang 9. And furthermore
 our `mingw-clang` cross-build is
 [https://bugzilla.mozilla.org/show_bug.cgi?id=1590624 not ready for clang
 9 yet]. Finally, it's a quite invasive change as it would effect almost
 all of our builds and we'd want a newer Rust version, which is using clang
 9, too, as well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32053 [Applications/Tor Browser]: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)

[Tor Bug Tracker & Wiki]

#32053: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM
optimization issue)
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  Immediate|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201911, tbb-9.0-must,  |  Actual Points:
  tbb-9.0-issues, tbb-regression, tbb-9.0.1-can  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Okay, some good news. Testing with clang 9 + the patch for
 https://reviews.llvm.org/D70376 gives me reproducible output while without
 it it does not. Thus, the bug we are chasing seems to got fixed somewhere
 between 8.0.0 and 9.0.0 (assuming that the https://reviews.llvm.org/D70376
 fix is equivalent to Eli's [https://bugs.llvm.org/attachment.cgi?id=22803
 backported patch for 8.0.0] which I'll check soon). I'll do another
 bisecting figuring out which commit actually fixed the issue we hit while
 still trying pin the exact optimization down that is troubling us.

 Another good news is that Mozilla seems to be
 [https://bugs.llvm.org/show_bug.cgi?id=44147 ready to find this kind of
 bugs, too], and potentially earlier than we from now on so that we
 hopefully have been dealing with this kind of stuff for the last time. I
 guess that got solved on Mozilla's side by
 https://bugzilla.mozilla.org/show_bug.cgi?id=1577212.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32053 [Applications/Tor Browser]: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)

[Tor Bug Tracker & Wiki]

#32053: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM
optimization issue)
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  Immediate|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201911, tbb-9.0-must,  |  Actual Points:
  tbb-9.0-issues, tbb-regression, tbb-9.0.1-can  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Replying to [comment:48 gk]:
 > So, I am back with bisecting the optimization options with the patch
 from Eli applied to rule out that the jump-threading issue is affecting
 us. That takes considerable time on my machines, though, alas. :(
 Apply for funding to get an AMD ThreadRipper 3970X 32 cores 64 threads
 beast (or wait for 2020 when the 3990X 64 cores 128 threads BEAST comes
 out).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32053 [Applications/Tor Browser]: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)

[Tor Bug Tracker & Wiki]

#32053: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM
optimization issue)
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  Immediate|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201911, tbb-9.0-must,  |  Actual Points:
  tbb-9.0-issues, tbb-regression, tbb-9.0.1-can  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:47 gk]:
 > Replying to [comment:43 gk]:
 > > Okay, some status update. Bisecting gets hard. I am down to building
 stylo with Rust 1.30.0 and am at LLVM's
 b1546da0e8849d58fcdcf17fa1f2fab0cdae70a4 and have not reached the bottom
 yet.
 >
 > Building with Rust 1.29.2 I am down to LLVM's
 8c59921ca3284ced1c358c4c86ec2c830db0bd70 and still have not reached the
 bottom...
 >
 > > While exploring ways to move further here I'll investigate whether we
 can just move the `jump-threading` optimization out of `-O1`, say, into
 `-O3` so the we are actually do not use that one.
 >
 > I tried that, surprisingly enough that does not fix the issue. I
 inspected the log of the optimization passes that got run and no jump-
 threading showed up (so, that part worked). However, I still got non-
 reproducible outcomes. I gonna ask on the LLVM bug whether that's expected
 and if not whether that could give us some lead where to look closer to
 understand the bug better.

 So, it turns out the issue Alex was hitting and reporting to LLVM is a new
 determinism problem. I verified that the commit he used + the patch
 applied gives deterministic output, which is promising as we can
 theoretically bisect our way to the fix for the bug *we* are hitting.
 However, Eli over in the LLVM bug said there were some determinism related
 fixes and it might be hard to figure out which is affecting us. :(

 So, I am back with bisecting the optimization options with the patch from
 Eli applied to rule out that the jump-threading issue is affecting us.
 That takes considerable time on my machines, though, alas. :(

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32053 [Applications/Tor Browser]: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)

[Tor Bug Tracker & Wiki]

#32053: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM
optimization issue)
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  Immediate|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201911, tbb-9.0-must,  |  Actual Points:
  tbb-9.0-issues, tbb-regression, tbb-9.0.1-can  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:43 gk]:
 > Okay, some status update. Bisecting gets hard. I am down to building
 stylo with Rust 1.30.0 and am at LLVM's
 b1546da0e8849d58fcdcf17fa1f2fab0cdae70a4 and have not reached the bottom
 yet.

 Building with Rust 1.29.2 I am down to LLVM's
 8c59921ca3284ced1c358c4c86ec2c830db0bd70 and still have not reached the
 bottom...

 > While exploring ways to move further here I'll investigate whether we
 can just move the `jump-threading` optimization out of `-O1`, say, into
 `-O3` so the we are actually do not use that one.

 I tried that, surprisingly enough that does not fix the issue. I inspected
 the log of the optimization passes that got run and no jump-threading
 showed up (so, that part worked). However, I still got non-reproducible
 outcomes. I gonna ask on the LLVM bug whether that's expected and if not
 whether that could give us some lead where to look closer to understand
 the bug better.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32053 [Applications/Tor Browser]: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)

[Tor Bug Tracker & Wiki]

#32053: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM
optimization issue)
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Immediate|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201911, tbb-9.0-must,  |  Actual Points:
  tbb-9.0-issues, tbb-regression,|
  tbb-9.0.1-can, GeorgKoppen201911   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Okay, some status update. Bisecting gets hard. I am down to building stylo
 with Rust 1.30.0 and am at LLVM's b1546da0e8849d58fcdcf17fa1f2fab0cdae70a4
 and have not reached the bottom yet. While exploring ways to move further
 here I'll investigate whether we can just move the `jump-threading`
 optimization out of `-O1`, say, into `-O3` so the we are actually do not
 use that one.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32053 [Applications/Tor Browser]: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)

[Tor Bug Tracker & Wiki]

#32053: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM
optimization issue)
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Immediate|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201911, tbb-9.0-must,  |  Actual Points:
  tbb-9.0-issues, tbb-regression,|
  tbb-9.0.1-can, GeorgKoppen201911   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:40 alexcrichton]:
 > I think Eli from LLVM found a fix at https://reviews.llvm.org/D70103, or
 at least that fixes the test cases for me locally. Can y'all patch LLVM
 locally to test out on your end?

 Yeah, I am on it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32053 [Applications/Tor Browser]: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)

[Tor Bug Tracker & Wiki]

#32053: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM
optimization issue)
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Immediate|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201911, tbb-9.0-must,  |  Actual Points:
  tbb-9.0-issues, tbb-regression,|
  tbb-9.0.1-can, GeorgKoppen201911   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:39 alexcrichton]:
 > Oh so for just `-jump-threading` to work you'll need to do:
 >
 > 1. Start with `foo.bc`
 > 2. Figure out smallest N where `opt -O3 foo.bc -opt-bisect-limit` is
 non-deterministic
 > 3. Run `opt -O3 -o input.bc -opt-bisect-limit=N-1 foo.bc`
 > 4. Use `llvm-extract` on `input.bc` to extract the function
 > 5. Run `opt -jump-threading` over the extracted `*.bc` file
 >
 > You won't be able to run `-jump-threading` over the original module,
 you'll need to run it over the module just before the output becomes
 nondeterministic.

 Yeah, that's what I did. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32053 [Applications/Tor Browser]: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)

[Tor Bug Tracker & Wiki]

#32053: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM
optimization issue)
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Immediate|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201911, tbb-9.0-must,  |  Actual Points:
  tbb-9.0-issues, tbb-regression,|
  tbb-9.0.1-can, GeorgKoppen201911   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by alexcrichton):

 I think Eli from LLVM found a fix at https://reviews.llvm.org/D70103, or
 at least that fixes the test cases for me locally. Can y'all patch LLVM
 locally to test out on your end?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32053 [Applications/Tor Browser]: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)

[Tor Bug Tracker & Wiki]

#32053: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM
optimization issue)
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Immediate|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201911, tbb-9.0-must,  |  Actual Points:
  tbb-9.0-issues, tbb-regression,|
  tbb-9.0.1-can, GeorgKoppen201911   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by alexcrichton):

 Oh so for just `-jump-threading` to work you'll need to do:

 1. Start with `foo.bc`
 2. Figure out smallest N where `opt -O3 foo.bc -opt-bisect-limit` is non-
 deterministic
 3. Run `opt -O3 -o input.bc -opt-bisect-limit=N-1 foo.bc`
 4. Use `llvm-extract` on `input.bc` to extract the function
 5. Run `opt -jump-threading` over the extracted `*.bc` file

 You won't be able to run `-jump-threading` over the original module,
 you'll need to run it over the module just before the output becomes
 nondeterministic.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32053 [Applications/Tor Browser]: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)

[Tor Bug Tracker & Wiki]

#32053: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM
optimization issue)
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Immediate|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201911, tbb-9.0-must,  |  Actual Points:
  tbb-9.0-issues, tbb-regression,|
  tbb-9.0.1-can, GeorgKoppen201911   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:37 alexcrichton]:
 > Oh for `llvm-extract` I used the `-rfunc` argument which is a regex
 instead of an exact name,  like so: `llvm-extract before.bc
 -rfunc=17h5949677e2a2fd343E -o before-extract.bc`

 Thanks, that helped. However, I've tried to repro just doing the `-jump-
 threading` pass thousands of times on the same machine (kernel, glibc
 etc.), with the same clang version, essentially with the same script, as I
 reproduce the bug when running *all* the passes up to and including the
 problematic `-jump-threading` one: but I don't hit the bug that way, which
 seems to reproduce my results from comment:30. I wonder what we are
 missing here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32053 [Applications/Tor Browser]: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)

[Tor Bug Tracker & Wiki]

#32053: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM
optimization issue)
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Immediate|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201911, tbb-9.0-must,  |  Actual Points:
  tbb-9.0-issues, tbb-regression,|
  tbb-9.0.1-can, GeorgKoppen201911   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by alexcrichton):

 Oh for `llvm-extract` I used the `-rfunc` argument which is a regex
 instead of an exact name,  like so: `llvm-extract before.bc
 -rfunc=17h5949677e2a2fd343E -o before-extract.bc`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32053 [Applications/Tor Browser]: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)

[Tor Bug Tracker & Wiki]

#32053: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM
optimization issue)
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Immediate|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201911, tbb-9.0-must,  |  Actual Points:
  tbb-9.0-issues, tbb-regression,|
  tbb-9.0.1-can, GeorgKoppen201911   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:31 gk]:
 > Okay, so before I speculate further I double-check your results using
 `-opt-bisect-limit` at least figuring out which optimization is the
 culprit for the tests I am currently running.

 Yeah, I can confirm that this is the `-jump-threading` operation here,
 too, good. Then let's get the LLVM bisecting going.

 Alex: So, I tried to extract the problematic function name with `llvm-
 extract` but I failed so far due to my lack of knowledge of LLVM tools.
 How do I properly demangle the function name so that `llvm-extract` likes
 it? I tried `llvm-cxxfilt` but no dice. The `opt` output for the
 problematic function I get is:
 {{{
 BISECT: running pass (1208271) Jump Threading on function
 
(_ZN83_$LT$style..values..specified..box_..Appearance$u20$as$u20$style..parser..Parse$GT$5parse17ha60227de7ee101e5E)
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32053 [Applications/Tor Browser]: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)

[Tor Bug Tracker & Wiki]

#32053: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM
optimization issue)
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Immediate|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201911, tbb-9.0-must,  |  Actual Points:
  tbb-9.0-issues, tbb-regression,|
  tbb-9.0.1-can, GeorgKoppen201911   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:33 boklm]:
 > Replying to [comment:32 gk]:
 > > Let's test -O1 in our upcoming alpha build to get a feeling whether
 that would be an acceptable workaround or not and to check whether it
 actually resolves our build issues: `bug_32053_workaround`
 (https://gitweb.torproject.org/user/gk/tor-
 
browser.git/commit/?h=bug_32053_workaround=f1f9fa0286982d1fa486880ad6037e1e7a46457d)
 has a patch for review.
 >
 > That sounds like a good idea to test this in the next alpha. And the
 patch looks good to me.

 That strategy does not fly, alas, as using -O1 is causing build bustage on
 Linux at least (due to the current defense we have against proxy bypasses
 of Rust code), see: #32426.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32053 [Applications/Tor Browser]: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)

[Tor Bug Tracker & Wiki]

#32053: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM
optimization issue)
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Immediate|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201911, tbb-9.0-must,  |  Actual Points:
  tbb-9.0-issues, tbb-regression,|
  tbb-9.0.1-can, GeorgKoppen201911   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:
 TorBrowserTeam201911R, tbb-9.0-must, tbb-9.0-issues, tbb-regression,
 tbb-9.0.1-can, GeorgKoppen201911
 =>
 TorBrowserTeam201911, tbb-9.0-must, tbb-9.0-issues, tbb-regression,
 tbb-9.0.1-can, GeorgKoppen201911
 * status:  needs_review => new


Comment:

 That made it onto `tor-browser-68.2.0esr-9.5-1` (commit
 f1f9fa0286982d1fa486880ad6037e1e7a46457d) and will hopefully available in
 9.5a2.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32053 [Applications/Tor Browser]: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)

[Tor Bug Tracker & Wiki]

#32053: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM
optimization issue)
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Immediate|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201911R,   |  Actual Points:
  tbb-9.0-must, tbb-9.0-issues, tbb-regression,  |
  tbb-9.0.1-can, GeorgKoppen201911   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:32 gk]:
 > Let's test -O1 in our upcoming alpha build to get a feeling whether that
 would be an acceptable workaround or not and to check whether it actually
 resolves our build issues: `bug_32053_workaround`
 (https://gitweb.torproject.org/user/gk/tor-
 
browser.git/commit/?h=bug_32053_workaround=f1f9fa0286982d1fa486880ad6037e1e7a46457d)
 has a patch for review.

 That sounds like a good idea to test this in the next alpha. And the patch
 looks good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32053 [Applications/Tor Browser]: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)

[Tor Bug Tracker & Wiki]

#32053: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM
optimization issue)
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Immediate|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201911R,   |  Actual Points:
  tbb-9.0-must, tbb-9.0-issues, tbb-regression,  |
  tbb-9.0.1-can, GeorgKoppen201911   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:
 TorBrowserTeam201911, tbb-9.0-must, tbb-9.0-issues, tbb-regression,
 tbb-9.0.1-can, GeorgKoppen201911
 =>
 TorBrowserTeam201911R, tbb-9.0-must, tbb-9.0-issues, tbb-regression,
 tbb-9.0.1-can, GeorgKoppen201911
 * status:  new => needs_review


Comment:

 Let's test -O1 in our upcoming alpha build to get a feeling whether that
 would be an acceptable workaround or not and to check whether it actually
 resolves our build issues: `bug_32053_workaround`
 (https://gitweb.torproject.org/user/gk/tor-
 
browser.git/commit/?h=bug_32053_workaround=f1f9fa0286982d1fa486880ad6037e1e7a46457d)
 has a patch for review.

 FWIW: It might have been enough to just patch `toolchain.configure` but
 that would result in different `opt-level` options passed to `rustc` and I
 was not exactly sure what would happen in that case.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32053 [Applications/Tor Browser]: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)

[Tor Bug Tracker & Wiki]

#32053: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM
optimization issue)
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Immediate|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201911, tbb-9.0-must,  |  Actual Points:
  tbb-9.0-issues, tbb-regression,|
  tbb-9.0.1-can, GeorgKoppen201911   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Okay, so before I speculate further I double-check your results using
 `-opt-bisect-limit` at least figuring out which optimization is the
 culprit for the tests I am currently running.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32053 [Applications/Tor Browser]: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)

[Tor Bug Tracker & Wiki]

#32053: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM
optimization issue)
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Immediate|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201911, tbb-9.0-must,  |  Actual Points:
  tbb-9.0-issues, tbb-regression,|
  tbb-9.0.1-can, GeorgKoppen201911   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:29 alexcrichton]:
 > The bug seems to be in the `-jump-threading` pass which I suspect is
 included in the O1 optimizations, yeah, but this technically only arose
 during O3 when presumably enough inlining had happened to then trigger the
 bug. I'm not really sure what the best way to avoid this bug would be
 unfortunately, but I suspect that an `-O1` build should be reproducible
 (albeit slow).

 Actually O2 is already enough. I can't trigger the issue with O1 nor with
 just `jump-threading` (and I tried pretty hard today). So, from those
 results I would say "something in O2 is the problem" which brings me to
 the thought that we might hunt different bugs. :) But on the positive side
 of things I think I have a setup ready now for actual bisecting LLVM which
 I will pick up tomorrow.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32053 [Applications/Tor Browser]: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)

[Tor Bug Tracker & Wiki]

#32053: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM
optimization issue)
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Immediate|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201911, tbb-9.0-must,  |  Actual Points:
  tbb-9.0-issues, tbb-regression,|
  tbb-9.0.1-can, GeorgKoppen201911   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by alexcrichton):

 The bug seems to be in the `-jump-threading` pass which I suspect is
 included in the O1 optimizations, yeah, but this technically only arose
 during O3 when presumably enough inlining had happened to then trigger the
 bug. I'm not really sure what the best way to avoid this bug would be
 unfortunately, but I suspect that an `-O1` build should be reproducible
 (albeit slow).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32053 [Applications/Tor Browser]: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)

[Tor Bug Tracker & Wiki]

#32053: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM
optimization issue)
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Immediate|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201911, tbb-9.0-must,  |  Actual Points:
  tbb-9.0-issues, tbb-regression,|
  tbb-9.0.1-can, GeorgKoppen201911   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:27 alexcrichton]:
 > I just posted a comment on the bug report with a much more minimal test
 case (only a few hundred KB!), it only took many cpu hours to extract :)
 >
 > From here I'm still trying to reduce it further to increase the
 likelihood that someone from LLVM can help fix (I'm not so good at LLVM
 internals). This test case is small enough though that it may be pretty
 reasonable to bisect LLVM itself with. Dealing with a bitcode file across
 that many LLVM revisions may be pretty difficult though, so bisection
 likely won't be trivial.

 Okay, it seems the optimization being the problem here is in -O1, which is
 unfortunate because I had some hope reducing the current -O2 to it could
 be a workaround... I am not sure whether -O0 is worth it. But it might be
 an option if we don't solve the bug until the next planned release.

 I'll set up some bisecting in parallel to your efforts and see whether
 that gets us anywhere. If you get to the problem with `bugpoint` or some
 LLVM dev is helping meanwhile even better. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32053 [Applications/Tor Browser]: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)

[Tor Bug Tracker & Wiki]

#32053: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM
optimization issue)
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Immediate|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201911, tbb-9.0-must,  |  Actual Points:
  tbb-9.0-issues, tbb-regression,|
  tbb-9.0.1-can, GeorgKoppen201911   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by alexcrichton):

 I just posted a comment on the bug report with a much more minimal test
 case (only a few hundred KB!), it only took many cpu hours to extract :)

 From here I'm still trying to reduce it further to increase the likelihood
 that someone from LLVM can help fix (I'm not so good at LLVM internals).
 This test case is small enough though that it may be pretty reasonable to
 bisect LLVM itself with. Dealing with a bitcode file across that many LLVM
 revisions may be pretty difficult though, so bisection likely won't be
 trivial.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32053 [Applications/Tor Browser]: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue)

[Tor Bug Tracker & Wiki]

#32053: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM
optimization issue)
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Immediate|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201911, tbb-9.0-must,  |  Actual Points:
  tbb-9.0-issues, tbb-regression,|
  tbb-9.0.1-can, GeorgKoppen201911   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:24 alexcrichton]:
 > I've opened up https://bugs.llvm.org/show_bug.cgi?id=43909 and will
 track that, I'm attempting to use LLVM's automatic test case reduction
 tools but it's likely going to take quite some time due to how large the
 module is.

 Thanks! Let me know whether/how I can help here. I don't know much about
 `opt` and its options/flags, so there is some learning curve for me but I
 could spend some cycles tomorrow and the coming days given how important
 that bug is for us. Maybe I should just start bisecting figuring out where
 this got introduced. Might help tracking the optimization issue down.
 Either way, let me know.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32053 [Applications/Tor Browser]: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM optimization issue) (was: macOS bundles for Tor Browser 9.0a8 are not reproduci

[Tor Bug Tracker & Wiki]

#32053: Tor Browser bundles based on Firefox 68 ESR are not reproducible (LLVM
optimization issue)
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Immediate|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  TorBrowserTeam201911, tbb-9.0-must,  |  Actual Points:
  tbb-9.0-issues, tbb-regression,|
  tbb-9.0.1-can, GeorgKoppen201911   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Old description:

> For some reasons boklm and I got different macOS bundles when building
> our rc for 9.0a8.

New description:

 For some reasons boklm and I got different macOS bundles when building our
 rc for 9.0a8. Linux bundles are affected, too (seee #32052) and other
 platforms as well.

--

Comment (by gk):

 Closed #32052 as an actual duplicate after inspecting the intermediate
 compilation output of non-matching results.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs