Re: [tor-bugs] #32072 [Applications/Tor Browser]: Fix Field Name For Tor Binary to Match Orbot

[Tor Bug Tracker & Wiki]

#32072: Fix Field Name For Tor Binary to Match Orbot
+--
 Reporter:  sisbell |  Owner:  tbb-team
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff68-esr, TorBrowserTeam201910  |  Actual Points:
Parent ID:  #32069  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by sisbell):

 I think we likely will be just importing the binaries from somewhere. In
 the case of tor-browser-build this would come in from the projects/tor
 dependency. But yes hard-coding in a Java field is not good. I think we
 can pull that version info from file name or some metadata within the
 file.

 Replying to [comment:3 eighthave]:
 > Seems like a good solution would be to do this via the `BuildConfig`
 class.  In ''build.gradle'', its possible to add things to `BuildConfig`,
 then its statically available.  So there could be some `BuildConfig` value
 based on that `getVersionName()`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32072 [Applications/Tor Browser]: Fix Field Name For Tor Binary to Match Orbot

[Tor Bug Tracker & Wiki]

#32072: Fix Field Name For Tor Binary to Match Orbot
+--
 Reporter:  sisbell |  Owner:  tbb-team
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff68-esr, TorBrowserTeam201910  |  Actual Points:
Parent ID:  #32069  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by eighthave):

 Seems like a good solution would be to do this via the `BuildConfig`
 class.  In ''build.gradle'', its possible to add things to `BuildConfig`,
 then its statically available.  So there could be some `BuildConfig` value
 based on that `getVersionName()`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32072 [Applications/Tor Browser]: Fix Field Name For Tor Binary to Match Orbot

[Tor Bug Tracker & Wiki]

#32072: Fix Field Name For Tor Binary to Match Orbot
+--
 Reporter:  sisbell |  Owner:  tbb-team
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff68-esr, TorBrowserTeam201910  |  Actual Points:
Parent ID:  #32069  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by eighthave):

 For tor-android, I did this too: https://github.com/eighthave/tor-
 android/commit/6993fce4be07f1dc8e796bb5a3d74a2e0eae90e4  so the AAR
 package version name is based on the git tag of the included tor.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32072 [Applications/Tor Browser]: Fix Field Name For Tor Binary to Match Orbot

[Tor Bug Tracker & Wiki]

#32072: Fix Field Name For Tor Binary to Match Orbot
-+-
 Reporter:  sisbell  |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  ff68-esr,
 Severity:  Normal   |  TorBrowserTeam201910
Actual Points:   |  Parent ID:  #32069
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 Match up the tor version field names. Note The binary version is currently
 out of date but we can update this as part of syncing the projects.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32072 [Applications/Tor Browser]: Fix Field Name For Tor Binary to Match Orbot

[Tor Bug Tracker & Wiki]

#32072: Fix Field Name For Tor Binary to Match Orbot
+--
 Reporter:  sisbell |  Owner:  tbb-team
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff68-esr, TorBrowserTeam201910  |  Actual Points:
Parent ID:  #32069  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by sisbell):

 https://github.com/sisbell/tor-android-
 service/commit/39d7fc1c0e75a56bddfc1c0cc5902b100244fce8

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs