Re: [tor-bugs] #32501 [Applications/Tor Browser]: Add hasDormantCanceledByStartup to TOPL TorSettings Interface

[Tor Bug Tracker & Wiki]

#32501: Add hasDormantCanceledByStartup to TOPL TorSettings Interface
---+--
 Reporter:  sisbell|  Owner:  tbb-team
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  tbb-mobile, TorBrowserTeam202004R  |  Actual Points:  .25
Parent ID: | Points:  .25
 Reviewer:  sysrqb |Sponsor:
---+--
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Fixed by #33359.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32501 [Applications/Tor Browser]: Add hasDormantCanceledByStartup to TOPL TorSettings Interface

[Tor Bug Tracker & Wiki]

#32501: Add hasDormantCanceledByStartup to TOPL TorSettings Interface
---+---
 Reporter:  sisbell|  Owner:  tbb-team
 Type:  defect | Status:
   |  needs_review
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201912R  |  Actual Points:  .25
Parent ID: | Points:  .25
 Reviewer:  sysrqb |Sponsor:
---+---
Changes (by sisbell):

 * actualpoints:   => .25


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32501 [Applications/Tor Browser]: Add hasDormantCanceledByStartup to TOPL TorSettings Interface

[Tor Bug Tracker & Wiki]

#32501: Add hasDormantCanceledByStartup to TOPL TorSettings Interface
---+---
 Reporter:  sisbell|  Owner:  tbb-team
 Type:  defect | Status:
   |  needs_review
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201912R  |  Actual Points:
Parent ID: | Points:  .25
 Reviewer: |Sponsor:
---+---
Changes (by sisbell):

 * keywords:  tbb-mobile, TorBrowserTeam201911R => tbb-mobile,
 TorBrowserTeam201912R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32501 [Applications/Tor Browser]: Add hasDormantCanceledByStartup to TOPL TorSettings Interface

[Tor Bug Tracker & Wiki]

#32501: Add hasDormantCanceledByStartup to TOPL TorSettings Interface
---+---
 Reporter:  sisbell|  Owner:  tbb-team
 Type:  defect | Status:
   |  needs_review
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201911R  |  Actual Points:
Parent ID: | Points:  .25
 Reviewer: |Sponsor:
---+---
Changes (by sisbell):

 * keywords:  tbb-mobile, TorBrowserTeam201911 => tbb-mobile,
 TorBrowserTeam201911R
 * status:  needs_revision => needs_review


Comment:

 Fixed space issue

 
https://github.com/sisbell/Tor_Onion_Proxy_Library/commit/e653904bab08a2f942bf8519db6ea5ae18e9887d

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32501 [Applications/Tor Browser]: Add hasDormantCanceledByStartup to TOPL TorSettings Interface

[Tor Bug Tracker & Wiki]

#32501: Add hasDormantCanceledByStartup to TOPL TorSettings Interface
--+
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:
  |  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201911  |  Actual Points:
Parent ID:| Points:  .25
 Reviewer:|Sponsor:
--+
Changes (by gk):

 * keywords:  tbb-mobile, TorBrowserTeam201911R => tbb-mobile,
 TorBrowserTeam201911


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32501 [Applications/Tor Browser]: Add hasDormantCanceledByStartup to TOPL TorSettings Interface

[Tor Bug Tracker & Wiki]

#32501: Add hasDormantCanceledByStartup to TOPL TorSettings Interface
---+---
 Reporter:  sisbell|  Owner:  tbb-team
 Type:  defect | Status:
   |  needs_revision
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201911R  |  Actual Points:
Parent ID: | Points:  .25
 Reviewer: |Sponsor:
---+---
Changes (by sysrqb):

 * status:  needs_review => needs_revision


Comment:

 {{{
 +@SettingsConfig
 +public TorConfigBuilder dormantCanceledByStartupFromSettings() {
 +if(settings.hasDormantCanceledByStartup()) {
 }}}
 nit: space

 It seems like this will benefit from #32516, too.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32501 [Applications/Tor Browser]: Add hasDormantCanceledByStartup to TOPL TorSettings Interface

[Tor Bug Tracker & Wiki]

#32501: Add hasDormantCanceledByStartup to TOPL TorSettings Interface
---+---
 Reporter:  sisbell|  Owner:  tbb-team
 Type:  defect | Status:
   |  needs_review
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201911R  |  Actual Points:
Parent ID: | Points:  .25
 Reviewer: |Sponsor:
---+---
Changes (by sisbell):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32501 [Applications/Tor Browser]: Add hasDormantCanceledByStartup to TOPL TorSettings Interface

[Tor Bug Tracker & Wiki]

#32501: Add hasDormantCanceledByStartup to TOPL TorSettings Interface
---+---
 Reporter:  sisbell|  Owner:  tbb-team
 Type:  defect | Status:
   |  needs_revision
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201911R  |  Actual Points:
Parent ID: | Points:  .25
 Reviewer: |Sponsor:
---+---
Changes (by sisbell):

 * keywords:  tbb-mobile, TorBrowserTeam201911 => tbb-mobile,
 TorBrowserTeam201911R
 * status:  new => needs_revision


Comment:

 I added in the implementation for hasDormantCanceledByStartup. The value
 is false by default (but this is overridden to true in tor-android-
 service.

 
https://github.com/sisbell/Tor_Onion_Proxy_Library/commit/2426b26c9f4563bc8459844ac82a9764cc3e46ae

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32501 [Applications/Tor Browser]: Add hasDormantCanceledByStartup to TOPL TorSettings Interface

[Tor Bug Tracker & Wiki]

#32501: Add hasDormantCanceledByStartup to TOPL TorSettings Interface
-+-
 Reporter:  sisbell  |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  tbb-mobile,
 Severity:  Normal   |  TorBrowserTeam201911
Actual Points:   |  Parent ID:
   Points:  .25  |   Reviewer:
  Sponsor:   |
-+-
 hasDormantCanceledByStartup has been added to TorSettings in tor-android-
 service but not in TOPL. This breaks the build.


 The reported issue
 https://github.com/sisbell/tor-android-service/issues/17

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs