Re: [tor-bugs] #32508 [Applications/Tor Browser]: opening about:preferences#privacy from the security toolbar button leads to adding about:preferences#tor items at the end of about:preferences#privacy

[Tor Bug Tracker & Wiki]

#32508: opening about:preferences#privacy from the security toolbar button 
leads to
adding about:preferences#tor items at the end of about:preferences#privacy
--+---
 Reporter:  boklm |  Owner:  pospeselr
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  TorBrowserTeam201911R |  Actual Points:  0.5
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+---
Changes (by gk):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:5 pospeselr]:
 > gk: I speculated in IRC that you might have a startupCache issue:

 Actually, I don't think so see 1) in comment:3.

 [snip]

 > https://people.torproject.org/~richard/builds/bug_32508/tor-browser-
 linux64-tbb-nightly_en-US.tar.xz

 Thanks! I think the mistake I made was just patching `torPane.xul` (that
 is 5) in comment:3 is not enough). It seems when building then
 corresponding changes in `preferences.xul` got made which I overlooked by
 trying to take a shortcut.

 We are good here, thanks! Cherry-picked your patch to `tor-
 browser-68.2.0esr-9.5-1` (commit
 e847b87fda117ebf06459755b5dbd037eb1d349a).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32508 [Applications/Tor Browser]: opening about:preferences#privacy from the security toolbar button leads to adding about:preferences#tor items at the end of about:preferences#privacy

[Tor Bug Tracker & Wiki]

#32508: opening about:preferences#privacy from the security toolbar button 
leads to
adding about:preferences#tor items at the end of about:preferences#privacy
--+---
 Reporter:  boklm |  Owner:  pospeselr
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201911R |  Actual Points:  0.5
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+---
Changes (by pospeselr):

 * owner:  tbb-team => pospeselr
 * status:  needs_review => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32508 [Applications/Tor Browser]: opening about:preferences#privacy from the security toolbar button leads to adding about:preferences#tor items at the end of about:preferences#privacy

[Tor Bug Tracker & Wiki]

#32508: opening about:preferences#privacy from the security toolbar button 
leads to
adding about:preferences#tor items at the end of about:preferences#privacy
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201911R |  Actual Points:  0.5
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+--
Changes (by pospeselr):

 * status:  needs_information => needs_review


Comment:

 gk: I speculated in IRC that you might have a startupCache issue:

 {{{
 (2019-11-18 11:38:44 AM) pospeselr: GeKo: I'm not sure why you're not
 seeing any change after applying the patch (regarding #32508 )
 (2019-11-18 11:38:47 AM) zwiebelbot: (notice) tor#32508: opening
 about:preferences#privacy from the security toolbar button leads to adding
 about:preferences#tor items at the end of about:preferences#privacy -
 [needs_information] - https://bugs.torproject.org/32508
 (2019-11-18 11:39:10 AM) pospeselr: perhaps you need to nuke your
 startcupCache ?
 (2019-11-18 11:39:38 AM) pospeselr: doing a full build, and copying
 $out/dist/firefox/* over /Browser gives the right behavior
 (2019-11-18 11:39:57 AM) pospeselr: I could do a full tor-browser-build to
 verify if you like
 }}}

 I did a nightly tor-browser-build using this patch just to be sure and the
 behaviour is as expected:

 https://people.torproject.org/~richard/builds/bug_32508/tor-browser-
 linux64-tbb-nightly_en-US.tar.xz

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32508 [Applications/Tor Browser]: opening about:preferences#privacy from the security toolbar button leads to adding about:preferences#tor items at the end of about:preferences#privacy

[Tor Bug Tracker & Wiki]

#32508: opening about:preferences#privacy from the security toolbar button 
leads to
adding about:preferences#tor items at the end of about:preferences#privacy
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201911R |  Actual Points:  0.5
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 Hm, so the patch is not working for me. I still see the network settings
 on the security/privacy pane after applying your patch. Here is what I
 did:

 1) Take a clean, new 9.5a2 Linux bundle (64bit) and extract it
 2) Go tor tor-browser_$$/Browser/browser
 3) `unzip -d test omni.ja`
 4) `cd test/chrome/browser/content/browser/torpreferences/`
 5) `patch -p5 < /path/to/your/patch`
 6) `cd ../../../../../`
 7) `rm ../omni.ja`
 8) `zip -r9 ../omni.ja *`
 9) start the so modified bundle for the first time and click on the shield
 icon so the security settings show up

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32508 [Applications/Tor Browser]: opening about:preferences#privacy from the security toolbar button leads to adding about:preferences#tor items at the end of about:preferences#privacy

[Tor Bug Tracker & Wiki]

#32508: opening about:preferences#privacy from the security toolbar button 
leads to
adding about:preferences#tor items at the end of about:preferences#privacy
--+---
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201911R |  Actual Points:  0.5
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+---
Changes (by gk):

 * status:  needs_review => needs_information


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32508 [Applications/Tor Browser]: opening about:preferences#privacy from the security toolbar button leads to adding about:preferences#tor items at the end of about:preferences#privacy

[Tor Bug Tracker & Wiki]

#32508: opening about:preferences#privacy from the security toolbar button 
leads to
adding about:preferences#tor items at the end of about:preferences#privacy
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201911R |  Actual Points:  0.5
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+--
Changes (by pospeselr):

 * keywords:  TorBrowserTeam201911 => TorBrowserTeam201911R
 * status:  new => needs_review
 * actualpoints:   => 0.5


Comment:

 Needed to make all the immediate child elements in the tor preferences xul
 hidden by default. Pushed a fixup commit on the original 31286 patch.

 tor-browser: https://gitweb.torproject.org/user/richard/tor-
 browser.git/commit/?h=bug_32508

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32508 [Applications/Tor Browser]: opening about:preferences#privacy from the security toolbar button leads to adding about:preferences#tor items at the end of about:preferences#privacy

[Tor Bug Tracker & Wiki]

#32508: opening about:preferences#privacy from the security toolbar button 
leads to
adding about:preferences#tor items at the end of about:preferences#privacy
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201911  |  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * cc: pospeselr (added)
 * points:   => 0.5


Comment:

 That's a bug I think.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32508 [Applications/Tor Browser]: opening about:preferences#privacy from the security toolbar button leads to adding about:preferences#tor items at the end of about:preferences#privacy

[Tor Bug Tracker & Wiki]

#32508: opening about:preferences#privacy from the security toolbar button 
leads to
adding about:preferences#tor items at the end of about:preferences#privacy
--+
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
  |  TorBrowserTeam201911
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 Someone reported this on the blog:
 https://blog.torproject.org/comment/285516#comment-285516

 Using the icon on the toolbar to change the security level is showing the
 "Privacy & Security" and "Tor" settings in the same pane, while they are
 in two different ones when opening them through the hamburger menu and
 selecting "Preferences".

 I am not sure if it is a bug, or if it is intentional.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs