Re: [tor-bugs] #32546 [Core Tor/Tor]: hs-v3: Report invalid onion address SOCKS5 extended error code

[Tor Bug Tracker & Wiki]

#32546: hs-v3: Report invalid onion address SOCKS5 extended error code
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  tor-hs|  Actual Points:  0.1
Parent ID:  #30022| Points:  0.1
 Reviewer:  asn   |Sponsor:  Sponsor27-must
--+
Changes (by asn):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Great! Merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32546 [Core Tor/Tor]: hs-v3: Report invalid onion address SOCKS5 extended error code

[Tor Bug Tracker & Wiki]

#32546: hs-v3: Report invalid onion address SOCKS5 extended error code
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs|  Actual Points:  0.1
Parent ID:  #30022| Points:  0.1
 Reviewer:  asn   |Sponsor:  Sponsor27-must
--+
Changes (by dgoulet):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:7 asn]:
 > Hm. I think this description is not right, since we don't return `F6` if
 the onion address has the wrong length (since that's how we realize it's a
 v3 address). Please describe the exact cases under which we return `F6`
 since it might be used as part of the error page in #30022. Also, let's
 mention that it's v3 exclusive.

 Pushed as fixup. Actually, all ExtendedErrors are v3 only so I added a
 note to each code about it.

 >
 > (Also the PR did not update for some reason)

 Here is the fresh PR: https://github.com/torproject/tor/pull/1555

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32546 [Core Tor/Tor]: hs-v3: Report invalid onion address SOCKS5 extended error code

[Tor Bug Tracker & Wiki]

#32546: hs-v3: Report invalid onion address SOCKS5 extended error code
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs|  Actual Points:  0.1
Parent ID:  #30022| Points:  0.1
 Reviewer:  asn   |Sponsor:  Sponsor27-must
--+
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 {{{
 +  X'F6' Onion Service Invalid Address
 +
 +The given .onion address is invalid. Either the checksum
 doesn't
 +match or the length or encoding.
 +
 }}}

 Hm. I think this description is not right, since we don't return `F6` if
 the onion address has the wrong length (since that's how we realize it's a
 v3 address). Please describe the exact cases under which we return `F6`
 since it might be used as part of the error page in #30022. Also, let's
 mention that it's v3 exclusive.

 (Also the PR did not update for some reason)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32546 [Core Tor/Tor]: hs-v3: Report invalid onion address SOCKS5 extended error code

[Tor Bug Tracker & Wiki]

#32546: hs-v3: Report invalid onion address SOCKS5 extended error code
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs|  Actual Points:  0.1
Parent ID:  #30022| Points:  0.1
 Reviewer:  asn   |Sponsor:  Sponsor27-must
--+

Comment (by dgoulet):

 New fixup commit pushed for the manpage. Then an extra commit for the
 #30382 changes file (which includes this change).

 Finally, spec branch to not forget:

 Spec: `ticket32546_01`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32546 [Core Tor/Tor]: hs-v3: Report invalid onion address SOCKS5 extended error code

[Tor Bug Tracker & Wiki]

#32546: hs-v3: Report invalid onion address SOCKS5 extended error code
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs|  Actual Points:  0.1
Parent ID:  #30022| Points:  0.1
 Reviewer:  asn   |Sponsor:  Sponsor27-must
--+
Changes (by dgoulet):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32546 [Core Tor/Tor]: hs-v3: Report invalid onion address SOCKS5 extended error code

[Tor Bug Tracker & Wiki]

#32546: hs-v3: Report invalid onion address SOCKS5 extended error code
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs|  Actual Points:  0.1
Parent ID:  #30022| Points:  0.1
 Reviewer:  asn   |Sponsor:  Sponsor27-must
--+
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Looks good! Missing a changes file, and I just noticed that #30382 was
 also missing a changes file. So if possible please provide for both!

 Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32546 [Core Tor/Tor]: hs-v3: Report invalid onion address SOCKS5 extended error code

[Tor Bug Tracker & Wiki]

#32546: hs-v3: Report invalid onion address SOCKS5 extended error code
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs|  Actual Points:  0.1
Parent ID:  #30022| Points:  0.1
 Reviewer:  asn   |Sponsor:  Sponsor27-must
--+
Changes (by asn):

 * parent:  #14389 => #30022


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32546 [Core Tor/Tor]: hs-v3: Report invalid onion address SOCKS5 extended error code

[Tor Bug Tracker & Wiki]

#32546: hs-v3: Report invalid onion address SOCKS5 extended error code
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs|  Actual Points:  0.1
Parent ID:  #14389| Points:  0.1
 Reviewer:  asn   |Sponsor:  Sponsor27-must
--+
Changes (by dgoulet):

 * parent:  #30022 => #14389


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32546 [Core Tor/Tor]: hs-v3: Report invalid onion address SOCKS5 extended error code

[Tor Bug Tracker & Wiki]

#32546: hs-v3: Report invalid onion address SOCKS5 extended error code
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs|  Actual Points:  0.1
Parent ID:  #30022| Points:  0.1
 Reviewer:  asn   |Sponsor:  Sponsor27-must
--+
Changes (by dgoulet):

 * status:  assigned => needs_review


Comment:

 Branch: `ticket32546_043_01`
 PR: ​https://github.com/torproject/tor/pull/1551

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32546 [Core Tor/Tor]: hs-v3: Report invalid onion address SOCKS5 extended error code

[Tor Bug Tracker & Wiki]

#32546: hs-v3: Report invalid onion address SOCKS5 extended error code
+
 Reporter:  dgoulet |  Owner:  dgoulet
 Type:  defect  | Status:  assigned
 Priority:  Medium  |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  |   Keywords:  tor-hs
Actual Points:  0.1 |  Parent ID:  #30022
   Points:  0.1 |   Reviewer:  asn
  Sponsor:  Sponsor27-must  |
+
 From prop304, continuing on after #30382, add a new error code to indicate
 invalid address.

 This is the little-t tor side of #30022.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs