Re: [tor-bugs] #32614 [Core Tor/Tor]: hs-v3: Consider flagging an intro point as bad if rendezvous fails multiple times

[Tor Bug Tracker & Wiki]

#32614: hs-v3: Consider flagging an intro point as bad if rendezvous fails 
multiple
times
-+
 Reporter:  dgoulet  |  Owner:  neel
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-circuit, tor-hs  |  Actual Points:
Parent ID:   | Points:  0.2
 Reviewer:  dgoulet  |Sponsor:  Sponsor27-can
-+
Changes (by asn):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32614 [Core Tor/Tor]: hs-v3: Consider flagging an intro point as bad if rendezvous fails multiple times

[Tor Bug Tracker & Wiki]

#32614: hs-v3: Consider flagging an intro point as bad if rendezvous fails 
multiple
times
-+
 Reporter:  dgoulet  |  Owner:  neel
 Type:  defect   | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-circuit, tor-hs  |  Actual Points:
Parent ID:   | Points:  0.2
 Reviewer:  dgoulet  |Sponsor:  Sponsor27-can
-+

Comment (by neel):

 Also, I did not see your comment

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32614 [Core Tor/Tor]: hs-v3: Consider flagging an intro point as bad if rendezvous fails multiple times

[Tor Bug Tracker & Wiki]

#32614: hs-v3: Consider flagging an intro point as bad if rendezvous fails 
multiple
times
-+
 Reporter:  dgoulet  |  Owner:  neel
 Type:  defect   | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-circuit, tor-hs  |  Actual Points:
Parent ID:   | Points:  0.2
 Reviewer:  dgoulet  |Sponsor:  Sponsor27-can
-+

Comment (by neel):

 Sorry for the delay.

 I have extended the ticket changes writeup in a fixup commit.

 I do not have tests, I don't know of any test that calls
 `hs_client_circuit_cleanup_on_free()`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32614 [Core Tor/Tor]: hs-v3: Consider flagging an intro point as bad if rendezvous fails multiple times

[Tor Bug Tracker & Wiki]

#32614: hs-v3: Consider flagging an intro point as bad if rendezvous fails 
multiple
times
-+
 Reporter:  dgoulet  |  Owner:  neel
 Type:  defect   | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-circuit, tor-hs  |  Actual Points:
Parent ID:   | Points:  0.2
 Reviewer:  dgoulet  |Sponsor:  Sponsor27-can
-+
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Hmm chceked the PR and made a small comment.

 I'm generally concerned here about the lack of unittests.

 Also I'd appreciate a torspec branch (or a thorough post on this ticket)
 that analyzes the effects of this new behavior. For example, what is the
 old behavior vs the new behavior in the following two scenarios:
 - Intro node is broken and does not forward rend requests.
 - Service is overloaded and cannot handle rendezvous.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32614 [Core Tor/Tor]: hs-v3: Consider flagging an intro point as bad if rendezvous fails multiple times

[Tor Bug Tracker & Wiki]

#32614: hs-v3: Consider flagging an intro point as bad if rendezvous fails 
multiple
times
-+
 Reporter:  dgoulet  |  Owner:  neel
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-circuit, tor-hs  |  Actual Points:
Parent ID:   | Points:  0.2
 Reviewer:  dgoulet  |Sponsor:  Sponsor27-can
-+
Changes (by teor):

 * status:  needs_revision => needs_review
 * milestone:  Tor: unspecified => Tor: 0.4.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32614 [Core Tor/Tor]: hs-v3: Consider flagging an intro point as bad if rendezvous fails multiple times

[Tor Bug Tracker & Wiki]

#32614: hs-v3: Consider flagging an intro point as bad if rendezvous fails 
multiple
times
-+--
 Reporter:  dgoulet  |  Owner:  neel
 Type:  defect   | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-circuit, tor-hs  |  Actual Points:
Parent ID:   | Points:  0.2
 Reviewer:  dgoulet  |Sponsor:  Sponsor27-can
-+--

Comment (by neel):

 New simplified PR: https://github.com/torproject/tor/pull/1682

 No tests, however.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32614 [Core Tor/Tor]: hs-v3: Consider flagging an intro point as bad if rendezvous fails multiple times

[Tor Bug Tracker & Wiki]

#32614: hs-v3: Consider flagging an intro point as bad if rendezvous fails 
multiple
times
-+--
 Reporter:  dgoulet  |  Owner:  neel
 Type:  defect   | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-circuit, tor-hs  |  Actual Points:
Parent ID:   | Points:  0.2
 Reviewer:  dgoulet  |Sponsor:  Sponsor27-can
-+--
Changes (by dgoulet):

 * status:  needs_review => needs_revision
 * keywords:  tor-circuit, tor-hs, 043-can => tor-circuit, tor-hs
 * milestone:  Tor: 0.4.3.x-final => Tor: unspecified


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32614 [Core Tor/Tor]: hs-v3: Consider flagging an intro point as bad if rendezvous fails multiple times

[Tor Bug Tracker & Wiki]

#32614: hs-v3: Consider flagging an intro point as bad if rendezvous fails 
multiple
times
-+
 Reporter:  dgoulet  |  Owner:  neel
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-circuit, tor-hs  |  Actual Points:
Parent ID:   | Points:  0.2
 Reviewer:  dgoulet  |Sponsor:  Sponsor27-can
-+

Comment (by neel):

 Old PR has merge conflicts. New PR:
 https://github.com/torproject/tor/pull/1653

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32614 [Core Tor/Tor]: hs-v3: Consider flagging an intro point as bad if rendezvous fails multiple times

[Tor Bug Tracker & Wiki]

#32614: hs-v3: Consider flagging an intro point as bad if rendezvous fails 
multiple
times
-+
 Reporter:  dgoulet  |  Owner:  neel
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-circuit, tor-hs  |  Actual Points:
Parent ID:   | Points:  0.2
 Reviewer:  dgoulet  |Sponsor:  Sponsor27-can
-+
Changes (by neel):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32614 [Core Tor/Tor]: hs-v3: Consider flagging an intro point as bad if rendezvous fails multiple times

[Tor Bug Tracker & Wiki]

#32614: hs-v3: Consider flagging an intro point as bad if rendezvous fails 
multiple
times
-+
 Reporter:  dgoulet  |  Owner:  neel
 Type:  defect   | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-circuit, tor-hs  |  Actual Points:
Parent ID:   | Points:  0.2
 Reviewer:  dgoulet  |Sponsor:  Sponsor27-can
-+
Changes (by neel):

 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32614 [Core Tor/Tor]: hs-v3: Consider flagging an intro point as bad if rendezvous fails multiple times

[Tor Bug Tracker & Wiki]

#32614: hs-v3: Consider flagging an intro point as bad if rendezvous fails 
multiple
times
-+
 Reporter:  dgoulet  |  Owner:  neel
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-circuit, tor-hs  |  Actual Points:
Parent ID:   | Points:  0.2
 Reviewer:  dgoulet  |Sponsor:  Sponsor27-can
-+
Changes (by neel):

 * status:  needs_revision => needs_review


Comment:

 Made the changes. Setting as needs review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32614 [Core Tor/Tor]: hs-v3: Consider flagging an intro point as bad if rendezvous fails multiple times

[Tor Bug Tracker & Wiki]

#32614: hs-v3: Consider flagging an intro point as bad if rendezvous fails 
multiple
times
-+
 Reporter:  dgoulet  |  Owner:  neel
 Type:  defect   | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-circuit, tor-hs  |  Actual Points:
Parent ID:   | Points:  0.2
 Reviewer:  dgoulet  |Sponsor:  Sponsor27-can
-+
Changes (by dgoulet):

 * status:  needs_review => needs_revision
 * reviewer:   => dgoulet


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32614 [Core Tor/Tor]: hs-v3: Consider flagging an intro point as bad if rendezvous fails multiple times

[Tor Bug Tracker & Wiki]

#32614: hs-v3: Consider flagging an intro point as bad if rendezvous fails 
multiple
times
-+
 Reporter:  dgoulet  |  Owner:  neel
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-circuit, tor-hs  |  Actual Points:
Parent ID:   | Points:  0.2
 Reviewer:   |Sponsor:  Sponsor27-can
-+
Changes (by neel):

 * status:  needs_revision => needs_review


Comment:

 Made the change. Setting as needs review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32614 [Core Tor/Tor]: hs-v3: Consider flagging an intro point as bad if rendezvous fails multiple times

[Tor Bug Tracker & Wiki]

#32614: hs-v3: Consider flagging an intro point as bad if rendezvous fails 
multiple
times
-+
 Reporter:  dgoulet  |  Owner:  neel
 Type:  defect   | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-circuit, tor-hs  |  Actual Points:
Parent ID:   | Points:  0.2
 Reviewer:   |Sponsor:  Sponsor27-can
-+
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 The changes file for #32020 does not mention failing rendezvous points, so
 we need another changelog entry for this ticket:
 https://github.com/torproject/tor/blob/master/changes/ticket32020

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32614 [Core Tor/Tor]: hs-v3: Consider flagging an intro point as bad if rendezvous fails multiple times

[Tor Bug Tracker & Wiki]

#32614: hs-v3: Consider flagging an intro point as bad if rendezvous fails 
multiple
times
-+
 Reporter:  dgoulet  |  Owner:  neel
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-circuit, tor-hs  |  Actual Points:
Parent ID:   | Points:  0.2
 Reviewer:   |Sponsor:  Sponsor27-can
-+

Comment (by neel):

 I don't believe so, as this feature was introduced in the commits
 `7f83c43594dcf13fb04352f5faa8db2cd86354c1` and
 `cbc495453cb522db1584525a06d26386f5819e05`, and aren't introduced in a
 released version yet (from the information I got on GitHub).

 Sources:

  *
 
https://github.com/torproject/tor/commit/cbc495453cb522db1584525a06d26386f5819e05

  *
 
https://github.com/torproject/tor/commit/7f83c43594dcf13fb04352f5faa8db2cd86354c1

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32614 [Core Tor/Tor]: hs-v3: Consider flagging an intro point as bad if rendezvous fails multiple times

[Tor Bug Tracker & Wiki]

#32614: hs-v3: Consider flagging an intro point as bad if rendezvous fails 
multiple
times
-+
 Reporter:  dgoulet  |  Owner:  neel
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-circuit, tor-hs  |  Actual Points:
Parent ID:   | Points:  0.2
 Reviewer:   |Sponsor:  Sponsor27-can
-+
Changes (by teor):

 * milestone:  Tor: unspecified => Tor: 0.4.3.x-final


Comment:

 I think this PR needs a changes file?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32614 [Core Tor/Tor]: hs-v3: Consider flagging an intro point as bad if rendezvous fails multiple times

[Tor Bug Tracker & Wiki]

#32614: hs-v3: Consider flagging an intro point as bad if rendezvous fails 
multiple
times
-+--
 Reporter:  dgoulet  |  Owner:  neel
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-circuit, tor-hs  |  Actual Points:
Parent ID:   | Points:  0.2
 Reviewer:   |Sponsor:  Sponsor27-can
-+--
Changes (by neel):

 * status:  assigned => needs_review


Comment:

 PR: https://github.com/torproject/tor/pull/1601

 I just handle `CIRCUIT_PURPOSE_C_REND_READY_INTRO_ACKED` on cleanup in
 here. Is that okay, or is there more I need to do?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32614 [Core Tor/Tor]: hs-v3: Consider flagging an intro point as bad if rendezvous fails multiple times

[Tor Bug Tracker & Wiki]

#32614: hs-v3: Consider flagging an intro point as bad if rendezvous fails 
multiple
times
-+--
 Reporter:  dgoulet  |  Owner:  neel
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-circuit, tor-hs  |  Actual Points:
Parent ID:   | Points:  0.2
 Reviewer:   |Sponsor:  Sponsor27-can
-+--
Changes (by neel):

 * keywords:  tor-circuit, -tor-hs => tor-circuit, tor-hs


Comment:

 Fix keywords.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32614 [Core Tor/Tor]: hs-v3: Consider flagging an intro point as bad if rendezvous fails multiple times

[Tor Bug Tracker & Wiki]

#32614: hs-v3: Consider flagging an intro point as bad if rendezvous fails 
multiple
times
--+--
 Reporter:  dgoulet   |  Owner:  neel
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-circuit, -tor-hs  |  Actual Points:
Parent ID:| Points:  0.2
 Reviewer:|Sponsor:  Sponsor27-can
--+--
Changes (by neel):

 * status:  new => assigned
 * cc: neel (added)
 * owner:  (none) => neel


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32614 [Core Tor/Tor]: hs-v3: Consider flagging an intro point as bad if rendezvous fails multiple times

[Tor Bug Tracker & Wiki]

#32614: hs-v3: Consider flagging an intro point as bad if rendezvous fails 
multiple
times
---+--
 Reporter:  dgoulet|  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor   |Version:
 Severity:  Normal |   Keywords:  tor-circuit, -tor-hs
Actual Points: |  Parent ID:
   Points:  0.2|   Reviewer:
  Sponsor:  Sponsor27-can  |
---+--
 This comes from #25882.

 Should a client claim that an IP is failing if the RP never connected? In
 other words, handling the `CIRCUIT_PURPOSE_C_REND_READY_INTRO_ACKED`
 purpose when cleaning up a circuit.

 I would think that having a maximum amount of retries let say
 (arbitrarily) after 2 times that you introduce, the IP sends back the ACK
 but then you end up timing out the RP circuit, we would flag the IP in the
 failure cache and move on to a new IP.

 This would not be a "catch all" issues with connectivity but would at
 least zone out buggy or malicious IP that do not relay the introduction.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs