Re: [tor-bugs] #32791 [Core Tor/Tor]: Check all of Tor's python scripts run under python 3

[Tor Bug Tracker & Wiki]

#32791: Check all of Tor's python scripts run under python 3
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  task  | Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  043-should, tor-python-3  |  Actual Points:  0.1
Parent ID:| Points:  1
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 merged it; thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32791 [Core Tor/Tor]: Check all of Tor's python scripts run under python 3

[Tor Bug Tracker & Wiki]

#32791: Check all of Tor's python scripts run under python 3
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  task  | Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  043-should, tor-python-3  |  Actual Points:  0.1
Parent ID:| Points:  1
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  needs_revision => merge_ready


Comment:

 Let's merge this PR:
 https://github.com/torproject/tor/pull/1703

 It's a very simple change, which looks good to me.

 We can also run flake8 again, if we want.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32791 [Core Tor/Tor]: Check all of Tor's python scripts run under python 3

[Tor Bug Tracker & Wiki]

#32791: Check all of Tor's python scripts run under python 3
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  task  | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  043-should, tor-python-3  |  Actual Points:  0.1
Parent ID:| Points:  1
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  new => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32791 [Core Tor/Tor]: Check all of Tor's python scripts run under python 3

[Tor Bug Tracker & Wiki]

#32791: Check all of Tor's python scripts run under python 3
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  043-should, tor-python-3  |  Actual Points:  0.1
Parent ID:| Points:  1
 Reviewer:|Sponsor:
--+
Changes (by dgoulet):

 * status:  needs_review => new


Comment:

 I've merged PR 1687, lgtm.

 However I ran `flake8` and I still get issues. The
 `./scripts/codegen/makedesc.py` script is failing with python 3 starting
 with:

 {{{
 Traceback (most recent call last):
   File "./scripts/codegen/makedesc.py", line 27, in 
 import UserDict
 ModuleNotFoundError: No module named 'UserDict'
 }}}

 Obviously more things to do. Putting this one back to `New`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32791 [Core Tor/Tor]: Check all of Tor's python scripts run under python 3

[Tor Bug Tracker & Wiki]

#32791: Check all of Tor's python scripts run under python 3
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  043-should, tor-python-3  |  Actual Points:  0.1
Parent ID:| Points:  1
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  new => needs_review
 * actualpoints:   => 0.1


Comment:

 Here's a partial fix PR from a new contributor:
 * master: https://github.com/torproject/tor/pull/1687

 We should review and merge this fix, and then do more testing, to make
 sure we haven't missed anything.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32791 [Core Tor/Tor]: Check all of Tor's python scripts run under python 3

[Tor Bug Tracker & Wiki]

#32791: Check all of Tor's python scripts run under python 3
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  043-should, tor-python-3  |  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * keywords:  043-can, tor-python-3 => 043-should, tor-python-3


Comment:

 This PR generates a list of python 3 print function errors:
 https://github.com/torproject/tor/pull/1686

 Now that we have a list of errors, we should fix them in 0.4.3.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32791 [Core Tor/Tor]: Check all of Tor's python scripts run under python 3

[Tor Bug Tracker & Wiki]

#32791: Check all of Tor's python scripts run under python 3
--+---
 Reporter:  teor  |  Owner:  (none)
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  043-can, tor-python-3
Actual Points:|  Parent ID:
   Points:  1 |   Reviewer:
  Sponsor:|
--+---
 We've added `__future__` statements to all our scripts, and done some
 testing, but we should check the output of all our python scripts.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs