Re: [tor-bugs] #32928 [Core Tor/Tor]: Tor Manual: Split Circuit Timeout options into their own subsection

2020-02-10 Thread Tor Bug Tracker & Wiki
#32928: Tor Manual: Split Circuit Timeout options into their own subsection
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  implemented
  easy 043-can extra-review  |  Actual Points:
Parent ID:  #4310| Points:  0.5
 Reviewer:  catalyst, nickm  |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32928 [Core Tor/Tor]: Tor Manual: Split Circuit Timeout options into their own subsection

2020-02-07 Thread Tor Bug Tracker & Wiki
#32928: Tor Manual: Split Circuit Timeout options into their own subsection
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  task | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can extra-review  |
Parent ID:  #4310| Points:  0.5
 Reviewer:  catalyst, nickm  |Sponsor:
-+-
Changes (by catalyst):

 * status:  needs_review => merge_ready


Comment:

 Note to merger: please merge https://github.com/torproject/tor/pull/1711
 instead; it adds a changes file.  Thanks!

 Swati, I think that should auto-close your pull request if it's merged
 without additional changes or rebasing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32928 [Core Tor/Tor]: Tor Manual: Split Circuit Timeout options into their own subsection

2020-02-07 Thread Tor Bug Tracker & Wiki
#32928: Tor Manual: Split Circuit Timeout options into their own subsection
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can extra-review  |
Parent ID:  #4310| Points:  0.5
 Reviewer:  catalyst, nickm  |Sponsor:
-+-

Comment (by catalyst):

 Replying to [comment:16 swati]:
 > Reworded your suggestion a bit and updated the introductory text in both
 the sections.
 Thanks!  It looks good.  There needs to be a changes file, but I can write
 one and push it to your branch if that's ok.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32928 [Core Tor/Tor]: Tor Manual: Split Circuit Timeout options into their own subsection

2020-02-07 Thread Tor Bug Tracker & Wiki
#32928: Tor Manual: Split Circuit Timeout options into their own subsection
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can extra-review  |
Parent ID:  #4310| Points:  0.5
 Reviewer:  catalyst, nickm  |Sponsor:
-+-

Comment (by swati):

 Replying to [comment:15 catalyst]:
 >
 > Thanks for the changes!
 >
 > >  - I added a new section called **Dormant Mode Options** and moved the
 four options under this section. Does anyone want to suggest a better
 introductory sentence for this section?
 >
 > Dormant mode is a state that tor can enter and leave, and the options in
 this section modify that behavior.  Maybe this?
 >
 > "Tor can enter a dormant mode to conserve power and network bandwidth.
 The following options control when tor enters and leaves dormant mode."
 >
 > >  - Also, I renamed the Timeout Options section to **Circuit Timeout
 Options**, as suggested by catalyst. I haven't moved the other options
 that aren't directly related to timeout under this section. Leaving them
 where they are for now. Is that okay?
 >
 > I think that's fine.  I couldn't come up with a concise heading for an
 expanded section that would contain the other options you were
 considering.  I would suggest rewording the introductory paragraph to
 something like this?
 >
 > "The following options are useful for configuring timeouts related to
 building Tor circuits and using them."
 >
 > >  - Can we consider this ticket resolved? If yes, can we merge the PR
 so that I can continue working on the rest of the manual?
 >
 > I think we're mostly there.  There are a couple of minor wording changes
 I suggested above for the introductory text of the new sections.  If you
 agree, please go ahead and make those changes.

 Reworded your suggestion a bit and updated the introductory text in both
 the sections.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32928 [Core Tor/Tor]: Tor Manual: Split Circuit Timeout options into their own subsection

2020-02-06 Thread Tor Bug Tracker & Wiki
#32928: Tor Manual: Split Circuit Timeout options into their own subsection
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can extra-review  |
Parent ID:  #4310| Points:  0.5
 Reviewer:  catalyst, nickm  |Sponsor:
-+-

Comment (by catalyst):

 Replying to [comment:13 swati]:

 Thanks for the changes!

 >  - I added a new section called **Dormant Mode Options** and moved the
 four options under this section. Does anyone want to suggest a better
 introductory sentence for this section?

 Dormant mode is a state that tor can enter and leave, and the options in
 this section modify that behavior.  Maybe this?

 "Tor can enter a dormant mode to conserve power and network bandwidth.
 The following options control when tor enters and leaves dormant mode."

 >  - Also, I renamed the Timeout Options section to **Circuit Timeout
 Options**, as suggested by catalyst. I haven't moved the other options
 that aren't directly related to timeout under this section. Leaving them
 where they are for now. Is that okay?

 I think that's fine.  I couldn't come up with a concise heading for an
 expanded section that would contain the other options you were
 considering.  I would suggest rewording the introductory paragraph to
 something like this?

 "The following options are useful for configuring timeouts related to
 building Tor circuits and using them."

 >  - Can we consider this ticket resolved? If yes, can we merge the PR so
 that I can continue working on the rest of the manual?

 I think we're mostly there.  There are a couple of minor wording changes I
 suggested above for the introductory text of the new sections.  If you
 agree, please go ahead and make those changes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32928 [Core Tor/Tor]: Tor Manual: Split Circuit Timeout options into their own subsection

2020-02-06 Thread Tor Bug Tracker & Wiki
#32928: Tor Manual: Split Circuit Timeout options into their own subsection
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can extra-review  |
Parent ID:  #4310| Points:  0.5
 Reviewer:  catalyst, nickm  |Sponsor:
-+-

Comment (by nickm):

 This looks good to me; I say we should merge if catalyst is okay with it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32928 [Core Tor/Tor]: Tor Manual: Split Circuit Timeout options into their own subsection

2020-02-06 Thread Tor Bug Tracker & Wiki
#32928: Tor Manual: Split Circuit Timeout options into their own subsection
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can extra-review  |
Parent ID:  #4310| Points:  0.5
 Reviewer:  catalyst, nickm  |Sponsor:
-+-

Comment (by swati):

 Hey nickm and catalyst,

  - I added a new section called **Dormant Mode Options** and moved the
 four options under this section.
  - Also, I renamed the Timeout Options section to **Circuit Timeout
 Options**, as suggested by catalyst. I haven't moved the other options
 that aren't directly related to timeout under this section. Leaving them
 where they are for now. Is that okay?
  - Can we consider this ticket resolved? If yes, can we merge the PR so
 that I can continue working on the rest of the manual?

 Thank you,
 Swati

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32928 [Core Tor/Tor]: Tor Manual: Split Circuit Timeout options into their own subsection

2020-02-05 Thread Tor Bug Tracker & Wiki
#32928: Tor Manual: Split Circuit Timeout options into their own subsection
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can extra-review  |
Parent ID:  #4310| Points:  0.5
 Reviewer:  catalyst, nickm  |Sponsor:
-+-

Comment (by nickm):

 Replying to [comment:10 swati]:
 > Replying to [comment:8 catalyst]:
 > > Replying to [comment:6 swati]:
 > > > Thanks, Taylor. Regarding your comment about renaming the section to
 'Circuit Timeout Options', I see that I have added DormantClientTimeout
 and DormantTimeoutDisabledByIdleStreams options to this section. Are these
 two circuit options as well?
 > >
 > > I see. I think you're right there. They're client options that aren't
 directly related to circuit timeouts. They might belong in a separate
 section about Dormant mode?
 > >
 > Currently, there are only four Dormant mode options in the manual -
 DormantCanceledByStartup, DormantOnFirstStartup, DormantClientTimeout and
 DormantTimeoutDisabledByIdleStreams. Do you think we can have a separate
 section for dormant mode with just these four options? If yes, I'll put
 them out from here and create a new section.

 I think that's a fine idea.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32928 [Core Tor/Tor]: Tor Manual: Split Circuit Timeout options into their own subsection

2020-02-05 Thread Tor Bug Tracker & Wiki
#32928: Tor Manual: Split Circuit Timeout options into their own subsection
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can extra-review  |
Parent ID:  #4310| Points:  0.5
 Reviewer:  catalyst, nickm  |Sponsor:
-+-

Comment (by nickm):

 Replying to [comment:8 catalyst]:
 > Replying to [comment:6 swati]:
 > > Thanks, Taylor. Regarding your comment about renaming the section to
 'Circuit Timeout Options', I see that I have added DormantClientTimeout
 and DormantTimeoutDisabledByIdleStreams options to this section. Are these
 two circuit options as well?
 >
 > I see. I think you're right there. They're client options that aren't
 directly related to circuit timeouts. They might belong in a separate
 section about Dormant mode?

 [...]

 For what it's worth, I agree with catalyst in their assessment of the
 options discussed in the comment above.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32928 [Core Tor/Tor]: Tor Manual: Split Circuit Timeout options into their own subsection

2020-02-04 Thread Tor Bug Tracker & Wiki
#32928: Tor Manual: Split Circuit Timeout options into their own subsection
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can extra-review  |
Parent ID:  #4310| Points:  0.5
 Reviewer:  catalyst, nickm  |Sponsor:
-+-

Comment (by swati):

 Replying to [comment:8 catalyst]:
 Currently, there are only four Dormant mode options in the manual -
 DormantCanceledByStartup, DormantOnFirstStartup, DormantClientTimeout and
 DormantTimeoutDisabledByIdleStreams. Do you think we can have a separate
 section for dormant mode with just these four options? If yes, I'll put
 them out from here and create a new section.

 > Replying to [comment:6 swati]:
 > > Thanks, Taylor. Regarding your comment about renaming the section to
 'Circuit Timeout Options', I see that I have added DormantClientTimeout
 and DormantTimeoutDisabledByIdleStreams options to this section. Are these
 two circuit options as well?
 >
 > I see. I think you're right there. They're client options that aren't
 directly related to circuit timeouts. They might belong in a separate
 section about Dormant mode?
 >
 > > Also, should I add the following circuit options to this section:?
 >
 > Unfortunately, I think these are a little bit tricky to classify. Maybe
 we want to expand the section heading to include client circuit behavior
 overall? (The Nodes options have to do with the details of building a
 circuit, while many of these operations are at a higher level of
 abstraction that ignores individual nodes in a circuit.)
 >
 > > MaxCircuitDirtiness
 >
 > I think this is not directly timing related? This is related to reusing
 a circuit for multiple application streams. I think there is a tradeoff
 between circuit reuse (for efficiency and decreased latency) and traffic
 analysis risk.
 >
 > > MaxClientCircuitsPending
 >
 > I'm not quite sure how this one interacts with timing.
 >
 > > CircuitPadding
 > > ReducedCircuitPadding
 >
 > I think these aren't directly timing-related. These options are related
 to a countermeasure that we use against traffic analysis. There is a
 tradeoff because the countermeasure can increase bandwidth consumption. (I
 guess in situations of highly constrained bandwidth it could decrease
 performance in a user-visible way.)
 >
 > > NewCircuitPeriod
 > > PathsNeededToBuildCircuits
 >
 > These help tor decide when to build new circuits.
 PathsNeededToBuildCircuits is a bit more strongly related to the
 bootstrapping process than the other options here, so I'm not quite sure
 whether it belongs with the others.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32928 [Core Tor/Tor]: Tor Manual: Split Circuit Timeout options into their own subsection

2020-02-04 Thread Tor Bug Tracker & Wiki
#32928: Tor Manual: Split Circuit Timeout options into their own subsection
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can extra-review  |
Parent ID:  #4310| Points:  0.5
 Reviewer:  catalyst, nickm  |Sponsor:
-+-
Changes (by catalyst):

 * reviewer:  catalyst => catalyst, nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32928 [Core Tor/Tor]: Tor Manual: Split Circuit Timeout options into their own subsection

2020-02-04 Thread Tor Bug Tracker & Wiki
#32928: Tor Manual: Split Circuit Timeout options into their own subsection
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can extra-review  |
Parent ID:  #4310| Points:  0.5
 Reviewer:  catalyst |Sponsor:
-+-

Comment (by catalyst):

 Replying to [comment:6 swati]:
 > Thanks, Taylor. Regarding your comment about renaming the section to
 'Circuit Timeout Options', I see that I have added DormantClientTimeout
 and DormantTimeoutDisabledByIdleStreams options to this section. Are these
 two circuit options as well?

 I see. I think you're right there. They're client options that aren't
 directly related to circuit timeouts. They might belong in a separate
 section about Dormant mode?

 > Also, should I add the following circuit options to this section:?

 Unfortunately, I think these are a little bit tricky to classify. Maybe we
 want to expand the section heading to include client circuit behavior
 overall? (The Nodes options have to do with the details of building a
 circuit, while many of these operations are at a higher level of
 abstraction that ignores individual nodes in a circuit.)

 > MaxCircuitDirtiness

 I think this is not directly timing related? This is related to reusing a
 circuit for multiple application streams. I think there is a tradeoff
 between circuit reuse (for efficiency and decreased latency) and traffic
 analysis risk.

 > MaxClientCircuitsPending

 I'm not quite sure how this one interacts with timing.

 > CircuitPadding
 > ReducedCircuitPadding

 I think these aren't directly timing-related. These options are related to
 a countermeasure that we use against traffic analysis. There is a tradeoff
 because the countermeasure can increase bandwidth consumption. (I guess in
 situations of highly constrained bandwidth it could decrease performance
 in a user-visible way.)

 > NewCircuitPeriod
 > PathsNeededToBuildCircuits

 These help tor decide when to build new circuits.
 PathsNeededToBuildCircuits is a bit more strongly related to the
 bootstrapping process than the other options here, so I'm not quite sure
 whether it belongs with the others.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32928 [Core Tor/Tor]: Tor Manual: Split Circuit Timeout options into their own subsection

2020-02-04 Thread Tor Bug Tracker & Wiki
#32928: Tor Manual: Split Circuit Timeout options into their own subsection
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can extra-review  |
Parent ID:  #4310| Points:  0.5
 Reviewer:  catalyst |Sponsor:
-+-

Comment (by swati):

 Taylor, Could you please add any other reviewers?

 Replying to [comment:5 teor]:
 > Hi, I'm busy with Sponsor 55 right now, can you find someone else to
 review?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32928 [Core Tor/Tor]: Tor Manual: Split Circuit Timeout options into their own subsection

2020-02-04 Thread Tor Bug Tracker & Wiki
#32928: Tor Manual: Split Circuit Timeout options into their own subsection
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can extra-review  |
Parent ID:  #4310| Points:  0.5
 Reviewer:  catalyst |Sponsor:
-+-

Comment (by swati):

 Thanks, Taylor. Regarding your comment about renaming the section to
 'Circuit Timeout Options', I see that I have added DormantClientTimeout
 and DormantTimeoutDisabledByIdleStreams options to this section. Are these
 two circuit options as well?

 Also, should I add the following circuit options to this section:?

 MaxCircuitDirtiness
 MaxClientCircuitsPending
 CircuitPadding
 ReducedCircuitPadding
 NewCircuitPeriod
 PathsNeededToBuildCircuits

 Replying to [comment:4 catalyst]:
 > Thanks!
 >
 > It mostly looks good.  I think it's better to have a title like "Circuit
 timeout options".  (I think we don't currently have any timeout options
 other than circuit timeout options, but we might in the future.)
 >
 > I'll try to comment more after the weekend.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32928 [Core Tor/Tor]: Tor Manual: Split Circuit Timeout options into their own subsection

2020-02-02 Thread Tor Bug Tracker & Wiki
#32928: Tor Manual: Split Circuit Timeout options into their own subsection
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can extra-review  |
Parent ID:  #4310| Points:  0.5
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by teor):

 * reviewer:  teor, catalyst => catalyst


Comment:

 Hi, I'm busy with Sponsor 55 right now, can you find someone else to
 review?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32928 [Core Tor/Tor]: Tor Manual: Split Circuit Timeout options into their own subsection

2020-01-31 Thread Tor Bug Tracker & Wiki
#32928: Tor Manual: Split Circuit Timeout options into their own subsection
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can extra-review  |
Parent ID:  #4310| Points:  0.5
 Reviewer:  teor, catalyst   |Sponsor:
-+-
Changes (by catalyst):

 * keywords:  documentation tor-client manpage easy 043-can => documentation
 tor-client manpage easy 043-can extra-review


Comment:

 Thanks!

 It mostly looks good.  I think it's better to have a title like "Circuit
 timeout options".  (I think we don't currently have any timeout options
 other than circuit timeout options, but we might in the future.)

 I'll try to comment more after the weekend.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32928 [Core Tor/Tor]: Tor Manual: Split Circuit Timeout options into their own subsection

2020-01-31 Thread Tor Bug Tracker & Wiki
#32928: Tor Manual: Split Circuit Timeout options into their own subsection
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can   |
Parent ID:  #4310| Points:  0.5
 Reviewer:  teor, catalyst   |Sponsor:
-+-
Changes (by swati):

 * reviewer:   => teor, catalyst


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32928 [Core Tor/Tor]: Tor Manual: Split Circuit Timeout options into their own subsection

2020-01-31 Thread Tor Bug Tracker & Wiki
#32928: Tor Manual: Split Circuit Timeout options into their own subsection
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can   |
Parent ID:  #4310| Points:  0.5
 Reviewer:   |Sponsor:
-+-
Changes (by swati):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32928 [Core Tor/Tor]: Tor Manual: Split Circuit Timeout options into their own subsection

2020-01-31 Thread Tor Bug Tracker & Wiki
#32928: Tor Manual: Split Circuit Timeout options into their own subsection
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can   |
Parent ID:  #4310| Points:  0.5
 Reviewer:   |Sponsor:
-+-

Comment (by swati):

 Added a new section called Timeout Options. See PR -
 https://github.com/torproject/tor/pull/1702
 Currently, there are 7 options in this section.

 Some questions:

  - Is the **Timeout Options** an appropriate title for this category?

  - Do the following options also belong to the Timeout Options category?
 MaxCircuitDirtiness
 MaxClientCircuitsPending
 CircuitPadding
 ReducedCircuitPadding
 NewCircuitPeriod
 PathsNeededToBuildCircuits

 If yes, I will have to add these two.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32928 [Core Tor/Tor]: Tor Manual: Split Circuit Timeout options into their own subsection

2020-01-12 Thread Tor Bug Tracker & Wiki
#32928: Tor Manual: Split Circuit Timeout options into their own subsection
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  documentation tor-client manpage
 Severity:  Normal   |  easy 043-can
Actual Points:   |  Parent ID:  #4310
   Points:  0.5  |   Reviewer:
  Sponsor:   |
-+-
 Let's put the *Circuit*Timeout options in their own manpage section.

 For context, see:
 https://trac.torproject.org/projects/tor/ticket/32846#comment:11

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs