Re: [tor-bugs] #33092 [Core Tor/Tor]: Pass -bind_at_load on macOS

2020-02-05 Thread Tor Bug Tracker & Wiki 
#33092: Pass -bind_at_load on macOS
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  wontfix
 Keywords:  macos |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor, nickm   |Sponsor:
--+
Changes (by teor):

 * status:  needs_review => closed
 * resolution:   => wontfix


Comment:

 Thanks for submitting the patch!

 Sorry we weren't able to accept it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33092 [Core Tor/Tor]: Pass -bind_at_load on macOS

2020-02-04 Thread Tor Bug Tracker & Wiki 
#33092: Pass -bind_at_load on macOS
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  macos |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor, nickm   |Sponsor:
--+

Comment (by rex4539):

 If the small binary size reduction is not worth it, there is no other
 useful side effect I'm aware of.

 Thanks for reviewing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33092 [Core Tor/Tor]: Pass -bind_at_load on macOS

2020-02-04 Thread Tor Bug Tracker & Wiki 
#33092: Pass -bind_at_load on macOS
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  macos |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor, nickm   |Sponsor:
--+

Comment (by teor):

 I've commented on the PR asking for more information.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33092 [Core Tor/Tor]: Pass -bind_at_load on macOS

2020-02-03 Thread Tor Bug Tracker & Wiki 
#33092: Pass -bind_at_load on macOS
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  macos |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor, nickm   |Sponsor:
--+
Changes (by dgoulet):

 * keywords:   => macos
 * reviewer:   => teor, nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33092 [Core Tor/Tor]: Pass -bind_at_load on macOS

2020-02-03 Thread Tor Bug Tracker & Wiki 
#33092: Pass -bind_at_load on macOS
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 So if I'm figuring right, 5.5k is currently around .05% (that is, 5% of
 1%) of the binary size?  Right now, I don't think a savings that small is
 worth even a small amount of risk, if that's the only motivation.

 Is there anything else going on here?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33092 [Core Tor/Tor]: Pass -bind_at_load on macOS

2020-02-02 Thread Tor Bug Tracker & Wiki 
#33092: Pass -bind_at_load on macOS
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by teor):

 Replying to [comment:3 nickm]:
 > What is the reason for doing this?

 The original PR says that it reduces the tor binary size by about 5.5
 kilobytes on macOS:
 https://github.com/torproject/tor/pull/1655

 However, it's a risky change if we're using weak linking on macOS or iOS
 (which I don't think we do, but other tor packagers might). I think if we
 try to bind all symbols at launch, and the current macOS doesn't have an
 optional symbol, we'll crash at launch. (Rather than testing if the
 optional symbol is NULL, or if we don't test, crashing when we use that
 symbol.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33092 [Core Tor/Tor]: Pass -bind_at_load on macOS

2020-01-30 Thread Tor Bug Tracker & Wiki 
#33092: Pass -bind_at_load on macOS
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 What is the reason for doing this?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33092 [Core Tor/Tor]: Pass -bind_at_load on macOS

2020-01-29 Thread Tor Bug Tracker & Wiki 
#33092: Pass -bind_at_load on macOS
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by rex4539):

 This is essentially the equivalent of passing
 {{{
 -Wl,-z,now
 }}}
 on Linux.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33092 [Core Tor/Tor]: Pass -bind_at_load on macOS

2020-01-29 Thread Tor Bug Tracker & Wiki 
#33092: Pass -bind_at_load on macOS
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33092 [Core Tor/Tor]: Pass -bind_at_load on macOS

2020-01-29 Thread Tor Bug Tracker & Wiki 
#33092: Pass -bind_at_load on macOS
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 Here is a PR from a new contributor:
 https://github.com/torproject/tor/pull/1655

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs