Re: [tor-bugs] #33103 [Core Tor/Tor]: LeakSanitizer is kicking in with tor being on 39c5e1b84994c2f226a8530b930f215cc5ffb877 when closing Tor Browser

2020-02-06 Thread Tor Bug Tracker & Wiki
#33103: LeakSanitizer is kicking in with tor being on
39c5e1b84994c2f226a8530b930f215cc5ffb877 when closing Tor Browser
-+-
 Reporter:  gk   |  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  regression leak 043-must |  Actual Points:  .1
  BugSmashFund   |
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged to master.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33103 [Core Tor/Tor]: LeakSanitizer is kicking in with tor being on 39c5e1b84994c2f226a8530b930f215cc5ffb877 when closing Tor Browser

2020-02-05 Thread Tor Bug Tracker & Wiki
#33103: LeakSanitizer is kicking in with tor being on
39c5e1b84994c2f226a8530b930f215cc5ffb877 when closing Tor Browser
-+-
 Reporter:  gk   |  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  regression leak 043-must |  Actual Points:  .1
  BugSmashFund   |
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by teor):

 * keywords:  regression leak 043-must => regression leak 043-must
 BugSmashFund
 * reviewer:   => teor
 * status:  needs_review => merge_ready


Comment:

 Looks good to me!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33103 [Core Tor/Tor]: LeakSanitizer is kicking in with tor being on 39c5e1b84994c2f226a8530b930f215cc5ffb877 when closing Tor Browser

2020-02-05 Thread Tor Bug Tracker & Wiki
#33103: LeakSanitizer is kicking in with tor being on
39c5e1b84994c2f226a8530b930f215cc5ffb877 when closing Tor Browser
--+
 Reporter:  gk|  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  High  |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  regression leak 043-must  |  Actual Points:  .1
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  accepted => needs_review
 * actualpoints:   => .1


Comment:

 One-line fix in branch `ticket33103`; PR at
 https://github.com/torproject/tor/pull/1708

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33103 [Core Tor/Tor]: LeakSanitizer is kicking in with tor being on 39c5e1b84994c2f226a8530b930f215cc5ffb877 when closing Tor Browser

2020-02-05 Thread Tor Bug Tracker & Wiki
#33103: LeakSanitizer is kicking in with tor being on
39c5e1b84994c2f226a8530b930f215cc5ffb877 when closing Tor Browser
--+
 Reporter:  gk|  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  regression leak 043-must  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * owner:  (none) => nickm
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33103 [Core Tor/Tor]: LeakSanitizer is kicking in with tor being on 39c5e1b84994c2f226a8530b930f215cc5ffb877 when closing Tor Browser

2020-01-30 Thread Tor Bug Tracker & Wiki
#33103: LeakSanitizer is kicking in with tor being on
39c5e1b84994c2f226a8530b930f215cc5ffb877 when closing Tor Browser
--+
 Reporter:  gk|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  regression leak 043-must  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * keywords:   => regression leak 043-must
 * milestone:   => Tor: 0.4.3.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33103 [Core Tor/Tor]: LeakSanitizer is kicking in with tor being on 39c5e1b84994c2f226a8530b930f215cc5ffb877 when closing Tor Browser

2020-01-30 Thread Tor Bug Tracker & Wiki
#33103: LeakSanitizer is kicking in with tor being on
39c5e1b84994c2f226a8530b930f215cc5ffb877 when closing Tor Browser
--+
 Reporter:  gk|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 I just updated my hardened Tor Browser setup and I got LeakSanitizer
 issues when closing Tor Browser. That's with `tor` being on
 `39c5e1b84994c2f226a8530b930f215cc5ffb877`:
 {{{
 ==10555==ERROR: LeakSanitizer: detected memory leaks

 Direct leak of 6762 byte(s) in 4 object(s) allocated from:
 #0 0x7f0d81c53628 in malloc (/usr/lib/x86_64-linux-
 gnu/libasan.so.5+0x107628)
 #1 0x55863eead50a in tor_malloc_ ../src/lib/malloc/malloc.c:45
 #2 0x55863ee86121 in smartlist_join_strings2
 ../src/lib/container/smartlist.c:309
 #3 0x55863ec2bb08 in getinfo_helper_events
 ../src/feature/control/control_getinfo.c:1169
 #4 0x55863ec31d53 in handle_getinfo_helper
 ../src/feature/control/control_getinfo.c:1696
 #5 0x55863ec31d53 in handle_control_getinfo
 ../src/feature/control/control_getinfo.c:1721
 #6 0x55863ec1e092 in handle_single_control_command
 ../src/feature/control/control_cmd.c:2374
 #7 0x55863ec1e092 in handle_control_command
 ../src/feature/control/control_cmd.c:2405
 #8 0x55863ec0fa91 in connection_control_process_inbuf
 ../src/feature/control/control.c:508
 #9 0x55863eb19c21 in connection_handle_read_impl
 ../src/core/mainloop/connection.c:3737
 #10 0x55863eb19c21 in connection_handle_read
 ../src/core/mainloop/connection.c:3777
 #11 0x55863eb25ce0 in conn_read_callback
 ../src/core/mainloop/mainloop.c:892
 #12 0x7f0d819b4b0e  (/usr/lib/x86_64-linux-
 gnu/libevent-2.1.so.7+0x23b0e)

 Direct leak of 2244 byte(s) in 12 object(s) allocated from:
 #0 0x7f0d81c53628 in malloc (/usr/lib/x86_64-linux-
 gnu/libasan.so.5+0x107628)
 #1 0x55863eead50a in tor_malloc_ ../src/lib/malloc/malloc.c:45
 #2 0x55863ee86121 in smartlist_join_strings2
 ../src/lib/container/smartlist.c:309
 #3 0x55863ed0e522 in routerstatus_format_entry
 ../src/feature/nodelist/fmt_routerstatus.c:197
 #4 0x55863ece1718 in networkstatus_getinfo_helper_single
 ../src/feature/nodelist/networkstatus.c:2353
 #5 0x55863ece1718 in getinfo_helper_networkstatus
 ../src/feature/nodelist/networkstatus.c:2694
 #6 0x55863ec31d53 in handle_getinfo_helper
 ../src/feature/control/control_getinfo.c:1696
 #7 0x55863ec31d53 in handle_control_getinfo
 ../src/feature/control/control_getinfo.c:1721
 #8 0x55863ec1e092 in handle_single_control_command
 ../src/feature/control/control_cmd.c:2374
 #9 0x55863ec1e092 in handle_control_command
 ../src/feature/control/control_cmd.c:2405
 #10 0x55863ec0fa91 in connection_control_process_inbuf
 ../src/feature/control/control.c:508
 #11 0x55863eb19c21 in connection_handle_read_impl
 ../src/core/mainloop/connection.c:3737
 #12 0x55863eb19c21 in connection_handle_read
 ../src/core/mainloop/connection.c:3777
 #13 0x55863eb25ce0 in conn_read_callback
 ../src/core/mainloop/mainloop.c:892
 #14 0x7f0d819b4b0e  (/usr/lib/x86_64-linux-
 gnu/libevent-2.1.so.7+0x23b0e)

 Direct leak of 147 byte(s) in 2 object(s) allocated from:
 #0 0x7f0d81bde0b5 in strdup (/usr/lib/x86_64-linux-
 gnu/libasan.so.5+0x920b5)
 #1 0x55863eead7a0 in tor_strdup_ ../src/lib/malloc/malloc.c:165
 #2 0x55863ec2bdb7 in getinfo_helper_events
 ../src/feature/control/control_getinfo.c:1289
 #3 0x55863ec31d53 in handle_getinfo_helper
 ../src/feature/control/control_getinfo.c:1696
 #4 0x55863ec31d53 in handle_control_getinfo
 ../src/feature/control/control_getinfo.c:1721
 #5 0x55863ec1e092 in handle_single_control_command
 ../src/feature/control/control_cmd.c:2374
 #6 0x55863ec1e092 in handle_control_command
 ../src/feature/control/control_cmd.c:2405
 #7 0x55863ec0fa91 in connection_control_process_inbuf
 ../src/feature/control/control.c:508
 #8 0x55863eb19c21 in connection_handle_read_impl
 ../src/core/mainloop/connection.c:3737
 #9 0x55863eb19c21 in connection_handle_read
 ../src/core/mainloop/connection.c:3777
 #10 0x55863eb25ce0 in conn_read_callback
 ../src/core/mainloop/mainloop.c:892
 #11 0x7f0d819b4b0e  (/usr/lib/x86_64-linux-
 gnu/libevent-2.1.so.7+0x23b0e)

 Direct leak of 36 byte(s) in 12 object(s) allocated from:
 #0 0x7f0d81bde0b5 in strdup (/usr/lib/x86_64-linux-
 gnu/libasan.so.5+0x920b5)
 #1 0x55863eead7a0 in tor_strdup_ ../src/lib/malloc/malloc.c:165
 #2 0x55863ec34aba in getinfo_helper_geoip
 ../src/feature/control/getinfo_geoip.c:51
 #3 0x55863ec31d53 in handle_getinfo_helper