Re: [tor-bugs] #33205 [Metrics/Library]: Avoid invoking overridable methods from constructors

[Tor Bug Tracker & Wiki]

#33205: Avoid invoking overridable methods from constructors
-+-
 Reporter:  karsten  |  Owner:  karsten
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Metrics/Library  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:  irl  |Sponsor:
-+-
Changes (by karsten):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Agreed! Thanks for checking. Merged to master. Closing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33205 [Metrics/Library]: Avoid invoking overridable methods from constructors

[Tor Bug Tracker & Wiki]

#33205: Avoid invoking overridable methods from constructors
-+-
 Reporter:  karsten  |  Owner:  karsten
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Metrics/Library  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:  irl  |Sponsor:
-+-
Changes (by irl):

 * status:  needs_review => merge_ready


Comment:

 I think I do prefer this approach. ​commit 9ccb934 in task-33205-2 branch
 looks good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33205 [Metrics/Library]: Avoid invoking overridable methods from constructors (was: Move all parsing code out of constructors)

[Tor Bug Tracker & Wiki]

#33205: Avoid invoking overridable methods from constructors
-+--
 Reporter:  karsten  |  Owner:  karsten
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Library  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:  irl  |Sponsor:
-+--

Comment (by karsten):

 Updating the summary to reflect what the issue is, not to imply a possible
 solution that we did not take in the end.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs