Re: [tor-bugs] #33342 [Applications/Tor Browser]: Disconnect search addon causes error at startup

[Tor Bug Tracker & Wiki]

#33342: Disconnect search addon causes error at startup
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-9.5a9, TorBrowserTeam202004R,|  Actual Points:  0.5
  tbb-no-uplift  |
Parent ID:   | Points:
 Reviewer:  brade,mcs|Sponsor:
-+-
Changes (by acat):

 * keywords:  tbb-9.5a9, TorBrowserTeam202004R => tbb-9.5a9,
 TorBrowserTeam202004R, tbb-no-uplift


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33342 [Applications/Tor Browser]: Disconnect search addon causes error at startup

[Tor Bug Tracker & Wiki]

#33342: Disconnect search addon causes error at startup
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  tbb-9.5a9, TorBrowserTeam202004R  |  Actual Points:  0.5
Parent ID:| Points:
 Reviewer:  brade,mcs |Sponsor:
--+--
Changes (by mcs):

 * status:  needs_information => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:11 pili]:
 > I'm a bit confused whether this is reviewed or it needs revisions or can
 be closed (I see a patch was merged already.)
 >
 > Can someone who knows better please update :) Thanks!

 In comment:9, Alex provided a good answer to my question. Closing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33342 [Applications/Tor Browser]: Disconnect search addon causes error at startup

[Tor Bug Tracker & Wiki]

#33342: Disconnect search addon causes error at startup
--+
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:
  |  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-9.5a9, TorBrowserTeam202004R  |  Actual Points:  0.5
Parent ID:| Points:
 Reviewer:  brade,mcs |Sponsor:
--+
Changes (by pili):

 * keywords:  TorBrowserTeam202003R, tbb-9.5a9, TorBrowserTeam202004 =>
 tbb-9.5a9, TorBrowserTeam202004R


Comment:

 I'm a bit confused whether this is reviewed or it needs revisions or can
 be closed (I see a patch was merged already.)

 Can someone who knows better please update :) Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33342 [Applications/Tor Browser]: Disconnect search addon causes error at startup

[Tor Bug Tracker & Wiki]

#33342: Disconnect search addon causes error at startup
--+
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:
  |  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202003R, tbb-9.5a9  |  Actual Points:  0.5
Parent ID:| Points:
 Reviewer:  brade,mcs |Sponsor:
--+

Comment (by acat):

 Sorry, I trusted my mail classification too much and missed mcs question.
 Replying to [comment:7 mcs]:
 > One question: would it also work to remove the `addonStartup.json.lz4`
 file? If I remember correctly it is a cache that would get rebuilt based
 on the installed addons.
 I think not, in the sense that it might break some stuff. For example, if
 you remove `addonStartup.json.lz4` the search builtin extensions will not
 load at all, which means that the search icons in the urlbar will be
 broken (similar to #31563). Launching the browser with env variable
 `RELOAD_ENGINES=1` makes `SearchService.jsm` reinstall these search
 extensions again, so perhaps removing `addonStartup.json.lz4` + forcing
 search extensions reinstall might do the trick.

 I'm not completely sure about the details, but I think one of the reasons
 why `addonStartup.json.lz4` is "not just a cache", at least for builtin
 extensions, is that the `BuiltInLocation` is not [https://searchfox.org
 /mozilla-
 
esr68/rev/0ef234279fd0608a8fd6bb1f792d080087d638d8/toolkit/mozapps/extensions/internal/XPIProvider.jsm#979
 enumerable], which means that in [https://searchfox.org/mozilla-
 
esr68/rev/0ef234279fd0608a8fd6bb1f792d080087d638d8/toolkit/mozapps/extensions/internal/XPIProvider.jsm#1455
 scanForChanges] the builtin location is skipped and it cannot notice the
 fact that the addon disappeared from `addonStartup.json.lz4` (because
 actually it was the only place this was persisted on). I think this would
 not be an issue if the search engines were temptatively installed every
 time, like  it's done with the [https://searchfox.org/mozilla-
 
esr68/rev/0ef234279fd0608a8fd6bb1f792d080087d638d8/browser/components/BrowserGlue.jsm#1179
 themes], but that's not the case (probably to make the browser load
 faster?).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33342 [Applications/Tor Browser]: Disconnect search addon causes error at startup

[Tor Bug Tracker & Wiki]

#33342: Disconnect search addon causes error at startup
--+
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:
  |  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202003R, tbb-9.5a9  |  Actual Points:  0.5
Parent ID:| Points:
 Reviewer:  brade,mcs |Sponsor:
--+
Changes (by sysrqb):

 * keywords:  TorBrowserTeam202003R => TorBrowserTeam202003R, tbb-9.5a9
 * status:  merge_ready => needs_information


Comment:

 Thanks! I merged this onto `tor-browser-68.6.0esr-9.5-1` (commit
 `69dfbacfa8b3d6abd6eb5e248fcd24a03c30a962`). It's  in 9.5a9.

 acat, do you know an answer to mcs' question?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33342 [Applications/Tor Browser]: Disconnect search addon causes error at startup

[Tor Bug Tracker & Wiki]

#33342: Disconnect search addon causes error at startup
--+-
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202003R |  Actual Points:  0.5
Parent ID:| Points:
 Reviewer:  brade,mcs |Sponsor:
--+-
Changes (by mcs):

 * status:  needs_review => merge_ready


Comment:

 r=brade,r=mcs
 The code looks good and we tested it on macOS.

 Kathy and I agree that we should try to handle this via some migration
 code next time.

 One question: would it also work to remove the `addonStartup.json.lz4`
 file? If I remember correctly it is a cache that would get rebuilt based
 on the installed addons.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33342 [Applications/Tor Browser]: Disconnect search addon causes error at startup

[Tor Bug Tracker & Wiki]

#33342: Disconnect search addon causes error at startup
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202003R |  Actual Points:  0.5
Parent ID:| Points:
 Reviewer:  brade,mcs |Sponsor:
--+--
Changes (by mcs):

 * reviewer:   => brade,mcs


Comment:

 Kathy and I started to review the patch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33342 [Applications/Tor Browser]: Disconnect search addon causes error at startup

[Tor Bug Tracker & Wiki]

#33342: Disconnect search addon causes error at startup
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202003R |  Actual Points:  0.5
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by acat):

 * status:  new => needs_review
 * keywords:  TorBrowserTeam202003 => TorBrowserTeam202003R
 * actualpoints:   => 0.5


Comment:

 Patch for review in https://github.com/acatarineu/tor-
 browser/commit/33342.

 Perhaps for the next time, we may want to keep the extension files but
 just remove the engine from `list.json`, and do a migration similar to
 https://searchfox.org/mozilla-
 
esr68/rev/8927c721cdd45f2d692a6f00cc3ce725ff10/browser/components/BrowserGlue.jsm#2950
 for uninstalling the addon manually (while it can be loaded properly).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33342 [Applications/Tor Browser]: Disconnect search addon causes error at startup

[Tor Bug Tracker & Wiki]

#33342: Disconnect search addon causes error at startup
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202003  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks):

 > error at startup
 is
 {{{
 1581718500072   addons.xpi-utilsWARNupdateMetadata: Add-on
 disconn...@search.mozilla.org is invalid: Error: File resource://search-
 extensions/disconnect/ does not contain a valid
 manifest(resource://gre/modules/addons/XPIInstall.jsm:671:11) JS Stack
 trace: loadmanif...@xpiinstall.jsm:671:11
 awaitprom...@xpiprovider.jsm:228:15
 syncloadmanif...@xpiinstall.jsm:750:24
 updatemetad...@xpidatabase.jsm:2832:32
 updateexistingad...@xpidatabase.jsm:3048:23
 processfilechan...@xpidatabase.jsm:3137:31
 checkforchan...@xpiprovider.jsm:2969:55
 star...@xpiprovider.jsm:2429:12
 callprovi...@addonmanager.jsm:215:31
 _startprovi...@addonmanager.jsm:651:5
 star...@addonmanager.jsm:897:14
 star...@addonmanager.jsm:3493:26
 obse...@addonmanager.js:70:29
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33342 [Applications/Tor Browser]: Disconnect search addon causes error at startup

[Tor Bug Tracker & Wiki]

#33342: Disconnect search addon causes error at startup
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202002  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by Thorin):

 FWIW: except for the path and timestamp, on Windows I get the same error
 as gk

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33342 [Applications/Tor Browser]: Disconnect search addon causes error at startup

[Tor Bug Tracker & Wiki]

#33342: Disconnect search addon causes error at startup
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202002  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 FWIW, I get something like
 {{{
 1582213850508   addons.xpi  WARNException running bootstrap method
 startup on disconn...@search.mozilla.org: Error: Error while loading
 'jar:file:///home/thomas/Arbeit/Tor/tor-browser-build/tor-browser_sv-
 SE/Browser/browser/omni.ja!/chrome/browser/search-
 extensions/disconnect/manifest.json'
 (NS_ERROR_FILE_NOT_FOUND)(resource://gre/modules/Extension.jsm:513:20) JS
 Stack trace: readJSON/https://trac.torproject.org/projects/tor/ticket/33342#comment:1>
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33342 [Applications/Tor Browser]: Disconnect search addon causes error at startup

[Tor Bug Tracker & Wiki]

#33342: Disconnect search addon causes error at startup
--+
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
  |  TorBrowserTeam202002
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 Following #32767, it seems Firefox is throwing an exception. I don't think
 it's too important.

 {{{
 1581718500372   addons.xpi-utilsWARNaddMetadata: Add-on
 disconn...@search.mozilla.org is invalid: Error: File resource://search-
 extensions/disconnect/ does not contain a valid
 manifest(resource://gre/modules/addons/XPIInstall.jsm:671:11) JS Stack
 trace: loadmanif...@xpiinstall.jsm:671:11
 awaitprom...@xpiprovider.jsm:228:15
 syncloadmanif...@xpiinstall.jsm:750:24
 addmetad...@xpidatabase.jsm:2721:32
 processfilechan...@xpidatabase.jsm:3162:26
 getnewsidelo...@xpiprovider.jsm:3005:28
 1581718500362   addons.xpi-utilsWARNNot uninstalling invalid item
 because it is a proxy file
 }}}

 We may not need to do anything about this, but if there is a way we can
 prevent this error then that'll be even better (reducing noise in logging
 is helpful).

 acat, what do you think? I haven't looked at the code in the stacktrace at
 all.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs