Re: [tor-bugs] #33436 [Core Tor/Tor]: Remove all non-dirauth usage of dirauth timing options.

[Tor Bug Tracker & Wiki]

#33436: Remove all non-dirauth usage of dirauth timing options.
+
 Reporter:  nickm   |  Owner:  nickm
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  technical-debt  |  Actual Points:
Parent ID:  #32810  | Points:  .5
 Reviewer:  asn |Sponsor:
+
Changes (by asn):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks really good!

 Merged after fixing the following trivial comment:
 {{{
  /* We should never be reaching this point, since a client should
 never
 - * call this code unless they have some kidn of a consensus. All we
 can
 + * call this code unless they have some kind of a consensus. All we
 can
   * do is hope that this network is using the default voting interval.
 */
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33436 [Core Tor/Tor]: Remove all non-dirauth usage of dirauth timing options.

[Tor Bug Tracker & Wiki]

#33436: Remove all non-dirauth usage of dirauth timing options.
+
 Reporter:  nickm   |  Owner:  nickm
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  technical-debt  |  Actual Points:
Parent ID:  #32810  | Points:  .5
 Reviewer:  asn |Sponsor:
+
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 I've made the requested changes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33436 [Core Tor/Tor]: Remove all non-dirauth usage of dirauth timing options.

[Tor Bug Tracker & Wiki]

#33436: Remove all non-dirauth usage of dirauth timing options.
+
 Reporter:  nickm   |  Owner:  nickm
 Type:  defect  | Status:  needs_revision
 Priority:  Medium  |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  technical-debt  |  Actual Points:
Parent ID:  #32810  | Points:  .5
 Reviewer:  asn |Sponsor:
+

Comment (by nickm):

 I've added comments to the code and asked some questions on the review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33436 [Core Tor/Tor]: Remove all non-dirauth usage of dirauth timing options.

[Tor Bug Tracker & Wiki]

#33436: Remove all non-dirauth usage of dirauth timing options.
+
 Reporter:  nickm   |  Owner:  nickm
 Type:  defect  | Status:  needs_revision
 Priority:  Medium  |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  technical-debt  |  Actual Points:
Parent ID:  #32810  | Points:  .5
 Reviewer:  asn |Sponsor:
+
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 This is nice! Did a review as well!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33436 [Core Tor/Tor]: Remove all non-dirauth usage of dirauth timing options.

[Tor Bug Tracker & Wiki]

#33436: Remove all non-dirauth usage of dirauth timing options.
+
 Reporter:  nickm   |  Owner:  nickm
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  technical-debt  |  Actual Points:
Parent ID:  #32810  | Points:  .5
 Reviewer:  asn |Sponsor:
+
Changes (by dgoulet):

 * reviewer:   => asn


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33436 [Core Tor/Tor]: Remove all non-dirauth usage of dirauth timing options.

[Tor Bug Tracker & Wiki]

#33436: Remove all non-dirauth usage of dirauth timing options.
+
 Reporter:  nickm   |  Owner:  nickm
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  technical-debt  |  Actual Points:
Parent ID:  #32810  | Points:  .5
 Reviewer:  |Sponsor:
+
Changes (by nickm):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33436 [Core Tor/Tor]: Remove all non-dirauth usage of dirauth timing options.

[Tor Bug Tracker & Wiki]

#33436: Remove all non-dirauth usage of dirauth timing options.
+
 Reporter:  nickm   |  Owner:  nickm
 Type:  defect  | Status:  assigned
 Priority:  Medium  |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  technical-debt  |  Actual Points:
Parent ID:  #32810  | Points:  .5
 Reviewer:  |Sponsor:
+

Comment (by nickm):

 Code in ticket33436, with PR at
 https://github.com/torproject/tor/pull/1763 .

 I'd like to know what asn and dgoulet think of this; I hope that some
 approach like this will work, but it might need changes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33436 [Core Tor/Tor]: Remove all non-dirauth usage of dirauth timing options.

[Tor Bug Tracker & Wiki]

#33436: Remove all non-dirauth usage of dirauth timing options.
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  technical-debt
Actual Points:|  Parent ID:  #32810
   Points:  .5|   Reviewer:
  Sponsor:|
--+
 There's code in shared_random_client.c that uses dirauth-only options,
 directly or indirectly.  It shouldn't, since clients should only be
 looking at the consensus to learn what the vote schedule is.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs