Re: [tor-bugs] #33460 [Core Tor/Tor]: confmgt: include variable name in all complaints.

[Tor Bug Tracker & Wiki]

#33460: confmgt: include variable name in all complaints.
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ui, ux, ui-regression 043-may??  |  implemented
  043-backport   |  Actual Points:  .1
Parent ID:  #33014   | Points:  .1
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by teor):

 * milestone:  Tor: 0.4.4.x-final => Tor: 0.4.3.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33460 [Core Tor/Tor]: confmgt: include variable name in all complaints.

[Tor Bug Tracker & Wiki]

#33460: confmgt: include variable name in all complaints.
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ui, ux, ui-regression 043-may??  |  implemented
  043-backport   |  Actual Points:  .1
Parent ID:  #33014   | Points:  .1
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Thanks for the review; merged this to 0.4.3 and forward.

 I agree with you about the design limitation.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33460 [Core Tor/Tor]: confmgt: include variable name in all complaints.

[Tor Bug Tracker & Wiki]

#33460: confmgt: include variable name in all complaints.
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ui, ux, ui-regression 043-may??  |  Actual Points:  .1
  043-backport   |
Parent ID:  #33014   | Points:  .1
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by catalyst):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:3 nickm]:
 > See branch `ticket33460_043` with PR at
 https://github.com/torproject/tor/pull/1765 .
 >
 > The new error message for the case in the ticket description is `Could
 not parse UseBridges: Unrecognized value 99. Allowed values are 0 and 1.`
 >
 > This branch is against 0.4.3 but merges cleanly to master.
 The pull request is against master. I'm not sure there's been enough
 divergence for it to cause problems, though.

 I made a small comment on the pull request about appearing to work around
 a design limitation in the existing code. I think we don't need to address
 it right now, but I wanted to make a note of it in case it requires
 related workarounds in the future.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33460 [Core Tor/Tor]: confmgt: include variable name in all complaints.

[Tor Bug Tracker & Wiki]

#33460: confmgt: include variable name in all complaints.
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ui, ux, ui-regression 043-may??  |  Actual Points:  .1
  043-backport   |
Parent ID:  #33014   | Points:  .1
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by dgoulet):

 * reviewer:   => catalyst


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33460 [Core Tor/Tor]: confmgt: include variable name in all complaints.

[Tor Bug Tracker & Wiki]

#33460: confmgt: include variable name in all complaints.
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ui, ux, ui-regression 043-may??  |  Actual Points:  .1
  043-backport   |
Parent ID:  #33014   | Points:  .1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  assigned => needs_review


Comment:

 See branch `ticket33460_043` with PR at
 https://github.com/torproject/tor/pull/1765 .

 The new error message for the case in the ticket description is `Could not
 parse UseBridges: Unrecognized value 99. Allowed values are 0 and 1.`

 This branch is against 0.4.3 but merges cleanly to master.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33460 [Core Tor/Tor]: confmgt: include variable name in all complaints.

[Tor Bug Tracker & Wiki]

#33460: confmgt: include variable name in all complaints.
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ui, ux, ui-regression 043-may??  |  Actual Points:  .1
  043-backport   |
Parent ID:  #33014   | Points:  .1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  ui, ux, ui-regression 043-may?? => ui, ux, ui-regression
 043-may?? 043-backport
 * milestone:  Tor: 0.4.3.x-final => Tor: 0.4.4.x-final
 * actualpoints:   => .1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33460 [Core Tor/Tor]: confmgt: include variable name in all complaints.

[Tor Bug Tracker & Wiki]

#33460: confmgt: include variable name in all complaints.
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ui, ux, ui-regression 043-may??  |  Actual Points:
Parent ID:  #33014   | Points:  .1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * parent:   => #33014


Comment:

 This is needed to avoid a usability regression on #33014.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33460 [Core Tor/Tor]: confmgt: include variable name in all complaints.

[Tor Bug Tracker & Wiki]

#33460: confmgt: include variable name in all complaints.
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
Component:  Core |Version:
  Tor/Tor|
 Severity:  Normal   |   Keywords:  ui, ux, ui-regression 043-may??
Actual Points:   |  Parent ID:
   Points:  .1   |   Reviewer:
  Sponsor:   |
-+-
 When we give a msg about failing to parse a variable, we should say what
 the variable was, and ideally what was wrong with it.

 Compare the results for running `./src/app/tor UseBridges 99` in 0.3.5 and
 in master.  With 0.3.5 you got: `Boolean 'UseBridges 99' expects 0 or 1.`
 but now you get `Unrecognized value 99.`

 Let's make that better.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs