Re: [tor-bugs] #33503 [Core Tor/Tor]: LeakSanitizer detected memory leak with Tor 0.4.4.0-alpha-dev (git-6472d9cfdf1198cf)

[Tor Bug Tracker & Wiki]

#33503: LeakSanitizer detected memory leak with Tor 0.4.4.0-alpha-dev (git-
6472d9cfdf1198cf)
-+-
 Reporter:  gk   |  Owner:  asn
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  regresssion, memleak, tor-hs,|  Actual Points:
  044-must, postfreeze-ok|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by asn):

 Hmm, I don't see an obvious memleak in cache_store_as_client(). It seems
 like we are always freeing the old cache entry when we replace it. And wea
 always free the cache in the end in `hs_cache_free_all()`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33503 [Core Tor/Tor]: LeakSanitizer detected memory leak with Tor 0.4.4.0-alpha-dev (git-6472d9cfdf1198cf)

[Tor Bug Tracker & Wiki]

#33503: LeakSanitizer detected memory leak with Tor 0.4.4.0-alpha-dev (git-
6472d9cfdf1198cf)
-+-
 Reporter:  gk   |  Owner:  asn
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  regresssion, memleak, tor-hs,|  Actual Points:
  044-must, postfreeze-ok|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:8 asn]:
 > This seems related to the new client auth descriptor code. geko do you
 remember if you used any client auth protected websites during your
 browsering 3 months ago? :/

 Not intentionally and I did not enter any credentials anywhere.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33503 [Core Tor/Tor]: LeakSanitizer detected memory leak with Tor 0.4.4.0-alpha-dev (git-6472d9cfdf1198cf)

[Tor Bug Tracker & Wiki]

#33503: LeakSanitizer detected memory leak with Tor 0.4.4.0-alpha-dev (git-
6472d9cfdf1198cf)
-+-
 Reporter:  gk   |  Owner:  asn
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  regresssion, memleak, tor-hs,|  Actual Points:
  044-must, postfreeze-ok|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by asn):

 This seems related to the new client auth descriptor code. geko do you
 remember if you used any client auth protected websites during your
 browsering 3 months ago? :/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33503 [Core Tor/Tor]: LeakSanitizer detected memory leak with Tor 0.4.4.0-alpha-dev (git-6472d9cfdf1198cf)

[Tor Bug Tracker & Wiki]

#33503: LeakSanitizer detected memory leak with Tor 0.4.4.0-alpha-dev (git-
6472d9cfdf1198cf)
-+-
 Reporter:  gk   |  Owner:  asn
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  regresssion, memleak, tor-hs,|  Actual Points:
  044-must, postfreeze-ok|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by asn):

 * owner:  (none) => asn
 * status:  new => assigned


Comment:

 I think this has been fixed in the meanwhile, but assigning it to me for
 now to check it out further.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33503 [Core Tor/Tor]: LeakSanitizer detected memory leak with Tor 0.4.4.0-alpha-dev (git-6472d9cfdf1198cf)

[Tor Bug Tracker & Wiki]

#33503: LeakSanitizer detected memory leak with Tor 0.4.4.0-alpha-dev (git-
6472d9cfdf1198cf)
-+-
 Reporter:  gk   |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  regresssion memleak tor-hs 044-must  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  regresssion memleak tor-hs 044-should => regresssion memleak
 tor-hs 044-must


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33503 [Core Tor/Tor]: LeakSanitizer detected memory leak with Tor 0.4.4.0-alpha-dev (git-6472d9cfdf1198cf)

[Tor Bug Tracker & Wiki]

#33503: LeakSanitizer detected memory leak with Tor 0.4.4.0-alpha-dev (git-
6472d9cfdf1198cf)
-+-
 Reporter:  gk   |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  regresssion memleak tor-hs   |  Actual Points:
  044-should |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  regresssion memleak tor-hs => regresssion memleak tor-hs
 044-should


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33503 [Core Tor/Tor]: LeakSanitizer detected memory leak with Tor 0.4.4.0-alpha-dev (git-6472d9cfdf1198cf)

[Tor Bug Tracker & Wiki]

#33503: LeakSanitizer detected memory leak with Tor 0.4.4.0-alpha-dev (git-
6472d9cfdf1198cf)
+--
 Reporter:  gk  |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor:
|  0.4.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  regresssion memleak tor-hs  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by dgoulet):

 * cc: dgoulet (removed)
 * keywords:   => regresssion memleak tor-hs


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33503 [Core Tor/Tor]: LeakSanitizer detected memory leak with Tor 0.4.4.0-alpha-dev (git-6472d9cfdf1198cf)

[Tor Bug Tracker & Wiki]

#33503: LeakSanitizer detected memory leak with Tor 0.4.4.0-alpha-dev (git-
6472d9cfdf1198cf)
--+
 Reporter:  gk|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * cc: asn, dgoulet (added)


Comment:

 Could this be related to the new onionbalance-helper code?  Adding dgoulet
 and asn in case.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33503 [Core Tor/Tor]: LeakSanitizer detected memory leak with Tor 0.4.4.0-alpha-dev (git-6472d9cfdf1198cf)

[Tor Bug Tracker & Wiki]

#33503: LeakSanitizer detected memory leak with Tor 0.4.4.0-alpha-dev (git-
6472d9cfdf1198cf)
--+
 Reporter:  gk|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * milestone:   => Tor: 0.4.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33503 [Core Tor/Tor]: LeakSanitizer detected memory leak with Tor 0.4.4.0-alpha-dev (git-6472d9cfdf1198cf)

[Tor Bug Tracker & Wiki]

#33503: LeakSanitizer detected memory leak with Tor 0.4.4.0-alpha-dev (git-
6472d9cfdf1198cf)
--+
 Reporter:  gk|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by gk):

 * Attachment "33503_leaks" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33503 [Core Tor/Tor]: LeakSanitizer detected memory leak with Tor 0.4.4.0-alpha-dev (git-6472d9cfdf1198cf)

[Tor Bug Tracker & Wiki]

#33503: LeakSanitizer detected memory leak with Tor 0.4.4.0-alpha-dev (git-
6472d9cfdf1198cf)
--+
 Reporter:  gk|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 I hit a memory leak with the latest `tor` code from `master` when using it
 in Tor Browser.
 {{{
 Direct leak of 112 byte(s) in 2 object(s) allocated from:
 #0 0x7fdee552d628 in malloc (/usr/lib/x86_64-linux-
 gnu/libasan.so.5+0x107628)
 #1 0x55e7f567b5fa in tor_malloc_ ../src/lib/malloc/malloc.c:45
 #2 0x55e7f567b690 in tor_malloc_zero_ ../src/lib/malloc/malloc.c:71
 #3 0x55e7f5478339 in cache_client_desc_new
 ../src/feature/hs/hs_cache.c:429
 #4 0x55e7f5478339 in hs_cache_store_as_client
 ../src/feature/hs/hs_cache.c:830
 #5 0x55e7f5487e50 in client_dir_fetch_200
 ../src/feature/hs/hs_client.c:1372
 #6 0x55e7f5487e50 in hs_client_dir_fetch_done
 ../src/feature/hs/hs_client.c:2264
 #7 0x55e7f54445fa in handle_response_fetch_hsdesc_v3
 ../src/feature/dirclient/dirclient.c:2776
 #8 0x55e7f54445fa in connection_dir_client_reached_eof
 ../src/feature/dirclient/dirclient.c:2202
 #9 0x55e7f54445fa in connection_dir_reached_eof
 ../src/feature/dirclient/dirclient.c:2989
 #10 0x55e7f52e5505 in connection_reached_eof
 ../src/core/mainloop/connection.c:5029
 #11 0x55e7f52e5505 in connection_handle_read_impl
 ../src/core/mainloop/connection.c:3776
 #12 0x55e7f52e5505 in connection_handle_read
 ../src/core/mainloop/connection.c:3788
 #13 0x55e7f52f18e0 in conn_read_callback
 ../src/core/mainloop/mainloop.c:892
 #14 0x7fdee528eb0e  (/usr/lib/x86_64-linux-
 gnu/libevent-2.1.so.7+0x23b0e)
 }}}
 I've attached all the direct/indirect leaks that LeakSanitizer gave me, in
 case there is more lurking.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs