Re: [tor-bugs] #33556 [Applications/Tor Browser]: Add TBB project for android-components

[Tor Bug Tracker & Wiki]

#33556: Add TBB project for android-components
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005, GeorgKoppen202005|
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-

Comment (by gk):

 So, [comment:10:ticket:33932 this] has been a big PITA and I found another
 .jar file was missing. I am still not sure why. But I added both "by hand"
 to be able to work on the integration of your custom `geckoview` further.
 `bug_33556_v4` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/log/?h=bug_33556_v4) is what I am currently using for that.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33556 [Applications/Tor Browser]: Add TBB project for android-components

[Tor Bug Tracker & Wiki]

#33556: Add TBB project for android-components
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005, GeorgKoppen202005|
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * cc: tbb-team (added)
 * owner:  tbb-team => gk
 * status:  needs_revision => assigned
 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam202005 => tbb-mobile, tbb-
 rbm, TorBrowserTeam202005, GeorgKoppen202005
 * reviewer:  gk => sysrqb


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33556 [Applications/Tor Browser]: Add TBB project for android-components

[Tor Bug Tracker & Wiki]

#33556: Add TBB project for android-components
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005   |
Parent ID:  #33184   | Points:
 Reviewer:  gk   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam202004R => tbb-mobile, tbb-
 rbm, TorBrowserTeam202005


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33556 [Applications/Tor Browser]: Add TBB project for android-components

[Tor Bug Tracker & Wiki]

#33556: Add TBB project for android-components
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202004R  |
Parent ID:  #33184   | Points:
 Reviewer:  gk   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * keywords:  tbb-mobile, Android, TorBrowserTeam202004R => tbb-mobile, tbb-
 rbm, TorBrowserTeam202004R
 * reviewer:   => gk
 * type:  defect => task


Comment:

 sisbell: Do you have an update for that bug somewhere (the old review
 request is 5 weeks old and there were open questions) or should I still
 look at `bug_33556b`?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33556 [Applications/Tor Browser]: Add TBB project for android-components

[Tor Bug Tracker & Wiki]

#33556: Add TBB project for android-components
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, Android, |  Actual Points:
  TorBrowserTeam202004R  |
Parent ID:  #33184   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * keywords:  tbb-mobile, Android => tbb-mobile, Android,
 TorBrowserTeam202004R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33556 [Applications/Tor Browser]: Add TBB project for android-components

[Tor Bug Tracker & Wiki]

#33556: Add TBB project for android-components
--+
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, Android   |  Actual Points:
Parent ID:  #33184| Points:
 Reviewer:|Sponsor:  Sponsor58-must
--+

Comment (by sisbell):

 Some additional changes needed are to have this project depend on a
 TBB[wiki:GeckoView] project that we build, rather than downloading
 geckoview from the repo.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33556 [Applications/Tor Browser]: Add TBB project for android-components

[Tor Bug Tracker & Wiki]

#33556: Add TBB project for android-components
--+--
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, Android   |  Actual Points:
Parent ID:  #33184| Points:
 Reviewer:|Sponsor:
--+--
Changes (by sisbell):

 * cc: eighthave (removed)
 * status:  new => needs_review


Comment:

 Made the following changes

 Remove projects that we don't need from .buildconfig.yml

 Push Related

  * concept-push


  * feature-accounts-push


  * feature-push


  * lib-push-amazon


  * lib-push-firebase



 Accounts

  * feature-accounts


  * service-firefox-accounts



 Synch

  * feature-syncedtabs


  * browser-storage-sync


  * service-sync-logins



 Glean/Telemetry

  * service-glean


  * support-sync-telemetry



 Rust

  * support-rustlog


  * support-rusthttp



 Crash Reporting

  * lib-crash - (feature-push and service-firefox-accounts both depend on
 this, since they are removed we can remove this project)



 Miscs

  * service-experiments


  * support-migration (may need this)


  * support-test-appservices (removing all appservices components)


  * all sample projects



 Add mavenLocal() in build configs to reference local repo

 Use legacy setup for plugins so that they can find plugin artifact in
 local maven repo

 Since we are removing glean/telemetry support

  * Remove glean plugin references from gradle build files


  * Remove glean GekoAdapter.kt from builds.



 Add @aar to dependency references. The build is not finding these library
 artifacts locally without specifying type It looks for them as a jar)

 Remove use of git plugin. This is used to embed the hash in the meta-data,
 which we don't want to do

 TODOs:

  1. leftover change to rustlog version in path to remove


  1. The local maven repo section in the command line doesn't work
 correctly anymore. I had to copy artifacts to the standard .m2 repo. This
 needs investigation


  1. [wiki:PluginManagement Plugin Management section I added in
 settings.gradle doesn't do anything. This requires patching as a legacy
 plugin. Needs investigation.]


  1. The gradle-depenency file is outdated. It may not need everything in
 with the latest removal of projects from the .buildconfig.yml file. I'll
 need to regenerate it.


  1. We have variants for production, beta and nightly builds. These should
 be configurable based on the rbm build (currently fenix only supports
 using beta and nightly build, so only uses the respective variants  of
 android-components, meaning it doesn't use android-components production
 artifacts)Le



 Latest commit is here

 !https://github.com/sisbell/tor-browser-build/commits/bug-33556b

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33556 [Applications/Tor Browser]: Add TBB project for android-components

[Tor Bug Tracker & Wiki]

#33556: Add TBB project for android-components
--+--
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, Android   |  Actual Points:
Parent ID:  #33184| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks):

 https://stackoverflow.com/questions/42765113/how-to-publish-source-into-
 local-maven-repository-with-gradle

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33556 [Applications/Tor Browser]: Add TBB project for android-components

[Tor Bug Tracker & Wiki]

#33556: Add TBB project for android-components
--+--
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, Android   |  Actual Points:
Parent ID:  #33184| Points:
 Reviewer:|Sponsor:
--+--

Comment (by sisbell):

 android-components build pulls the git hash and adds it as meta-data to
 the aar. The git.patch removes this feature. This is necessary since the
 build doesn't have the git meta-data included. Without the patch the build
 fails.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33556 [Applications/Tor Browser]: Add TBB project for android-components

[Tor Bug Tracker & Wiki]

#33556: Add TBB project for android-components
--+--
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, Android   |  Actual Points:
Parent ID:  #33184| Points:
 Reviewer:|Sponsor:
--+--

Comment (by sisbell):

 This one is not complete so its more of a preview. This works with network
 turned on. Its a work in progress for network turned off.

 Some problems I detected, mostly around changes to local repos

  * Setting of the local maven repo is not working with gradle 5.6.x:
 -Dmaven.repo.local=$gradle_repo
  * There are a couple of dozen downloads that the build tries to download
 but they are all 404 (from same repo). This doesn't appear to affect the
 build.
  * Customs Gradle Plugins need a different repo location than the rest of
 the build. I've managed to get one of the plugins poiting to the correct
 local repo but having trouble with the second one.

 On the plus side, the parsing of the logs for dependencies works without
 needing any changes.

 So the way this works is that we build all the components into an aar and
 the invoke the gradle task ''publishToMavenLocal''

 This will publish to a local repo that the build then packages up to be
 used by fenix.

 https://github.com/sisbell/tor-browser-build/commits/bug-33556

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33556 [Applications/Tor Browser]: Add TBB project for android-components

[Tor Bug Tracker & Wiki]

#33556: Add TBB project for android-components
--+
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-mobile,
  |  Android
Actual Points:|  Parent ID:  #33184
   Points:|   Reviewer:
  Sponsor:|
--+
 Contains dependent libraries of Fenix

 Source: !https://github.com/mozilla-mobile/android-components

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs