Re: [tor-bugs] #33561 [Applications/Tor Browser]: Upgrade openssl to use Android NDK 21

[Tor Bug Tracker & Wiki]

#33561: Upgrade openssl to use Android NDK 21
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-

Comment (by gk):

 Similar to comment:12:ticket:33760 specifying `clang` as our compiler is
 not correct anymore with NDK 20. The fix for that is included on
 `bug_33561_v3` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_33561_v3=696b8717e0d9d33b8a5503f3c770513b8c045cc4).

 There might still be more as `tor` is choking now but I am not sure yet
 this is an `openssl` project related bug. From `tor`'s `config.log`:
 {{{
 configure:9857: armv7a-linux-androideabi16-clang -o conftest -g -O2
 -I/var/tmp/dist/openssl/openssl/include
 -L/var/tmp/dist/openssl/openssl/lib  conftest.c -llog  -lssl -lcrypto
 >&5
 /var/tmp/dist/openssl/openssl/lib/libcrypto.a(armcap.o):armcap.c:function
 OPENSSL_cpuid_setup: error: undefined reference to 'sigfillset'
 /var/tmp/dist/openssl/openssl/lib/libcrypto.a(armcap.o):armcap.c:function
 OPENSSL_cpuid_setup: error: undefined reference to 'sigdelset'
 /var/tmp/dist/openssl/openssl/lib/libcrypto.a(armcap.o):armcap.c:function
 OPENSSL_cpuid_setup: error: undefined reference to 'sigdelset'
 /var/tmp/dist/openssl/openssl/lib/libcrypto.a(armcap.o):armcap.c:function
 OPENSSL_cpuid_setup: error: undefined reference to 'sigdelset'
 /var/tmp/dist/openssl/openssl/lib/libcrypto.a(armcap.o):armcap.c:function
 OPENSSL_cpuid_setup: error: undefined reference to 'sigdelset'
 /var/tmp/dist/openssl/openssl/lib/libcrypto.a(cryptlib.o):cryptlib.c:function
 OPENSSL_showfatal: error: undefined reference to 'stderr'
 
/var/tmp/dist/openssl/openssl/lib/libcrypto.a(eng_openssl.o):eng_openssl.c:function
 openssl_load_privkey: error: undefined reference to 'stderr'
 
/var/tmp/dist/openssl/openssl/lib/libcrypto.a(eng_openssl.o):eng_openssl.c:function
 test_rc4_init_key: error: undefined reference to 'stderr'
 
/var/tmp/dist/openssl/openssl/lib/libcrypto.a(ui_openssl.o):ui_openssl.c:function
 open_console: error: undefined reference to 'tcgetattr'
 
/var/tmp/dist/openssl/openssl/lib/libcrypto.a(ui_openssl.o):ui_openssl.c:function
 open_console: error: undefined reference to 'stdin'
 
/var/tmp/dist/openssl/openssl/lib/libcrypto.a(ui_openssl.o):ui_openssl.c:function
 open_console: error: undefined reference to 'stderr'
 
/var/tmp/dist/openssl/openssl/lib/libcrypto.a(ui_openssl.o):ui_openssl.c:function
 close_console: error: undefined reference to 'stdin'
 
/var/tmp/dist/openssl/openssl/lib/libcrypto.a(ui_openssl.o):ui_openssl.c:function
 read_string_inner: error: undefined reference to 'signal'
 
/var/tmp/dist/openssl/openssl/lib/libcrypto.a(ui_openssl.o):ui_openssl.c:function
 read_string_inner: error: undefined reference to 'tcsetattr'
 
/var/tmp/dist/openssl/openssl/lib/libcrypto.a(ui_openssl.o):ui_openssl.c:function
 read_string_inner: error: undefined reference to 'tcsetattr'
 clang: error: linker command failed with exit code 1 (use -v to see
 invocation)
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33561 [Applications/Tor Browser]: Upgrade openssl to use Android NDK 21

[Tor Bug Tracker & Wiki]

#33561: Upgrade openssl to use Android NDK 21
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-

Comment (by gk):

 `bug_33561_v2` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_33561_v2=5ba0336685601621ff999accec5767f7989aa9ac)
 has no patch changes but is based on the slightly changed toolchain (see:
 #33557).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33561 [Applications/Tor Browser]: Upgrade openssl to use Android NDK 21

[Tor Bug Tracker & Wiki]

#33561: Upgrade openssl to use Android NDK 21
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam202005, GeorgKoppen202005
 => tbb-mobile, tbb-rbm, TorBrowserTeam202005R, GeorgKoppen202005
 * status:  assigned => needs_review


Comment:

 I re-did the commit a bit addressing my feedback and changing the commit
 message slightly: `bug_33561` (https://gitweb.torproject.org/user/gk/tor-
 browser-
 build.git/commit/?h=bug_33561=f74b9394a75ec7589ba64b9b9d2c53ee9353bf04).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33561 [Applications/Tor Browser]: Upgrade openssl to use Android NDK 21

[Tor Bug Tracker & Wiki]

#33561: Upgrade openssl to use Android NDK 21
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005, GeorgKoppen202005|
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * owner:  tbb-team => gk
 * cc: sysrqb, boklm (removed)
 * cc: tbb-team (added)
 * status:  needs_revision => assigned
 * reviewer:   => sysrqb


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33561 [Applications/Tor Browser]: Upgrade openssl to use Android NDK 21

[Tor Bug Tracker & Wiki]

#33561: Upgrade openssl to use Android NDK 21
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005, GeorgKoppen202005|
Parent ID:  #33184   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * keywords:  tbb-mobile, Android, TorBrowserTeam202004 => tbb-mobile, tbb-
 rbm, TorBrowserTeam202005, GeorgKoppen202005


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33561 [Applications/Tor Browser]: Upgrade openssl to use Android NDK 21

[Tor Bug Tracker & Wiki]

#33561: Upgrade openssl to use Android NDK 21
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, Android, |  Actual Points:
  TorBrowserTeam202004   |
Parent ID:  #33184   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  tbb-mobile, Android, TorBrowserTeam202004R => tbb-mobile,
 Android, TorBrowserTeam202004


Comment:

 Replying to [comment:3 sisbell]:
 > Using the new NDK allows us to remove needing to to reset
 ANDROID_NDK_HOME
 >
 > https://github.com/sisbell/tor-browser-build/commits/bug-33561

 If you remove the if-clause please remove the comment above it as well
 which is explaining said if-clause.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33561 [Applications/Tor Browser]: Upgrade openssl to use Android NDK 21

[Tor Bug Tracker & Wiki]

#33561: Upgrade openssl to use Android NDK 21
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, Android, |  Actual Points:
  TorBrowserTeam202004R  |
Parent ID:  #33184   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * keywords:  tbb-mobile, Android => tbb-mobile, Android,
 TorBrowserTeam202004R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33561 [Applications/Tor Browser]: Upgrade openssl to use Android NDK 21

[Tor Bug Tracker & Wiki]

#33561: Upgrade openssl to use Android NDK 21
--+
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, Android   |  Actual Points:
Parent ID:  #33184| Points:
 Reviewer:|Sponsor:  Sponsor58-must
--+
Changes (by sisbell):

 * status:  new => needs_review
 * cc: eighthave (removed)


Comment:

 Using the new NDK allows us to remove needing to to reset ANDROID_NDK_HOME

 https://github.com/sisbell/tor-browser-build/commits/bug-33561

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33561 [Applications/Tor Browser]: Upgrade openssl to use Android NDK 21

[Tor Bug Tracker & Wiki]

#33561: Upgrade openssl to use Android NDK 21
--+--
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, Android   |  Actual Points:
Parent ID:  #33184| Points:
 Reviewer:|Sponsor:
--+--

Comment (by eighthave):

 The official NDK binaries have worked directly with autotools, make, etc
 for several years now.  Ditching support for the old "standalone" approach
 is definitely the right way, and will also work for all the bits that are
 used in Orbot.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33561 [Applications/Tor Browser]: Upgrade openssl to use Android NDK 21

[Tor Bug Tracker & Wiki]

#33561: Upgrade openssl to use Android NDK 21
--+
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-mobile,
  |  Android
Actual Points:|  Parent ID:  #33184
   Points:|   Reviewer:
  Sponsor:|
--+
 This is based of the current work done in branch for android support. We
 need to upgrade to build with NDK 21.

 Make standalone toolchain is not longer supported in NDK 21 so need to
 configure to use new locations.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs