Re: [tor-bugs] #33564 [Applications/Tor Browser]: Upgrade ZSTD to use Android NDK 21

[Tor Bug Tracker & Wiki]

#33564: Upgrade ZSTD to use Android NDK 21
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:  .1
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam202005, GeorgKoppen202005
 => tbb-mobile, tbb-rbm, TorBrowserTeam202005R, GeorgKoppen202005
 * status:  needs_revision => needs_review
 * reviewer:  gk => sysrqb


Comment:

 `bug_33564_v2` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_33564_v2&id=cd0f6197483d8d60043c3663872c294271e6edb4)
 has the latest fix for review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33564 [Applications/Tor Browser]: Upgrade ZSTD to use Android NDK 21

[Tor Bug Tracker & Wiki]

#33564: Upgrade ZSTD to use Android NDK 21
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:  .1
  TorBrowserTeam202005, GeorgKoppen202005|
Parent ID:  #33184   | Points:
 Reviewer:  gk   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam202005R => tbb-mobile, tbb-
 rbm, TorBrowserTeam202005, GeorgKoppen202005
 * status:  merge_ready => needs_revision


Comment:

 While this works we can do slightly better by using `var/CC`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33564 [Applications/Tor Browser]: Upgrade ZSTD to use Android NDK 21

[Tor Bug Tracker & Wiki]

#33564: Upgrade ZSTD to use Android NDK 21
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:  .1
  TorBrowserTeam202005R  |
Parent ID:  #33184   | Points:
 Reviewer:  gk   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * status:  needs_review => merge_ready


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33564 [Applications/Tor Browser]: Upgrade ZSTD to use Android NDK 21

[Tor Bug Tracker & Wiki]

#33564: Upgrade ZSTD to use Android NDK 21
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:  .1
  TorBrowserTeam202005R  |
Parent ID:  #33184   | Points:
 Reviewer:  gk   |Sponsor:
 |  Sponsor58-must
-+-

Comment (by gk):

 Looks good to me and works. I've pushed `bug_33564`
 (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_33564&id=a772e81b5104e5aa179b62ffceaff3f60ae127b2)
 with a slightly modified commit message and on top of my `fenix_toolchain`
 branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33564 [Applications/Tor Browser]: Upgrade ZSTD to use Android NDK 21

[Tor Bug Tracker & Wiki]

#33564: Upgrade ZSTD to use Android NDK 21
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:  .1
  TorBrowserTeam202005R  |
Parent ID:  #33184   | Points:
 Reviewer:  gk   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * keywords:  tbb-mobile, Android, TorBrowserTeam202004R => tbb-mobile, tbb-
 rbm, TorBrowserTeam202005R
 * reviewer:   => gk


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33564 [Applications/Tor Browser]: Upgrade ZSTD to use Android NDK 21

[Tor Bug Tracker & Wiki]

#33564: Upgrade ZSTD to use Android NDK 21
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, Android, |  Actual Points:  .1
  TorBrowserTeam202004R  |
Parent ID:  #33184   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * keywords:  tbb-mobile, Android => tbb-mobile, Android,
 TorBrowserTeam202004R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33564 [Applications/Tor Browser]: Upgrade ZSTD to use Android NDK 21

[Tor Bug Tracker & Wiki]

#33564: Upgrade ZSTD to use Android NDK 21
--+
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, Android   |  Actual Points:  .1
Parent ID:  #33184| Points:
 Reviewer:|Sponsor:  Sponsor58-must
--+
Changes (by sisbell):

 * status:  new => needs_review
 * actualpoints:   => .1


Comment:

 Latest NDK changes how we specify the target sdk version

 https://github.com/sisbell/tor-browser-build/commits/bug-33564

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33564 [Applications/Tor Browser]: Upgrade ZSTD to use Android NDK 21

[Tor Bug Tracker & Wiki]

#33564: Upgrade ZSTD to use Android NDK 21
--+--
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, Android   |  Actual Points:
Parent ID:  #33184| Points:
 Reviewer:|Sponsor:
--+--
Changes (by eighthave):

 * cc: eighthave (removed)


Comment:

 The official NDK binaries have worked directly with autotools, make, etc
 for several years now.  Ditching support for the old "standalone" approach
 is definitely the right way, and will also work for all the bits that are
 used in Orbot.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33564 [Applications/Tor Browser]: Upgrade ZSTD to use Android NDK 21

[Tor Bug Tracker & Wiki]

#33564: Upgrade ZSTD to use Android NDK 21
--+
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-mobile,
  |  Android
Actual Points:|  Parent ID:  #33184
   Points:|   Reviewer:
  Sponsor:|
--+
 This is based of the current work done in branch for android support. We
 need to upgrade to build with NDK 21.

 Make standalone toolchain is not longer supported in NDK 21 so need to
 configure to use new locations

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs