Re: [tor-bugs] #33626 [Applications/Tor Browser]: Add TBB project for GeckoView

[Tor Bug Tracker & Wiki]

#33626: Add TBB project for GeckoView
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  GeorgKoppen202006, TorBrowserTeam202006R   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb, ahf  |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * status:  needs_revision => needs_review
 * keywords:  tbb-mobile, tbb-rbm, GeorgKoppen202006, TorBrowserTeam202006
 => tbb-mobile, tbb-rbm, GeorgKoppen202006, TorBrowserTeam202006R


Comment:

 Replying to [comment:24 gk]:
 > This needs a small fixup at least.

 `bug_33626_v11` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_33626_v11&id=de88f1991023744cc22067c5e46e8ad78486f29c)
 has the fixup. `bug_33626_v13` (https://gitweb.torproject.org/user/gk/tor-
 browser-build.git/log/?h=bug_33626_v13) has everything rebased on latest
 `master`/`fenix_toolchain5`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33626 [Applications/Tor Browser]: Add TBB project for GeckoView

[Tor Bug Tracker & Wiki]

#33626: Add TBB project for GeckoView
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  GeorgKoppen202006, TorBrowserTeam202006|
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb, ahf  |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * keywords:  tbb-mobile, tbb-rbm, GeorgKoppen202005, TorBrowserTeam202006
 => tbb-mobile, tbb-rbm, GeorgKoppen202006, TorBrowserTeam202006


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33626 [Applications/Tor Browser]: Add TBB project for GeckoView

[Tor Bug Tracker & Wiki]

#33626: Add TBB project for GeckoView
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  GeorgKoppen202005, TorBrowserTeam202006|
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb, ahf  |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * status:  merge_ready => needs_revision
 * keywords:  tbb-mobile, tbb-rbm, GeorgKoppen202005, TorBrowserTeam202006R
 => tbb-mobile, tbb-rbm, GeorgKoppen202005, TorBrowserTeam202006


Comment:

 This needs a small fixup at least.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33626 [Applications/Tor Browser]: Add TBB project for GeckoView

[Tor Bug Tracker & Wiki]

#33626: Add TBB project for GeckoView
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  merge_ready
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb, ahf  |Sponsor:
 |  Sponsor58-must
-+-
Changes (by ahf):

 * status:  needs_review => merge_ready
 * reviewer:  sysrqb => sysrqb, ahf


Comment:

 Branch bug_33626_v11 looks good, and was reviewed as part of #33973.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33626 [Applications/Tor Browser]: Add TBB project for GeckoView

[Tor Bug Tracker & Wiki]

#33626: Add TBB project for GeckoView
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam202005, GeorgKoppen202005
 => tbb-mobile, tbb-rbm, TorBrowserTeam202005R, GeorgKoppen202005
 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:18 boklm]:
 > In projects/firefox/build:
 > {{{
 > +# We need to have the get-moz-build-date script available in the
 container
 > +# but we can't include it via input_files as it is a script shared
 between
 > +# projects.
 > +cat > get-moz-build-date << EOF
 > + [% INCLUDE get-moz-build-date %]
 > +EOF
 > +
 > }}}
 > I think the `INCLUDE` line should not be indented, as it's adding a
 space at the beginning of the file. Although it still works as we run the
 script with `perl $rootdir/get-moz-build-date` and don't use the shebang
 line.

 Good catch. I pushed a fixup commit to my `bug_33626_v10` branch and
 rebased everything onto `master`. I picked `fenix_toolchain4` as the
 toolchain branch, so that `bug_33626_v11` contains the latest toolchain
 fixes, too. `bug_33626_v11` (https://gitweb.torproject.org/user/gk/tor-
 browser-
 build.git/commit/?h=bug_33626_v11&id=a0dabf00712fbfc4d000136d19be5280cce9b82a)
 is up for further review now (again with a follow-up commit not for review
 to make everything buildable easily).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33626 [Applications/Tor Browser]: Add TBB project for GeckoView

[Tor Bug Tracker & Wiki]

#33626: Add TBB project for GeckoView
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005, GeorgKoppen202005|
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam202005R, GeorgKoppen202005
 => tbb-mobile, tbb-rbm, TorBrowserTeam202005, GeorgKoppen202005
 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33626 [Applications/Tor Browser]: Add TBB project for GeckoView

[Tor Bug Tracker & Wiki]

#33626: Add TBB project for GeckoView
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-

Comment (by boklm):

 In projects/firefox/build:
 {{{
 +# We need to have the get-moz-build-date script available in the
 container
 +# but we can't include it via input_files as it is a script shared
 between
 +# projects.
 +cat > get-moz-build-date << EOF
 + [% INCLUDE get-moz-build-date %]
 +EOF
 +
 }}}
 I think the `INCLUDE` line should not be indented, as it's adding a space
 at the beginning of the file. Although it still works as we run the script
 with `perl $rootdir/get-moz-build-date` and don't use the shebang line.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33626 [Applications/Tor Browser]: Add TBB project for GeckoView

[Tor Bug Tracker & Wiki]

#33626: Add TBB project for GeckoView
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-

Comment (by gk):

 `bug_33626_v10` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_33626_v10&id=fed284f47a25b940d3fd537ae07401b83cb59f3a)
 contains the latest fix, which did not change compared to v9. It's just
 built on top of the slightly changed toolchain in #33557.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33626 [Applications/Tor Browser]: Add TBB project for GeckoView

[Tor Bug Tracker & Wiki]

#33626: Add TBB project for GeckoView
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam202005, GeorgKoppen202005
 => tbb-mobile, tbb-rbm, TorBrowserTeam202005R, GeorgKoppen202005
 * status:  needs_revision => needs_review


Comment:

 `bug_33626_v9` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_33626_v9&id=85da134aeea5dafaa342b7a80bc3ae13f08f9879)
 has the new patch. Again, the branch contains a follow-up patch (not for
 review) which should make the result buildable, based on acat's latest
 rebase work (`33533+5`).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33626 [Applications/Tor Browser]: Add TBB project for GeckoView

[Tor Bug Tracker & Wiki]

#33626: Add TBB project for GeckoView
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005, GeorgKoppen202005|
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam202005R, GeorgKoppen202005
 => tbb-mobile, tbb-rbm, TorBrowserTeam202005, GeorgKoppen202005
 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33626 [Applications/Tor Browser]: Add TBB project for GeckoView

[Tor Bug Tracker & Wiki]

#33626: Add TBB project for GeckoView
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-

Comment (by gk):

 Replying to [comment:13 boklm]:
 > Replying to [comment:12 boklm]:
 > > Replying to [comment:10 gk]:
 > > > `bug_33626_v6` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_33626_v6&id=288efe34fbcdbc8ea69184585646440c89f5b2d1)
 contains a patch for review.
 > > >
 > > > Ideally I'd like to have the `get-moz-build-date` either in the
 `commons` project and then refer to that from the `firefox` and
 `geckoview` config file or, less ideally, just have a symlink in
 `geckoview` pointing to the script in `firefox`. I got neither of that to
 work. Maybe boklm has an idea about how to do that.
 > >
 > > What happens when you do a symlink `projects/geckoview/get-moz-build-
 date -> projects/firefox/get-moz-build-date`?
 >
 > After checking, it seems we copy symlinks as symlinks to the container,
 so this is probably why it doesn't work. But this is what we want for
 `projects/tor-browser/Bundle-Data/mac-applications.dmg/Applications`.
 Maybe we could add an option to rbm to select whether de-reference
 symlinks while copying a file from `input_files`.

 Yeah, I think that's the issue I saw. Well, I don't have strong opinions
 as to whether we should have such an option as the symlinking was the
 second best solution I could come up anyway and you gave me a promising
 candidate for the first one to try, thanks. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33626 [Applications/Tor Browser]: Add TBB project for GeckoView

[Tor Bug Tracker & Wiki]

#33626: Add TBB project for GeckoView
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-

Comment (by boklm):

 Replying to [comment:12 boklm]:
 > Replying to [comment:10 gk]:
 > > `bug_33626_v6` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_33626_v6&id=288efe34fbcdbc8ea69184585646440c89f5b2d1)
 contains a patch for review.
 > >
 > > Ideally I'd like to have the `get-moz-build-date` either in the
 `commons` project and then refer to that from the `firefox` and
 `geckoview` config file or, less ideally, just have a symlink in
 `geckoview` pointing to the script in `firefox`. I got neither of that to
 work. Maybe boklm has an idea about how to do that.
 >
 > What happens when you do a symlink `projects/geckoview/get-moz-build-
 date -> projects/firefox/get-moz-build-date`?

 After checking, it seems we copy symlinks as symlinks to the container, so
 this is probably why it doesn't work. But this is what we want for
 `projects/tor-browser/Bundle-Data/mac-applications.dmg/Applications`.
 Maybe we could add an option to rbm to select whether de-reference
 symlinks while copying a file from `input_files`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33626 [Applications/Tor Browser]: Add TBB project for GeckoView

[Tor Bug Tracker & Wiki]

#33626: Add TBB project for GeckoView
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-

Comment (by boklm):

 Replying to [comment:10 gk]:
 > `bug_33626_v6` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_33626_v6&id=288efe34fbcdbc8ea69184585646440c89f5b2d1)
 contains a patch for review.
 >
 > Ideally I'd like to have the `get-moz-build-date` either in the
 `commons` project and then refer to that from the `firefox` and
 `geckoview` config file or, less ideally, just have a symlink in
 `geckoview` pointing to the script in `firefox`. I got neither of that to
 work. Maybe boklm has an idea about how to do that.

 What happens when you do a symlink `projects/geckoview/get-moz-build-date
 -> projects/firefox/get-moz-build-date`?

 The `common` directory cannot be used for input_files (unless we change
 rbm to also look into this directory). However it can be used with
 `INCLUDE` directives in templates. So if you put `get-moz-build-date` in
 `projects/common`, you can remove it from `input_files`, and have
 something like this at the top of the `build` files:
 {{{
 cat > $rootdir/get-moz-build-date << EOF
 [% INCLUDE get-moz-build-date %]
 EOF
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33626 [Applications/Tor Browser]: Add TBB project for GeckoView

[Tor Bug Tracker & Wiki]

#33626: Add TBB project for GeckoView
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-

Comment (by gk):

 `bug_33626_v7` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_33626_v7&id=5833eb2afa543c14cccb9c847d892d2064b50e09)
 contains a better patch it fixes typos in a comment and removes the
 erroneously added `mozconfig-android-all` file.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33626 [Applications/Tor Browser]: Add TBB project for GeckoView

[Tor Bug Tracker & Wiki]

#33626: Add TBB project for GeckoView
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * cc: boklm (added)
 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam202005, GeorgKoppen202005
 => tbb-mobile, tbb-rbm, TorBrowserTeam202005R, GeorgKoppen202005
 * status:  assigned => needs_review


Comment:

 `bug_33626_v6` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_33626_v6&id=288efe34fbcdbc8ea69184585646440c89f5b2d1)
 contains a patch for review.

 Ideally I'd like to have the `get-moz-build-date` either in the `commons`
 project and then refer to that from the `firefox` and `geckoview` config
 file or, less ideally, just have a symlink in `geckoview` pointing to the
 script in `firefox`. I got neither of that to work. Maybe boklm has an
 idea about how to do that.

 I moved forward with splitting up `firefox` and moving the mobile part out
 into `geckoview`. I suspect this will at least help us during the time
 where desktop and mobile Gecko versions are not in sync. Not sure how
 useful it is in the long term, though.

 I put a patch on top of the actual patch to review containing some code
 changes that make it possible to build the per-arch .aar files in the
 first place.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33626 [Applications/Tor Browser]: Add TBB project for GeckoView

[Tor Bug Tracker & Wiki]

#33626: Add TBB project for GeckoView
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005, GeorgKoppen202005|
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * reviewer:   => sysrqb


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33626 [Applications/Tor Browser]: Add TBB project for GeckoView

[Tor Bug Tracker & Wiki]

#33626: Add TBB project for GeckoView
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005, GeorgKoppen202005|
Parent ID:  #33184   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * status:  needs_information => assigned
 * cc: sysrqb, boklm, acat (removed)
 * cc: tbb-team (added)
 * priority:  Medium => High
 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam202004 => tbb-mobile, tbb-
 rbm, TorBrowserTeam202005, GeorgKoppen202005
 * owner:  tbb-team => gk
 * type:  defect => task


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33626 [Applications/Tor Browser]: Add TBB project for GeckoView

[Tor Bug Tracker & Wiki]

#33626: Add TBB project for GeckoView
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202004   |
Parent ID:  #33184   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * keywords:  tbb-mobile, Android => tbb-mobile, tbb-rbm,
   TorBrowserTeam202004


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33626 [Applications/Tor Browser]: Add TBB project for GeckoView

[Tor Bug Tracker & Wiki]

#33626: Add TBB project for GeckoView
--+---
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, Android   |  Actual Points:
Parent ID:  #33184| Points:
 Reviewer:|Sponsor:  Sponsor58-must
--+---

Comment (by gk):

 Okay, `bug_33626_v2` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_33626_v2&id=0ecaa38cc24ee8d8d86d988eb3a02c70f2da432f)
 allows an offline build of an arch-specific `geckoview` .aar. I am working
 now on getting things set up to assemble the fat .aar we need
 (https://bugzilla.mozilla.org/show_bug.cgi?id=1563711 is a good starting
 point for seeing Mozilla's tooling around it).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33626 [Applications/Tor Browser]: Add TBB project for GeckoView

[Tor Bug Tracker & Wiki]

#33626: Add TBB project for GeckoView
--+---
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, Android   |  Actual Points:
Parent ID:  #33184| Points:
 Reviewer:|Sponsor:  Sponsor58-must
--+---

Comment (by gk):

 Replying to [comment:3 sysrqb]:
 > I expect we can simply re-use the `firefox` project, but I'll leave this
 open until we get that working.

 I've thought a bit more about it. I think it's worthwhile creating an own
 project for geckoview, at least for two reasons:

 1) It's conceptually easier as we don't build an app anymore, let alone
 firefox. We just build the .aar we then need in other projects

 2) I expect having an own project will help us in the time when we run
 desktop ESR and regular release for mobile. It can get easily complex when
 dealing with different nightly branches and release branches in a single
 project. And putting different logic into one build script to handle
 different artifact types adds to that complexity, too.

 I feel a bit more boilerplate by having separate projects is a trade-off
 worth doing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33626 [Applications/Tor Browser]: Add TBB project for GeckoView

[Tor Bug Tracker & Wiki]

#33626: Add TBB project for GeckoView
--+---
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, Android   |  Actual Points:
Parent ID:  #33184| Points:
 Reviewer:|Sponsor:  Sponsor58-must
--+---
Changes (by sysrqb):

 * status:  new => needs_information


Comment:

 I expect we can simply re-use the `firefox` project, but I'll leave this
 open until we get that working.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33626 [Applications/Tor Browser]: Add TBB project for GeckoView

[Tor Bug Tracker & Wiki]

#33626: Add TBB project for GeckoView
--+
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, Android   |  Actual Points:
Parent ID:  #33184| Points:
 Reviewer:|Sponsor:  Sponsor58-must
--+
Changes (by sisbell):

 * cc: acat (added)


Comment:

 I'm working off of this branch

 https://github.com/acatarineu/tor-browser/commits/33533+2

 I get various errors around config options in the 'mach build'


 {{{
 mozbuild.configure.ConfigureError: `MOZ_ANDROID_DOWNLOAD_CONTENT_SERVICE`,
 emitted from `/var/tmp/build/firefox-
 997e76c0a91b/mobile/android/torbrowser.configure` line 13,
 }}}

 OR

 {{{
  0:01.14 mozbuild.configure.options.InvalidOptionError: Unknown option:
 --disable-signmar
 }}}

 It looks like we still need patches for AppConfig. I'm working through
 these issues to decide which we need (geckoview specific) and which ones
 would go to the latest fenix app.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33626 [Applications/Tor Browser]: Add TBB project for GeckoView

[Tor Bug Tracker & Wiki]

#33626: Add TBB project for GeckoView
--+
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-mobile,
  |  Android
Actual Points:|  Parent ID:  #33184
   Points:|   Reviewer:
  Sponsor:|
--+
 Fenix and android-components have dependencies on GeckoView. Need to setup
 environment to build this for production, beta and nightly. Involves rust
 and clang setup.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs