Re: [tor-bugs] #33667 [Applications/Tor Browser]: TorBrowser installer bungles permissions when umask is set

2020-03-23 Thread Tor Bug Tracker & Wiki 
#33667: TorBrowser installer bungles permissions when umask is set
--+--
 Reporter:  sdavids   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:  Tor: unspecified
 Severity:  Major | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by mcs):

 I did not follow the steps to reproduce this problem, but it does look
 like permissions changed between Tor Browser 9.0.4 and 9.0.5.

 After mounting TorBrowser-9.0.4-osx64_en-US:
 {{{
 % ls -l Tor\ Browser/Tor\ Browser.app/Contents/MacOS/
 total 210364
 drwxr-xr-x  3 USER  staff   2048 Jan  9 06:44 Tor/
 -rwxr-xr-x  1 USER  staff  100724160 Jan  9 05:08 XUL*
 -rwxr-xr-x  1 USER  staff  36128 Jan  9 05:08 firefox*
 ...
 }}}

 After mounting TorBrowser-9.0.5-osx64_en-US:
 {{{
 ls -l Tor\ Browser/Tor\ Browser.app/Contents/MacOS/
 total 210380
 drwxr-x---  3 USER  staff   2048 Feb 11 11:18 Tor/
 -rwxr-x---  1 USER  staff  100732448 Feb 10 16:43 XUL*
 -rwxr-x---  1 USER  staff  36128 Feb 10 16:43 firefox*
 ...
 }}}

 I am not sure what caused this change though. The fix for #33200 only
 changed the permissions for `bookmarks.html`.

 boklm or sysrqb, any ideas?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33667 [Applications/Tor Browser]: TorBrowser installer bungles permissions when umask is set

2020-03-19 Thread Tor Bug Tracker & Wiki 
#33667: TorBrowser installer bungles permissions when umask is set
--+--
 Reporter:  sdavids   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:  Tor: unspecified
 Severity:  Major | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by sdavids):

 The permissions are correct according to the umask but the installer
 should have ensured the application is usable by all.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33667 [Applications/Tor Browser]: TorBrowser installer bungles permissions when umask is set

2020-03-19 Thread Tor Bug Tracker & Wiki 
#33667: TorBrowser installer bungles permissions when umask is set
--+--
 Reporter:  sdavids   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Component:  Applications/Tor Browser
  Version:  Tor: unspecified  |   Severity:  Major
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
 !TorBrowser-9.0.6-osx64_en-US

 Previous versions worked OK.

 As a sudoer:

 Execute

 {{{
 # visudo
 }}}
 Add

 {{{
 Defaults        umask = 0022

 Defaults        umask_override
 }}}
 Save

 Execute

 {{{
 # sudo launchctl config user umask 002
 }}}
 Reboot

 
 As a user:

 Add to .zshrc / .bashrc

 {{{
 umask 077
 }}}
 
 References:

 https://support.apple.com/en-us/HT201684

 https://superuser.com/questions/79914/how-do-i-tell-sudo-to-write-files-
 with-a-umask-of-0022

 
 Permissions after installation via !TorBrowser-9.0.6-osx64_en-US.dmg:

 {{{
 # tree -p /Applications/Tor\ Browser.app

 /Applications/Tor\ Browser.app

 └── [drwxr-x---] Contents

 ├── [-rw-r-] CodeResources

 ├── [-rw-r-] Info.plist

 ├── [drwxr-x---] MacOS

 │ ├── [drwxr-x---] Tor

 │ │ ├── [drwxr-x---] PluggableTransports

 │ │ │ └── [-rwxr-x---] obfs4proxy

 │ │ ├── [-rwxr-x---] libevent-2.1.6.dylib

 │ │ └── [-rwxr-x---] tor.real

 │ ├── [-rwxr-x---] XUL

 │ ├── [-rwxr-x---] firefox

 │ ├── [-rwxr-x---] libfreebl3.dylib

 │ ├── [-rwxr-x---] liblgpllibs.dylib

 │ ├── [-rwxr-x---] libmozavcodec.dylib

 │ ├── [-rwxr-x---] libmozavutil.dylib

 │ ├── [-rwxr-x---] libmozglue.dylib

 │ ├── [-rwxr-x---] libnss3.dylib

 │ ├── [-rwxr-x---] libnssckbi.dylib

 │ ├── [-rwxr-x---] libnssdbm3.dylib

 │ ├── [-rwxr-x---] libplugin_child_interpose.dylib

 │ ├── [-rwxr-x---] libsoftokn3.dylib

 │ ├── [drwxr-x---] plugin-container.app

 │ │ └── [drwxr-x---] Contents

 │ │ ├── [-rw-r-] Info.plist

 │ │ ├── [drwxr-x---] MacOS

 │ │ │ └── [-rwxr-x---] plugin-container

 │ │ ├── [-rw-r-] PkgInfo

 │ │ ├── [drwxr-x---] Resources

 │ │ │ └── [drwxr-x---] English.lproj

 │ │ │ └── [-rw-r-] InfoPlist.strings

 │ │ └── [drwxr-x---] _CodeSignature

 │ │ └── [-rw-r-] CodeResources

 │ └── [drwxr-x---] updater.app

 │ └── [drwxr-x---] Contents

 │ ├── [-rw-r-] Info.plist

 │ ├── [drwxr-x---] MacOS

 │ │ └── [-rwxr-x---] org.mozilla.updater

 │ ├── [-rw-r-] PkgInfo

 │ ├── [drwxr-x---] Resources

 │ │ ├── [drwxr-x---] English.lproj

 │ │ │ ├── [-rw-r-] InfoPlist.strings

 │ │ │ └── [drwxr-x---] MainMenu.nib

 │ │ │ ├── [-rw-r-] classes.nib

 │ │ │ ├── [-rw-r-] info.nib

 │ │ │ └── [-rw-r-] keyedobjects.nib

 │ │ └── [-rw-r-] updater.icns

 │ └── [drwxr-x---] _CodeSignature

 │ └── [-rw-r-] CodeResources

 ├── [-rw-r-] PkgInfo

 ├── [drwxr-x---] Resources

 │ ├── [drwxr-x---] TorBrowser

 │ │ ├── [drwxr-x---] Docs

 │ │ │ ├── [-rw-r-] ChangeLog.txt

 │ │ │ └── [drwxr-x---] Licenses

 │ │ │ ├── [-rw-r-] Firefox.txt

 │ │ │ ├── [-rw-r-] HTTPS-Everywhere.txt

 │ │ │ ├── [-rw-r-] NoScript.txt

 │ │ │ ├── [-rw-r-] Noto-CJK-Font.txt

 │ │ │ ├── [-rw-r-] Noto-Fonts.txt

 │ │ │ ├── [drwxr-x---] PluggableTransports

 │ │ │ │ ├── [-rw-r-] LICENSE

 │ │ │ │ ├── [-rw-r-] LICENSE.CC0

 │ │ │ │ └── [-rw-r-] LICENSE.GO

 │ │ │ ├── [-rw-r-] Tor-Launcher.txt

 │ │ │ ├── [-rw-r-] Tor.txt

 │ │ │ └── [-rw-r-] Torbutton.txt

 │ │ └── [drwxr-x---] Tor

 │ │ ├── [-rw-r-] geoip

 │ │ ├── [-rw-r-] geoip6

 │ │ ├── [-rwxr-x---] tor

 │ │ └── [-rw-r-] torrc-defaults

 │ ├── [-rw-r-] application.ini

 │ ├── [drwxr-x---] browser

 │ │ ├── [-rw-r-] blocklist.xml

 │ │ ├── [-rw-r-] chrome.manifest

 │ │ ├── [drwxr-x---] features

 │ │ │ └── [-rw-r-] onboard...@mozilla.org.xpi

 │ │ ├── [-rw-r-] omni.ja

 │ │ └── [-rw-r-] override.ini

 │ ├── [-rw-r-] chrome.manifest

 │ ├── [drwxr-x---] defaults

 │ │ └── [drwxr-x---] pref

 │ │ └── [-rw-r-] channel-prefs.js

 │ ├── [-rw-r-] dependentlibs.list

 │ ├── [drwxr-x---] distribution

 │ │ └── [drwxr-x---] extensions

 │ │ ├── [-rw-r-] https-everywhere-...@eff.org.xpi

 │ │ └── [-rw-r-] {73a6fe31-595d-460b-a920-fcc0f8843232}.xpi

 │ ├── [-rw-r-] document.icns

 │ ├── [drwxr-x---] en.lproj

 │ │ └── [-rw-r-] InfoPlist.strings

 │ ├── [-rw-r-] firefox.icns

 │ ├── [drwxr-x---] fonts

 │ │ ├── [-rw-r-] NotoSansArmenian-Regular.ttf

 │ │ ├── [-rw-r-] NotoSansBengali-Regular.ttf

 │ │ ├── [-rw-r-] NotoSansBuginese-Regular.ttf

 │ │ ├── [-rw-r-] NotoSansCanadianAboriginal-Regular.ttf

 │ │ ├── [-rw-r-] NotoSansCherokee-Regular.ttf

 │ │ ├── [-rw-r-] NotoSansDevanagari-Regular.ttf

 │ │ ├── [-rw-r-] NotoSansEthiopic-Regular.ttf

 │ │ ├── [-rw-r-]