Re: [tor-bugs] #33761 [Circumvention/Snowflake]: Remove unnecessary dependencies of Snowflake from Tor Browser

[Tor Bug Tracker & Wiki]

#33761: Remove unnecessary dependencies of Snowflake from Tor Browser
-+-
 Reporter:  cohosh   |  Owner:  (none)
 Type:  task | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by dcf):

 * status:  needs_review => merge_ready


Comment:

 It looks good to me. Thanks for undertaking to check with a Tor Browser
 build.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33761 [Circumvention/Snowflake]: Remove unnecessary dependencies of Snowflake from Tor Browser

[Tor Bug Tracker & Wiki]

#33761: Remove unnecessary dependencies of Snowflake from Tor Browser
-+--
 Reporter:  cohosh   |  Owner:  (none)
 Type:  task | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+--
Changes (by cohosh):

 * status:  new => needs_review


Comment:

 You were right, we don't even need to patch the source.

 Here's a patch that removes 11 unnecessary projects from tor browser:
 https://gitweb.torproject.org/user/cohosh/tor-browser-
 build.git/commit/?h=ticket/33761=515c2eb30db1ee37f39ac8126f948d4b244a11cc

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33761 [Circumvention/Snowflake]: Remove unnecessary dependencies of Snowflake from Tor Browser

[Tor Bug Tracker & Wiki]

#33761: Remove unnecessary dependencies of Snowflake from Tor Browser
-+
 Reporter:  cohosh   |  Owner:  (none)
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+

Comment (by cohosh):

 Replying to [comment:1 dcf]:
 > Is it necessary to patch the source? Or could we just remove the
 dependencies from projects/pion-webrtc/config and delete the projects? It
 seems to me that the quic parts of pion-webrtc are not built by default;
 all the involved files have a `+build quic`
 [https://golang.org/pkg/go/build/#hdr-Build_Constraints build constraint].
 In the [https://github.com/pion/webrtc/blob/v2.2.0/.travis.yml#L53
 upstream CI] they have to specifically pass `-tags quic` to `go build`.
 Thanks for pointing this out. I've started a Tor Browser build to test
 this.
 > On the other hand, if in #28325 the Tor Browser team starts using go.mod
 files directly for dependency tracking (as we are kind of currently doing
 with the gomodtorbm script), then it makes sense to patch the source and
 get a new go.mod, as you've done.
 Interestingly, even this didn't remove all the dependencies it could have
 from go.sum.
 > What tor-browser-build projects does it allow to be removed? My
 reckoning from a quick grep is pion-quic, quic-go, genny, ginkgo, gomega,
 gomock, qtls.
 Looks like 10 projects, at least:
 genny, ginkgo, gofsnotify, gomega, gotail, gotomb, goxtools, pion-quic,
 quic-go, qtls

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33761 [Circumvention/Snowflake]: Remove unnecessary dependencies of Snowflake from Tor Browser

[Tor Bug Tracker & Wiki]

#33761: Remove unnecessary dependencies of Snowflake from Tor Browser
-+
 Reporter:  cohosh   |  Owner:  (none)
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+

Comment (by dcf):

 By the way thanks for tracking this down.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33761 [Circumvention/Snowflake]: Remove unnecessary dependencies of Snowflake from Tor Browser

[Tor Bug Tracker & Wiki]

#33761: Remove unnecessary dependencies of Snowflake from Tor Browser
-+
 Reporter:  cohosh   |  Owner:  (none)
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+

Comment (by dcf):

 Is it necessary to patch the source? Or could we just remove the
 dependencies from projects/pion-webrtc/config and delete the projects? It
 seems to me that the quic parts of pion-webrtc are not built by default;
 all the involved files have a `+build quic`
 [https://golang.org/pkg/go/build/#hdr-Build_Constraints build constraint].
 In the [https://github.com/pion/webrtc/blob/v2.2.0/.travis.yml#L53
 upstream CI] they have to specifically pass `-tags quic` to `go build`.

 On the other hand, if in #28325 the Tor Browser team starts using go.mod
 files directly for dependency tracking (as we are kind of currently doing
 with the gomodtorbm script), then it makes sense to patch the source and
 get a new go.mod, as you've done.

 What tor-browser-build projects does it allow to be removed? My reckoning
 from a quick grep is pion-quic, quic-go, genny, ginkgo, gomega, gomock,
 qtls.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33761 [Circumvention/Snowflake]: Remove unnecessary dependencies of Snowflake from Tor Browser

[Tor Bug Tracker & Wiki]

#33761: Remove unnecessary dependencies of Snowflake from Tor Browser
-+
 Reporter:  cohosh   |  Owner:  (none)
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+
Changes (by cohosh):

 * Attachment "0001-Disable-experimental-quic-features-of-ORTC.patch"
 added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33761 [Circumvention/Snowflake]: Remove unnecessary dependencies of Snowflake from Tor Browser

[Tor Bug Tracker & Wiki]

#33761: Remove unnecessary dependencies of Snowflake from Tor Browser
-+
 Reporter:  cohosh   |  Owner:  (none)
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:  1|   Reviewer:
  Sponsor:   |
-+
 pion/webrtc brings in a lot of dependencies for Tor Browser, and many of
 these are for unused features. Specifically, we never use pion/quic, and
 its dependency on quic-go has the potential to cause us a lot of headache
 in the future (see #33745).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs