Re: [tor-bugs] #33778 [Core Tor/Tor]: TestingTorNetwork options in the man page are out of date

[Tor Bug Tracker & Wiki]

#33778: TestingTorNetwork options in the man page are out of date
--+
 Reporter:  opara |  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  doc   |  Actual Points:
Parent ID:| Points:
 Reviewer:  asn   |Sponsor:
--+
Changes (by asn):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Merged! Thanks a lot!

 I agree with teor that there are more things to be desired. I'll close
 this ticket for now, but if people think we should do more, feel free to
 open tickets for those tasks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33778 [Core Tor/Tor]: TestingTorNetwork options in the man page are out of date

[Tor Bug Tracker & Wiki]

#33778: TestingTorNetwork options in the man page are out of date
--+
 Reporter:  opara |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  doc   |  Actual Points:
Parent ID:| Points:
 Reviewer:  asn   |Sponsor:
--+
Changes (by dgoulet):

 * reviewer:   => asn


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33778 [Core Tor/Tor]: TestingTorNetwork options in the man page are out of date

[Tor Bug Tracker & Wiki]

#33778: TestingTorNetwork options in the man page are out of date
--+
 Reporter:  opara |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  doc   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * keywords:   => doc
 * status:  new => needs_review
 * milestone:   => Tor: 0.4.4.x-final


Comment:

 > Since these are all of type INTERVAL, is there a reason why these units
 are different when all of them support any unit in unitparse.c (seconds,
 minutes, hours, days, weeks)? One reason could be that some options have
 lower bounds (for example V3AuthVotingInterval must be greater than 300
 seconds which is of the order of minutes), but the user can just specify
 300 seconds rather than 5 minutes.

 I think that's the reason, but it hasn't been done consistently.

 Maybe it's worth putting the minimum and maximum values in the man page?
 Maybe it's not, they would just get out of date :-)

 Maybe it's worth consistently documenting all the INTERVAL options in the
 man page?

 In any case, those tasks can be done in other tickets.

 I'll let the reviewer decide what they want to do with the current set of
 changes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33778 [Core Tor/Tor]: TestingTorNetwork options in the man page are out of date

[Tor Bug Tracker & Wiki]

#33778: TestingTorNetwork options in the man page are out of date
--+
 Reporter:  opara |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by opara):

 https://github.com/torproject/tor/pull/1850

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33778 [Core Tor/Tor]: TestingTorNetwork options in the man page are out of date

[Tor Bug Tracker & Wiki]

#33778: TestingTorNetwork options in the man page are out of date
+--
 Reporter:  opara   |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Component:  Core Tor/Tor
  Version:  |   Severity:  Normal
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
 A few of the values under {{{TestingTorNetwork}}} in {{{doc/tor.1.txt}}}
 are out of date compared to the options in
 {{{src/app/config/testnet.inc}}}. Also, some of the units listed for
 options only state 'minutes|hours' when they actually support 'seconds' as
 well. I only fixed the ones that were relevant to {{{TestingTorNetwork}}},
 but there are probably others as well. Will add a PR shortly.

 In addition, many of the options that are of type {{{INTERVAL}}} use
 different units in the man page. For example:
 {{{
 ShutdownWaitLength NUM
 V3AuthVotingInterval N minutes|hours
 TestingV3AuthVotingStartOffset N seconds|minutes|hours
 DormantClientTimeout N minutes|hours|days|weeks
 }}}

 Since these are all of type {{{INTERVAL}}}, is there a reason why these
 units are different when all of them support any unit in {{{unitparse.c}}}
 (seconds, minutes, hours, days, weeks)? One reason could be that some
 options have lower bounds (for example {{{V3AuthVotingInterval}}} must be
 greater than 300 seconds which is of the order of minutes), but the user
 can just specify 300 seconds rather than 5 minutes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs