Re: [tor-bugs] #33804 [Core Tor/Tor]: Defer "PreferIPv6 by default" to 0.4.4

2020-04-08 Thread Tor Bug Tracker & Wiki
#33804: Defer "PreferIPv6 by default" to 0.4.4
+--
 Reporter:  teor|  Owner:  dgoulet
 Type:  defect  | Status:  closed
 Priority:  Very High   |  Milestone:  Tor:
|  0.4.3.x-final
Component:  Core Tor/Tor|Version:  Tor:
|  0.4.3.1-alpha
 Severity:  Normal  | Resolution:  fixed
 Keywords:  tor-dns torsocks ipv6 043-must  |  Actual Points:  0.1
Parent ID:  #33796  | Points:  0.1
 Reviewer:  teor|Sponsor:
+--
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Also fixed a typo (IPv4 -> IPv6).

 Merged to 0.4.3 only, "ours" merge to master, skipping the changes in this
 PR.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33804 [Core Tor/Tor]: Defer "PreferIPv6 by default" to 0.4.4

2020-04-08 Thread Tor Bug Tracker & Wiki
#33804: Defer "PreferIPv6 by default" to 0.4.4
+--
 Reporter:  teor|  Owner:  dgoulet
 Type:  defect  | Status:  merge_ready
 Priority:  Very High   |  Milestone:  Tor:
|  0.4.3.x-final
Component:  Core Tor/Tor|Version:  Tor:
|  0.4.3.1-alpha
 Severity:  Normal  | Resolution:
 Keywords:  tor-dns torsocks ipv6 043-must  |  Actual Points:  0.1
Parent ID:  #33796  | Points:  0.1
 Reviewer:  teor|Sponsor:
+--

Comment (by dgoulet):

 Replying to [comment:3 teor]:
 > We could make a minor tweak to the man page, to say "PreferIPv6" (rather
 than "NoPreferIPv6"). But I don't think it matters that much.

 I've pushed that fixup.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33804 [Core Tor/Tor]: Defer "PreferIPv6 by default" to 0.4.4

2020-04-07 Thread Tor Bug Tracker & Wiki
#33804: Defer "PreferIPv6 by default" to 0.4.4
+--
 Reporter:  teor|  Owner:  dgoulet
 Type:  defect  | Status:  merge_ready
 Priority:  Very High   |  Milestone:  Tor:
|  0.4.3.x-final
Component:  Core Tor/Tor|Version:  Tor:
|  0.4.3.1-alpha
 Severity:  Normal  | Resolution:
 Keywords:  tor-dns torsocks ipv6 043-must  |  Actual Points:  0.1
Parent ID:  #33796  | Points:  0.1
 Reviewer:  teor|Sponsor:
+--
Changes (by teor):

 * status:  needs_review => merge_ready
 * actualpoints:   => 0.1


Comment:

 Looks good! Thanks.

 Let's merge to **0.4.3 only**, after CI passes.

 We could make a minor tweak to the man page, to say "PreferIPv6" (rather
 than "NoPreferIPv6"). But I don't think it matters that much.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33804 [Core Tor/Tor]: Defer "PreferIPv6 by default" to 0.4.4

2020-04-07 Thread Tor Bug Tracker & Wiki
#33804: Defer "PreferIPv6 by default" to 0.4.4
+--
 Reporter:  teor|  Owner:  dgoulet
 Type:  defect  | Status:  needs_review
 Priority:  Very High   |  Milestone:  Tor:
|  0.4.3.x-final
Component:  Core Tor/Tor|Version:  Tor:
|  0.4.3.1-alpha
 Severity:  Normal  | Resolution:
 Keywords:  tor-dns torsocks ipv6 043-must  |  Actual Points:
Parent ID:  #33796  | Points:  0.1
 Reviewer:  teor|Sponsor:
+--
Changes (by dgoulet):

 * status:  assigned => needs_review


Comment:

 Branch: `ticket33804_043_01`
 PR: https://github.com/torproject/tor/pull/1854

 **To be clear, this should be merged in 043 __ONLY__**

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33804 [Core Tor/Tor]: Defer "PreferIPv6 by default" to 0.4.4

2020-04-06 Thread Tor Bug Tracker & Wiki
#33804: Defer "PreferIPv6 by default" to 0.4.4
+--
 Reporter:  teor|  Owner:  dgoulet
 Type:  defect  | Status:  assigned
 Priority:  Very High   |  Milestone:  Tor:
|  0.4.3.x-final
Component:  Core Tor/Tor|Version:  Tor:
|  0.4.3.1-alpha
 Severity:  Normal  | Resolution:
 Keywords:  tor-dns torsocks ipv6 043-must  |  Actual Points:
Parent ID:  #33796  | Points:  0.1
 Reviewer:  teor|Sponsor:
+--
Changes (by nickm):

 * priority:  Medium => Very High


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33804 [Core Tor/Tor]: Defer "PreferIPv6 by default" to 0.4.4

2020-04-03 Thread Tor Bug Tracker & Wiki
#33804: Defer "PreferIPv6 by default" to 0.4.4
--+
 Reporter:  teor  |  Owner:  dgoulet
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.4.3.1-alpha
 Severity:  Normal|   Keywords:  tor-dns torsocks ipv6 043-must
Actual Points:|  Parent ID:  #33796
   Points:  0.1   |   Reviewer:  teor
  Sponsor:|
--+
 In #32637, we made clients default to "PreferIPv6" on SOCKSPorts (and
 other client ports).

 But in #33796, we discovered that this change broke torsocks.

 We want to defer this change to 0.4.4, so tor can implement IPv4-only and
 IPv6-only resolves for torsocks.

 Since #32637, we have also merged:
 * #33608, which removes a forced PreferIPv6 for non-SOCKSPorts
 * #32994, which puts the PreferIPv6 default in port_parse_config(), rather
 than in 2 different places in the code

 So it should be very easy to change the default for PreferIPv6.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs