Re: [tor-bugs] #33807 [Applications/Tor Browser]: Namecoin eTLD patch conflicted with securedrop.tor.onion

2020-04-06 Thread Tor Bug Tracker & Wiki 
#33807: Namecoin eTLD patch conflicted with securedrop.tor.onion
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  TorBrowserTeam202004R |  Actual Points:
Parent ID:| Points:
 Reviewer:  sysrqb|Sponsor:
--+--
Changes (by sysrqb):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 The additional index information for
 `mobile/android/app/src/main/assets/publicsuffixlist` is unfortunate
 {{{
 -index 7f834b1..6874b40 100644
 +index 7f834b1a89bd..6874b4005ae3 100644
 }}}

 But I merge it with commit `5a2948b7195d1daa2b73b3cef2ed5507a922a76e`.

 Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33807 [Applications/Tor Browser]: Namecoin eTLD patch conflicted with securedrop.tor.onion

2020-04-06 Thread Tor Bug Tracker & Wiki 
#33807: Namecoin eTLD patch conflicted with securedrop.tor.onion
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202004R |  Actual Points:
Parent ID:| Points:
 Reviewer:  sysrqb|Sponsor:
--+--
Changes (by pili):

 * reviewer:   => sysrqb


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33807 [Applications/Tor Browser]: Namecoin eTLD patch conflicted with securedrop.tor.onion

2020-04-05 Thread Tor Bug Tracker & Wiki 
#33807: Namecoin eTLD patch conflicted with securedrop.tor.onion
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202004R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by boklm):

 `bug_33807_v2` has the patch rebased on master:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_33807_v2=65a1aca6a618016afd97ec4b956ba58014db9051

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33807 [Applications/Tor Browser]: Namecoin eTLD patch conflicted with securedrop.tor.onion

2020-04-05 Thread Tor Bug Tracker & Wiki 
#33807: Namecoin eTLD patch conflicted with securedrop.tor.onion
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202004R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by boklm):

 * cc: JeremyRand (added)
 * keywords:  TorBrowserTeam202004 => TorBrowserTeam202004R
 * status:  new => needs_review


Comment:

 There is a patch for review in branch `bug_33807`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_33807=fa0331901c1419c5a90dc33ac8e2942442cc61de

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33807 [Applications/Tor Browser]: Namecoin eTLD patch conflicted with securedrop.tor.onion

2020-04-04 Thread Tor Bug Tracker & Wiki 
#33807: Namecoin eTLD patch conflicted with securedrop.tor.onion
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202004  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * cc: gk (added)
 * priority:  Medium => High


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33807 [Applications/Tor Browser]: Namecoin eTLD patch conflicted with securedrop.tor.onion

2020-04-03 Thread Tor Bug Tracker & Wiki 
#33807: Namecoin eTLD patch conflicted with securedrop.tor.onion
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202004  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by sysrqb):

 {{{
 diff --git a/projects/firefox/namecoin-etld.patch b/projects/firefox
 /namecoin-etld.patch
 index 4a97f997..743df581 100644
 --- a/projects/firefox/namecoin-etld.patch
 +++ b/projects/firefox/namecoin-etld.patch
 @@ -16,9 +16,9 @@ index 9dd962a..3402b20 100644
  --- a/netwerk/dns/effective_tld_names.dat
  +++ b/netwerk/dns/effective_tld_names.dat
  @@ -5480,6 +5480,7 @@ pro.om
 -
 - // onion : https://tools.ietf.org/html/rfc7686
   onion
 + tor.onion
 + securedrop.tor.onion
  +bit.onion

   // org : https://en.wikipedia.org/wiki/.org
 }}}

 For reference. I'll create the patch later.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33807 [Applications/Tor Browser]: Namecoin eTLD patch conflicted with securedrop.tor.onion

2020-04-03 Thread Tor Bug Tracker & Wiki 
#33807: Namecoin eTLD patch conflicted with securedrop.tor.onion
--+
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
  |  TorBrowserTeam202004
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 {{{
 /tmp/tmp.EB97rs4a6X/z /var/tmp/dist/firefox
 /var/tmp/dist/firefox
 Starting build: Fri Apr  3 08:07:15 2020
 /var/tmp/dist/gcc/bin ~
 ~
 patching file mobile/android/app/src/main/assets/publicsuffixlist
 patching file netwerk/dns/effective_tld_names.dat
 Hunk #1 FAILED at 5480.
 1 out of 1 hunk FAILED -- saving rejects to file
 netwerk/dns/effective_tld_names.dat.rej
 }}}

 where the namecoin eTLD patch (`projects/firefox/namecoin-etld.patch`)
 does:
 {{{
 diff --git a/netwerk/dns/effective_tld_names.dat
 b/netwerk/dns/effective_tld_names.dat
 index 9dd962a..3402b20 100644
 --- a/netwerk/dns/effective_tld_names.dat
 +++ b/netwerk/dns/effective_tld_names.dat
 @@ -5480,6 +5480,7 @@ pro.om

  // onion : https://tools.ietf.org/html/rfc7686
  onion
 +bit.onion

  // org : https://en.wikipedia.org/wiki/.org
  org
 }}}

 It's an easy fix.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs