Re: [tor-bugs] #33831 [Core Tor/sbws]: Relays without descriptors are not scaled, but still added to the bwlines without vote=0

2020-05-18 Thread Tor Bug Tracker & Wiki
#33831: Relays without descriptors are not scaled, but still added to the 
bwlines
without vote=0
-+---
 Reporter:  juga |  Owner:  juga
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  sbws: 1.1.x-final
Component:  Core Tor/sbws|Version:  sbws: 1.1.0
 Severity:  Normal   | Resolution:
 Keywords:  sbws-roadmap, intro  |  Actual Points:
Parent ID:  #33121   | Points:  1
 Reviewer:   |Sponsor:
-+---
Changes (by gk):

 * owner:  gk => juga
 * keywords:  sbws-roadmap, intro, GeorgKoppen202005 => sbws-roadmap, intro


Comment:

 Replying to [comment:5 juga]:
 > I think i'm going to need to change the logic on what to do when there
 is not descriptor observed bandwidth nor consensus bandwidth for #33871,
 so i think i'll implement this as part of that ticket.
 > No need then to work on this ticket for now.

 Works for me. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33831 [Core Tor/sbws]: Relays without descriptors are not scaled, but still added to the bwlines without vote=0

2020-05-17 Thread Tor Bug Tracker & Wiki
#33831: Relays without descriptors are not scaled, but still added to the 
bwlines
without vote=0
-+-
 Reporter:  juga |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  sbws:
 |  1.1.x-final
Component:  Core Tor/sbws|Version:  sbws:
 |  1.1.0
 Severity:  Normal   | Resolution:
 Keywords:  sbws-roadmap, intro, |  Actual Points:
  GeorgKoppen202005  |
Parent ID:  #33121   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by juga):

 I think i'm going to need to change the logic on what to do when there is
 not descriptor observed bandwidth nor consensus bandwidth for #33871, so i
 think i'll implement this as part of that ticket.
 No need then to work on this ticket for now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33831 [Core Tor/sbws]: Relays without descriptors are not scaled, but still added to the bwlines without vote=0

2020-04-14 Thread Tor Bug Tracker & Wiki
#33831: Relays without descriptors are not scaled, but still added to the 
bwlines
without vote=0
-+-
 Reporter:  juga |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  sbws:
 |  1.1.x-final
Component:  Core Tor/sbws|Version:  sbws:
 |  1.1.0
 Severity:  Normal   | Resolution:
 Keywords:  sbws-roadmap, intro, |  Actual Points:
  GeorgKoppen202004  |
Parent ID:  #33121   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  sbws-roadmap, intro => sbws-roadmap, intro, GeorgKoppen202004
 * owner:  (none) => gk
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33831 [Core Tor/sbws]: Relays without descriptors are not scaled, but still added to the bwlines without vote=0

2020-04-10 Thread Tor Bug Tracker & Wiki
#33831: Relays without descriptors are not scaled, but still added to the 
bwlines
without vote=0
-+---
 Reporter:  juga |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  sbws: 1.1.x-final
Component:  Core Tor/sbws|Version:  sbws: 1.1.0
 Severity:  Normal   | Resolution:
 Keywords:  sbws-roadmap, intro  |  Actual Points:
Parent ID:  #33121   | Points:  1
 Reviewer:   |Sponsor:
-+---

Comment (by juga):

 What i'd do is to check whether there're descriptor bandwidth values in
 https://gitlab.torproject.org/torproject/network-
 health/sbws/-/blob/maint-1.1/sbws/lib/v3bwfile.py#L775 and if not, add
 something like:
 {{{
 kwargs['vote'] = 0
 kwargs['unmeasured'] = 1
 return (cls(node_id, 1, **kwargs), "no descriptors")
 }}
 without adding a new KeyValue to the header.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33831 [Core Tor/sbws]: Relays without descriptors are not scaled, but still added to the bwlines without vote=0

2020-04-08 Thread Tor Bug Tracker & Wiki
#33831: Relays without descriptors are not scaled, but still added to the 
bwlines
without vote=0
-+---
 Reporter:  juga |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  sbws: 1.1.x-final
Component:  Core Tor/sbws|Version:  sbws: 1.1.0
 Severity:  Normal   | Resolution:
 Keywords:  sbws-roadmap, intro  |  Actual Points:
Parent ID:  #33121   | Points:  1
 Reviewer:   |Sponsor:
-+---
Changes (by juga):

 * keywords:  sbws-roadmap => sbws-roadmap, intro


Comment:

 In principle, this is an easy change, but because vote=0 occurs in one
 part of the code and the scaling where the relays are discarded in other,
 might be a bit tricky (yup, a big refactor would be great at some point).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33831 [Core Tor/sbws]: Relays without descriptors are not scaled, but still added to the bwlines without vote=0

2020-04-06 Thread Tor Bug Tracker & Wiki
#33831: Relays without descriptors are not scaled, but still added to the 
bwlines
without vote=0
---+---
 Reporter:  juga   |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  sbws: 1.1.x-final
Component:  Core Tor/sbws  |Version:  sbws: 1.1.0
 Severity:  Normal |   Keywords:  sbws-roadmap
Actual Points: |  Parent ID:  #33121
   Points:  1  |   Reviewer:
  Sponsor: |
---+---
 As can be seen in:
 
https://gitweb.torproject.org/sbws.git/tree/sbws/lib/v3bwfile.py?h=maint-1.1#n1317

 As a result, some relays (in sample data  counted ~800) are included in
 the bandwidth file without its bandwidth scaled, which could be quite
 different (higher or lower) than the scaled bandwidth.

 This is one of the several reasons of #33775.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs