Re: [tor-bugs] #33832 [Core Tor/sbws]: For relays that change ip, only the measurements with the last ip are kept

[Tor Bug Tracker & Wiki]

#33832: For relays that change ip, only the measurements with the last ip are 
kept
-+-
 Reporter:  juga |  Owner:  gk
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  sbws:
 |  1.1.x-final
Component:  Core Tor/sbws|Version:  sbws:
 |  1.1.0
 Severity:  Normal   | Resolution:
 Keywords:  sbws-roadmap, intro, |  Actual Points:
  GeorgKoppen202004  |
Parent ID:  #33121   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:8 juga]:
 > Replying to [comment:6 gk] and [comment:7 arma]:
 >
 > i'm replying to both of you, last comments.
 >
 > So, my first thought was, yeah, the relay is the same, it's probably
 changing IP cause of having dynamic IP address, so we should keep the
 recent measurements with a different IP.
 >
 > Then, i thought, what if the relay changes IP cause it changes physical
 location? (while keeping the keys/configuration), in that case the
 measurements could actually be quite different and the previous ones would
 not make sense.
 >
 > So we have at least 2 cases in which a relay might change IP and think
 the first one is the more common one.
 >
 > I don't know what's was the initial thought to implement this, i also
 didn't find i in the git log or tickets.
 >
 > I realize now that we don't need to change the code, we can just change
 the default configuration to set `reset_bw_ipv4_changes` to false.

 Yep, that's what I came up with as well.

 > I don't know what Torflow does and it's not so easy to check.
 >
 > What we can do, it's to wait a few days until longclaw uses nightly
 changes, see how many relays it's measuring with the current fixes and see
 whether we should change this.

 I am fine with that.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33832 [Core Tor/sbws]: For relays that change ip, only the measurements with the last ip are kept

[Tor Bug Tracker & Wiki]

#33832: For relays that change ip, only the measurements with the last ip are 
kept
-+-
 Reporter:  juga |  Owner:  gk
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  sbws:
 |  1.1.x-final
Component:  Core Tor/sbws|Version:  sbws:
 |  1.1.0
 Severity:  Normal   | Resolution:
 Keywords:  sbws-roadmap, intro, |  Actual Points:
  GeorgKoppen202004  |
Parent ID:  #33121   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by juga):

 Replying to [comment:6 gk] and [comment:7 arma]:

 i'm replying to both of you, last comments.

 So, my first thought was, yeah, the relay is the same, it's probably
 changing IP cause of having dynamic IP address, so we should keep the
 recent measurements with a different IP.

 Then, i thought, what if the relay changes IP cause it changes physical
 location? (while keeping the keys/configuration), in that case the
 measurements could actually be quite different and the previous ones would
 not make sense.

 So we have at least 2 cases in which a relay might change IP and think the
 first one is the more common one.

 I don't know what's was the initial thought to implement this, i also
 didn't find i in the git log or tickets.

 I realize now that we don't need to change the code, we can just change
 the default configuration to set `reset_bw_ipv4_changes` to false.

 I don't know what Torflow does and it's not so easy to check.

 What we can do, it's to wait a few days until longclaw uses nightly
 changes, see how many relays it's measuring with the current fixes and see
 whether we should change this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33832 [Core Tor/sbws]: For relays that change ip, only the measurements with the last ip are kept

[Tor Bug Tracker & Wiki]

#33832: For relays that change ip, only the measurements with the last ip are 
kept
-+-
 Reporter:  juga |  Owner:  gk
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  sbws:
 |  1.1.x-final
Component:  Core Tor/sbws|Version:  sbws:
 |  1.1.0
 Severity:  Normal   | Resolution:
 Keywords:  sbws-roadmap, intro, |  Actual Points:
  GeorgKoppen202004  |
Parent ID:  #33121   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arma):

 I would expect that we would aggregate all our results of testing the
 relay "somewhat recently", regardless of what IP address it was on when we
 did each test.

 Otherwise, as juga says, we're more likely to end up relays on dynamic ip
 addresses being unmeasured.

 I think this behavior that I describe ("use them all") is what Torflow
 does, too, but I'm not certain.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33832 [Core Tor/sbws]: For relays that change ip, only the measurements with the last ip are kept

[Tor Bug Tracker & Wiki]

#33832: For relays that change ip, only the measurements with the last ip are 
kept
-+-
 Reporter:  juga |  Owner:  gk
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  sbws:
 |  1.1.x-final
Component:  Core Tor/sbws|Version:  sbws:
 |  1.1.0
 Severity:  Normal   | Resolution:
 Keywords:  sbws-roadmap, intro, |  Actual Points:
  GeorgKoppen202004  |
Parent ID:  #33121   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:5 juga]:
 > Replying to [comment:4 gk]:
 > > Replying to [comment:2 juga]:
 > > > To solve this, the function `trim_results_ip_changed` in
 `resultdump.py` should be changed
 > >
 > > What is the intended behavior? Not ignoring previous measurements
 anymore? Do we still need the `trim_results_ip_changed` function in that
 case (you seem to indicate that)?
 >
 > Hmm, i thought that we could ignore the other ips but still keep the
 results. After your questions, i realize that it'd not make sense to do
 that.
 > So, we can probably close this ticket as invalid. Maybe let fix other
 tickets first and then rethink about this one?

 We can do that. But why do we keep only the measurements just with the
 last IP address? I mean it's still the *same* relay, just has a new IP
 address (you could probably argue that the IP address is just an attribute
 like an option in the `torrc` file and we do not exclude measurements when
 any of those changes). Is the assumption that bandwidth improves with a
 new IP address? Or is Torflow doing that and sbws is trying to mimic it?
 Or...?

 I looked at the `git` history of this code to figure out whether there is
 some rationale given in a commit message or ticket it points to or some
 older comment but did not find any hint.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33832 [Core Tor/sbws]: For relays that change ip, only the measurements with the last ip are kept

[Tor Bug Tracker & Wiki]

#33832: For relays that change ip, only the measurements with the last ip are 
kept
-+-
 Reporter:  juga |  Owner:  gk
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  sbws:
 |  1.1.x-final
Component:  Core Tor/sbws|Version:  sbws:
 |  1.1.0
 Severity:  Normal   | Resolution:
 Keywords:  sbws-roadmap, intro, |  Actual Points:
  GeorgKoppen202004  |
Parent ID:  #33121   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by juga):

 Replying to [comment:4 gk]:
 > Replying to [comment:2 juga]:
 > > To solve this, the function `trim_results_ip_changed` in
 `resultdump.py` should be changed
 >
 > What is the intended behavior? Not ignoring previous measurements
 anymore? Do we still need the `trim_results_ip_changed` function in that
 case (you seem to indicate that)?

 Hmm, i thought that we could ignore the other ips but still keep the
 results. After your questions, i realize that it'd not make sense to do
 that.
 So, we can probably close this ticket as invalid. Maybe let fix other
 tickets first and then rethink about this one?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33832 [Core Tor/sbws]: For relays that change ip, only the measurements with the last ip are kept

[Tor Bug Tracker & Wiki]

#33832: For relays that change ip, only the measurements with the last ip are 
kept
-+-
 Reporter:  juga |  Owner:  gk
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  sbws:
 |  1.1.x-final
Component:  Core Tor/sbws|Version:  sbws:
 |  1.1.0
 Severity:  Normal   | Resolution:
 Keywords:  sbws-roadmap, intro, |  Actual Points:
  GeorgKoppen202004  |
Parent ID:  #33121   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  assigned => needs_information


Comment:

 Replying to [comment:2 juga]:
 > To solve this, the function `trim_results_ip_changed` in `resultdump.py`
 should be changed

 What is the intended behavior? Not ignoring previous measurements anymore?
 Do we still need the `trim_results_ip_changed` function in that case (you
 seem to indicate that)?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33832 [Core Tor/sbws]: For relays that change ip, only the measurements with the last ip are kept

[Tor Bug Tracker & Wiki]

#33832: For relays that change ip, only the measurements with the last ip are 
kept
-+-
 Reporter:  juga |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  sbws:
 |  1.1.x-final
Component:  Core Tor/sbws|Version:  sbws:
 |  1.1.0
 Severity:  Normal   | Resolution:
 Keywords:  sbws-roadmap, intro, |  Actual Points:
  GeorgKoppen202004  |
Parent ID:  #33121   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  sbws-roadmap, intro => sbws-roadmap, intro, GeorgKoppen202004
 * owner:  (none) => gk
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33832 [Core Tor/sbws]: For relays that change ip, only the measurements with the last ip are kept

[Tor Bug Tracker & Wiki]

#33832: For relays that change ip, only the measurements with the last ip are 
kept
-+---
 Reporter:  juga |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  sbws: 1.1.x-final
Component:  Core Tor/sbws|Version:  sbws: 1.1.0
 Severity:  Normal   | Resolution:
 Keywords:  sbws-roadmap, intro  |  Actual Points:
Parent ID:  #33121   | Points:
 Reviewer:   |Sponsor:
-+---
Changes (by juga):

 * keywords:  sbws-roadmap => sbws-roadmap, intro


Comment:

 To solve this, the function `trim_results_ip_changed` in `resultdump.py`
 should be changed

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33832 [Core Tor/sbws]: For relays that change ip, only the measurements with the last ip are kept

[Tor Bug Tracker & Wiki]

#33832: For relays that change ip, only the measurements with the last ip are 
kept
---+---
 Reporter:  juga   |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  sbws: 1.1.x-final
Component:  Core Tor/sbws  |Version:  sbws: 1.1.0
 Severity:  Normal | Resolution:
 Keywords:  sbws-roadmap   |  Actual Points:
Parent ID:  #33121 | Points:
 Reviewer: |Sponsor:
---+---

Comment (by juga):

 As commented in
 
https://gitweb.torproject.org/sbws.git/tree/sbws/lib/resultdump.py?h=maint-1.1#n111

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33832 [Core Tor/sbws]: For relays that change ip, only the measurements with the last ip are kept

[Tor Bug Tracker & Wiki]

#33832: For relays that change ip, only the measurements with the last ip are 
kept
---+---
 Reporter:  juga   |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  sbws: 1.1.x-final
Component:  Core Tor/sbws  |Version:  sbws: 1.1.0
 Severity:  Normal |   Keywords:  sbws-roadmap
Actual Points: |  Parent ID:  #33121
   Points: |   Reviewer:
  Sponsor: |
---+---
 which makes those relays more likely to don't be "eligible" cause don't
 have enough results and therefore, sbws voting in less relays.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs