Re: [tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder

[Tor Bug Tracker & Wiki]

#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
+---
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  merge_ready
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o22a2   |  Actual Points:
Parent ID:  #31279  | Points:  1
 Reviewer:  |Sponsor:  Sponsor30-can
+---
Changes (by agix):

 * status:  needs_information => merge_ready


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder

[Tor Bug Tracker & Wiki]

#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
+---
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  needs_information
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o22a2   |  Actual Points:
Parent ID:  #31279  | Points:  1
 Reviewer:  |Sponsor:  Sponsor30-can
+---
Changes (by agix):

 * status:  needs_review => needs_information


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder

[Tor Bug Tracker & Wiki]

#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
+---
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o22a2   |  Actual Points:
Parent ID:  #31279  | Points:  1
 Reviewer:  |Sponsor:  Sponsor30-can
+---

Comment (by agix):

 I just left one comment on your patch
 
[https://github.com/NullHypothesis/bridgedb/commit/8caa83df6382f772c02453705a1014f156b66850
 here]
 Other than that, the patch looks good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder

[Tor Bug Tracker & Wiki]

#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
+---
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o22a2   |  Actual Points:
Parent ID:  #31279  | Points:  1
 Reviewer:  |Sponsor:  Sponsor30-can
+---

Comment (by phw):

 Here's a revised patch set including two unit tests:
 https://github.com/NullHypothesis/bridgedb/compare/defect/33835-2

 Basically, if our autoresponder receives a multipart email, the patch
 removes the parts whose content type is not text/plain. If there is no
 text/plain part (which shouldn't happen), we log a warning message. Let's
 keep an eye out for that warning message after deploying this branch.

 Agix, can you please take another look at my latest revisions?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder

[Tor Bug Tracker & Wiki]

#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
+---
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o22a2   |  Actual Points:
Parent ID:  #31279  | Points:  1
 Reviewer:  |Sponsor:  Sponsor30-can
+---

Comment (by agix):

 Replying to [comment:21 phw]:
 > Hmm. I think the right way forward is to discard message parts whose
 content type is not text/plain. In both my and agix's example, the
 text/html part shouldn't reach the parser and the text/plain part should
 be fine.
 >
 > We won't be able to support every single email client but at the very
 least, we should be able to support emails from Gmail's and Riseup's web
 interface.
 >
 > What do you think?
 \\
 I agree.
 Let's match for the content-type being text/plain and this should solve
 the issue for now.
 We just have to keep in mind, if we ever add support for other email
 services that the issue might occur again.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder

[Tor Bug Tracker & Wiki]

#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
+---
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o22a2   |  Actual Points:
Parent ID:  #31279  | Points:  1
 Reviewer:  |Sponsor:  Sponsor30-can
+---

Comment (by phw):

 Hmm. I think the right way forward is to discard message parts whose
 content type is not text/plain. In both my and agix's example, the
 text/html part shouldn't reach the parser and the text/plain part should
 be fine.

 We won't be able to support every single email client but at the very
 least, we should be able to support emails from Gmail's and Riseup's web
 interface.

 What do you think?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder

[Tor Bug Tracker & Wiki]

#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
+---
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o22a2   |  Actual Points:
Parent ID:  #31279  | Points:  1
 Reviewer:  |Sponsor:  Sponsor30-can
+---

Comment (by agix):

 Replying to [comment:19 phw]:
 > Oh, that's good to know! Do you happen to have such an email that you
 can paste in here? We should add it to our unit tests and find a way to
 support it.
 [[br]]
 Sure, I posted the original email [http://agix.at/33835-mail.html here]

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder

[Tor Bug Tracker & Wiki]

#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
+---
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o22a2   |  Actual Points:
Parent ID:  #31279  | Points:  1
 Reviewer:  |Sponsor:  Sponsor30-can
+---

Comment (by phw):

 Replying to [comment:18 agix]:
 > The reason for my messy approach was that I noticed when, for example,
 the email is sent from an outlook address to a gmail address, every part
 is encoded as quoted-printable, while when the mails are sent between two
 gmail addresses, only the content of type html is being encoded as quoted-
 printable.
 [[br]]
 Oh, that's good to know! Do you happen to have such an email that you can
 paste in here? We should add it to our unit tests and find a way to
 support it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder

[Tor Bug Tracker & Wiki]

#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
+---
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o22a2   |  Actual Points:
Parent ID:  #31279  | Points:  1
 Reviewer:  |Sponsor:  Sponsor30-can
+---

Comment (by agix):

 Replying to [comment:17 phw]:
 > I took a look at this issue and may have found a simpler way to fix it.
 Agix, what do you think about the following fix?
 > https://github.com/NullHypothesis/bridgedb/compare/defect/33835-2
 >
 > The unit tests pass. If you think it looks good, we can test-deploy it
 on polyanthum.

 Your fix is definitely more elegant.
 The reason for my messy approach was that I noticed when, for example, the
 email is sent from an outlook address to a gmail address, every part is
 encoded as quoted-printable, while when the mails are sent between two
 gmail addresses, only the content of type html is being encoded as quoted-
 printable.
 I guess I went a little overboard with my solution, since the different
 encoding behaviors might not effect BridgeDB at all (since it only replies
 to gmail & riseup).
 So I am all for testing your fix.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder

[Tor Bug Tracker & Wiki]

#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
+---
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o22a2   |  Actual Points:
Parent ID:  #31279  | Points:  1
 Reviewer:  |Sponsor:  Sponsor30-can
+---

Comment (by phw):

 I took a look at this issue and may have found a simpler way to fix it.
 Agix, what do you think about the following fix?
 https://github.com/NullHypothesis/bridgedb/compare/defect/33835-2

 The unit tests pass. If you think it looks good, we can test-deploy it on
 polyanthum.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder

[Tor Bug Tracker & Wiki]

#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
+---
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o22a2   |  Actual Points:
Parent ID:  #31279  | Points:  1
 Reviewer:  |Sponsor:  Sponsor30-can
+---

Comment (by agix):

 Replying to [comment:15 phw]:
 > Replying to [comment:14 agix]:
 > > I implemented your feedback and made a commit for it
 
[https://github.com/agiix/bridgedb/commit/44f455b1eeb422e625c2b74fc59ed24ac4ca6351
 here]
 > [[br]]
 > This looks better, thanks. Can you please squash your two commits into
 one? I will then clean it up a bit, take a look at the unit tests, and get
 it merged.

 
[https://github.com/agiix/bridgedb/commit/a648a29b4b5abe9b037548cf182a60e29147e9c1
 Here you go]
 Additionally I removed the fallback solution in request.py on line 80
 since it was not an elegant solution anyway and was only there for testing
 purposes. Should get_payload return a string instead of a list, an
 exception will be raised.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder

[Tor Bug Tracker & Wiki]

#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
+---
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o22a2   |  Actual Points:
Parent ID:  #31279  | Points:  1
 Reviewer:  |Sponsor:  Sponsor30-can
+---

Comment (by phw):

 Replying to [comment:14 agix]:
 > I implemented your feedback and made a commit for it
 
[https://github.com/agiix/bridgedb/commit/44f455b1eeb422e625c2b74fc59ed24ac4ca6351
 here]
 [[br]]
 This looks better, thanks. Can you please squash your two commits into
 one? I will then clean it up a bit, take a look at the unit tests, and get
 it merged.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder

[Tor Bug Tracker & Wiki]

#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
+---
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o22a2   |  Actual Points:
Parent ID:  #31279  | Points:  1
 Reviewer:  |Sponsor:  Sponsor30-can
+---

Comment (by agix):

 Replying to [comment:12 phw]:
 > Replying to [comment:11 agix]:
 > > There you go:
 > >
 
[https://github.com/agiix/bridgedb/commit/1fb531ed505352026223c298607554654116564e]
 > >
 > > Correction about comment:8
 > > What I meant was that all but 4 unit tests (and a few commented out
 ones) pass :)
 > [[br]]
 > Thanks! I left a bunch of comments
 
[https://github.com/agiix/bridgedb/commit/1fb531ed505352026223c298607554654116564e
 here]. The overall approach seems reasonable but we should make a handful
 of small changes – I'm happy to elaborate on any of my comments, just let
 me know. I would also suggest to not worry about the unit tests for now.
 Let's make sure that we're happy with the overall design, and then we can
 make sure that everything is properly tested.
 >
 > Finally, please don't feel discouraged by my asking for revisions. Non-
 trivial patches (and this certainly is one) typically go through at least
 one round of revisions.

 Thanks :)
 I implemented your feedback and made a commit for it
 
[https://github.com/agiix/bridgedb/commit/44f455b1eeb422e625c2b74fc59ed24ac4ca6351
 here]

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder

[Tor Bug Tracker & Wiki]

#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
+---
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o22a2   |  Actual Points:
Parent ID:  #31279  | Points:  1
 Reviewer:  |Sponsor:  Sponsor30-can
+---
Changes (by agix):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder

[Tor Bug Tracker & Wiki]

#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
+
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o22a2   |  Actual Points:
Parent ID:  #31279  | Points:  1
 Reviewer:  |Sponsor:  Sponsor30-can
+
Changes (by phw):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:11 agix]:
 > There you go:
 >
 
[https://github.com/agiix/bridgedb/commit/1fb531ed505352026223c298607554654116564e]
 >
 > Correction about comment:8
 > What I meant was that all but 4 unit tests (and a few commented out
 ones) pass :)
 [[br]]
 Thanks! I left a bunch of comments
 
[https://github.com/agiix/bridgedb/commit/1fb531ed505352026223c298607554654116564e
 here]. The overall approach seems reasonable but we should make a handful
 of small changes – I'm happy to elaborate on any of my comments, just let
 me know. I would also suggest to not worry about the unit tests for now.
 Let's make sure that we're happy with the overall design, and then we can
 make sure that everything is properly tested.

 Finally, please don't feel discouraged by my asking for revisions. Non-
 trivial patches (and this certainly is one) typically go through at least
 one round of revisions.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder

[Tor Bug Tracker & Wiki]

#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
+---
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o22a2   |  Actual Points:
Parent ID:  #31279  | Points:  1
 Reviewer:  |Sponsor:  Sponsor30-can
+---

Comment (by agix):

 There you go:
 
[https://github.com/agiix/bridgedb/commit/1fb531ed505352026223c298607554654116564e]

 Correction about comment:8
 What I meant was that all but 4 unit tests (and a few commented out ones)
 pass :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder

[Tor Bug Tracker & Wiki]

#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
+---
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o22a2   |  Actual Points:
Parent ID:  #31279  | Points:  1
 Reviewer:  |Sponsor:  Sponsor30-can
+---

Comment (by phw):

 For some reason I'm unable to comment on GitHub's "Files changed" view. Do
 you mind squashing your branch to a single commit? It will make it easier
 for me to comment on specific code lines.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder

[Tor Bug Tracker & Wiki]

#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
+---
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o22a2   |  Actual Points:
Parent ID:  #31279  | Points:  1
 Reviewer:  |Sponsor:  Sponsor30-can
+---
Changes (by agix):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder

[Tor Bug Tracker & Wiki]

#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
+
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o22a2   |  Actual Points:
Parent ID:  #31279  | Points:  1
 Reviewer:  |Sponsor:  Sponsor30-can
+

Comment (by agix):

 Thanks for the feedback!
 On the branch 'stable-optionparser' you will find my work over the last
 week.
 All but 4 unit tests still result in an error.
 If my approach is acceptable thus far, I will continue to fix those as
 well.

 Here is what I got so far:
 [https://github.com/agiix/bridgedb/tree/stable-optionparser]

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder

[Tor Bug Tracker & Wiki]

#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
+
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o22a2   |  Actual Points:
Parent ID:  #31279  | Points:  1
 Reviewer:  |Sponsor:  Sponsor30-can
+
Changes (by phw):

 * status:  needs_review => needs_revision


Comment:

 With "push your patch to GitHub," I meant pushing the commits that your
 patch is based on.

 That said, here's some feedback:

 * Overall, the `get_payload()` approach seems reasonable. Nicely done!

 * Make sure that your code is based on the develop and not on the master
 branch. For BridgeDB, we're using [https://nvie.com/posts/a-successful-
 git-branching-model/ a development model] in which patches branch off of
 develop rather than master.

 * I'm not sure why the patch deletes `TRANSPORT_PATTERN` and
 `UNBLOCKED_PATTERN`, and replaces them with a TODO item?

 * The patch's commit message should provide a short summary of how the
 patch accomplishes its goal. [https://git-scm.com/book/en/v2/Distributed-
 Git-Contributing-to-a-Project#Commit-Guidelines Here's a summary] of how
 to write good commit messages.

 * We should add unit tests to make sure that the patch correctly deals
 with emails of different content types.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder

[Tor Bug Tracker & Wiki]

#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
+---
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o22a2   |  Actual Points:
Parent ID:  #31279  | Points:  1
 Reviewer:  |Sponsor:  Sponsor30-can
+---

Comment (by agix):

 
[https://github.com/agiix/bridgedb/commit/3bc1903ca3a442de7e8895708fb787a1e45c7d6d]

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder

[Tor Bug Tracker & Wiki]

#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
+---
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o22a2   |  Actual Points:
Parent ID:  #31279  | Points:  1
 Reviewer:  |Sponsor:  Sponsor30-can
+---

Comment (by phw):

 Can you please push your patch to GitHub or GitLab? It makes code review
 easier if I can comment on specific lines.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder

[Tor Bug Tracker & Wiki]

#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
+---
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o22a2   |  Actual Points:
Parent ID:  #31279  | Points:  1
 Reviewer:  |Sponsor:  Sponsor30-can
+---
Changes (by agix):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder

[Tor Bug Tracker & Wiki]

#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
+---
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  assigned
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o22a2   |  Actual Points:
Parent ID:  #31279  | Points:  1
 Reviewer:  |Sponsor:  Sponsor30-can
+---

Comment (by agix):

 Sorry, the previous patch had a small issue.
 I fixed it in the second attachment.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder

[Tor Bug Tracker & Wiki]

#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
+---
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  assigned
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o22a2   |  Actual Points:
Parent ID:  #31279  | Points:  1
 Reviewer:  |Sponsor:  Sponsor30-can
+---
Changes (by agix):

 * Attachment "Replacing-the-current-Mail-parsing-option.2.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder

[Tor Bug Tracker & Wiki]

#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
+---
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  assigned
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o22a2   |  Actual Points:
Parent ID:  #31279  | Points:  1
 Reviewer:  |Sponsor:  Sponsor30-can
+---
Changes (by agix):

 * Attachment "Replacing-the-current-Mail-parsing-option.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder

[Tor Bug Tracker & Wiki]

#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
+---
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  assigned
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o22a2   |  Actual Points:
Parent ID:  #31279  | Points:  1
 Reviewer:  |Sponsor:  Sponsor30-can
+---

Comment (by agix):

 To effectively parse out the requested options via email, I used the
 get_payload() function for EmailMessage objects.
 As pointed out in both answers of
 [https://stackoverflow.com/questions/45124127/unable-to-extract-the-body-
 of-the-email-file-in-python/45124153] there needs to be a certain policy
 defined (policy.compat32 instead the default policy) to be able to use
 get_payload instead of get_body.
 The advantage of get_payload is that it ignores the Content-Type and
 Content-Transfer-Encoding header and therefore solely focuses on the
 actual payload which makes the parsing way easier.
 get_payload(0).get_payload() parses out the plain text, but cant
 differentiate between the actual message and previous responses.
 Thats why this approach just focuses on the first 3 words of an incoming
 email to determine the response action.
 This seems to be one of only few approaches if we don't want to rely on
 regex anymore, but I am open to suggestions.
 Additionally some unittests need to be adjusted for this patch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder

[Tor Bug Tracker & Wiki]

#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
+---
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  assigned
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  s30-o22a2   |  Actual Points:
Parent ID:  #31279  | Points:  1
 Reviewer:  |Sponsor:  Sponsor30-can
+---
Changes (by agix):

 * owner:  (none) => agix
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder

[Tor Bug Tracker & Wiki]

#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
+---
 Reporter:  phw |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  |   Keywords:  s30-o22a2
Actual Points:  |  Parent ID:  #31279
   Points:  1   |   Reviewer:
  Sponsor:  Sponsor30-can   |
+---
 When replying to a BridgeDB email in Gmail's web interface, one ends up
 sending an email like this:
 {{{
 On Mon, Apr 6, 2020 at 2:12 PM  wrote:

 >
 > [This is an automated email.  Please do not reply.]
 >
 > Here are your bridges:
 >
 >   [redacted]
 >
 > Add these bridges to your Tor Browser by opening your browser
 > preferences, clicking on "Tor", and then adding them to the "Provide a
 > bridge" field.
 >
 > If these bridges are not what you need, reply to this email with one of
 > the following commands in the message body:
 >
 >   get bridges(Request unobfuscated Tor bridges.)
 >   get ipv6   (Request IPv6 bridges.)
 >   get transport TYPE (Request obfuscated bridges. Replace TYPE with
 > 'obfs4'.)
 >   get key(Get a copy of BridgeDB's public GnuPG key.)
 >
 >
 >

 --dde1a205a2a60f3e
 Content-Type: text/html; charset="UTF-8"
 Content-Transfer-Encoding: quoted-printable

 get transport obfs4On Mon, Apr 6, 2020 at 2:12 PM
 =
 mailto:brid...@torproject.org;>brid...@torproject.org
 wr=
 ote:
 [This is an automated email.=C2=A0 Please do not reply.]
 
 Here are your bridges:
 
 =C2=A0 [redacted]
 
 Add these bridges to your Tor Browser by opening your browser
 preferences, clicking on Tor, and then adding them to the
 =
 ;Provide a
 bridge field.
 
 If these bridges are not what you need, reply to this email with one
 of
 the following commands in the message body:
 
 =C2=A0 get bridges=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (Request
 unobfu=
 scated Tor bridges.)
 =C2=A0 get ipv6=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
 =C2=A0(Requ=
 est IPv6 bridges.)
 =C2=A0 get transport TYPE=C2=A0 =C2=A0 =C2=A0(Request obfuscated bridges.
 R=
 eplace TYPE with obfs4.)
 =C2=A0 get key=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (Get
 =
 a copy of BridgeDBs public GnuPG key.)
 
 
 

 --dde1a205a2a60f3e--
 }}}

 BridgeDB correctly ignores the commands that start with `>` but it doesn't
 ignore the commands that are encoded in quoted-printable. BridgeDB's email
 parser ends up
 
[https://gitweb.torproject.org/bridgedb.git/tree/bridgedb/distributors/email/request.py?h=develop=bca64964a255cf959489c7049c66e5eb70b5291c#n87
 interpreting each line as command], ending in "get key", which raises an
 exception, resulting in BridgeDB sending no response at all.

 We should make sure that BridgeDB doesn't get confused by Gmail's quoted-
 printable response.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs