Re: [tor-bugs] #33837 [Core Tor/Tor]: Tor.framework Unknown type name 'dispatch_queue_t'

[Tor Bug Tracker & Wiki]

#33837: Tor.framework Unknown type name 'dispatch_queue_t'
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  043-should, 043-backport,|  Actual Points:
  042-backport, 041-backport |
Parent ID:   | Points:  .5
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by tla):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 True.

 I opened #33924 and #33925 instead! Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33837 [Core Tor/Tor]: Tor.framework Unknown type name 'dispatch_queue_t'

[Tor Bug Tracker & Wiki]

#33837: Tor.framework Unknown type name 'dispatch_queue_t'
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  reopened
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  043-should, 043-backport,|  Actual Points:
  042-backport, 041-backport |
Parent ID:   | Points:  .5
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by teor):

 Looks like you've found two more bugs in two different tor versions.

 Please open a separate ticket for each bug, it's easier for us to fix them
 that way.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33837 [Core Tor/Tor]: Tor.framework Unknown type name 'dispatch_queue_t'

[Tor Bug Tracker & Wiki]

#33837: Tor.framework Unknown type name 'dispatch_queue_t'
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  reopened
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  043-should, 043-backport,|  Actual Points:
  042-backport, 041-backport |
Parent ID:   | Points:  .5
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by tla):

 * status:  closed => reopened
 * resolution:  fixed =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33837 [Core Tor/Tor]: Tor.framework Unknown type name 'dispatch_queue_t'

[Tor Bug Tracker & Wiki]

#33837: Tor.framework Unknown type name 'dispatch_queue_t'
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  043-should, 043-backport,|  Actual Points:
  042-backport, 041-backport |
Parent ID:   | Points:  .5
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by tla):

 Ok, so it seems Tor doesn't honor SIGNAL SHUTDOWN anymore. The first Tor
 version I tested was 0.4.1.5 (first stable of 0.4.1).

 Sending it with 0.4.0.6, I see this in the logs:

 {{{
 Apr 16 16:31:58.000 [notice] Interrupt: exiting cleanly.
 }}}

 With later Tor versions, this message disappears and the TorThread still
 hangs around after app wake up.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33837 [Core Tor/Tor]: Tor.framework Unknown type name 'dispatch_queue_t'

[Tor Bug Tracker & Wiki]

#33837: Tor.framework Unknown type name 'dispatch_queue_t'
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  043-should, 043-backport,|  Actual Points:
  042-backport, 041-backport |
Parent ID:   | Points:  .5
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by tla):

 I improved the build script further:
 
https://github.com/iCepa/Tor.framework/commit/8881bfb627d2ebbd37eb7aa9cced46092bb0f96e

 Now, there's a configure before make show-libs is called.

 I can compile 0.4.3.4-rc without problem now.
 Master not so great, though:


 {{{
 Ld
 /Users/berhart/Library/Developer/Xcode/DerivedData/Tor-
 atzjucxhwnhfrqcmzwlymuguursh/Build/Products/Debug/Tor.framework/Versions
 /A/Tor normal x86_64 (in target 'Tor-Mac' from project 'Tor') cd
 /Users/berhart/workspace/gp/Tor.framework
 /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.
 /xctoolchain/usr/bin/clang -target x86_64-apple-macos10.9
 /-dynamiclib -isysroot
 //Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.
 /platform/Developer/SDKs/MacOSX10.15.sdk
 /-L/Users/berhart/Library/Developer/Xcode/DerivedData/Tor-
 /atzjucxhwnhfrqcmzwlymuguursh/Build/Products/Debug
 /-F/Users/berhart/Library/Developer/Xcode/DerivedData/Tor-
 /atzjucxhwnhfrqcmzwlymuguursh/Build/Products/Debug -filelist
 //Users/berhart/Library/Developer/Xcode/DerivedData/Tor-
 /atzjucxhwnhfrqcmzwlymuguursh/Build/Intermediates.noindex/Tor.build/
 /Debug/Tor-Mac.build/Objects-normal/x86_64/Tor.LinkFileList
 /-install_name @rpath/Tor.framework/Tor -Xlinker -rpath -Xlinker
 /@executable_path/../Frameworks -Xlinker -rpath -Xlinker
 /@loader_path/../Frameworks -Xlinker -object_path_lto -Xlinker
 //Users/berhart/Library/Developer/Xcode/DerivedData/Tor-
 /atzjucxhwnhfrqcmzwlymuguursh/Build/Intermediates.noindex/Tor.build/
 /Debug/Tor-Mac.build/Objects-normal/x86_64/Tor_lto.o -Xlinker
 /-export_dynamic -Xlinker -no_deduplicate -fobjc-arc
 /-fobjc-link-runtime -fapplication-extension -framework CFNetwork
 /-ltor-app -ltor-compress -ltor-evloop -ltor-tls -ltor-crypt-ops
 /-lkeccak-tiny -ltor-pubsub -ltor-confmgt -led25519_ref10
 /-led25519_donna -lcurve25519_donna -ltor-geoip -ltor-process
 /-ltor-buf -ltor-time -ltor-fs -ltor-encoding -ltor-sandbox
 /-ltor-container -ltor-net -ltor-thread -ltor-memarea -ltor-math
 /-ltor-meminfo -ltor-osinfo -ltor-dispatch -ltor-log -ltor-lock
 /-ltor-fdio -ltor-string -ltor-term -ltor-smartlist-core
 /-ltor-malloc -ltor-wallclock -ltor-err -ltor-version -ltor-intmath
 /-ltor-ctime -lor-trunnel -ltor-trace -lssl -lcrypto -levent
 /-levent_core -levent_extra -levent_pthreads -llzma -lz -Xlinker
 /-dependency_info -Xlinker
 //Users/berhart/Library/Developer/Xcode/DerivedData/Tor-
 /atzjucxhwnhfrqcmzwlymuguursh/Build/Intermediates.noindex/Tor.build/
 /Debug/Tor-Mac.build/Objects-normal/x86_64/Tor_dependency_info.dat
 /-o
 //Users/berhart/Library/Developer/Xcode/DerivedData/Tor-
 /atzjucxhwnhfrqcmzwlymuguursh/Build/Products/Debug/Tor.framework/
 /Versions/A/Tor
 /
 Undefined symbols for architecture x86_64: "_sys_winprocess", referenced
 from: _tor_subsystems in libtor-app.a(subsystem_list.o) ld: symbol(s)
 not found for architecture x86_64 clang: error: linker command failed
 with exit code 1 (use -v to see invocation)
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33837 [Core Tor/Tor]: Tor.framework Unknown type name 'dispatch_queue_t'

[Tor Bug Tracker & Wiki]

#33837: Tor.framework Unknown type name 'dispatch_queue_t'
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  043-should, 043-backport,|  Actual Points:
  042-backport, 041-backport |
Parent ID:   | Points:  .5
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by tla):

 Oh: Tor 0.4.2.7 is not stopping anymore:
 https://github.com/iCepa/Tor.framework/issues/62

 I'll investigate.

 > Is there any reason that you don't use zstd?

 There sure is one, but I don't know it. Mike devised this and it's not so
 long ago, that liblzma was added by him.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33837 [Core Tor/Tor]: Tor.framework Unknown type name 'dispatch_queue_t'

[Tor Bug Tracker & Wiki]

#33837: Tor.framework Unknown type name 'dispatch_queue_t'
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  043-should, 043-backport,|  Actual Points:
  042-backport, 041-backport |
Parent ID:   | Points:  .5
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by teor):

 Replying to [comment:10 tla]:
 > With your fixes I was able to do a new release containing
 >
 > - Tor 0.4.2.7
 > - libevent 2.1.11
 > - OpenSSL 1.1.1f
 > - liblzma 5.2.5
 >
 > https://github.com/iCepa/Tor.framework/releases/tag/v402.7.1

 Is there any reason that you dopn't use zstd?

 lzma and zstd are used to compress different tor directory documents.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33837 [Core Tor/Tor]: Tor.framework Unknown type name 'dispatch_queue_t'

[Tor Bug Tracker & Wiki]

#33837: Tor.framework Unknown type name 'dispatch_queue_t'
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  043-should, 043-backport,|  Actual Points:
  042-backport, 041-backport |
Parent ID:   | Points:  .5
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by nickm):

 It looks like the configure script was out of date -- so it re-ran
 autoconf and then ran configure again.  The actual info you want is down
 at the bottom there -- but maybe you should make sure that you re-run
 autogen.sh and configure after updating to a new version?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33837 [Core Tor/Tor]: Tor.framework Unknown type name 'dispatch_queue_t'

[Tor Bug Tracker & Wiki]

#33837: Tor.framework Unknown type name 'dispatch_queue_t'
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  043-should, 043-backport,|  Actual Points:
  042-backport, 041-backport |
Parent ID:   | Points:  .5
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by tla):

 Hmmm. With 0.4.3.4-rc, on the first run after a clean `make show-libs`
 returns this:

 {{{
 /bin/sh ./config.status --recheck running CONFIG_SHELL=/bin/sh /bin/sh
 /./configure --enable-restart-debugging --enable-silent-rules
 /--enable-pic --disable-module-dirauth --disable-tool-name-check
 /--disable-unittests --enable-static-openssl --enable-static-libevent
 /--disable-asciidoc --disable-system-torrc --disable-linker-hardening
 /--disable-dependency-tracking --disable-manpage --disable-html-manual
 /--prefix=/Users/berhart/Library/Developer/Xcode/DerivedData/Tor-
 /atzjucxhwnhfrqcmzwlymuguursh/Build/Intermediates.noindex/Tor.build/
 /Debug-iphonesimulator/tor-x86_64
 /--with-libevent-dir=/Users/berhart/Library/Developer/Xcode/DerivedData/
 /Tor-atzjucxhwnhfrqcmzwlymuguursh/Build/Products/Debug-iphonesimulator
 /--with-openssl-dir=/Users/berhart/Library/Developer/Xcode/DerivedData/
 /Tor-atzjucxhwnhfrqcmzwlymuguursh/Build/Products/Debug-iphonesimulator
 /--enable-lzma --enable-zstd=no
 /CC=/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.
 /xctoolchain/usr/bin/clang -arch x86_64 -isysroot
 //Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.
 /platform/Developer/SDKs/iPhoneSimulator13.4.sdk
 /CPP=/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.
 /xctoolchain/usr/bin/clang -E -arch x86_64 -isysroot
 //Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.
 /platform/Developer/SDKs/iPhoneSimulator13.4.sdk CPPFLAGS=-g -O0
 /-fembed-bitcode-marker
 /-I/Users/berhart/workspace/gp/Tor.framework/Tor/tor/core
 /-I/Users/berhart/workspace/gp/Tor.framework/Tor/openssl/include
 /-I/Users/berhart/Library/Developer/Xcode/DerivedData/Tor-
 /atzjucxhwnhfrqcmzwlymuguursh/Build/Products/Debug-iphonesimulator/
 /openssl-x86_64
 /-I/Users/berhart/workspace/gp/Tor.framework/Tor/libevent/include
 /-I/Users/berhart/Library/Developer/Xcode/DerivedData/Tor-
 /atzjucxhwnhfrqcmzwlymuguursh/Build/Products/Debug-iphonesimulator/
 /libevent-x86_64
 /-I/Users/berhart/Library/Developer/Xcode/DerivedData/Tor-
 /atzjucxhwnhfrqcmzwlymuguursh/Build/Products/Debug-iphonesimulator/
 /libevent-x86_64/include
 /-I/Users/berhart/Library/Developer/Xcode/DerivedData/Tor-
 /atzjucxhwnhfrqcmzwlymuguursh/Build/Products/Debug-iphonesimulator/
 /liblzma-x86_64
 /-I/Users/berhart/Library/Developer/Xcode/DerivedData/Tor-
 /atzjucxhwnhfrqcmzwlymuguursh/Build/Products/Debug-iphonesimulator/
 /liblzma-x86_64/include
 /-I/Users/berhart/Library/Developer/Xcode/DerivedData/Tor-
 /atzjucxhwnhfrqcmzwlymuguursh/Build/Intermediates.noindex/Tor.build/
 /Debug-iphonesimulator/tor-sys -isysroot
 //Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.
 /platform/Developer/SDKs/iPhoneSimulator13.4.sdk cross_compiling=yes
 /ac_cv_func__NSGetEnviron=no ac_cv_func_clock_gettime=no
 /ac_cv_func_getentropy=no LDFLAGS=-lz -fembed-bitcode-marker --no-create
 /--no-recursion checking for a BSD-compatible install...
 //usr/bin/install -c checking whether build environment is sane... yes
 /checking for strip... strip checking for a thread-safe mkdir -p...
 /./install-sh -c -d checking for gawk... no checking for mawk... no
 /checking for nawk... no checking for awk... awk checking whether make
 /sets $(MAKE)... yes checking whether make supports nested variables...
 /yes checking whether make supports nested variables... (cached) yes
 /checking whether make supports the include directive... yes (GNU style)
 /checking for gcc...
 //Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.
 /xctoolchain/usr/bin/clang -arch x86_64 -isysroot
 //Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.
 /platform/Developer/SDKs/iPhoneSimulator13.4.sdk checking whether the C
 /compiler works... yes checking for C compiler default output file
 /name... a.out checking for suffix of executables... checking whether we
 /are cross compiling... yes checking for suffix of object files... o
 /checking whether we are using the GNU C compiler... yes checking
 /whether
 

Re: [tor-bugs] #33837 [Core Tor/Tor]: Tor.framework Unknown type name 'dispatch_queue_t'

[Tor Bug Tracker & Wiki]

#33837: Tor.framework Unknown type name 'dispatch_queue_t'
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  043-should, 043-backport,|  Actual Points:
  042-backport, 041-backport |
Parent ID:   | Points:  .5
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Cool, glad it worked!

 Could you also please test out Tor 0.4.3.4-rc and the current tor master
 branch?  If there is going to be trouble with those, it would be good to
 know _before_ they're released. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33837 [Core Tor/Tor]: Tor.framework Unknown type name 'dispatch_queue_t'

[Tor Bug Tracker & Wiki]

#33837: Tor.framework Unknown type name 'dispatch_queue_t'
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  043-should, 043-backport,|  Actual Points:
  042-backport, 041-backport |
Parent ID:   | Points:  .5
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by tla):

 I can't change the status, but from my side, you can close this any time.
 Happy, if you want to review the latest Tor.framework, though! :-)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33837 [Core Tor/Tor]: Tor.framework Unknown type name 'dispatch_queue_t'

[Tor Bug Tracker & Wiki]

#33837: Tor.framework Unknown type name 'dispatch_queue_t'
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  043-should, 043-backport,|  Actual Points:
  042-backport, 041-backport |
Parent ID:   | Points:  .5
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by tla):

 Thank you so much for finding this!
 With your fixes I was able to do a new release containing

 - Tor 0.4.2.7
 - libevent 2.1.11
 - OpenSSL 1.1.1f
 - liblzma 5.2.5

 https://github.com/iCepa/Tor.framework/releases/tag/v402.7.1


 I also improved the build script as per your suggestions!

 Thanks, thanks, thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33837 [Core Tor/Tor]: Tor.framework Unknown type name 'dispatch_queue_t'

[Tor Bug Tracker & Wiki]

#33837: Tor.framework Unknown type name 'dispatch_queue_t'
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  043-should, 043-backport,|  Actual Points:
  042-backport, 041-backport |
Parent ID:   | Points:  .5
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by teor):

 I had a look at the PR, it looks good to me.

 There's one typo, but it's in a comment that will get deleted after the
 other bugs are fixed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33837 [Core Tor/Tor]: Tor.framework Unknown type name 'dispatch_queue_t'

[Tor Bug Tracker & Wiki]

#33837: Tor.framework Unknown type name 'dispatch_queue_t'
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  043-should, 043-backport,|  Actual Points:
  042-backport, 041-backport |
Parent ID:   | Points:  .5
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by nickm):

 * status:  new => needs_review
 * reviewer:   => ahf
 * points:   => .5


Comment:

 Setting Ahf as reviewer. Ahf, I don't think this is our bug, but I'd like
 you to look over the fix just in case.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33837 [Core Tor/Tor]: Tor.framework Unknown type name 'dispatch_queue_t'

[Tor Bug Tracker & Wiki]

#33837: Tor.framework Unknown type name 'dispatch_queue_t'
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  043-should, 043-backport,|  Actual Points:
  042-backport, 041-backport |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 I have a PR for you at ​https://github.com/iCepa/Tor.framework/pulls/61 .

 There will be some more work needed to port to 0.4.1 and beyond, but this
 should fix the problem you're seeing here.  It also notes some other cases
 where you're likely to run into problems down the line.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33837 [Core Tor/Tor]: Tor.framework Unknown type name 'dispatch_queue_t'

[Tor Bug Tracker & Wiki]

#33837: Tor.framework Unknown type name 'dispatch_queue_t'
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  043-should, 043-backport,|  Actual Points:
  042-backport, 041-backport |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 One interesting thing about TorNode.m is that it includes TorNode.h before
 anything else, and TorNode.h includes foundation/foundation.h before
 anything else.  So we can tell that whatever the problem is, it has to be
 something on the command line.

 These are the options I'm most suspicious about:
 {{{
 -I/Users/nickm/src/minitor/src/Tor.framework/Tor/tor
 -I/Users/nickm/src/minitor/src/Tor.framework/Tor/tor/src
 -I/Users/nickm/src/minitor/src/Tor.framework/Tor/tor/src/common
 -I/Users/nickm/src/minitor/src/Tor.framework/Tor/tor/src/core
 -I/Users/nickm/src/minitor/src/Tor.framework/Tor/tor/src/ext
 -I/Users/nickm/src/minitor/src/Tor.framework/Tor/tor/src/feature
 -I/Users/nickm/src/minitor/src/Tor.framework/Tor/tor/src/lib
 }}}

 My guess is that Tor is defining some header that conflicts with one of
 the system headers, and since you're importing all directories into your
 namespace, you're getting a conflict.

 I wouldn't recommend including any of Tor's headers at all besides
 tor_api.h.  It looks like you are also including or.h, and log.h.  We
 should talk about how that can be avoided -- it is likely to cause
 instability in the future.  But if you really need to include these files,
 the recommended way to do it is relative to src.

 So that's my hunch -- I'm trying this out now to see if it works for me.
 My setup only "sort of" works, so whatever I come up with is going to need
 further testing, but let's see how it goes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33837 [Core Tor/Tor]: Tor.framework Unknown type name 'dispatch_queue_t'

[Tor Bug Tracker & Wiki]

#33837: Tor.framework Unknown type name 'dispatch_queue_t'
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  043-should, 043-backport,|  Actual Points:
  042-backport, 041-backport |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 I've managed to ''sort of'' get the build environment running.  Here is an
 instance of the command line that failed, split up so that it doesn't
 scroll too much.

 {{{

 
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang
 -x objective-c -target armv7-apple-ios8.0 -fmessage-length=0
 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0
 -std=gnu99 -fobjc-arc -fmodules -gmodules
 -fmodules-cache-
 path=/Users/nickm/Library/Developer/Xcode/DerivedData/ModuleCache.noindex
 -fmodules-prune-interval=86400 -fmodules-prune-after=345600
 -fbuild-session-
 
file=/Users/nickm/Library/Developer/Xcode/DerivedData/ModuleCache.noindex/Session.modulevalidation
 -fmodules-validate-once-per-build-session -fmodule-name=Tor
 -fapplication-extension -Wno-trigraphs -fpascal-strings -Os
 -fno-common -Wmissing-field-initializers -Wno-missing-prototypes
 -Werror=return-type -Wunreachable-code -Wno-implicit-atomic-properties
 -Werror=deprecated-objc-isa-usage -Wno-objc-interface-ivars
 -Werror=objc-root-class -Wno-arc-repeated-use-of-weak
 -Wimplicit-retain-self -Wduplicate-method-match -Wmissing-braces
 -Wparentheses -Wswitch -Wunused-function -Wunused-label
 -Wno-unused-parameter -Wunused-variable -Wunused-value -Wempty-body
 -Wuninitialized -Wno-unknown-pragmas -Wno-shadow -Wfour-char-constants
 -Wconversion -Wconstant-conversion -Wint-conversion -Wbool-conversion
 -Wenum-conversion -Wfloat-conversion -Wnon-literal-null-conversion
 -Wobjc-literal-conversion -Wsign-compare -Wshorten-64-to-32
 -Wpointer-sign -Wno-newline-eof -Wno-selector
 -Wno-strict-selector-match -Wundeclared-selector
 -Wdeprecated-implementations -DOBJC_OLD_DISPATCH_PROTOTYPES=0
 -isysroot
 
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS13.4.sdk
 -fstrict-aliasing -Wprotocol -Wdeprecated-declarations -g
 -Wno-sign-conversion -Winfinite-recursion -Wcomma
 -Wblock-capture-autoreleasing -Wstrict-prototypes
 -Wno-semicolon-before-method-body -fembed-bitcode -iquote
 /Users/nickm/Library/Developer/Xcode/DerivedData/Tor-
 ccpyrdylcgmlgjgvzcjuffrxljph/Build/Intermediates.noindex/ArchiveIntermediates
 /Tor-iOS/IntermediateBuildFilesPath/Tor.build/Release-iphoneos/Tor-
 iOS.build/Tor-generated-files.hmap
 -I/Users/nickm/Library/Developer/Xcode/DerivedData/Tor-
 ccpyrdylcgmlgjgvzcjuffrxljph/Build/Intermediates.noindex/ArchiveIntermediates
 /Tor-iOS/IntermediateBuildFilesPath/Tor.build/Release-iphoneos/Tor-
 iOS.build/Tor-own-target-headers.hmap
 -I/Users/nickm/Library/Developer/Xcode/DerivedData/Tor-
 ccpyrdylcgmlgjgvzcjuffrxljph/Build/Intermediates.noindex/ArchiveIntermediates
 /Tor-iOS/IntermediateBuildFilesPath/Tor.build/Release-iphoneos/Tor-
 iOS.build/Tor-all-non-framework-target-headers.hmap
 -ivfsoverlay
 /Users/nickm/Library/Developer/Xcode/DerivedData/Tor-
 ccpyrdylcgmlgjgvzcjuffrxljph/Build/Intermediates.noindex/ArchiveIntermediates
 /Tor-iOS/IntermediateBuildFilesPath/Tor.build/Release-iphoneos/Tor-
 iOS.build/all-product-headers.yaml
 -iquote
 /Users/nickm/Library/Developer/Xcode/DerivedData/Tor-
 ccpyrdylcgmlgjgvzcjuffrxljph/Build/Intermediates.noindex/ArchiveIntermediates
 /Tor-iOS/IntermediateBuildFilesPath/Tor.build/Release-iphoneos/Tor-
 iOS.build/Tor-project-headers.hmap
 -iquote
 /Users/nickm/Library/Developer/Xcode/DerivedData/Tor-
 ccpyrdylcgmlgjgvzcjuffrxljph/Build/Intermediates.noindex/ArchiveIntermediates
 /Tor-iOS/BuildProductsPath/Release-iphoneos/tor
 -I/Users/nickm/Library/Developer/Xcode/DerivedData/Tor-
 ccpyrdylcgmlgjgvzcjuffrxljph/Build/Intermediates.noindex/ArchiveIntermediates
 /Tor-iOS/BuildProductsPath/Release-iphoneos/include
 -I/Users/nickm/Library/Developer/Xcode/DerivedData/Tor-
 ccpyrdylcgmlgjgvzcjuffrxljph/Build/Intermediates.noindex/ArchiveIntermediates
 /Tor-iOS/IntermediateBuildFilesPath/UninstalledProducts/include
 -I/Users/nickm/src/minitor/src/Tor.framework/Tor/include
 -I/Users/nickm/src/minitor/src/Tor.framework/Tor/tor
 -I/Users/nickm/src/minitor/src/Tor.framework/Tor/tor/src
 

Re: [tor-bugs] #33837 [Core Tor/Tor]: Tor.framework Unknown type name 'dispatch_queue_t'

[Tor Bug Tracker & Wiki]

#33837: Tor.framework Unknown type name 'dispatch_queue_t'
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  043-should, 043-backport,|  Actual Points:
  042-backport, 041-backport |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by tla):

 So sorry. My account didn't have an e-mail address, so I wasn't notified.
 D'oh!

 Here's more info:
 https://github.com/iCepa/Tor.framework/issues/53

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33837 [Core Tor/Tor]: Tor.framework Unknown type name 'dispatch_queue_t'

[Tor Bug Tracker & Wiki]

#33837: Tor.framework Unknown type name 'dispatch_queue_t'
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  043-should, 043-backport,|  Actual Points:
  042-backport, 041-backport |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by rl1987):

 * cc: rl1987 (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33837 [Core Tor/Tor]: Tor.framework Unknown type name 'dispatch_queue_t'

[Tor Bug Tracker & Wiki]

#33837: Tor.framework Unknown type name 'dispatch_queue_t'
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  043-should, 043-backport,|  Actual Points:
  042-backport, 041-backport |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 Can somebody paste or link to the complete error here?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33837 [Core Tor/Tor]: Tor.framework Unknown type name 'dispatch_queue_t'

[Tor Bug Tracker & Wiki]

#33837: Tor.framework Unknown type name 'dispatch_queue_t'
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  043-should, 043-backport,|  Actual Points:
  042-backport, 041-backport |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * cc: tla (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33837 [Core Tor/Tor]: Tor.framework Unknown type name 'dispatch_queue_t'

[Tor Bug Tracker & Wiki]

#33837: Tor.framework Unknown type name 'dispatch_queue_t'
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  043-should, 043-backport,
 Severity:  Normal   |  042-backport, 041-backport
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 From https://trac.torproject.org/projects/tor/ticket/33522#comment:2
 >
 > Replying to [ticket:33522 tla]:
 > > It has a Travis-CI configuration, which I just updated to work on the
 latest macOS/Xcode image:
 > >
 > > https://github.com/iCepa/Tor.framework/blob/master/.travis.yml
 > >
 > >
 > > Currently, we have issues in getting past Tor 0.4.0.6 on iOS. When I
 try to use a newer core, I get this error message:
 > >
 > > > Unknown type name 'dispatch_queue_t'
 > >
 > > in CFStream of Apple's CoreFoundation framework.
 > >
 > >
 > > But "dispatch_queue_t" is actually a valid symbol from Apple's
 Foundation libraries.
 > >
 > > So somehow, it gets cancelled out through something which changed in
 Tor recently.
 >
 > This looks like a bug in tor's code, or perhaps in the Tor.framework
 embedding scripts.
 >
 > We'd be happy to help you diagnose this issue.
 >
 > Can you tell us the first release that has this issue? Is it 0.4.1,
 0.4.2, or 0.4.3 ?
 > Have you done a git bisect, to track down the commit that introduced the
 issue?
 >
 > Let's open a separate ticket, so we can fix this bug in tor's code.
 > Or help you find a workaround when you embed tor.

 I can't see dispatch_queue_t in Tor's code.

 Perhaps we're defining some preprocessor symbols, or including a header
 that conflicts with dispatch_queue_t's header.

 We don't know which release this bug was introduced in. But Tor 0.4.0.6
 does not have this error.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs