Re: [tor-bugs] #3940 [Core Tor/Tor]: Allow MapAddress .exit even if AllowDotExit is 0

[Tor Bug Tracker & Wiki]

#3940: Allow MapAddress .exit even if AllowDotExit is 0
-+-
 Reporter:  sjmurdoch|  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.32
 Severity:  Normal   | Resolution:
 Keywords:  regression, tor-client,  |  worksforme
  032-backport, 031-backport, 029-backport,  |  Actual Points:
  033-must, review-group-33, review-group-34,|
  033-triage-20180320, 033-included-20180320 |
Parent ID:   | Points:
 Reviewer:  isis |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_information => closed
 * resolution:   => worksforme


Comment:

 Can't reproduce; no contact from reporter for ~2 months; and above
 analysis suggests this is not a bug.  Please reopen if one of those
 changes. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3940 [Core Tor/Tor]: Allow MapAddress .exit even if AllowDotExit is 0

[Tor Bug Tracker & Wiki]

#3940: Allow MapAddress .exit even if AllowDotExit is 0
-+-
 Reporter:  sjmurdoch|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_information
 Priority:  High |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.32
 Severity:  Normal   | Resolution:
 Keywords:  regression, tor-client,  |  Actual Points:
  032-backport, 031-backport, 029-backport,  |
  033-must, review-group-33, review-group-34,|
  033-triage-20180320, 033-included-20180320 |
Parent ID:   | Points:
 Reviewer:  isis |Sponsor:
-+-

Comment (by nickm):

 > I wonder if we intended for that use case to work?

 So, AutomapHostsOnResolve is supposed to work with DNSPort... and if you
 pass a .exit address to the DNSPort, it is supposed to counts as if you
 had specified the .exit address in your connect request.  If I understand
 correctly, AllowDotExit is not supposed to allow that case.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3940 [Core Tor/Tor]: Allow MapAddress .exit even if AllowDotExit is 0

[Tor Bug Tracker & Wiki]

#3940: Allow MapAddress .exit even if AllowDotExit is 0
-+-
 Reporter:  sjmurdoch|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_information
 Priority:  High |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.32
 Severity:  Normal   | Resolution:
 Keywords:  regression, tor-client,  |  Actual Points:
  032-backport, 031-backport, 029-backport,  |
  033-must, review-group-33, review-group-34,|
  033-triage-20180320, 033-included-20180320 |
Parent ID:   | Points:
 Reviewer:  isis |Sponsor:
-+-

Comment (by arma):

 According to the regression.patch that they attached, the new bug happens
 when they're doing an automap. That is, they probably have DNSPort set,
 and something like AutomapHostsOnResolve set, and they're making queries
 against their DNSPort.

 I wonder if we intended for that use case to work?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3940 [Core Tor/Tor]: Allow MapAddress .exit even if AllowDotExit is 0

[Tor Bug Tracker & Wiki]

#3940: Allow MapAddress .exit even if AllowDotExit is 0
-+-
 Reporter:  sjmurdoch|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_information
 Priority:  High |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.32
 Severity:  Normal   | Resolution:
 Keywords:  regression, tor-client,  |  Actual Points:
  032-backport, 031-backport, 029-backport,  |
  033-must, review-group-33, review-group-34 |
Parent ID:   | Points:
 Reviewer:  isis |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => needs_information


Comment:

 fuzzyTew -- could you give instructions for reproducing this bug?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3940 [Core Tor/Tor]: Allow MapAddress .exit even if AllowDotExit is 0

[Tor Bug Tracker & Wiki]

#3940: Allow MapAddress .exit even if AllowDotExit is 0
-+-
 Reporter:  sjmurdoch|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.32
 Severity:  Normal   | Resolution:
 Keywords:  regression, tor-client,  |  Actual Points:
  032-backport, 031-backport, 029-backport,  |
  033-must, review-group-33, review-group-34 |
Parent ID:   | Points:
 Reviewer:  isis |Sponsor:
-+-
Changes (by dgoulet):

 * reviewer:  nickm, isis => isis


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3940 [Core Tor/Tor]: Allow MapAddress .exit even if AllowDotExit is 0

[Tor Bug Tracker & Wiki]

#3940: Allow MapAddress .exit even if AllowDotExit is 0
-+-
 Reporter:  sjmurdoch|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.32
 Severity:  Normal   | Resolution:
 Keywords:  regression tor-client 032-backport   |  Actual Points:
  031-backport 029-backport 033-must review- |
  group-33   |
Parent ID:   | Points:
 Reviewer:  nickm, isis  |Sponsor:
-+-
Changes (by isis):

 * reviewer:  nickm => nickm, isis


Comment:

 I tested this on a tor-0.3.1.4-alpha (the version just after when
 `AllowDotExit` was removed). I'm not able to reproduce the issue? It could
 very well be that I've not taken the right steps, since it's been so long
 since I've tried to manually use .exit notation. In the arm control panel,
 I did:

 {{{
 >>> MAPADDRESS
 google.com=google.com.9D6AE1BD4FDF39721CE908966E79E16F9BFCCF2F.exit
 google.com=google.com.9d6ae1bd4fdf39721ce908966e79e16f9bfccf2f.exit
 >>> GETINFO address-mappings/all
 google.com.9d6ae1bd4fdf39721ce908966e79e16f9bfccf2f.exit
 172.217.22.142.9d6ae1bd4fdf39721ce908966e79e16f9bfccf2f.exit "2018-03-01
 01:57:29"
 }}}

 I then went to google.com, and my tor seems to have built a four-hop
 circuit, with `9d6ae1bd4fdf39721ce908966e79e16f9bfccf2f` as the exit node
 to google.com.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3940 [Core Tor/Tor]: Allow MapAddress .exit even if AllowDotExit is 0

[Tor Bug Tracker & Wiki]

#3940: Allow MapAddress .exit even if AllowDotExit is 0
-+-
 Reporter:  sjmurdoch|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.32
 Severity:  Normal   | Resolution:
 Keywords:  regression tor-client 032-backport   |  Actual Points:
  031-backport 029-backport 033-must review- |
  group-33   |
Parent ID:   | Points:
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * reviewer:   => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3940 [Core Tor/Tor]: Allow MapAddress .exit even if AllowDotExit is 0

[Tor Bug Tracker & Wiki]

#3940: Allow MapAddress .exit even if AllowDotExit is 0
-+-
 Reporter:  sjmurdoch|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.32
 Severity:  Normal   | Resolution:
 Keywords:  regression tor-client 032-backport   |  Actual Points:
  031-backport 029-backport 033-must review- |
  group-33   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  regression tor-client 032-backport 031-backport 029-backport
 033-must =>
 regression tor-client 032-backport 031-backport 029-backport 033-must
 review-group-33


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3940 [Core Tor/Tor]: Allow MapAddress .exit even if AllowDotExit is 0

[Tor Bug Tracker & Wiki]

#3940: Allow MapAddress .exit even if AllowDotExit is 0
-+-
 Reporter:  sjmurdoch|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.32
 Severity:  Normal   | Resolution:
 Keywords:  regression tor-client 032-backport   |  Actual Points:
  031-backport 029-backport 033-must |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  regression tor-client => regression tor-client 032-backport
 031-backport 029-backport 033-must
 * status:  reopened => needs_review
 * severity:  Blocker => Normal
 * milestone:  Tor: 0.2.3.x-final => Tor: 0.3.3.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3940 [Core Tor/Tor]: Allow MapAddress .exit even if AllowDotExit is 0

[Tor Bug Tracker & Wiki]

#3940: Allow MapAddress .exit even if AllowDotExit is 0
---+
 Reporter:  sjmurdoch  |  Owner:  (none)
 Type:  defect | Status:  reopened
 Priority:  High   |  Milestone:  Tor: 0.2.3.x-final
Component:  Core Tor/Tor   |Version:  Tor: 0.2.2.32
 Severity:  Blocker| Resolution:
 Keywords:  regression tor-client  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by fuzzyTew):

 Note that although the comment on the code I removed states it is
 preventing .exit domains that have come from users, actually it is
 preventing automapped mapaddresses.  User-provided .exit domains are
 blocked on line 1247 of src/or/connection_edge.c:
 {{{
   /* Check for whether this is a .exit address.  By default, those are
* disallowed when they're coming straight from the client, but you're
* allowed to have them in MapAddress commands and so forth. */
   if (!strcmpend(socks->address, ".exit")) {
 log_warn(LD_APP, "The  \".exit\" notation is disabled in Tor due to "
  "security risks.");
 control_event_client_status(LOG_WARN, "SOCKS_BAD_HOSTNAME
 HOSTNAME=%s",
 escaped(socks->address));
 out->end_reason = END_STREAM_REASON_TORPROTOCOL;
 out->should_close = 1;
 return;
   }
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3940 [Core Tor/Tor]: Allow MapAddress .exit even if AllowDotExit is 0

[Tor Bug Tracker & Wiki]

#3940: Allow MapAddress .exit even if AllowDotExit is 0
---+
 Reporter:  sjmurdoch  |  Owner:  (none)
 Type:  defect | Status:  reopened
 Priority:  High   |  Milestone:  Tor: 0.2.3.x-final
Component:  Core Tor/Tor   |Version:  Tor: 0.2.2.32
 Severity:  Blocker| Resolution:
 Keywords:  regression tor-client  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by fuzzyTew):

 * status:  closed => reopened
 * resolution:  fixed =>
 * severity:   => Blocker


Comment:

 This bug was reintroduced with 9d0fab9872807ef212fadb3feb299cf6309a185f
 'Allow MapAddress and Automap to work together' on 2014-04-08.  Combined
 with f02fd6c3af71141241137403d070d72310cbfd82 'Remove AllowDotExit'
 2017-09-07, it has not been possible to use MapAddress .exit for a number
 of months now.

 The attached patch fixes the issue again.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3940 [Core Tor/Tor]: Allow MapAddress .exit even if AllowDotExit is 0

[Tor Bug Tracker & Wiki]

#3940: Allow MapAddress .exit even if AllowDotExit is 0
---+
 Reporter:  sjmurdoch  |  Owner:  (none)
 Type:  defect | Status:  closed
 Priority:  High   |  Milestone:  Tor: 0.2.3.x-final
Component:  Core Tor/Tor   |Version:  Tor: 0.2.2.32
 Severity: | Resolution:  fixed
 Keywords:  regression tor-client  |  Actual Points:
Parent ID: | Points:
---+
Changes (by fuzzyTew):

 * Attachment "regression.patch" added.

 remnove check with false assumption

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs