Re: [tor-bugs] #8323 [Core Tor/Tor]: Missing 'GETINFO md/all'

[Tor Bug Tracker & Wiki]

#8323: Missing 'GETINFO md/all'
--+
 Reporter:  atagar|  Owner:  rl1987
 Type:  enhancement   | Status:  closed
 Priority:  High  |  Milestone:  Tor:
  |  0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  tor-client tor-control microdesc  |  Actual Points:
Parent ID:| Points:
 Reviewer:  asn   |Sponsor:
--+
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 #26210 hasn't been implemented, so I un-parented it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #8323 [Core Tor/Tor]: Missing 'GETINFO md/all'

[Tor Bug Tracker & Wiki]

#8323: Missing 'GETINFO md/all'
--+
 Reporter:  atagar|  Owner:  rl1987
 Type:  enhancement   | Status:
  |  merge_ready
 Priority:  High  |  Milestone:  Tor:
  |  0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-client tor-control microdesc  |  Actual Points:
Parent ID:| Points:
 Reviewer:  asn   |Sponsor:
--+

Comment (by nickm):

 Merged!

 Please close or un-parent the child tickets as appropriate, and then close
 this?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #8323 [Core Tor/Tor]: Missing 'GETINFO md/all'

[Tor Bug Tracker & Wiki]

#8323: Missing 'GETINFO md/all'
--+
 Reporter:  atagar|  Owner:  rl1987
 Type:  enhancement   | Status:
  |  merge_ready
 Priority:  High  |  Milestone:  Tor:
  |  0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-client tor-control microdesc  |  Actual Points:
Parent ID:| Points:
 Reviewer:  asn   |Sponsor:
--+
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 LGTM!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #8323 [Core Tor/Tor]: Missing 'GETINFO md/all'

[Tor Bug Tracker & Wiki]

#8323: Missing 'GETINFO md/all'
--+
 Reporter:  atagar|  Owner:  rl1987
 Type:  enhancement   | Status:
  |  needs_review
 Priority:  High  |  Milestone:  Tor:
  |  0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-client tor-control microdesc  |  Actual Points:
Parent ID:| Points:
 Reviewer:  asn   |Sponsor:
--+

Comment (by rl1987):

 Squashed the branch again: https://github.com/torproject/tor/pull/137

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #8323 [Core Tor/Tor]: Missing 'GETINFO md/all'

[Tor Bug Tracker & Wiki]

#8323: Missing 'GETINFO md/all'
--+
 Reporter:  atagar|  Owner:  rl1987
 Type:  enhancement   | Status:
  |  needs_review
 Priority:  High  |  Milestone:  Tor:
  |  0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-client tor-control microdesc  |  Actual Points:
Parent ID:| Points:
 Reviewer:  asn   |Sponsor:
--+
Changes (by rl1987):

 * status:  needs_revision => needs_review


Comment:

 Fixed the code to use existing function and wrote unit tests.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #8323 [Core Tor/Tor]: Missing 'GETINFO md/all'

[Tor Bug Tracker & Wiki]

#8323: Missing 'GETINFO md/all'
--+
 Reporter:  atagar|  Owner:  rl1987
 Type:  enhancement   | Status:
  |  needs_revision
 Priority:  High  |  Milestone:  Tor:
  |  0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-client tor-control microdesc  |  Actual Points:
Parent ID:| Points:
 Reviewer:  asn   |Sponsor:
--+
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Thanks for the code!

 I did an initial review on your PR! Some small changes will be needed, but
 you are pretty much there.

 Also, perhaps we should have some unittests for this new control command.
 SEe `src/test/test_controller.c` for some examples of other getinfo
 unittests.

 Cheers!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #8323 [Core Tor/Tor]: Missing 'GETINFO md/all'

[Tor Bug Tracker & Wiki]

#8323: Missing 'GETINFO md/all'
--+
 Reporter:  atagar|  Owner:  rl1987
 Type:  enhancement   | Status:
  |  needs_review
 Priority:  High  |  Milestone:  Tor:
  |  0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-client tor-control microdesc  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * milestone:  Tor: unspecified => Tor: 0.3.5.x-final


Comment:

 Putting in 0.3.5 because 0.3.4 is closed to new features.

 Do we have unit tests for control commands?
 If we do, then please add a unit test.

 Yes, please add a stem integration test, maybe ask atagar how it's done.

 And we'll also need a control spec patch.

 Please open child tickets for stem and the control spec, so we can merge
 those patches separately if we need to.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #8323 [Core Tor/Tor]: Missing 'GETINFO md/all'

[Tor Bug Tracker & Wiki]

#8323: Missing 'GETINFO md/all'
--+
 Reporter:  atagar|  Owner:  rl1987
 Type:  enhancement   | Status:
  |  needs_review
 Priority:  High  |  Milestone:  Tor:
  |  unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-client tor-control microdesc  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by rl1987):

 * status:  accepted => needs_review


Comment:

 https://github.com/torproject/tor/pull/122

 I suppose integration test should be done in stem?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #8323 [Core Tor/Tor]: Missing 'GETINFO md/all'

[Tor Bug Tracker & Wiki]

#8323: Missing 'GETINFO md/all'
--+
 Reporter:  atagar|  Owner:  rl1987
 Type:  enhancement   | Status:  accepted
 Priority:  High  |  Milestone:  Tor:
  |  unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-client tor-control microdesc  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by rl1987):

 * status:  new => accepted
 * owner:  (none) => rl1987


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #8323 [Core Tor/Tor]: Missing 'GETINFO md/all'

[Tor Bug Tracker & Wiki]

#8323: Missing 'GETINFO md/all'
--+
 Reporter:  atagar|  Owner:
 Type:  enhancement   | Status:  new
 Priority:  High  |  Milestone:  Tor:
  |  unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-client tor-control microdesc  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * keywords:  tor-client => tor-client tor-control microdesc
 * type:  defect => enhancement
 * severity:   => Normal


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs