Re: [tor-bugs] #8706 [Applications/Tor Browser]: .recently-used.xbel contains filenames if browser stored them to disk

[Tor Bug Tracker & Wiki]

#8706: .recently-used.xbel contains filenames if browser stored them to disk
-+-
 Reporter:  runa |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  backport-to-mozilla, tbb-disk-leak,  |  Actual Points:
  tbb-firefox-patch  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 >Storing file names in recently-used.xbel
 And here:
 {{{
 $ strings tor-browser_en-US/Browser/.local/share/gvfs-metadata/*
 }}}

 fix (use '''srm''' for secure wipe):
 {{{
 $ rm -r tor-browser_en-US/Browser/.local/share/
 $ ln -s /dev/null tor-browser_en-US/Browser/.local/share/
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #8706 [Applications/Tor Browser]: .recently-used.xbel contains filenames if browser stored them to disk

[Tor Bug Tracker & Wiki]

#8706: .recently-used.xbel contains filenames if browser stored them to disk
-+-
 Reporter:  runa |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  backport-to-mozilla, tbb-disk-leak,  |  Actual Points:
  tbb-firefox-patch  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by strix):

 According to
 https://developer.gnome.org/gtk3/stable/GtkSettings.html#GtkSettings--gtk-
 recent-files-limit, gtk-recent-files-limit is now deprecated.

 However, adding
 {{{
 gtk-recent-files-max-age = 0
 }}}
 to settings.ini for users so afflicted by gtk on their install does the
 trick.

 Storing file names in recently-used.xbel remains an outstanding issue as
 of Tor Browser 9.0.2, and the fix seems trivial.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #8706 [Applications/Tor Browser]: .recently-used.xbel contains filenames if browser stored them to disk

[Tor Bug Tracker & Wiki]

#8706: .recently-used.xbel contains filenames if browser stored them to disk
-+-
 Reporter:  runa |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  backport-to-mozilla, tbb-disk-leak,  |  Actual Points:
  tbb-firefox-patch  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * cc: randosando (added)


Comment:

 Resolved #31346 as duplicate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #8706 [Applications/Tor Browser]: .recently-used.xbel contains filenames if browser stored them to disk

[Tor Bug Tracker & Wiki]

#8706: .recently-used.xbel contains filenames if browser stored them to disk
-+-
 Reporter:  runa |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  backport-to-mozilla, tbb-disk-leak,  |  Actual Points:
  tbb-firefox-patch  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 https://blog.torproject.org/comment/282249#comment-282249 mentioned just
 adding
 {{{
 gtk-recent-files-max-age=0
 gtk-recent-files-limit=0
 }}}
 to `tor-browser_en-US/Browser/.config/gtk-3.0/settings.ini` should prevent
 a record of all files downloaded.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #8706 [Applications/Tor Browser]: .recently-used.xbel contains filenames if browser stored them to disk

[Tor Bug Tracker & Wiki]

#8706: .recently-used.xbel contains filenames if browser stored them to disk
-+-
 Reporter:  runa |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  backport-to-mozilla, tbb-disk-leak,  |  Actual Points:
  tbb-firefox-patch  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arma):

 I'm still excited to see this disk leak get fixed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #8706 [Applications/Tor Browser]: .recently-used.xbel contains filenames if browser stored them to disk

[Tor Bug Tracker & Wiki]

#8706: .recently-used.xbel contains filenames if browser stored them to disk
-+-
 Reporter:  runa |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  backport-to-mozilla, tbb-disk-leak,  |  Actual Points:
  tbb-firefox-patch  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by yawning):

 > Patch firefox to override the setting my commit messes with, right after
 the `gtk_init()` call then.

 {{{
/* Disable the .recently-used.xbel file. */
gtk_settings_set_long_property(gtk_settings_get_default(), "gtk-recent-
 files-max-age", 0, "TorBrowser");
 }}}

 In the right place should work.  Finding the right place is left as an
 exercise for the student.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #8706 [Applications/Tor Browser]: .recently-used.xbel contains filenames if browser stored them to disk

[Tor Bug Tracker & Wiki]

#8706: .recently-used.xbel contains filenames if browser stored them to disk
-+-
 Reporter:  runa |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  backport-to-mozilla, tbb-disk-leak,  |  Actual Points:
  tbb-firefox-patch  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by yawning):

 Replying to [comment:8 arma]:
 > Is it rude for Tor Browser to clobber my {{{~/tor-browser_en-
 US/Browser/.local/share/recently-used.xbel}}} file? Why?

 Oh that's right, Tor Browser's script overrides `HOME`.  I haven't messed
 with non-sandboxed Tor Browser in forever, mea culpa.

 Patch firefox to override the setting my commit messes with, right after
 the `gtk_init()` call then.  I assume users will cry if Tor Browser ships
 with it's own `.gtkrc-2.0` because they'll lose Gtk theming

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #8706 [Applications/Tor Browser]: .recently-used.xbel contains filenames if browser stored them to disk

[Tor Bug Tracker & Wiki]

#8706: .recently-used.xbel contains filenames if browser stored them to disk
-+-
 Reporter:  runa |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  backport-to-mozilla, tbb-disk-leak,  |  Actual Points:
  tbb-firefox-patch  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arma):

 Is it rude for Tor Browser to clobber my {{{~/tor-browser_en-
 US/Browser/.local/share/recently-used.xbel}}} file? Why?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #8706 [Applications/Tor Browser]: .recently-used.xbel contains filenames if browser stored them to disk

[Tor Bug Tracker & Wiki]

#8706: .recently-used.xbel contains filenames if browser stored them to disk
-+-
 Reporter:  runa |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  backport-to-mozilla, tbb-disk-leak,  |  Actual Points:
  tbb-firefox-patch  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by yawning):

 Replying to [comment:5 arma]:
 > Or is it something else?

 Probably this?  It's not easy to disable on a per-application basis, and
 I'm fairly sure that attempting to do so without reaching into the guts of
 Gtk+ will make Tor Browser clobber the file (which is rude).

 That said in the sandbox Gtk+ is containerized and already ignores the
 users theming, so I can do something like: https://gitweb.torproject.org
 /tor-browser/sandboxed-tor-
 browser.git/commit/?id=36a580f723cdd7891eec5e2b2c878ed1a323178d

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #8706 [Applications/Tor Browser]: .recently-used.xbel contains filenames if browser stored them to disk

[Tor Bug Tracker & Wiki]

#8706: .recently-used.xbel contains filenames if browser stored them to disk
-+-
 Reporter:  runa |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  backport-to-mozilla, tbb-disk-leak,  |  Actual Points:
  tbb-firefox-patch  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arma):

 * severity:  Blocker => Normal


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #8706 [Applications/Tor Browser]: .recently-used.xbel contains filenames if browser stored them to disk

[Tor Bug Tracker & Wiki]

#8706: .recently-used.xbel contains filenames if browser stored them to disk
-+-
 Reporter:  runa |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Blocker  | Resolution:
 Keywords:  backport-to-mozilla, tbb-disk-leak,  |  Actual Points:
  tbb-firefox-patch  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arma):

 * severity:   => Blocker


Comment:

 Is this a Firefox bug, because private browsing mode ought to block this
 file from being created?

 Is it a Tor Browser bug, because we should try to step in somehow?

 Or is it something else?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs